112993 2013-03-21 19:29:08 -0700 Implement isEnabledFormControl() for SliderThumbElement and SpinButtonElement in terms of disabled() 2013-03-22 18:36:06 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 112085 1 falken falken darin esprehn+autocc mifenton ojan.autocc tkent webkit.review.bot oldest_to_newest 861000 0 falken 2013-03-21 19:29:08 -0700 SliderThumbElement and SpinButtonElement's isEnabledFormControl are the only ones that do not just return !disabled(). If we can make them return !disabled(), it would prove that having both disabled and isEnabledFormControl is redundant, and we can just refactor them into a single function. 861007 1 194420 falken 2013-03-21 19:40:53 -0700 Created attachment 194420 Patch 861008 2 194420 tkent 2013-03-21 19:41:53 -0700 Comment on attachment 194420 Patch ok 861738 3 194420 webkit.review.bot 2013-03-22 12:03:49 -0700 Comment on attachment 194420 Patch Clearing flags on attachment: 194420 Committed r146638: <http://trac.webkit.org/changeset/146638> 861739 4 webkit.review.bot 2013-03-22 12:03:54 -0700 All reviewed patches have been landed. Closing bug. 862058 5 darin 2013-03-22 18:21:33 -0700 Isn’t disabled is a web-exposed property? If so, then it seems that this change is a web-exposed change in behavior, not just a refactoring. If that is right, then we need a regression test and we need to be sure this is a correct change. 862063 6 tkent 2013-03-22 18:25:56 -0700 (In reply to comment #5) > Isn’t disabled is a web-exposed property? If so, then it seems that this change is a web-exposed change in behavior, not just a refactoring. If that is right, then we need a regression test and we need to be sure this is a correct change. No. Web-exposed 'disabled' IDL attributes are [Reflected]. Also, SliderThumbElement and SpinButtonElement are not Web-exposed. 862066 7 darin 2013-03-22 18:29:30 -0700 (In reply to comment #6) > Web-exposed 'disabled' IDL attributes are [Reflected]. Aha! Then it is critical to eliminate or rename the C++ member function named disabled since it is not the same as the web-exposed function named disabled, which is super-confusing! 862067 8 tkent 2013-03-22 18:32:10 -0700 (In reply to comment #7) > Then it is critical to eliminate or rename the C++ member function named disabled since it is not the same as the web-exposed function named disabled, which is super-confusing! Indeed. I'd like to rename HTMLFormControlElement::readOnly too because of the same reason. 862068 9 falken 2013-03-22 18:36:06 -0700 (In reply to comment #7) > Then it is critical to eliminate or rename the C++ member function named disabled since it is not the same as the web-exposed function named disabled, which is super-confusing! I'm hoping to do this: bug 112085, comment 13 194420 2013-03-21 19:40:53 -0700 2013-03-22 12:03:49 -0700 Patch bug-112993-20130322113641.patch text/plain 4159 falken U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ2NDgxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDBlNGE2YThiOWQ0MzEx OGU3YTM1MWMxN2VmNTJmNWQ0YmJjZDJiYi4uMDMxNWM1MDQ5ZDY2NjI2ZjIxNGMwMjE0OGMzZmMz N2MxYTI1NWI3MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI5IEBACisyMDEzLTAzLTIxICBNYXR0 IEZhbGtlbmhhZ2VuICA8ZmFsa2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBJbXBsZW1lbnQg aXNFbmFibGVkRm9ybUNvbnRyb2woKSBmb3IgU2xpZGVyVGh1bWJFbGVtZW50IGFuZCBTcGluQnV0 dG9uRWxlbWVudCBpbiB0ZXJtcyBvZiBkaXNhYmxlZCgpCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTI5OTMKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIGlzIGFuIGludGVybWVkaWF0ZSBzdGVwIGZv ciByZWZhY3RvcmluZyBOb2RlOjpkaXNhYmxlZCBhbmQKKyAgICAgICAgRWxlbWVudDo6aXNFbmFi bGVkRm9ybUNvbnRyb2wuIEFsbCBjbGFzc2VzIHRoYXQgb3ZlcnJpZGUKKyAgICAgICAgaXNFbmFi bGVkRm9ybUNvbnRyb2wganVzdCByZXR1cm4gIWRpc2FibGVkKCksIGV4Y2VwdCBmb3IKKyAgICAg ICAgU2xpZGVyVGh1bWJFbGVtZW50IGFuZCBTcGluQnV0dG9uRWxlbWVudC4gVGhpcyBwYXRjaCBj aGFuZ2VzIHRob3NlIHR3bworICAgICAgICBjbGFzc2VzIHRvIGRvIHNvLCB3aGljaCBzaG93cyB0 aGF0IHRoZSB0d28gZnVuY3Rpb25zIGFyZSByZWR1bmRhbnQgYW5kCisgICAgICAgIGVhc3kgdG8g cmVmYWN0b3IgaW50byBhIHNpbmdsZSBmdW5jdGlvbiBpbiBhIHN1YnNlcXVlbnQgcGF0Y2guCisK KyAgICAgICAgTm8gbmV3IHRlc3RzLCB0aGVyZSBzaG91bGQgYmUgbm8gYmVoYXZpb3IgY2hhbmdl LgorCisgICAgICAgICogaHRtbC9zaGFkb3cvU2xpZGVyVGh1bWJFbGVtZW50LmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OlNsaWRlclRodW1iRWxlbWVudDo6ZGlzYWJsZWQpOgorICAgICAgICAoV2Vi Q29yZSk6CisgICAgICAgIChXZWJDb3JlOjpTbGlkZXJUaHVtYkVsZW1lbnQ6OmlzRW5hYmxlZEZv cm1Db250cm9sKToKKyAgICAgICAgKiBodG1sL3NoYWRvdy9TbGlkZXJUaHVtYkVsZW1lbnQuaDoK KyAgICAgICAgKFNsaWRlclRodW1iRWxlbWVudCk6CisgICAgICAgICogaHRtbC9zaGFkb3cvU3Bp bkJ1dHRvbkVsZW1lbnQuaDogVGhlIGNoZWNrIG9mIHNoYWRvd0hvc3QoKSBpcworICAgICAgICBu ZWNlc3NhcnkgYmVjYXVzZSBpdCBjYW4gYmUgZGV0YWNoZWQgYnkgSmF2YVNjcmlwdCB0aGF0IHJ1 bnMgZHVyaW5nCisgICAgICAgIGV2ZW50IGhhbmRsaW5nIChzZWUgcjc2NTY2KQorCiAyMDEzLTAz LTIxICBTdWRhcnNhbmEgTmFnaW5lbmkgIDxzdWRhcnNhbmEubmFnaW5lbmlAaW50ZWwuY29tPgog CiAgICAgICAgIFtHU3RyZWFtZXJdIE5ldyByZWZlcmVuY2UgcmV0dXJuZWQgYnkgZ19tYWluX2Nv bnRleHRfbmV3KCkgbXVzdCBiZSBmcmVlZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRt bC9zaGFkb3cvU2xpZGVyVGh1bWJFbGVtZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvc2hh ZG93L1NsaWRlclRodW1iRWxlbWVudC5jcHAKaW5kZXggZjExZTBlMWE3Yzc1YTVhZDg5NjY4N2Jh YzFmZDc5ZDhiYTBmOGE4Mi4uMDIxNjBmODg4NGNjZTE4M2EzM2NkOGE2YTA2NmRmMGNmNGNjMzY1 NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9zaGFkb3cvU2xpZGVyVGh1bWJFbGVt ZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL3NoYWRvdy9TbGlkZXJUaHVtYkVsZW1l bnQuY3BwCkBAIC0yMjEsOSArMjIxLDE0IEBAIFJlbmRlck9iamVjdCogU2xpZGVyVGh1bWJFbGVt ZW50OjpjcmVhdGVSZW5kZXJlcihSZW5kZXJBcmVuYSogYXJlbmEsIFJlbmRlclN0eWxlCiAgICAg cmV0dXJuIG5ldyAoYXJlbmEpIFJlbmRlclNsaWRlclRodW1iKHRoaXMpOwogfQogCitib29sIFNs aWRlclRodW1iRWxlbWVudDo6ZGlzYWJsZWQoKSBjb25zdAoreworICAgIHJldHVybiBob3N0SW5w dXQoKS0+ZGlzYWJsZWQoKTsKK30KKwogYm9vbCBTbGlkZXJUaHVtYkVsZW1lbnQ6OmlzRW5hYmxl ZEZvcm1Db250cm9sKCkgY29uc3QKIHsKLSAgICByZXR1cm4gaG9zdElucHV0KCktPmlzRW5hYmxl ZEZvcm1Db250cm9sKCk7CisgICAgcmV0dXJuICFkaXNhYmxlZCgpOwogfQogCiBib29sIFNsaWRl clRodW1iRWxlbWVudDo6bWF0Y2hlc1JlYWRPbmx5UHNldWRvQ2xhc3MoKSBjb25zdApkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9zaGFkb3cvU2xpZGVyVGh1bWJFbGVtZW50LmggYi9T b3VyY2UvV2ViQ29yZS9odG1sL3NoYWRvdy9TbGlkZXJUaHVtYkVsZW1lbnQuaAppbmRleCA4OGFm ZjY0MDNkYjNjZDYxYzMzNGZkNDZmZWUwYTVkOWFmMTk5NWE1Li5kZTUxMDM3OGVlZDU1ODNkZjky OThkODcyNGI5NDY4NGZiNTU3ZTRmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL3No YWRvdy9TbGlkZXJUaHVtYkVsZW1lbnQuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL3NoYWRv dy9TbGlkZXJUaHVtYkVsZW1lbnQuaApAQCAtNjUsNyArNjUsOCBAQCBwcml2YXRlOgogICAgIFNs aWRlclRodW1iRWxlbWVudChEb2N1bWVudCopOwogICAgIHZpcnR1YWwgUmVuZGVyT2JqZWN0KiBj cmVhdGVSZW5kZXJlcihSZW5kZXJBcmVuYSosIFJlbmRlclN0eWxlKik7CiAgICAgdmlydHVhbCBQ YXNzUmVmUHRyPEVsZW1lbnQ+IGNsb25lRWxlbWVudFdpdGhvdXRBdHRyaWJ1dGVzQW5kQ2hpbGRy ZW4oKTsKLSAgICB2aXJ0dWFsIGJvb2wgaXNFbmFibGVkRm9ybUNvbnRyb2woKSBjb25zdDsKKyAg ICB2aXJ0dWFsIGJvb2wgZGlzYWJsZWQoKSBjb25zdCBPVkVSUklERTsKKyAgICB2aXJ0dWFsIGJv b2wgaXNFbmFibGVkRm9ybUNvbnRyb2woKSBjb25zdCBPVkVSUklERTsKICAgICB2aXJ0dWFsIGJv b2wgbWF0Y2hlc1JlYWRPbmx5UHNldWRvQ2xhc3MoKSBjb25zdCBPVkVSUklERTsKICAgICB2aXJ0 dWFsIGJvb2wgbWF0Y2hlc1JlYWRXcml0ZVBzZXVkb0NsYXNzKCkgY29uc3QgT1ZFUlJJREU7CiAg ICAgdmlydHVhbCBOb2RlKiBmb2N1c0RlbGVnYXRlKCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9odG1sL3NoYWRvdy9TcGluQnV0dG9uRWxlbWVudC5oIGIvU291cmNlL1dlYkNvcmUvaHRt bC9zaGFkb3cvU3BpbkJ1dHRvbkVsZW1lbnQuaAppbmRleCAyZjAwZDgyM2NkMmE0MDU2NzZlM2Uz YTg1NjY4NWRhZTczOTNmYWNmLi41NDlhZTQ0OTA4N2RmYzFmYjU4MGY1ZjgwOGVjZDI5NmQ4NzIz MTVlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL3NoYWRvdy9TcGluQnV0dG9uRWxl bWVudC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvc2hhZG93L1NwaW5CdXR0b25FbGVtZW50 LmgKQEAgLTcyLDcgKzcyLDggQEAgcHJpdmF0ZToKICAgICB2aXJ0dWFsIGNvbnN0IEF0b21pY1N0 cmluZyYgc2hhZG93UHNldWRvSWQoKSBjb25zdDsKICAgICB2aXJ0dWFsIHZvaWQgZGV0YWNoKCk7 CiAgICAgdmlydHVhbCBib29sIGlzU3BpbkJ1dHRvbkVsZW1lbnQoKSBjb25zdCB7IHJldHVybiB0 cnVlOyB9Ci0gICAgdmlydHVhbCBib29sIGlzRW5hYmxlZEZvcm1Db250cm9sKCkgY29uc3QgeyBy ZXR1cm4gc2hhZG93SG9zdCgpLT5pc0VuYWJsZWRGb3JtQ29udHJvbCgpOyB9CisgICAgdmlydHVh bCBib29sIGRpc2FibGVkKCkgY29uc3QgT1ZFUlJJREUgeyByZXR1cm4gc2hhZG93SG9zdCgpICYm IHNoYWRvd0hvc3QoKS0+ZGlzYWJsZWQoKTsgfQorICAgIHZpcnR1YWwgYm9vbCBpc0VuYWJsZWRG b3JtQ29udHJvbCgpIGNvbnN0IE9WRVJSSURFIHsgcmV0dXJuICFkaXNhYmxlZCgpOyB9CiAgICAg dmlydHVhbCBib29sIG1hdGNoZXNSZWFkT25seVBzZXVkb0NsYXNzKCkgY29uc3QgT1ZFUlJJREU7 CiAgICAgdmlydHVhbCBib29sIG1hdGNoZXNSZWFkV3JpdGVQc2V1ZG9DbGFzcygpIGNvbnN0IE9W RVJSSURFOwogICAgIHZpcnR1YWwgdm9pZCBkZWZhdWx0RXZlbnRIYW5kbGVyKEV2ZW50Kik7Cg==