112989 2013-03-21 17:48:17 -0700 [wk2] Page Overlays: Don't create backing store until the client asks us to paint 2013-03-21 18:41:57 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton andersca dino sam simon.fraser oldest_to_newest 860942 0 thorton 2013-03-21 17:48:17 -0700 There's no reason to create backing store for a page overlay if the client hasn't painted. There are cases where a client will install a page overlay solely in order to get its mouse-tracking functionality, or who will paint much later - there's no reason to be hanging on to (and wasting time compositing) a layer or tiles for the entire size of the view if they're just transparent. <rdar://problem/13355759> 860973 1 194411 thorton 2013-03-21 18:32:24 -0700 Created attachment 194411 patch 860974 2 194412 thorton 2013-03-21 18:32:24 -0700 Created attachment 194412 860981 3 194411 andersca 2013-03-21 18:35:40 -0700 Comment on attachment 194411 patch View in context: https://bugs.webkit.org/attachment.cgi?id=194411&action=review > Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:419 > for (PageOverlayLayerMap::iterator it = m_pageOverlayLayers.begin(); it != end; ++it) > - it->value->setSize(viewSize); > + if (it->value->drawsContent()) > + it->value->setSize(viewSize); Please add braces around the for loop and put it->value in its own variable. 860985 4 thorton 2013-03-21 18:41:57 -0700 http://trac.webkit.org/changeset/146551 194411 2013-03-21 18:32:24 -0700 2013-03-21 18:35:39 -0700 patch page-overlay-invalidation.diff text/plain 5494 thorton ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAzZjQ2NjFiLi44OWVjODljIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMzIg QEAKIDIwMTMtMDMtMjEgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CiAK KyAgICAgICAgW3drMl0gUGFnZSBPdmVybGF5czogRG9uJ3QgY3JlYXRlIGJhY2tpbmcgc3RvcmUg dW50aWwgdGhlIGNsaWVudCBhc2tzIHVzIHRvIHBhaW50CisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTI5ODkKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVt LzEzMzU1NzU5PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9XZWJJbnNwZWN0b3JDbGllbnQuY3BwOgor ICAgICAgICAoV2ViS2l0OjpXZWJJbnNwZWN0b3JDbGllbnQ6OmhpZ2hsaWdodCk6CisgICAgICAg ICogV2ViUHJvY2Vzcy9XZWJQYWdlL0ZpbmRDb250cm9sbGVyLmNwcDoKKyAgICAgICAgKFdlYktp dDo6RmluZENvbnRyb2xsZXI6OnVwZGF0ZUZpbmRVSUFmdGVyUGFnZVNjcm9sbCk6CisgICAgICAg IEludmFsaWRhdGUgdGhlIGVudGlyZSBvdmVybGF5IG9uIGluc3RhbGxhdGlvbiwgdG8gbWFpbnRh aW4gZXhpc3RpbmcgYmVoYXZpb3IKKyAgICAgICAgb24gcGxhdGZvcm1zIHdoZXJlIHRoZSBmYWRl LWluIGFuaW1hdGlvbiBpcyBub3QgcGVyZm9ybWVkIGJ5IGludmFsaWRhdGluZyB0aGUgb3Zlcmxh eS4KKworICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNwcDoKKyAgICAgICAg KFdlYktpdDo6V2ViUGFnZTo6aW5zdGFsbFBhZ2VPdmVybGF5KToKKyAgICAgICAgRG9uJ3QgaW52 YWxpZGF0ZSB0aGUgb3ZlcmxheSB1cG9uIGluc3RhbGxhdGlvbi4KKworICAgICAgICAqIFdlYlBy b2Nlc3MvV2ViUGFnZS9tYWMvVGlsZWRDb3JlQW5pbWF0aW9uRHJhd2luZ0FyZWEubW06CisgICAg ICAgIChXZWJLaXQ6OlRpbGVkQ29yZUFuaW1hdGlvbkRyYXdpbmdBcmVhOjpzZXRQYWdlT3Zlcmxh eU5lZWRzRGlzcGxheSk6CisgICAgICAgIENyZWF0ZSBiYWNraW5nIHN0b3JlIGZvciB0aGUgcGFn ZSBvdmVybGF5IGxheWVyIHRoZSBmaXJzdCB0aW1lIGl0IGlzIHBhaW50ZWQgaW50by4KKyAgICAg ICAgKFdlYktpdDo6VGlsZWRDb3JlQW5pbWF0aW9uRHJhd2luZ0FyZWE6OnVwZGF0ZUdlb21ldHJ5 KToKKyAgICAgICAgRG9uJ3QgdXBkYXRlIHRoZSBzaXplIG9mIHRoZSBwYWdlIG92ZXJsYXkgbGF5 ZXIgdW5sZXNzIHdlIGludGVuZCBmb3IgaXQgdG8gaGF2ZSBiYWNraW5nIHN0b3JlLgorICAgICAg ICAoV2ViS2l0OjpUaWxlZENvcmVBbmltYXRpb25EcmF3aW5nQXJlYTo6Y3JlYXRlUGFnZU92ZXJs YXlMYXllcik6CisgICAgICAgIERvbid0IGNyZWF0ZSBiYWNraW5nIHN0b3JlIHdoZW4gd2UgY3Jl YXRlIHRoZSBwYWdlIG92ZXJsYXkgbGF5ZXIuCisKKzIwMTMtMDMtMjEgIFRpbSBIb3J0b24gIDx0 aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisKICAgICAgICAgVW5yZXZpZXdlZCBidWlsZCBmaXgs IGZvcmdvdCB0byBzdGFnZSBvbmUgZmlsZS4KIAogICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFn ZS9EcmF3aW5nQXJlYS5oOgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9X ZWJDb3JlU3VwcG9ydC9XZWJJbnNwZWN0b3JDbGllbnQuY3BwIGIvU291cmNlL1dlYktpdDIvV2Vi UHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9XZWJJbnNwZWN0b3JDbGllbnQuY3BwCmluZGV4IGZmODU1 MTIuLjMzNmVhOTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViQ29y ZVN1cHBvcnQvV2ViSW5zcGVjdG9yQ2xpZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQ cm9jZXNzL1dlYkNvcmVTdXBwb3J0L1dlYkluc3BlY3RvckNsaWVudC5jcHAKQEAgLTczLDYgKzcz LDcgQEAgdm9pZCBXZWJJbnNwZWN0b3JDbGllbnQ6OmhpZ2hsaWdodCgpCiAgICAgICAgIFJlZlB0 cjxQYWdlT3ZlcmxheT4gaGlnaGxpZ2h0T3ZlcmxheSA9IFBhZ2VPdmVybGF5OjpjcmVhdGUodGhp cyk7CiAgICAgICAgIG1faGlnaGxpZ2h0T3ZlcmxheSA9IGhpZ2hsaWdodE92ZXJsYXkuZ2V0KCk7 CiAgICAgICAgIG1fcGFnZS0+aW5zdGFsbFBhZ2VPdmVybGF5KGhpZ2hsaWdodE92ZXJsYXkucmVs ZWFzZSgpLCB0cnVlKTsKKyAgICAgICAgbV9oaWdobGlnaHRPdmVybGF5LT5zZXROZWVkc0Rpc3Bs YXkoKTsKICAgICB9IGVsc2UgewogICAgICAgICBtX2hpZ2hsaWdodE92ZXJsYXktPnN0b3BGYWRl T3V0QW5pbWF0aW9uKCk7CiAgICAgICAgIG1faGlnaGxpZ2h0T3ZlcmxheS0+c2V0TmVlZHNEaXNw bGF5KCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvRmlu ZENvbnRyb2xsZXIuY3BwIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL0ZpbmRD b250cm9sbGVyLmNwcAppbmRleCA3MDQxODNkLi5mNDY3OGJhIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvRmluZENvbnRyb2xsZXIuY3BwCisrKyBiL1NvdXJj ZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9GaW5kQ29udHJvbGxlci5jcHAKQEAgLTE3MCwx MCArMTcwLDkgQEAgdm9pZCBGaW5kQ29udHJvbGxlcjo6dXBkYXRlRmluZFVJQWZ0ZXJQYWdlU2Ny b2xsKGJvb2wgZm91bmQsIGNvbnN0IFN0cmluZyYgc3RyaW4KICAgICAgICAgICAgIFJlZlB0cjxQ YWdlT3ZlcmxheT4gZmluZFBhZ2VPdmVybGF5ID0gUGFnZU92ZXJsYXk6OmNyZWF0ZSh0aGlzKTsK ICAgICAgICAgICAgIG1fZmluZFBhZ2VPdmVybGF5ID0gZmluZFBhZ2VPdmVybGF5LmdldCgpOwog ICAgICAgICAgICAgbV93ZWJQYWdlLT5pbnN0YWxsUGFnZU92ZXJsYXkoZmluZFBhZ2VPdmVybGF5 LnJlbGVhc2UoKSwgdHJ1ZSk7Ci0gICAgICAgIH0gZWxzZSB7Ci0gICAgICAgICAgICAvLyBUaGUg cGFnZSBvdmVybGF5IG5lZWRzIHRvIGJlIHJlcGFpbnRlZC4KICAgICAgICAgICAgIG1fZmluZFBh Z2VPdmVybGF5LT5zZXROZWVkc0Rpc3BsYXkoKTsKLSAgICAgICAgfQorICAgICAgICB9IGVsc2UK KyAgICAgICAgICAgIG1fZmluZFBhZ2VPdmVybGF5LT5zZXROZWVkc0Rpc3BsYXkoKTsKICAgICB9 CiB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQ YWdlLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNwcApp bmRleCAzM2IyNWViLi40ZmY1MGU4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9j ZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9X ZWJQYWdlL1dlYlBhZ2UuY3BwCkBAIC0xMzYwLDcgKzEzNjAsNiBAQCB2b2lkIFdlYlBhZ2U6Omlu c3RhbGxQYWdlT3ZlcmxheShQYXNzUmVmUHRyPFBhZ2VPdmVybGF5PiBwYWdlT3ZlcmxheSwgYm9v bCBzaG91bAogICAgICAgICBvdmVybGF5LT5zdGFydEZhZGVJbkFuaW1hdGlvbigpOwogCiAgICAg bV9kcmF3aW5nQXJlYS0+ZGlkSW5zdGFsbFBhZ2VPdmVybGF5KG92ZXJsYXkuZ2V0KCkpOwotICAg IG92ZXJsYXktPnNldE5lZWRzRGlzcGxheSgpOwogfQogCiB2b2lkIFdlYlBhZ2U6OnVuaW5zdGFs bFBhZ2VPdmVybGF5KFBhZ2VPdmVybGF5KiBwYWdlT3ZlcmxheSwgYm9vbCBzaG91bGRGYWRlT3V0 KQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL21hYy9UaWxl ZENvcmVBbmltYXRpb25EcmF3aW5nQXJlYS5tbSBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3Mv V2ViUGFnZS9tYWMvVGlsZWRDb3JlQW5pbWF0aW9uRHJhd2luZ0FyZWEubW0KaW5kZXggYTJjYjE3 NS4uZWFlZjljMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdl L21hYy9UaWxlZENvcmVBbmltYXRpb25EcmF3aW5nQXJlYS5tbQorKysgYi9Tb3VyY2UvV2ViS2l0 Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvbWFjL1RpbGVkQ29yZUFuaW1hdGlvbkRyYXdpbmdBcmVhLm1t CkBAIC0yMTAsNiArMjEwLDExIEBAIHZvaWQgVGlsZWRDb3JlQW5pbWF0aW9uRHJhd2luZ0FyZWE6 OnNldFBhZ2VPdmVybGF5TmVlZHNEaXNwbGF5KFBhZ2VPdmVybGF5KiBwYWdlCiAgICAgaWYgKCFs YXllcikKICAgICAgICAgcmV0dXJuOwogCisgICAgaWYgKCFsYXllci0+ZHJhd3NDb250ZW50KCkp IHsKKyAgICAgICAgbGF5ZXItPnNldERyYXdzQ29udGVudCh0cnVlKTsKKyAgICAgICAgbGF5ZXIt PnNldFNpemUoZXhwYW5kZWRJbnRTaXplKEZsb2F0U2l6ZShtX3Jvb3RMYXllci5nZXQoKS5mcmFt ZS5zaXplKSkpOworICAgIH0KKwogICAgIGxheWVyLT5zZXROZWVkc0Rpc3BsYXlJblJlY3QocmVj dCk7CiAgICAgc2NoZWR1bGVDb21wb3NpdGluZ0xheWVyRmx1c2goKTsKIH0KQEAgLTQxMCw3ICs0 MTUsOCBAQCB2b2lkIFRpbGVkQ29yZUFuaW1hdGlvbkRyYXdpbmdBcmVhOjp1cGRhdGVHZW9tZXRy eShjb25zdCBJbnRTaXplJiB2aWV3U2l6ZSkKIAogICAgIFBhZ2VPdmVybGF5TGF5ZXJNYXA6Oml0 ZXJhdG9yIGVuZCA9IG1fcGFnZU92ZXJsYXlMYXllcnMuZW5kKCk7CiAgICAgZm9yIChQYWdlT3Zl cmxheUxheWVyTWFwOjppdGVyYXRvciBpdCA9IG1fcGFnZU92ZXJsYXlMYXllcnMuYmVnaW4oKTsg aXQgIT0gZW5kOyArK2l0KQotICAgICAgICBpdC0+dmFsdWUtPnNldFNpemUodmlld1NpemUpOwor ICAgICAgICBpZiAoaXQtPnZhbHVlLT5kcmF3c0NvbnRlbnQoKSkKKyAgICAgICAgICAgIGl0LT52 YWx1ZS0+c2V0U2l6ZSh2aWV3U2l6ZSk7CiAKICAgICBpZiAoIW1fbGF5ZXJUcmVlU3RhdGVJc0Zy b3plbikKICAgICAgICAgZmx1c2hMYXllcnMoKTsKQEAgLTUyNSw4ICs1MzEsNiBAQCB2b2lkIFRp bGVkQ29yZUFuaW1hdGlvbkRyYXdpbmdBcmVhOjpjcmVhdGVQYWdlT3ZlcmxheUxheWVyKFBhZ2VP dmVybGF5KiBwYWdlT3ZlcgogI2VuZGlmCiAKICAgICBsYXllci0+c2V0QWNjZWxlcmF0ZXNEcmF3 aW5nKG1fd2ViUGFnZS0+Y29yZVBhZ2UoKS0+c2V0dGluZ3MoKS0+YWNjZWxlcmF0ZWREcmF3aW5n RW5hYmxlZCgpKTsKLSAgICBsYXllci0+c2V0RHJhd3NDb250ZW50KHRydWUpOwotICAgIGxheWVy LT5zZXRTaXplKGV4cGFuZGVkSW50U2l6ZShGbG9hdFNpemUobV9yb290TGF5ZXIuZ2V0KCkuZnJh bWUuc2l6ZSkpKTsKICAgICBsYXllci0+c2V0U2hvd0RlYnVnQm9yZGVyKG1fd2ViUGFnZS0+Y29y ZVBhZ2UoKS0+c2V0dGluZ3MoKS0+c2hvd0RlYnVnQm9yZGVycygpKTsKICAgICBsYXllci0+c2V0 U2hvd1JlcGFpbnRDb3VudGVyKG1fd2ViUGFnZS0+Y29yZVBhZ2UoKS0+c2V0dGluZ3MoKS0+c2hv d1JlcGFpbnRDb3VudGVyKCkpOwogCg==