112978 2013-03-21 16:32:46 -0700 [chromium] Linux ASAN WebKit canary is running out of memory 2013-03-21 17:27:40 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED NRWT P2 Normal --- 1 dpranke dpranke abarth antonm eric inferno phajdan.jr thakis thestig tony webkit.review.bot oldest_to_newest 860857 0 dpranke 2013-03-21 16:32:46 -0700 turns out that running the ASAN processing on the stderr takes an enormous amount of memory, and if you run multiple of these at a time, you can run out of memory on the bot (looks like we can manage two on the bot now, but three probably causes us to run out of memory). See, e.g.: http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20ASAN/builds/5269/steps/webkit_tests/logs/stdio It'd not obvious that there's a great answer here, but for the moment I'm going to try serializing the asan_filter script so we only run one at a time ... 860866 1 194383 dpranke 2013-03-21 16:44:03 -0700 Created attachment 194383 Patch 860869 2 tony 2013-03-21 16:46:46 -0700 Are you trying to lock across python processes? Why don't we just prepend flock to the commands you want to serialize? 860874 3 dpranke 2013-03-21 16:49:13 -0700 (In reply to comment #2) > Are you trying to lock across python processes? Why don't we just prepend flock to the commands you want to serialize? Well, this is portable to windows (not that we run asan on windows) and happened to reuse the well-tested stuff we have lying around :). I can change it to just use flock if you'd prefer. 860875 4 dpranke 2013-03-21 16:49:52 -0700 but, yes, we're trying to lock across processes. 860878 5 dpranke 2013-03-21 16:50:48 -0700 oh, one minor additional difference is that http_lock code ensures access is granted in order (FIFO). AFAIK, regular flock doesn't do that? 860879 6 dpranke 2013-03-21 16:51:03 -0700 that may also not really matter in this case. 860894 7 194383 tony 2013-03-21 17:02:38 -0700 Comment on attachment 194383 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=194383&action=review I think it's OK to use HttpLock, but it's a bit confusing (due to naming) and I have more confidence in flock. > Tools/Scripts/webkitpy/layout_tests/port/chromium.py:383 > + stderr = self._executive.run_command(['c++filt'], input=output, decode_output=False) Can we run c++filt outside the lock? That's not expensive, is it? Should there be a unit test for this? 860895 8 194383 tony 2013-03-21 17:03:22 -0700 Comment on attachment 194383 Patch Feel free to try this, I won't be around later tonight for further reviews. 860897 9 194383 dpranke 2013-03-21 17:07:42 -0700 Comment on attachment 194383 Patch thanks! 860921 10 194383 webkit.review.bot 2013-03-21 17:27:36 -0700 Comment on attachment 194383 Patch Clearing flags on attachment: 194383 Committed r146546: <http://trac.webkit.org/changeset/146546> 860922 11 webkit.review.bot 2013-03-21 17:27:40 -0700 All reviewed patches have been landed. Closing bug. 194383 2013-03-21 16:44:03 -0700 2013-03-21 17:27:36 -0700 Patch bug-112978-20130321163952.patch text/plain 5359 dpranke U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ2NDA5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNTc5ZmI2MTkzMWQyNzYxMjQ4NmEwMmNiM2RmMzU0ZWFm YmEwMmZiMy4uNGM4NzM0ODllYmNkNzRhODg5NDY4YzNlM2RiOTdiMzlkMGU5ODAzZCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIw IEBACisyMDEzLTAzLTIxICBEaXJrIFByYW5rZSAgPGRwcmFua2VAY2hyb21pdW0ub3JnPgorCisg ICAgICAgIFtjaHJvbWl1bV0gTGludXggQVNBTiBXZWJLaXQgY2FuYXJ5IGlzIHJ1bm5pbmcgb3V0 IG9mIG1lbW9yeQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTEyOTc4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgUnVubmluZyB0aGUgQWRkcmVzc1Nhbml0aXplciBvbiBhIGNyYXNoIHRha2VzIGEgbG90IG9m CisgICAgICAgIG1lbW9yeSwgc28gd2Ugc2hvdWxkIHNlcmlhbGl6ZSBhY2Nlc3MgdG8gaXQgdG8g YXZvaWQgcnVubmluZworICAgICAgICBvdXQgb2YgbWVtb3J5IG9uIGEgbWFjaGluZS4KKworICAg ICAgICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvY2hyb21pdW0ucHk6Cisg ICAgICAgIChDaHJvbWl1bVBvcnQuX2dldF9jcmFzaF9sb2cpOgorICAgICAgICAqIFNjcmlwdHMv d2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvaHR0cF9sb2NrLnB5OgorICAgICAgICAoSHR0cExv Y2suX19pbml0X18pOgorICAgICAgICAoSHR0cExvY2sud2FpdF9mb3JfaHR0cGRfbG9jayk6CisK IDIwMTMtMDMtMjAgIEJlbmphbWluIFBvdWxhaW4gIDxicG91bGFpbkBhcHBsZS5jb20+CiAKICAg ICAgICAgW1dLMl0gUmVtb3ZlIFZJRVdfTU9ERV9DU1NfTUVESUEgZnJvbSBXZWJLaXQyCmRpZmYg LS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2Nocm9taXVt LnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9jaHJvbWl1bS5w eQppbmRleCA4M2UxNzk1ZWMyNWY5NWIxYTcyMjQ1OWY1N2VjMjZjN2YyYmJkNDNjLi5hYTRkMzBj NjkwNDBhYWVhNDFlMDJkMjlkY2Y2N2JmNzAwYmUyYmQ2IDEwMDY0NAotLS0gYS9Ub29scy9TY3Jp cHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2Nocm9taXVtLnB5CisrKyBiL1Rvb2xzL1Nj cmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvY2hyb21pdW0ucHkKQEAgLTQxLDYgKzQx LDcgQEAgZnJvbSB3ZWJraXRweS5jb21tb24uc3lzdGVtIGltcG9ydCBleGVjdXRpdmUKIGZyb20g d2Via2l0cHkuY29tbW9uLnN5c3RlbS5wYXRoIGltcG9ydCBjeWdwYXRoCiBmcm9tIHdlYmtpdHB5 LmxheW91dF90ZXN0cy5tb2RlbHMudGVzdF9jb25maWd1cmF0aW9uIGltcG9ydCBUZXN0Q29uZmln dXJhdGlvbgogZnJvbSB3ZWJraXRweS5sYXlvdXRfdGVzdHMucG9ydC5iYXNlIGltcG9ydCBQb3J0 LCBWaXJ0dWFsVGVzdFN1aXRlCitmcm9tIHdlYmtpdHB5LmxheW91dF90ZXN0cy5wb3J0Lmh0dHBf bG9jayBpbXBvcnQgSHR0cExvY2sKIAogCiBfbG9nID0gbG9nZ2luZy5nZXRMb2dnZXIoX19uYW1l X18pCkBAIC0zNjksMTAgKzM3MCwxOSBAQCBjbGFzcyBDaHJvbWl1bVBvcnQoUG9ydCk6CiAKICAg ICBkZWYgX2dldF9jcmFzaF9sb2coc2VsZiwgbmFtZSwgcGlkLCBzdGRvdXQsIHN0ZGVyciwgbmV3 ZXJfdGhhbik6CiAgICAgICAgIGlmIHN0ZGVyciBhbmQgJ0FkZHJlc3NTYW5pdGl6ZXInIGluIHN0 ZGVycjoKLSAgICAgICAgICAgIGFzYW5fZmlsdGVyX3BhdGggPSBzZWxmLnBhdGhfZnJvbV9jaHJv bWl1bV9iYXNlKCd0b29scycsICd2YWxncmluZCcsICdhc2FuJywgJ2FzYW5fc3ltYm9saXplLnB5 JykKLSAgICAgICAgICAgIGlmIHNlbGYuX2ZpbGVzeXN0ZW0uZXhpc3RzKGFzYW5fZmlsdGVyX3Bh dGgpOgotICAgICAgICAgICAgICAgIG91dHB1dCA9IHNlbGYuX2V4ZWN1dGl2ZS5ydW5fY29tbWFu ZChbYXNhbl9maWx0ZXJfcGF0aF0sIGlucHV0PXN0ZGVyciwgZGVjb2RlX291dHB1dD1GYWxzZSkK LSAgICAgICAgICAgICAgICBzdGRlcnIgPSBzZWxmLl9leGVjdXRpdmUucnVuX2NvbW1hbmQoWydj KytmaWx0J10sIGlucHV0PW91dHB1dCwgZGVjb2RlX291dHB1dD1GYWxzZSkKKyAgICAgICAgICAg ICMgUnVubmluZyB0aGUgQWRkcmVzc1Nhbml0aXplciB0YWtlIGEgbG90IG9mIG1lbW9yeSwgc28g d2UgbmVlZCB0bworICAgICAgICAgICAgIyBzZXJpYWxpemUgYWNjZXNzIHRvIGl0IGFjcm9zcyBh bGwgdGhlIGNvbmN1cnJlbnRseSBydW5uaW5nIGRyaXZlcnMuCisgICAgICAgICAgICBsb2NrID0g SHR0cExvY2sobG9ja19wYXRoPU5vbmUsIGxvY2tfZmlsZV9wcmVmaXg9J1dlYktpdEFTQU4ubG9j ay4nLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgIGZpbGVzeXN0ZW09c2VsZi5fZmlsZXN5 c3RlbSwgZXhlY3V0aXZlPXNlbGYuX2V4ZWN1dGl2ZSwKKyAgICAgICAgICAgICAgICAgICAgICAg ICAgICBuYW1lPSdBU0FOJykKKyAgICAgICAgICAgIHRyeToKKyAgICAgICAgICAgICAgICBsb2Nr LndhaXRfZm9yX2h0dHBkX2xvY2soKQorICAgICAgICAgICAgICAgIGFzYW5fZmlsdGVyX3BhdGgg PSBzZWxmLnBhdGhfZnJvbV9jaHJvbWl1bV9iYXNlKCd0b29scycsICd2YWxncmluZCcsICdhc2Fu JywgJ2FzYW5fc3ltYm9saXplLnB5JykKKyAgICAgICAgICAgICAgICBpZiBzZWxmLl9maWxlc3lz dGVtLmV4aXN0cyhhc2FuX2ZpbHRlcl9wYXRoKToKKyAgICAgICAgICAgICAgICAgICAgb3V0cHV0 ID0gc2VsZi5fZXhlY3V0aXZlLnJ1bl9jb21tYW5kKFthc2FuX2ZpbHRlcl9wYXRoXSwgaW5wdXQ9 c3RkZXJyLCBkZWNvZGVfb3V0cHV0PUZhbHNlKQorICAgICAgICAgICAgICAgICAgICBzdGRlcnIg PSBzZWxmLl9leGVjdXRpdmUucnVuX2NvbW1hbmQoWydjKytmaWx0J10sIGlucHV0PW91dHB1dCwg ZGVjb2RlX291dHB1dD1GYWxzZSkKKyAgICAgICAgICAgIGZpbmFsbHk6CisgICAgICAgICAgICAg ICAgbG9jay5jbGVhbnVwX2h0dHBfbG9jaygpCiAKICAgICAgICAgcmV0dXJuIHN1cGVyKENocm9t aXVtUG9ydCwgc2VsZikuX2dldF9jcmFzaF9sb2cobmFtZSwgcGlkLCBzdGRvdXQsIHN0ZGVyciwg bmV3ZXJfdGhhbikKIApkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRf dGVzdHMvcG9ydC9odHRwX2xvY2sucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90 ZXN0cy9wb3J0L2h0dHBfbG9jay5weQppbmRleCBhZjBlZmMyMmM1ZTkzNDc2MGFkYjQxZGJkNjJh NjBjOTcyZWM4NGNjLi5iZGRlMzdlMzJiMzhhZTllZjFjYTNmMTMyODM3MDcyODMwNDc1OTU0IDEw MDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2h0dHBf bG9jay5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2h0 dHBfbG9jay5weQpAQCAtMjQsNiArMjQsOSBAQAogIyAoSU5DTFVESU5HIE5FR0xJR0VOQ0UgT1Ig T1RIRVJXSVNFKSBBUklTSU5HIElOIEFOWSBXQVkgT1VUIE9GIFRIRSBVU0UKICMgT0YgVEhJUyBT T0ZUV0FSRSwgRVZFTiBJRiBBRFZJU0VEIE9GIFRIRSBQT1NTSUJJTElUWSBPRiBTVUNIIERBTUFH RS4KIAorIyBGSVhNRTogcmVuYW1lIHRoaXMgZmlsZSwgYW5kIGFkZCBtb3JlIHRleHQgYWJvdXQg aG93IHRoaXMgaXMKKyMgZGlmZmVyZW50IGZyb20gdGhlIGJhc2UgZmlsZV9sb2NrIGNsYXNzLgor CiAiIiJUaGlzIGNsYXNzIGhlbHBzIHRvIGJsb2NrIE5SV1QgdGhyZWFkcyB3aGVuIG1vcmUgTlJX VHMgcnVuCiBwZXJmLCBodHRwIGFuZCB3ZWJzb2NrZXQgdGVzdHMgaW4gYSBzYW1lIHRpbWUuIiIi CiAKQEAgLTQyLDcgKzQ1LDcgQEAgX2xvZyA9IGxvZ2dpbmcuZ2V0TG9nZ2VyKF9fbmFtZV9fKQog CiAKIGNsYXNzIEh0dHBMb2NrKG9iamVjdCk6Ci0gICAgZGVmIF9faW5pdF9fKHNlbGYsIGxvY2tf cGF0aCwgbG9ja19maWxlX3ByZWZpeD0iV2ViS2l0SHR0cGQubG9jay4iLCBndWFyZF9sb2NrPSJX ZWJLaXQubG9jayIsIGZpbGVzeXN0ZW09Tm9uZSwgZXhlY3V0aXZlPU5vbmUpOgorICAgIGRlZiBf X2luaXRfXyhzZWxmLCBsb2NrX3BhdGgsIGxvY2tfZmlsZV9wcmVmaXg9IldlYktpdEh0dHBkLmxv Y2suIiwgZ3VhcmRfbG9jaz0iV2ViS2l0LmxvY2siLCBmaWxlc3lzdGVtPU5vbmUsIGV4ZWN1dGl2 ZT1Ob25lLCBuYW1lPSdIVFRQJyk6CiAgICAgICAgIHNlbGYuX2V4ZWN1dGl2ZSA9IGV4ZWN1dGl2 ZSBvciBFeGVjdXRpdmUoKQogICAgICAgICBzZWxmLl9maWxlc3lzdGVtID0gZmlsZXN5c3RlbSBv ciBGaWxlU3lzdGVtKCkKICAgICAgICAgc2VsZi5fbG9ja19wYXRoID0gbG9ja19wYXRoCkBAIC01 NCw2ICs1Nyw3IEBAIGNsYXNzIEh0dHBMb2NrKG9iamVjdCk6CiAgICAgICAgIHNlbGYuX2d1YXJk X2xvY2tfZmlsZSA9IHNlbGYuX2ZpbGVzeXN0ZW0uam9pbihzZWxmLl9sb2NrX3BhdGgsIGd1YXJk X2xvY2spCiAgICAgICAgIHNlbGYuX2d1YXJkX2xvY2sgPSBGaWxlTG9jayhzZWxmLl9ndWFyZF9s b2NrX2ZpbGUpCiAgICAgICAgIHNlbGYuX3Byb2Nlc3NfbG9ja19maWxlX25hbWUgPSAiIgorICAg ICAgICBzZWxmLl9uYW1lID0gbmFtZQogCiAgICAgZGVmIGNsZWFudXBfaHR0cF9sb2NrKHNlbGYp OgogICAgICAgICAiIiJEZWxldGUgdGhlIGxvY2sgZmlsZSBpZiBleGlzdHMuIiIiCkBAIC0xMjMs MTEgKzEyNywxMSBAQCBjbGFzcyBIdHRwTG9jayhvYmplY3QpOgogICAgICAgICAiIiJDcmVhdGUg YSBsb2NrIGZpbGUgYW5kIHdhaXQgdW50aWwgaXQncyB0dXJuIGNvbWVzLiBJZiBzb21ldGhpbmcg Z29lcyB3cm9uZwogICAgICAgICBpdCB3b250IGRvIGFueSBsb2NraW5nLiIiIgogICAgICAgICBp ZiBub3Qgc2VsZi5fY3JlYXRlX2xvY2tfZmlsZSgpOgotICAgICAgICAgICAgX2xvZy5kZWJ1Zygi V2FybmluZywgaHR0cCBsb2NraW5nIGZhaWxlZCEiKQorICAgICAgICAgICAgX2xvZy5kZWJ1Zygi V2FybmluZywgJXMgbG9ja2luZyBmYWlsZWQhIiAlIHNlbGYuX25hbWUpCiAgICAgICAgICAgICBy ZXR1cm4KIAogICAgICAgICAjIEZJWE1FOiBUaGlzIGNhbiBoYW5nIGZvcmV2ZXIhCiAgICAgICAg IHdoaWxlIHNlbGYuX2N1cnJlbnRfbG9ja19waWQoKSAhPSBvcy5nZXRwaWQoKToKICAgICAgICAg ICAgIHRpbWUuc2xlZXAoMSkKIAotICAgICAgICBfbG9nLmRlYnVnKCJIVFRQIGxvY2sgYWNxdWly ZWQiKQorICAgICAgICBfbG9nLmRlYnVnKCIlcyBsb2NrIGFjcXVpcmVkIiAlIHNlbGYuX25hbWUp Cg==