112976 2013-03-21 16:09:51 -0700 IndexedDB: Ensure script wrappers can be collected after context is stopped 2013-03-22 01:38:26 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jsbell jsbell abarth dgrogan haraken webkit.review.bot yurys oldest_to_newest 860829 0 jsbell 2013-03-21 16:09:51 -0700 IndexedDB: Ensure script wrappers can be collected after context is stopped 860835 1 194374 jsbell 2013-03-21 16:12:32 -0700 Created attachment 194374 Patch 860837 2 jsbell 2013-03-21 16:14:10 -0700 This could use some tests but I haven't thought about where to put them yet - trivial webkit_unit_tests might work just to avoid regressions. haraken@, abarth@ - can you take a look? 860846 3 abarth 2013-03-21 16:17:58 -0700 We don't have a good way to test these sorts of changes. :( 860883 4 194374 webkit.review.bot 2013-03-21 16:54:40 -0700 Comment on attachment 194374 Patch Clearing flags on attachment: 194374 Committed r146540: <http://trac.webkit.org/changeset/146540> 860884 5 webkit.review.bot 2013-03-21 16:54:43 -0700 All reviewed patches have been landed. Closing bug. 861107 6 dgrogan 2013-03-21 22:38:24 -0700 IntVersion tests flaked after this was rolled into chromium. http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20(dbg)(1)/builds/24146/steps/content_browsertests/logs/IntVersionTests1 [7826:7826:0321/221757:1974942344:INFO:layout_browsertest.cc(157)] Navigating to URL file:///mnt/data/b/build/slave/Linux_Tests__dbg__1_/build/src/content/test/data/layout_tests/LayoutTests/storage/indexeddb/intversion-close-in-upgradeneeded.html and blocking. ASSERTION FAILED: m_state == Finished ../../third_party/WebKit/Source/WebCore/Modules/indexeddb/IDBTransaction.cpp(119) : virtual WebCore::IDBTransaction::~IDBTransaction() 1 0x7fabd2cf3a5b 2 0x7fabd2cf3bec 3 0x7fabd2c9f536 4 0x7fabd3a6082c 5 0x7fabd2dfe2e4 6 0x7fabd2e53e82 7 0x7fabd621f434 8 0x7fabd621da8b 9 0x7fabd6241d77 10 0x7fabd6240fe6 11 0x7fabd6198836 12 0x7fabd6353ce1 13 0x7fabd63dda23 14 0x7fabd63de277 15 0x1a99337062ee [7826:7826:0321/221757:1975821025:INFO:layout_browsertest.cc(162)] Navigation completed. ../../content/test/layout_browsertest.cc:191: Failure Value of: actual_text Actual: "#CRASHED - renderer (pid 7856)\n" Expected: expected_text Which is: "Test that when db.close is called in upgradeneeded, the db is cleaned up on refresh.\n\nOn success, you will see a series of \"PASS\" messages, followed by \"TEST COMPLETE\".\n\n\nindexedDB = self.indexedDB || self.webkitIndexedDB || self.mozIndexedDB || self.msIndexedDB || self.OIndexedDB;\n\ndbname = \"intversion-close-in-upgradeneeded.html\"\nindexedDB.deleteDatabase(dbname)\nrequest = indexedDB.open(dbname, 7)\n\n\nupgradeNeeded():\ndb = event.target.result\nPASS event.newVersion is 7\ntransaction = event.target.transaction\ndb.createObjectStore('os')\ndb.close()\n\ntransaction.oncomplete:\nsawTransactionComplete = true\n\nopenError():\nPASS sawTransactionComplete is true\nPASS event.target.error.name is 'AbortError'\nPASS event.result is undefined\n\nVerify that the old connection is unchanged and was closed:\nPASS db is non-null.\nPASS db.version is 7\nExpecting exception from db.transaction('os')\nPASS Exception was thrown.\nPASS code is DOMException.INVALID_STATE_ERR\nPASS ename is 'InvalidStateError'\nPASS successfullyParsed is true\n\nTEST COMPLETE\n\n" [7826:7826:0321/221757:1975822278:INFO:layout_browsertest.cc(157)] Navigating to URL file:///mnt/data/b/build/slave/Linux_Tests__dbg__1_/build/src/content/test/data/layout_tests/LayoutTests/storage/indexeddb/delete-in-upgradeneeded-close-in-open-success.html and blocking. [7826:7826:0321/221758:1976465721:INFO:layout_browsertest.cc(162)] Navigation completed. 861112 7 jsbell 2013-03-21 22:41:59 -0700 Thanks. It can be rolled out if necessary. It's likely that the state isn't driven to finished if the context is stopped before the final event comes in. We can probably tweak that. 861226 8 194374 yurys 2013-03-22 01:37:46 -0700 Comment on attachment 194374 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=194374&action=review > Source/WebCore/ChangeLog:12 > + No new tests - suggestions welcome. How about repeating scenario described in https://code.google.com/p/chromium/issues/detail?id=222678 ? You could take heap snapshot before and after reload and check that number of say Window objects or IDBDatabases didn't grow. 194374 2013-03-21 16:12:32 -0700 2013-03-22 01:37:46 -0700 Patch bug-112976-20130321160820.patch text/plain 4288 jsbell U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ2NTE2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmU5YzY3MmIwNWM0OTc1 YjY2NjI1YmRjYjUyYzE1YzZmNjZjZGQ1Yi4uMjI5NmJmMDEwNmNiMjEyMzQ3OGYxZWM3MGE2NmI3 NGRjYjQyMGRhOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDEzLTAzLTIxICBKb3No dWEgQmVsbCAgPGpzYmVsbEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgSW5kZXhlZERCOiBFbnN1 cmUgc2NyaXB0IHdyYXBwZXJzIGNhbiBiZSBjb2xsZWN0ZWQgYWZ0ZXIgY29udGV4dCBpcyBzdG9w cGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTI5 NzYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBY3Rp dmVET01PYmplY3Q6Omhhc1BlbmRpbmdBY3Rpdml0eSBpcyBjYWxsZWQgdG8gc2VlIGlmIHNjcmlw dCB3cmFwcGVycworICAgICAgICBjYW4gYmUgZGlzcG9zZWQgb2YuIE9uY2UgdGhlIHNjcmlwdCBl eGVjdXRpb24gY29udGV4dCBoYXMgc3RvcHBlZCB0aGV5CisgICAgICAgIHNob3VsZCBiZSBmcmVl IHRvIGdvIC0gaW5jbHVkZSB0aGlzIGluIHRoZSBjaGVja3MuCisKKyAgICAgICAgTm8gbmV3IHRl c3RzIC0gc3VnZ2VzdGlvbnMgd2VsY29tZS4KKworICAgICAgICAqIE1vZHVsZXMvaW5kZXhlZGRi L0lEQkRhdGFiYXNlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OklEQkRhdGFiYXNlOjpoYXNQZW5k aW5nQWN0aXZpdHkpOiBSZXR1cm4gZmFsc2UgaWYgc3RvcHBlZC4KKyAgICAgICAgKFdlYkNvcmU6 OklEQkRhdGFiYXNlOjpzdG9wKTogRG9uJ3QgYm90aGVyIGNhbGxpbmcgZW1wdHkgc3VwZXIgaW1w bC4KKyAgICAgICAgKiBNb2R1bGVzL2luZGV4ZWRkYi9JREJSZXF1ZXN0LmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OklEQlJlcXVlc3Q6Omhhc1BlbmRpbmdBY3Rpdml0eSk6IFJldHVybiBmYWxzZSBp ZiBzdG9wcGVkLgorICAgICAgICAoV2ViQ29yZTo6SURCUmVxdWVzdDo6c3RvcCk6IERvbid0IGJv dGhlciBjYWxsaW5nIGVtcHR5IHN1cGVyIGltcGwuCisgICAgICAgICogTW9kdWxlcy9pbmRleGVk ZGIvSURCVHJhbnNhY3Rpb24uY3BwOgorICAgICAgICAoV2ViQ29yZTo6SURCVHJhbnNhY3Rpb246 Omhhc1BlbmRpbmdBY3Rpdml0eSk6IFJldHVybiBmYWxzZSBpZiBzdG9wcGVkLgorICAgICAgICAo V2ViQ29yZTo6SURCVHJhbnNhY3Rpb246OnN0b3ApOiBEb24ndCBib3RoZXIgY2FsbGluZyBlbXB0 eSBzdXBlciBpbXBsLgorCiAyMDEzLTAzLTIxICBNaWtlIFdlc3QgIDxta3dzdEBjaHJvbWl1bS5v cmc+CiAKICAgICAgICAgRHJvcCBmdWxsIFVSTHMgZnJvbSBjcm9zcy1vcmlnaW4gYWNjZXNzIGVy cm9ycyBjYXVzZWQgYnkgcHJvdG9jb2wgbWlzbWF0Y2hlcy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL01vZHVsZXMvaW5kZXhlZGRiL0lEQkRhdGFiYXNlLmNwcCBiL1NvdXJjZS9XZWJDb3Jl L01vZHVsZXMvaW5kZXhlZGRiL0lEQkRhdGFiYXNlLmNwcAppbmRleCBlZDg1ZjkwYTJmYTU3MTNm Mjg1ODkyYWVlODE3ZmMzYWM1ZTIwM2Q5Li40YjFmY2ZmNjhlM2FkZGQ3N2IwNTE3ZWM3NDFhMzUx ZDhkYTI0YzY2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2luZGV4ZWRkYi9J REJEYXRhYmFzZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9pbmRleGVkZGIvSURC RGF0YWJhc2UuY3BwCkBAIC0zNDcsMTIgKzM0NywxMSBAQCBib29sIElEQkRhdGFiYXNlOjpoYXNQ ZW5kaW5nQWN0aXZpdHkoKSBjb25zdAogewogICAgIC8vIFRoZSBzY3JpcHQgd3JhcHBlciBtdXN0 IG5vdCBiZSBjb2xsZWN0ZWQgYmVmb3JlIHRoZSBvYmplY3QgaXMgY2xvc2VkIG9yCiAgICAgLy8g d2UgY2FuJ3QgZmlyZSBhICJ2ZXJzaW9uY2hhbmdlIiBldmVudCB0byBsZXQgc2NyaXB0IG1hbnVh bGx5IGNsb3NlIHRoZSBjb25uZWN0aW9uLgotICAgIHJldHVybiAhbV9jbG9zZVBlbmRpbmcgJiYg IW1fZXZlbnRUYXJnZXREYXRhLmV2ZW50TGlzdGVuZXJNYXAuaXNFbXB0eSgpOworICAgIHJldHVy biAhbV9jbG9zZVBlbmRpbmcgJiYgIW1fZXZlbnRUYXJnZXREYXRhLmV2ZW50TGlzdGVuZXJNYXAu aXNFbXB0eSgpICYmICFtX2NvbnRleHRTdG9wcGVkOwogfQogCiB2b2lkIElEQkRhdGFiYXNlOjpz dG9wKCkKIHsKLSAgICBBY3RpdmVET01PYmplY3Q6OnN0b3AoKTsKICAgICAvLyBTdG9wIGZpcmVz IGF0IGEgZGV0ZXJtaW5pc3RpYyB0aW1lLCBzbyB3ZSBuZWVkIHRvIGNhbGwgY2xvc2UgaW4gaXQu CiAgICAgY2xvc2UoKTsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9pbmRl eGVkZGIvSURCUmVxdWVzdC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2luZGV4ZWRkYi9J REJSZXF1ZXN0LmNwcAppbmRleCBjMjA3Y2FkODg4ZDAzMTliYzlkYWE0ODY3NjMyYjc4N2Y3ZDFj NTUyLi4yOGRjZTM1NTgwOWIwNzYzMTZkMzAxNTBmZGMwY2MwYTUxMmVhYTE3IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2luZGV4ZWRkYi9JREJSZXF1ZXN0LmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2luZGV4ZWRkYi9JREJSZXF1ZXN0LmNwcApAQCAtNDIwLDEy ICs0MjAsMTEgQEAgYm9vbCBJREJSZXF1ZXN0OjpoYXNQZW5kaW5nQWN0aXZpdHkoKSBjb25zdAog ICAgIC8vIEZJWE1FOiBJbiBhbiBpZGVhbCB3b3JsZCwgd2Ugc2hvdWxkIHJldHVybiB0cnVlIGFz IGxvbmcgYXMgYW55b25lIGhhcyBhIG9yIGNhbgogICAgIC8vICAgICAgICBnZXQgYSBoYW5kbGUg dG8gdXMgYW5kIHdlIGhhdmUgZXZlbnQgbGlzdGVuZXJzLiBUaGlzIGlzIG9yZGVyIHRvIGhhbmRs ZQogICAgIC8vICAgICAgICB1c2VyIGdlbmVyYXRlZCBldmVudHMgcHJvcGVybHkuCi0gICAgcmV0 dXJuIG1faGFzUGVuZGluZ0FjdGl2aXR5OworICAgIHJldHVybiBtX2hhc1BlbmRpbmdBY3Rpdml0 eSAmJiAhbV9jb250ZXh0U3RvcHBlZDsKIH0KIAogdm9pZCBJREJSZXF1ZXN0OjpzdG9wKCkKIHsK LSAgICBBY3RpdmVET01PYmplY3Q6OnN0b3AoKTsKICAgICBpZiAobV9jb250ZXh0U3RvcHBlZCkK ICAgICAgICAgcmV0dXJuOwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2lu ZGV4ZWRkYi9JREJUcmFuc2FjdGlvbi5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2luZGV4 ZWRkYi9JREJUcmFuc2FjdGlvbi5jcHAKaW5kZXggZjU1NTk0M2Q4MDMzZDg4MDk1ODM1NjM4MjVh ZGYwYTUxNjRiZDI0Mi4uMzNjYzM4ZTc4NjZmMGVjNjM4YTA2MGVlZjZlNDk2Yjc3YTc0ODk3MiAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9pbmRleGVkZGIvSURCVHJhbnNhY3Rp b24uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvaW5kZXhlZGRiL0lEQlRyYW5zYWN0 aW9uLmNwcApAQCAtMzMzLDcgKzMzMyw3IEBAIGJvb2wgSURCVHJhbnNhY3Rpb246Omhhc1BlbmRp bmdBY3Rpdml0eSgpIGNvbnN0CiAgICAgLy8gRklYTUU6IEluIGFuIGlkZWFsIHdvcmxkLCB3ZSBz aG91bGQgcmV0dXJuIHRydWUgYXMgbG9uZyBhcyBhbnlvbmUgaGFzIGEgb3IgY2FuCiAgICAgLy8g ICAgICAgIGdldCBhIGhhbmRsZSB0byB1cyBvciBhbnkgY2hpbGQgcmVxdWVzdCBvYmplY3QgYW5k IGFueSBvZiB0aG9zZSBoYXZlCiAgICAgLy8gICAgICAgIGV2ZW50IGxpc3RlbmVycy4gVGhpcyBp cyAgaW4gb3JkZXIgdG8gaGFuZGxlIHVzZXIgZ2VuZXJhdGVkIGV2ZW50cyBwcm9wZXJseS4KLSAg ICByZXR1cm4gbV9oYXNQZW5kaW5nQWN0aXZpdHk7CisgICAgcmV0dXJuIG1faGFzUGVuZGluZ0Fj dGl2aXR5ICYmICFtX2NvbnRleHRTdG9wcGVkOwogfQogCiBJbmRleGVkREI6OlRyYW5zYWN0aW9u TW9kZSBJREJUcmFuc2FjdGlvbjo6c3RyaW5nVG9Nb2RlKGNvbnN0IFN0cmluZyYgbW9kZVN0cmlu ZywgU2NyaXB0RXhlY3V0aW9uQ29udGV4dCogY29udGV4dCwgRXhjZXB0aW9uQ29kZSYgZWMpCkBA IC00MjIsNyArNDIyLDYgQEAgYm9vbCBJREJUcmFuc2FjdGlvbjo6Y2FuU3VzcGVuZCgpIGNvbnN0 CiAKIHZvaWQgSURCVHJhbnNhY3Rpb246OnN0b3AoKQogewotICAgIEFjdGl2ZURPTU9iamVjdDo6 c3RvcCgpOwogICAgIG1fY29udGV4dFN0b3BwZWQgPSB0cnVlOwogCiAgICAgYWJvcnQoSUdOT1JF X0VYQ0VQVElPTik7Cg==