112968 2013-03-21 14:44:22 -0700 FKA: mouse click on buttons causes focus (document.activeElement) to be lost 2023-11-07 20:09:42 -0800 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) Unspecified Unspecified RESOLVED CONFIGURATION CHANGED https://bugs.webkit.org/show_bug.cgi?id=22261 InRadar P2 Normal --- 0 jcraig webkit-unassigned cfleizach fotis.papadogeorgopoulos gsnedders jcraig me ntim rego webkit-bug-importer webkit oldest_to_newest 860718 0 jcraig 2013-03-21 14:44:22 -0700 REPRO * 1. Load attached test case. 2. Tab so that focus is on one of the buttons. 3. Perform a mouse click on the same button. (Notice focus ring disappears.) 4. Press Tab again. (focus has been lost and resets to the beginning of the document) Note: It's probably okay to "hide" the focus pseudo-state when switching to a mouse, but Tabbing should cause focus to come back to the same element rather than losing document.activeElement entirely. 860730 1 194349 jcraig 2013-03-21 14:47:19 -0700 Created attachment 194349 test case demonstrating bug 860734 2 webkit-bug-importer 2013-03-21 14:48:14 -0700 <rdar://problem/13477257> 860735 3 jcraig 2013-03-21 14:48:42 -0700 See expected behavior in Firefox 19 for Mac. 860736 4 webkit-bug-importer 2013-03-21 14:49:02 -0700 <rdar://problem/13477269> 861923 5 ap 2013-03-22 15:51:21 -0700 See also: bug 22261. 1076572 6 jcraig 2015-03-11 23:20:37 -0700 <rdar://problem/13477257> 1449064 7 me 2018-08-09 11:26:44 -0700 Any updates on this? I see that there's not been any changes since the bug was reported 5 years ago. This issue makes building custom widget with focus management very tricky. 1769497 8 jcraig 2021-06-14 12:08:19 -0700 Relating to the newer :focus-visible tracker in bug 225148 1858709 9 rego 2022-04-06 00:36:16 -0700 Very related bug, see bug #229895. 1977040 10 me 2023-09-12 03:43:27 -0700 Just talked about this at TPAC with ntim and jcraig I just want to add to the repro steps: REPRO * 1. Load attached test case. 2. Tab so that focus is on one of the buttons. 3. Perform a mouse click on the same button. (Notice focus ring disappears.) 4. Press Tab again. (focus has been lost and resets to the beginning of the document) As of 16.6, step 4 is no longer the case. the next focus point does land on the button. However if you do `setInterval(() => console.log(document.activeElement), 1000)` to observe the current focused element, you would see that after step 3, the activeElement goes back to body. nTim mentioned that there has been a recent fix to account for how button[tabindex=0] should be click-focusable like div[tabindex=0]. https://github.com/WebKit/WebKit/pull/12743 Now that :focus-visible is implemented, I wonder if WebKit would mind reconsidering this special treatment (https://github.com/WebKit/WebKit/blob/b38121da42a0483fdb1bc13782f1c7a8059de100/Source/WebCore/html/HTMLFormControlElement.cpp#L255C13-L255C13) to buttons? 1990707 11 jcraig 2023-11-07 18:24:47 -0800 Seems reasonable to me... When I filed this back in 2013, :focus-visible didn't exist so there wasn't a way to make this work for all use cases, but I think that wwide support of :focus-visible now unblocks this, right? 1990720 12 jcraig 2023-11-07 20:09:42 -0800 Seems fixed in latest STP so this was probably resolved along with :focus-visible. Muan, if you know of other instances where this doesn't work, will you open a new issue? 194349 2013-03-21 14:47:19 -0700 2013-03-21 14:47:19 -0700 test case demonstrating bug webkit_112968.html text/html 274 jcraig PGh0bWw+CjxoZWFkPgoJPHRpdGxlPkZvY3VzIExvc3QgQnVnPC90aXRsZT4KPC9oZWFkPgo8Ym9k eT4KCTxidXR0b24+Rm9vPC9idXR0b24+Cgk8YnV0dG9uPkJhcjwvYnV0dG9uPgoJPGJ1dHRvbj5C YXo8L2J1dHRvbj4KCTxidXR0b24+Qm9wPC9idXR0b24+Cgk8YnV0dG9uPkJpZjwvYnV0dG9uPgoJ PGJ1dHRvbj5CYXA8L2J1dHRvbj4KCTxidXR0b24+Rml6PC9idXR0b24+Cgk8YnV0dG9uPkZ1ejwv YnV0dG9uPgoJPGJ1dHRvbj5GdW48L2J1dHRvbj4KPC9ib2R5Pgo8L2h0bWw+Cg==