112966 2013-03-21 14:35:20 -0700 [BlackBerry] Last paragraph can't be selected by touch hold selection if there is no new line after it in subframe 2013-03-21 15:14:07 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 shuwu webkit-unassigned mifenton rwlbuis tonikitoo webkit.review.bot oldest_to_newest 860707 0 shuwu 2013-03-21 14:35:20 -0700 If selection reaches the bottom of content, just ignore scroll margin so the text on the bottom can be selected. 860716 1 194344 shuwu 2013-03-21 14:41:50 -0700 Created attachment 194344 Patch 860742 2 194344 rwlbuis 2013-03-21 14:52:37 -0700 Comment on attachment 194344 Patch LGTM. 860776 3 194344 webkit.review.bot 2013-03-21 15:14:04 -0700 Comment on attachment 194344 Patch Clearing flags on attachment: 194344 Committed r146528: <http://trac.webkit.org/changeset/146528> 860777 4 webkit.review.bot 2013-03-21 15:14:07 -0700 All reviewed patches have been landed. Closing bug. 194344 2013-03-21 14:41:50 -0700 2013-03-21 15:14:04 -0700 Patch 0001-2013-03-21-Iris-Wu-shuwu-blackberry.com.patch text/plain 3543 shuwu RnJvbSA0MDI3MmM4MTA1YjdlYWYzZTZkZjM5NjQ3YmY4OWVmYmQ4ZGZlNGFmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBJcmlzIFd1IDxzaHV3dUBibGFja2JlcnJ5LmNvbT4KRGF0ZTog VGh1LCAyMSBNYXIgMjAxMyAxNjo0MzowNyAtMDQwMApTdWJqZWN0OiBbUEFUQ0hdIDIwMTMtMDMt MjEgIElyaXMgV3UgIDxzaHV3dUBibGFja2JlcnJ5LmNvbT4KCiAgICAgICAgW0JsYWNrQmVycnld IExhc3QgcGFyYWdyYXBoIGNhbid0IGJlIHNlbGVjdGVkIGJ5IHRvdWNoIGhvbGQgc2VsZWN0aW9u IGlmIHRoZXJlIGlzIG5vIG5ldyBsaW5lIGFmdGVyIGl0IGluIHN1YmZyYW1lLgogICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTI5NjYKCiAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgogICAgICAgIFBSIDMxMjA0NAogICAgICAgIFJldmll d2VkIEludGVybmFsbHkgQnkgR2VuZXZpZXZlIE1hay4KCiAgICAgICAgSWYgc2VsZWN0aW9uIHJl YWNoZXMgdGhlIGJvdHRvbSBvZiBjb250ZW50LCBpZ25vcmUgc2Nyb2xsIG1hcmdpbgogICAgICAg IHNvIHRoZSB0ZXh0IG9uIHRoZSBib3R0b20gY2FuIGJlIHNlbGVjdGVkLgogICAgICAgIFN0b3Ag ZXhwYW5kaW5nIHNlbGVjdGlvbiBvbmx5IGlmIHRoZSBlbmQgb2YgZG9jdW1lbnQgaXMgc2VsZWN0 ZWQKICAgICAgICBvciB0b3VjaCBpcyByZWxlYXNlZC4KCiAgICAgICAgKiBXZWJLaXRTdXBwb3J0 L1NlbGVjdGlvbkhhbmRsZXIuY3BwOgogICAgICAgIChCbGFja0JlcnJ5OjpXZWJLaXQ6OlNlbGVj dGlvbkhhbmRsZXI6OmV4cGFuZFNlbGVjdGlvbik6CiAgICAgICAgKEJsYWNrQmVycnk6OldlYktp dDo6U2VsZWN0aW9uSGFuZGxlcjo6ZW5zdXJlU2VsZWN0ZWRUZXh0VmlzaWJsZSk6Ci0tLQogU291 cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgfCAgIDE5ICsr KysrKysrKysrKysrKysrKysKIC4uLi9ibGFja2JlcnJ5L1dlYktpdFN1cHBvcnQvU2VsZWN0aW9u SGFuZGxlci5jcHAgIHwgICAgNCArKy0tCiAyIGZpbGVzIGNoYW5nZWQsIDIxIGluc2VydGlvbnMo KyksIDIgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5 L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cKaW5kZXggODk0 NGUwMy4uNmE1YWZkYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5n ZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEs MjIgQEAKKzIwMTMtMDMtMjEgIElyaXMgV3UgIDxzaHV3dUBibGFja2JlcnJ5LmNvbT4KKworICAg ICAgICBbQmxhY2tCZXJyeV0gTGFzdCBwYXJhZ3JhcGggY2FuJ3QgYmUgc2VsZWN0ZWQgYnkgdG91 Y2ggaG9sZCBzZWxlY3Rpb24gaWYgdGhlcmUgaXMgbm8gbmV3IGxpbmUgYWZ0ZXIgaXQgaW4gc3Vi ZnJhbWUuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x MTI5NjYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBQ UiAzMTIwNDQKKyAgICAgICAgUmV2aWV3ZWQgSW50ZXJuYWxseSBCeSBHZW5ldmlldmUgTWFrLgor CisgICAgICAgIElmIHNlbGVjdGlvbiByZWFjaGVzIHRoZSBib3R0b20gb2YgY29udGVudCwgaWdu b3JlIHNjcm9sbCBtYXJnaW4KKyAgICAgICAgc28gdGhlIHRleHQgb24gdGhlIGJvdHRvbSBjYW4g YmUgc2VsZWN0ZWQuCisgICAgICAgIFN0b3AgZXhwYW5kaW5nIHNlbGVjdGlvbiBvbmx5IGlmIHRo ZSBlbmQgb2YgZG9jdW1lbnQgaXMgc2VsZWN0ZWQKKyAgICAgICAgb3IgdG91Y2ggaXMgcmVsZWFz ZWQuCisKKyAgICAgICAgKiBXZWJLaXRTdXBwb3J0L1NlbGVjdGlvbkhhbmRsZXIuY3BwOgorICAg ICAgICAoQmxhY2tCZXJyeTo6V2ViS2l0OjpTZWxlY3Rpb25IYW5kbGVyOjpleHBhbmRTZWxlY3Rp b24pOgorICAgICAgICAoQmxhY2tCZXJyeTo6V2ViS2l0OjpTZWxlY3Rpb25IYW5kbGVyOjplbnN1 cmVTZWxlY3RlZFRleHRWaXNpYmxlKToKKwogMjAxMy0wMy0xOSAgQW5kcmV3IExvICA8YW5sb0By aW0uY29tPgogCiAgICAgICAgIFtCbGFja0JlcnJ5XSBTZWxlY3Rpb24gb3ZlcmxheSBpcyBzb21l dGltZXMgaW4gd3JvbmcgcG9zaXRpb24uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2JsYWNr YmVycnkvV2ViS2l0U3VwcG9ydC9TZWxlY3Rpb25IYW5kbGVyLmNwcCBiL1NvdXJjZS9XZWJLaXQv YmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L1NlbGVjdGlvbkhhbmRsZXIuY3BwCmluZGV4IDRiMjk2 Y2YuLmNiZTQ1NjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRT dXBwb3J0L1NlbGVjdGlvbkhhbmRsZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJy eS9XZWJLaXRTdXBwb3J0L1NlbGVjdGlvbkhhbmRsZXIuY3BwCkBAIC03NjQsNyArNzY0LDYgQEAg dm9pZCBTZWxlY3Rpb25IYW5kbGVyOjpleHBhbmRTZWxlY3Rpb24oYm9vbCBpc1Njcm9sbFN0YXJ0 ZWQpCiAgICAgICAgIGlmICghZmluZE5leHRBbmltYXRpb25PdmVybGF5UmVnaW9uKCkpIHsKICAg ICAgICAgICAgIGRyYXdBbmltYXRpb25PdmVybGF5KG1fbmV4dEFuaW1hdGlvbk92ZXJsYXlSZWdp b24sIGZhbHNlKTsKICAgICAgICAgICAgIHNlbGVjdE5leHRQYXJhZ3JhcGgoKTsKLSAgICAgICAg ICAgIG1fd2ViUGFnZS0+bV9jbGllbnQtPnN0b3BFeHBhbmRpbmdTZWxlY3Rpb24oKTsKICAgICAg ICAgICAgIHJldHVybjsKICAgICAgICAgfQogCkBAIC03ODQsNyArNzgzLDggQEAgYm9vbCBTZWxl Y3Rpb25IYW5kbGVyOjplbnN1cmVTZWxlY3RlZFRleHRWaXNpYmxlKGNvbnN0IFdlYkNvcmU6Oklu dFBvaW50JiBwb2ludCwKIHsKICAgICBXZWJDb3JlOjpJbnRSZWN0IHZpZXdwb3J0UmVjdCA9IHNl bGVjdGlvblZpZXdwb3J0UmVjdCgpOwogICAgIGlmICghc2Nyb2xsSWZOZWVkZWQpCi0gICAgICAg IHJldHVybiB2aWV3cG9ydFJlY3QubWF4WSgpID49IHBvaW50LnkoKSArIG1fc2Nyb2xsTWFyZ2lu LmhlaWdodCgpOworICAgICAgICAvLyBJZiByZWFjaGluZyB0aGUgYm90dG9tIG9mIGNvbnRlbnQs IGlnbm9yZSBzY3JvbGwgbWFyZ2luIHNvIHRoZSB0ZXh0IG9uIHRoZSBib3R0b20gY2FuIGJlIHNl bGVjdGVkLgorICAgICAgICByZXR1cm4gdmlld3BvcnRSZWN0Lm1heFkoKSA+PSBtX3dlYlBhZ2Ut PmNvbnRlbnRzU2l6ZSgpLmhlaWdodCgpID8gdmlld3BvcnRSZWN0Lm1heFkoKSA+PSBwb2ludC55 KCkgOiB2aWV3cG9ydFJlY3QubWF4WSgpID49IHBvaW50LnkoKSArIG1fc2Nyb2xsTWFyZ2luLmhl aWdodCgpOwogCiAgICAgLy8gU2Nyb2xsIHBvc2l0aW9uIGFkanVzdG1lbnQgaGVyZSBpcyBiYXNl ZCBvbiBtYWluIGZyYW1lLiBJZiBzZWxlY3RpbmcgaW4gYSBzdWJmcmFtZSwgZG9uJ3QgZG8gYW5p bWF0aW9uLgogICAgIGlmICghbV9zZWxlY3Rpb25WaWV3cG9ydFJlY3QuaXNFbXB0eSgpKQotLSAK MS43LjkuNQoK