112961 2013-03-21 14:02:52 -0700 [GTK][WK2] WebKitLoaderClient: add missing initializers 2013-04-05 01:20:38 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 berto webkit-unassigned benjamin cgarcia commit-queue gustavo mrobinson webkit.review.bot oldest_to_newest 860664 0 berto 2013-03-21 14:02:52 -0700 Else gcc complains: ../../Source/WebKit2/UIProcess/API/gtk/WebKitLoaderClient.cpp: In function 'void attachLoaderClientToView(WebKitWebView*)': ../../Source/WebKit2/UIProcess/API/gtk/WebKitLoaderClient.cpp:177:5: warning: missing initializer for member 'WKPageLoaderClient::pluginLoadPolicy' [-Wmissing-field-initializers] ../../Source/WebKit2/UIProcess/API/gtk/WebKitLoaderClient.cpp:177:5: warning: missing initializer for member 'WKPageLoaderClient::pluginDidFail' [-Wmissing-field-initializers] 860672 1 194330 berto 2013-03-21 14:05:39 -0700 Created attachment 194330 Patch 860678 2 webkit.review.bot 2013-03-21 14:08:34 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 861170 3 194330 cgarcia 2013-03-22 00:31:22 -0700 Comment on attachment 194330 Patch Thanks! 869624 4 194330 commit-queue 2013-04-05 01:20:36 -0700 Comment on attachment 194330 Patch Clearing flags on attachment: 194330 Committed r147725: <http://trac.webkit.org/changeset/147725> 869626 5 commit-queue 2013-04-05 01:20:38 -0700 All reviewed patches have been landed. Closing bug. 194330 2013-03-21 14:05:39 -0700 2013-04-05 01:20:36 -0700 Patch 112961.diff text/plain 1638 berto ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBkZWNlM2FmLi4xMjc1Mzk4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTMtMDMtMjEgIEFsYmVydG8gR2FyY2lhICA8YWdhcmNpYUBpZ2FsaWEuY29tPgorCisg ICAgICAgIFtHVEtdW1dLMl0gV2ViS2l0TG9hZGVyQ2xpZW50OiBhZGQgbWlzc2luZyBpbml0aWFs aXplcnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEx Mjk2MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRo ZXJlIGFyZSB0d28gbmV3IGF0dHJpYnV0ZXM6IHBsdWdpbkxvYWRQb2xpY3kgYW5kIHBsdWdpbkRp ZEZhaWwuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRMb2FkZXJDbGllbnQu Y3BwOgorICAgICAgICAoYXR0YWNoTG9hZGVyQ2xpZW50VG9WaWV3KToKKwogMjAxMy0wMy0yMSAg VGltIEhvcnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxlLmNvbT4KIAogICAgICAgICBUaWxlZCBw YWdlIG92ZXJsYXkgbGF5ZXJzIGRvbid0IGNyZWF0ZSB0aWxlcyB1bnRpbCB0aGUgZmlyc3QgZmx1 c2ggYWZ0ZXIgdGhleSBzd2l0Y2ggdG8gYmVpbmcgdGlsZWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdExvYWRlckNsaWVudC5jcHAgYi9Tb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRMb2FkZXJDbGllbnQuY3BwCmluZGV4IDMz MjZkMTIuLjA3MWE1YzkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkv Z3RrL1dlYktpdExvYWRlckNsaWVudC5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L0FQSS9ndGsvV2ViS2l0TG9hZGVyQ2xpZW50LmNwcApAQCAtMTY4LDEwICsxNjgsMTIgQEAgdm9p ZCBhdHRhY2hMb2FkZXJDbGllbnRUb1ZpZXcoV2ViS2l0V2ViVmlldyogd2ViVmlldykKICAgICAg ICAgMCwgLy8gZGlkRmlyc3RWaXN1YWxseU5vbkVtcHR5TGF5b3V0Rm9yRnJhbWUKICAgICAgICAg MCwgLy8gd2lsbEdvVG9CYWNrRm9yd2FyZExpc3RJdGVtCiAgICAgICAgIDAsIC8vIGludGVyYWN0 aW9uT2NjdXJyZWRXaGlsZVByb2Nlc3NVbnJlc3BvbnNpdmUKLSAgICAgICAgMCwgLy8gcGx1Z2lu RGlkRmFpbAorICAgICAgICAwLCAvLyBwbHVnaW5EaWRGYWlsX2RlcHJlY2F0ZWRGb3JVc2VXaXRo VjEKICAgICAgICAgMCwgLy8gZGlkUmVjZWl2ZUludGVudEZvckZyYW1lCiAgICAgICAgIDAsIC8v IHJlZ2lzdGVySW50ZW50U2VydmljZUZvckZyYW1lCiAgICAgICAgIDAsIC8vIGRpZExheW91dAor ICAgICAgICAwLCAvLyBwbHVnaW5Mb2FkUG9saWN5CisgICAgICAgIDAsIC8vIHBsdWdpbkRpZEZh aWwKICAgICB9OwogICAgIFdLUGFnZVJlZiB3a1BhZ2UgPSB0b0FQSSh3ZWJraXRXZWJWaWV3QmFz ZUdldFBhZ2UoV0VCS0lUX1dFQl9WSUVXX0JBU0Uod2ViVmlldykpKTsKICAgICBXS1BhZ2VTZXRQ YWdlTG9hZGVyQ2xpZW50KHdrUGFnZSwgJndrTG9hZGVyQ2xpZW50KTsK