112949 2013-03-21 12:20:10 -0700 Coordinates.idl lacks Conditional=GEOLOCATION 2013-03-22 13:16:36 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 112975 1 steveblock steveblock abarth benjamin esprehn+autocc ojan.autocc steveblock webkit.review.bot oldest_to_newest 860557 0 steveblock 2013-03-21 12:20:10 -0700 Coordinates.idl was added in http://trac.webkit.org/changeset/41650 and is used only by Geolocation. http://trac.webkit.org/changeset/56781 added the ENABLE_GEOLOCATION guard, but missed Coordinates.idl. 860681 1 194334 rcannings 2013-03-21 14:09:47 -0700 Created attachment 194334 Patch 860697 2 194334 eflews.bot 2013-03-21 14:26:28 -0700 Comment on attachment 194334 Patch Attachment 194334 did not pass efl-ews (efl): Output: http://webkit-commit-queue.appspot.com/results/17247268 860699 3 194334 abarth 2013-03-21 14:27:10 -0700 Comment on attachment 194334 Patch Should this move into Source/WebCore/Modules/geolocation ? 860765 4 steveblock 2013-03-21 15:05:10 -0700 > Should this move into Source/WebCore/Modules/geolocation ? Yes - https://bugs.webkit.org/show_bug.cgi?id=112945 860825 5 steveblock 2013-03-21 16:07:56 -0700 The EFL failure is because the custom bindings for Coordinates aren't guarded with GEOLOCATION. It seems a shame to add more guards there, but I think the problem can be avoided. The bindings generator now supports nullable types, so we should be able to remove the custom bindings altogether - Bug 112975 861092 6 194334 buildbot 2013-03-21 22:08:34 -0700 Comment on attachment 194334 Patch Attachment 194334 did not pass win-ews (win): Output: http://webkit-commit-queue.appspot.com/results/17169891 861735 7 194612 steveblock 2013-03-22 12:01:20 -0700 Created attachment 194612 Patch 861753 8 194612 steveblock 2013-03-22 12:19:45 -0700 Comment on attachment 194612 Patch Carrying forward abarth's r+ 861792 9 194612 webkit.review.bot 2013-03-22 13:16:33 -0700 Comment on attachment 194612 Patch Clearing flags on attachment: 194612 Committed r146645: <http://trac.webkit.org/changeset/146645> 861793 10 webkit.review.bot 2013-03-22 13:16:36 -0700 All reviewed patches have been landed. Closing bug. 194334 2013-03-21 14:09:47 -0700 2013-03-22 12:01:17 -0700 Patch bug-112949-20130321140534.patch text/plain 1126 rcannings U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ2NTA4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDQzZDlmN2FmNWU5Nzgx NzQ5MTZiMjU5NWRhNGZlOTUwNWZkOGQ2My4uMjJjYjM4Y2ViNjRkMWE2YTY0YWRjM2E3ZDA4Zjdk NGY3ZDhlNTNhMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEzLTAzLTIxICBTdGV2 ZSBCbG9jayAgPHN0ZXZlYmxvY2tAY2hyb21pdW0ub3JnPgorCisgICAgICAgIENvb3JkaW5hdGVz LmlkbCBsYWNrcyBDb25kaXRpb25hbD1HRU9MT0NBVElPTgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEyOTQ5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBidWlsZCBvcHRpbWl6YXRp b24gb25seS4KKworICAgICAgICAqIHBhZ2UvQ29vcmRpbmF0ZXMuaWRsOiBBZGRlZCBHRU9MT0NB VElPTiBjb25kaXRpb25hbCBndWFyZC4KKwogMjAxMy0wMy0yMSAgQWxleGV5IFByb3NrdXJ5YWtv diAgPGFwQGFwcGxlLmNvbT4KIAogICAgICAgICBNb3ZlIG5vbi10cml2aWFsIHZpcnR1YWwgZnVu Y3Rpb25zIG91dCBvZiBSZXNvdXJjZUhhbmRsZUNsaWVudC5oCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9wYWdlL0Nvb3JkaW5hdGVzLmlkbCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvQ29vcmRp bmF0ZXMuaWRsCmluZGV4IGRjNjRhNjBlNDk5NDA3ZmJjYmJiNDdlYTljNDRhZTI5MWFjMDExNzQu LjdjZWYzMzAwMWE0ZmQ4ZjcyMzY4OGQzNGQ4ZDk5MTk3OGQwZjIyNmYgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3BhZ2UvQ29vcmRpbmF0ZXMuaWRsCisrKyBiL1NvdXJjZS9XZWJDb3JlL3Bh Z2UvQ29vcmRpbmF0ZXMuaWRsCkBAIC0yNCw2ICsyNCw3IEBACiAgKi8KIAogWworICAgIENvbmRp dGlvbmFsPUdFT0xPQ0FUSU9OLAogICAgIE9taXRDb25zdHJ1Y3RvciwKICAgICBJbXBsZW1lbnRh dGlvbkxhY2tzVlRhYmxlCiBdIGludGVyZmFjZSBDb29yZGluYXRlcyB7Cg== 194612 2013-03-22 12:01:20 -0700 2013-03-22 13:16:32 -0700 Patch bug-112949-20130322115708.patch text/plain 1207 steveblock U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ2NjI2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDRjODBlZmQ1MDhhNzVl MDRjNTUwMzUyOGFhNGMzNTE0MDNhODJlYy4uMWQwM2RiMTJkNTZjY2RjMTRkNDAzMTYwMGNiZTQ0 MTAxOGFkNjAzNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEzLTAzLTIyICBTdGV2 ZSBCbG9jayAgPHN0ZXZlYmxvY2tAY2hyb21pdW0ub3JnPgorCisgICAgICAgIENvb3JkaW5hdGVz LmlkbCBsYWNrcyBDb25kaXRpb25hbD1HRU9MT0NBVElPTgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEyOTQ5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBidWlsZCBvcHRpbWl6YXRp b24gb25seS4KKworICAgICAgICAqIHBhZ2UvQ29vcmRpbmF0ZXMuaWRsOiBBZGRlZCBHRU9MT0NB VElPTiBjb25kaXRpb25hbCBndWFyZC4KKwogMjAxMy0wMy0yMiAgTmF0ZSBDaGFwaW4gIDxqYXBo ZXRAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJFR1JFU1NJT04gKHIxNDYyMzkpOiBSZXByb2R1 Y2libGUgY3Jhc2ggaW4gV2ViQ29yZTo6RG9jdW1lbnRMb2FkZXI6OnJlc3BvbnNlUmVjZWl2ZWQu CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2dlb2xvY2F0aW9uL0Nvb3JkaW5h dGVzLmlkbCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvZ2VvbG9jYXRpb24vQ29vcmRpbmF0ZXMu aWRsCmluZGV4IGYyN2ZmN2VmNDgxNTJjMjI3ZjE0NzE3MTk4YWE2Y2ViYzJiNGJkYzEuLjBmYjk3 ODEyMzJjMWVkOWE1Yzk4MDg3NWJmNmE0OWQ1NjY4ZTljZmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL01vZHVsZXMvZ2VvbG9jYXRpb24vQ29vcmRpbmF0ZXMuaWRsCisrKyBiL1NvdXJjZS9X ZWJDb3JlL01vZHVsZXMvZ2VvbG9jYXRpb24vQ29vcmRpbmF0ZXMuaWRsCkBAIC0yNCw2ICsyNCw3 IEBACiAgKi8KIAogWworICAgIENvbmRpdGlvbmFsPUdFT0xPQ0FUSU9OLAogICAgIE9taXRDb25z dHJ1Y3RvciwKICAgICBJbXBsZW1lbnRhdGlvbkxhY2tzVlRhYmxlCiBdIGludGVyZmFjZSBDb29y ZGluYXRlcyB7Cg==