112934 2013-03-21 11:09:54 -0700 [Windows, WinCairo] Correct Empty BitmapImage Test 2013-03-21 17:08:49 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bfulgham bfulgham roger_fong thorton oldest_to_newest 860474 0 bfulgham 2013-03-21 11:09:54 -0700 The TestWebKitAPI test for an empty image frame (added in Bug 102689) incorrectly handles the reference counting aspects of the underlying BitmapImage object. This patch corrects a debug-build assertion that would trigger for the WinCairo port when running this test. 860504 1 bfulgham 2013-03-21 11:27:27 -0700 Note that even with this patch we cannot run this test under the Windows CG build because the implementation of ImageSourceCG asserts that its internal frameCount method is non-zero. Since we do not provide an underlying CG image source for this test, the assertion will always fire. 860507 2 194303 bfulgham 2013-03-21 11:30:29 -0700 Created attachment 194303 Patch 860903 3 bfulgham 2013-03-21 17:08:49 -0700 Landed in r146507. 194303 2013-03-21 11:30:29 -0700 2013-03-21 11:33:27 -0700 Patch bug-112934-20130321112616.patch text/plain 1396 bfulgham SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE0NjQ4NykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDEzLTAzLTIxICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1Ad2Via2l0Lm9y Zz4KKworICAgICAgICBbV2luQ2Fpcm9dIENvcnJlY3QgYXNzZXJ0IGluIEVtcHR5IEJpdG1hcElt YWdlIFRlc3QuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMTI5MzQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIFRlc3RXZWJLaXRBUEkvVGVzdHMvV2ViQ29yZS93aW4vQml0bWFwSW1hZ2UuY3BwOgorICAg ICAgICAoVGVzdFdlYktpdEFQSTo6VEVTVCk6IFVzZSBwcm9wZXIgUmVmUHRyIGFuZCBhZG9wdFJl ZgorICAgICAgICB0byBhdm9pZCByZWYgY291bnRpbmcgYXNzZXJ0aW9uIHdoZW4gbGVhdmluZyB0 ZXN0IHNjb3BlLgorCiAyMDEzLTAzLTIxICBSb2dlciBGb25nICA8cm9nZXJfZm9uZ0BhcHBsZS5j b20+CiAKICAgICAgICAgUmUtZW5hYmxlIFdpbkVXUyB0ZXN0cyBmb2xsb3dpbmcgcjE0NjM3Ni4K SW5kZXg6IFRvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViQ29yZS93aW4vQml0bWFwSW1hZ2Uu Y3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViQ29yZS93aW4v Qml0bWFwSW1hZ2UuY3BwCShyZXZpc2lvbiAxNDY0ODEpCisrKyBUb29scy9UZXN0V2ViS2l0QVBJ L1Rlc3RzL1dlYkNvcmUvd2luL0JpdG1hcEltYWdlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNTAs MTAgKzUwLDEwIEBAIHB1YmxpYzoKIFRFU1QoV2ViQ29yZSwgQml0bWFwSW1hZ2VFbXB0eUZyYW1l VGVzdCkKIHsKICAgICBTSVpFIHN6ID0gezE2LCAxNn07Ci0gICAgQml0bWFwSW1hZ2VUZXN0IGJp dG1hcEltYWdlVGVzdDsKKyAgICBSZWZQdHI8Qml0bWFwSW1hZ2VUZXN0PiBiaXRtYXBJbWFnZVRl c3QgPSBhZG9wdFJlZihuZXcgQml0bWFwSW1hZ2VUZXN0KTsKICAgICBpbnQgYml0c1syNTZdOwog ICAgIEhCSVRNQVAgaEJpdG1hcCA9IENyZWF0ZUJpdG1hcCgxNiwgMTYsIDEsIDMyLCBiaXRzKTsK LSAgICBiaXRtYXBJbWFnZVRlc3QuZ2V0SEJJVE1BUE9mU2l6ZShoQml0bWFwLCAmc3opOworICAg IGJpdG1hcEltYWdlVGVzdC0+Z2V0SEJJVE1BUE9mU2l6ZShoQml0bWFwLCAmc3opOwogfQogCiB9 IC8vIG5hbWVzcGFjZSBUZXN0V2ViS2l0QVBJCg==