112925 2013-03-21 09:34:59 -0700 [GStreamer] Memory leak in AudioFileReader::createBus() 2013-03-22 01:10:07 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 naginenis naginenis eric.carlson feature-media-reviews jer.noble mrobinson pnormand webkit.review.bot oldest_to_newest 860416 0 naginenis 2013-03-21 09:34:59 -0700 Noticed the following leak while running MiniBrowser under valgrind. The source returned by g_timeout_source_new() must be freed to fix this leak. ==16369== 10,304 bytes in 92 blocks are definitely lost in loss record 14,493 of 14,765 ==16369== at 0x4C29DB4: calloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==16369== by 0xD5394C0: g_malloc0 (gmem.c:189) ==16369== by 0xD5319D4: g_source_new (gmain.c:793) ==16369== by 0xD5345C0: g_timeout_source_new (gmain.c:3908) ==16369== by 0x9F0721A: WebCore::AudioFileReader::createBus(float, bool) (AudioFileReaderGStreamer.cpp:464) ==16369== by 0x9F074C0: WebCore::createBusFromInMemoryAudioFile(void const*, unsigned long, bool, float) (AudioFileReaderGStreamer.cpp:492) ==16369== by 0x89D5435: WebCore::AudioBuffer::createFromAudioFileData(void const*, unsigned long, bool, float) (AudioBuffer.cpp:53) ==16369== by 0x89DBF30: WebCore::AudioContext::createBuffer(WTF::ArrayBuffer*, bool, int&) (AudioContext.cpp:328) ==16369== by 0x9A87F8E: WebCore::jsAudioContextPrototypeFunctionCreateBuffer2(JSC::ExecState*) (JSAudioContext.cpp:362) ==16369== by 0x9A880A9: WebCore::jsAudioContextPrototypeFunctionCreateBuffer(JSC::ExecState*) (JSAudioContext.cpp:374) 861154 1 194457 naginenis 2013-03-21 23:46:36 -0700 Created attachment 194457 Patch 861204 2 194457 webkit.review.bot 2013-03-22 01:10:03 -0700 Comment on attachment 194457 Patch Clearing flags on attachment: 194457 Committed r146571: <http://trac.webkit.org/changeset/146571> 861205 3 webkit.review.bot 2013-03-22 01:10:07 -0700 All reviewed patches have been landed. Closing bug. 194457 2013-03-21 23:46:36 -0700 2013-03-22 01:10:03 -0700 Patch 112925.patch text/plain 1918 naginenis ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA1YTEzNzhhLi41YmM0ODBiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTMtMDMtMjEgIFN1ZGFyc2FuYSBOYWdpbmVuaSAgPHN1ZGFyc2FuYS5uYWdpbmVuaUBp bnRlbC5jb20+CisKKyAgICAgICAgW0dTdHJlYW1lcl0gTWVtb3J5IGxlYWsgaW4gQXVkaW9GaWxl UmVhZGVyOjpjcmVhdGVCdXMoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTEyOTI1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgQWRvcHQgdGhlIHJlZmVyZW5jZSByZXR1cm5lZCBieSBnX3RpbWVvdXRfc291 cmNlX25ldygpCisgICAgICAgIHRvIGZpeCBhIG1lbW9yeSBsZWFrLgorCisgICAgICAgIE5vIG5l dyB0ZXN0cy4gTm8gY2hhbmdlIGluIGJlaGF2aW9yLgorCisgICAgICAgICogcGxhdGZvcm0vYXVk aW8vZ3N0cmVhbWVyL0F1ZGlvRmlsZVJlYWRlckdTdHJlYW1lci5jcHA6CisgICAgICAgIChXZWJD b3JlOjpBdWRpb0ZpbGVSZWFkZXI6OmNyZWF0ZUJ1cyk6CisKIDIwMTMtMDMtMjEgIEhhamltZSBN b3JyaXRhICA8bW9ycml0YUBnb29nbGUuY29tPgogCiAgICAgICAgIEN1c3RvbSBFbGVtZW50czog InJlYWR5Q2FsbGJhY2siIGxpZmVjeWNsZSBjYWxsYmFjayBzaG91bGQgYmUgY2FsbGVkLgpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYXVkaW8vZ3N0cmVhbWVyL0F1ZGlvRmls ZVJlYWRlckdTdHJlYW1lci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9hdWRpby9nc3Ry ZWFtZXIvQXVkaW9GaWxlUmVhZGVyR1N0cmVhbWVyLmNwcAppbmRleCBjOTg0Y2U5Li44ZWZiNmZj IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9hdWRpby9nc3RyZWFtZXIvQXVk aW9GaWxlUmVhZGVyR1N0cmVhbWVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9h dWRpby9nc3RyZWFtZXIvQXVkaW9GaWxlUmVhZGVyR1N0cmVhbWVyLmNwcApAQCAtNDU4LDkgKzQ1 OCw5IEBAIFBhc3NPd25QdHI8QXVkaW9CdXM+IEF1ZGlvRmlsZVJlYWRlcjo6Y3JlYXRlQnVzKGZs b2F0IHNhbXBsZVJhdGUsIGJvb2wgbWl4VG9Nb25vCiAgICAgbV9sb29wID0gYWRvcHRHUmVmKGdf bWFpbl9sb29wX25ldyhjb250ZXh0LmdldCgpLCBGQUxTRSkpOwogCiAgICAgLy8gU3RhcnQgdGhl IHBpcGVsaW5lIHByb2Nlc3NpbmcganVzdCBhZnRlciB0aGUgbG9vcCBpcyBzdGFydGVkLgotICAg IEdTb3VyY2UqIHRpbWVvdXRTb3VyY2UgPSBnX3RpbWVvdXRfc291cmNlX25ldygwKTsKLSAgICBn X3NvdXJjZV9hdHRhY2godGltZW91dFNvdXJjZSwgY29udGV4dC5nZXQoKSk7Ci0gICAgZ19zb3Vy Y2Vfc2V0X2NhbGxiYWNrKHRpbWVvdXRTb3VyY2UsIHJlaW50ZXJwcmV0X2Nhc3Q8R1NvdXJjZUZ1 bmM+KGVudGVyZWRNYWluTG9vcENhbGxiYWNrKSwgdGhpcywgMCk7CisgICAgR1JlZlB0cjxHU291 cmNlPiB0aW1lb3V0U291cmNlID0gYWRvcHRHUmVmKGdfdGltZW91dF9zb3VyY2VfbmV3KDApKTsK KyAgICBnX3NvdXJjZV9hdHRhY2godGltZW91dFNvdXJjZS5nZXQoKSwgY29udGV4dC5nZXQoKSk7 CisgICAgZ19zb3VyY2Vfc2V0X2NhbGxiYWNrKHRpbWVvdXRTb3VyY2UuZ2V0KCksIHJlaW50ZXJw cmV0X2Nhc3Q8R1NvdXJjZUZ1bmM+KGVudGVyZWRNYWluTG9vcENhbGxiYWNrKSwgdGhpcywgMCk7 CiAKICAgICBnX21haW5fbG9vcF9ydW4obV9sb29wLmdldCgpKTsKICAgICBnX21haW5fY29udGV4 dF9wb3BfdGhyZWFkX2RlZmF1bHQoY29udGV4dC5nZXQoKSk7Cg==