112892 2013-03-21 02:55:02 -0700 WinCairo build fails to link. 2013-03-22 09:21:26 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) PC Unspecified RESOLVED FIXED P2 Normal --- 0 peavo webkit-unassigned bfulgham haraken webkit.review.bot oldest_to_newest 860168 0 peavo 2013-03-21 02:55:02 -0700 The VS2005 WinCairo build fails with the following linker error: WebKit.exp : error LNK2001: unresolved external symbol "public: class WebCore::CaptionUserPreferences * __thiscall WebCore::PageGroup::captionPreferences(void)" (?captionPreferences@PageGroup@WebCore@@QAEPAVCaptionUserPreferences@2@XZ) C:\webkitdist\Release_Cairo_CFLite\bin\WebKit.dll : fatal error LNK1120: 1 unresolved externals 860170 1 194211 peavo 2013-03-21 03:00:29 -0700 Created attachment 194211 Patch 860949 2 194211 haraken 2013-03-21 17:57:00 -0700 Comment on attachment 194211 Patch rs=me 860979 3 194211 webkit.review.bot 2013-03-21 18:34:53 -0700 Comment on attachment 194211 Patch Clearing flags on attachment: 194211 Committed r146550: <http://trac.webkit.org/changeset/146550> 860980 4 webkit.review.bot 2013-03-21 18:34:56 -0700 All reviewed patches have been landed. Closing bug. 861550 5 bfulgham 2013-03-22 09:21:26 -0700 Thanks for fixing this. I corrected it in the VS2010 build, but forgot to check the VS2005 side! 194211 2013-03-21 03:00:29 -0700 2013-03-21 18:34:52 -0700 Patch bug-112892-20130321105604.patch text/plain 1441 peavo SW5kZXg6IFNvdXJjZS9XZWJLaXQvd2luL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L3dpbi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0NjQ0OSkKKysrIFNvdXJjZS9XZWJLaXQv d2luL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDEzLTAzLTIx ICBwZWF2b0BvdXRsb29rLmNvbSAgPHBlYXZvQG91dGxvb2suY29tPgorCisgICAgICAgIFdpbkNh aXJvIGJ1aWxkIGZhaWxzIHRvIGxpbmsuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xMTI4OTIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIFdlYktpdC52Y3Byb2ovV2ViS2l0RXhwb3J0cy5kZWYuaW46IEFk ZGVkIEVOQUJMRShWSURFT19UUkFDSykgZ3VhcmQuCisKIDIwMTMtMDMtMjAgIE1pY2hhZWwgUHJ1 ZXR0ICA8bWljaGFlbEA2OGsub3JnPgogCiAgICAgICAgIFtKU0NdIEltcGxlbWVudCBFbmZvcmNl UmFuZ2UgSURMIGF0dHJpYnV0ZSBmb3IgaW50ZWdlciBjb252ZXJzaW9ucwpJbmRleDogU291cmNl L1dlYktpdC93aW4vV2ViS2l0LnZjcHJvai9XZWJLaXRFeHBvcnRzLmRlZi5pbgo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvV2ViS2l0L3dpbi9XZWJLaXQudmNwcm9qL1dlYktpdEV4cG9ydHMuZGVmLmlu CShyZXZpc2lvbiAxNDY0NDcpCisrKyBTb3VyY2UvV2ViS2l0L3dpbi9XZWJLaXQudmNwcm9qL1dl YktpdEV4cG9ydHMuZGVmLmluCSh3b3JraW5nIGNvcHkpCkBAIC00MTYsNyArNDE2LDkgQEAgRVhQ T1JUUwogICAgICAgICA/c2V0QXV0aG9yQW5kVXNlclN0eWxlc0VuYWJsZWRAU2V0dGluZ3NAV2Vi Q29yZUBAUUFFWF9OQFoKICAgICAgICAgP3NldEFjY2VsZXJhdGVkQ29tcG9zaXRpbmdFbmFibGVk QFNldHRpbmdzQFdlYkNvcmVAQFFBRVhfTkBaCiAgICAgICAgID9zZXRBdXRvZmlsbGVkQEhUTUxJ bnB1dEVsZW1lbnRAV2ViQ29yZUBAUUFFWF9OQFoKKyNpZiBFTkFCTEUoVklERU9fVFJBQ0spCiAg ICAgICAgID9jYXB0aW9uUHJlZmVyZW5jZXNAUGFnZUdyb3VwQFdlYkNvcmVAQFFBRVBBVkNhcHRp b25Vc2VyUHJlZmVyZW5jZXNAMkBYWgorI2VuZGlmCiAgICAgICAgID9pbml0R3JvdXBAUGFnZUBX ZWJDb3JlQEBBQUVYWFoKICAgICAgICAgP3RvSW50MzJFbmZvcmNlUmFuZ2VAV2ViQ29yZUBAWUFI UEFWRXhlY1N0YXRlQEpTQ0BAVkpTVmFsdWVAM0BAWgogICAgICAgICA/dG9JbnQ2NEBXZWJDb3Jl QEBZQV9KUEFWRXhlY1N0YXRlQEpTQ0BAVkpTVmFsdWVAM0BXNEludGVnZXJDb252ZXJzaW9uQ29u ZmlndXJhdGlvbkAxQEBaCg==