112875 2013-03-20 22:03:45 -0700 REGRESSION(r146417-r146431): Substantially more leaks detected on Mountain Lion 2013-03-21 16:51:40 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED INVALID P2 Normal --- 1 rniwa webkit-unassigned ap barraclough haraken michael slewis oldest_to_newest 860021 0 rniwa 2013-03-20 22:03:45 -0700 http://build.webkit.org/builders/Apple%20MountainLion%20%28Leaks%29 Mar 20 20:20 146431 failure #3715 Failed 9145 total leaks found for a total of 3,025,392 bytes! 203 unique leaks found! 5 failures 11 new passes 23 flakes Mar 20 19:42 146430 failure #3714 Failed exiting early after 20 crashes and 0 timeouts. 3456 tests run. 20 failures 3 new passes 6 unit tests failed or timed out Mar 20 19:15 146426 failure #3713 Failed exiting early after 20 crashes and 0 timeouts. 3459 tests run. 20 failures 3 new passes 6 unit tests failed or timed out Mar 20 18:21 146420 failure #3712 Failed exiting early after 20 crashes and 0 timeouts. 3459 tests run. 20 failures 3 new passes 6 unit tests failed or timed out Mar 20 16:56 146412 failure #3711 Failed 10476 total leaks found for a total of 581,968 bytes! 163 unique leaks found! 11 new passes 28 flakes Mar 20 16:08 146405 failure #3710 Failed 10708 total leaks found for a total of 525,040 bytes! 166 unique leaks found! 14 new passes 32 flakes Mar 20 15:20 146394 failure #3709 Failed 11591 total leaks found for a total of 573,616 bytes! 194 unique leaks found! 14 new passes 29 flakes Mar 20 13:53 146383 failure #3708 Failed 10475 total leaks found for a total of 566,480 bytes! 185 unique leaks found! 14 new passes 32 flakes http://build.webkit.org/builders/Apple%20Lion%20%28Leaks%29 Mar 20 19:52 146430 failure #4230 Failed exiting early after 20 crashes and 0 timeouts. 3626 tests run. 20 failures 3 new passes 6 unit tests failed or timed out Mar 20 19:18 146426 failure #4229 Failed exiting early after 20 crashes and 0 timeouts. 3637 tests run. 20 failures 3 new passes 6 unit tests failed or timed out Mar 20 17:11 146416 failure #4228 Failed exiting early after 1 crashes and 19 timeouts. 21605 tests run. 5005 total leaks found for a total of 542,400 bytes! 196 unique leaks found! 41 failures 12 new passes 860022 1 rniwa 2013-03-20 22:05:36 -0700 Hm… it seems leaks are coming from __CFURLCache :( I'm not sure what to do. http://build.webkit.org/LeaksViewer/?url=%2Fresults%2FApple%20MountainLion%20%28Leaks%29%2Fr146431%20%283715%29%2F 860023 2 slewis 2013-03-20 22:10:51 -0700 we usually try to find once specific test case causes the leak and then we file a bug on CFNetwork. 860025 3 slewis 2013-03-20 22:12:02 -0700 Once a bug is filed we can add a regexp for the leak to the excluded leaks file so it doesn't interfere with the current results. 860065 4 rniwa 2013-03-20 23:33:37 -0700 Blame list: http://trac.webkit.org/log/?verbose=on&rev=146431&stop_rev=146412 In this range, only the following changesets contain relevant code changes other than http://trac.webkit.org/changeset/146419, which got later rolled out to fix builds: http://trac.webkit.org/changeset/146417 http://trac.webkit.org/changeset/146427 http://trac.webkit.org/changeset/146430 And it appears that 146417 and 146427 are trivial changes too. That makes me think that http://trac.webkit.org/changeset/146430 might be the culprit. 860112 5 haraken 2013-03-21 00:42:09 -0700 (In reply to comment #4) > And it appears that 146417 and 146427 are trivial changes too. That makes me think that http://trac.webkit.org/changeset/146430 might be the culprit. hmm, I don't think r146430 is the culprit. r146430 just changed a rule of integer conversion. michael: thoughts? 860264 6 michael 2013-03-21 06:01:10 -0700 (In reply to comment #5) > hmm, I don't think r146430 is the culprit. r146430 just changed a rule of integer conversion. > > michael: thoughts? I would be rather surprised if r146430 were the source of any leaks since it did only change IDL integer conversion. Aside from the implementation of EnforceRange, currently used only in IndexedDB and internal testing, the only other change of note in this revision concerns the conversion of ECMAScript numbers to IDL long long and unsigned long long types. Specifically +/-infinity are now converted to 0, and values greater in magnitude than 2^64 are converted to integers modulo 2^64. Previously such out-of-range values were mapped to the nearest representable integer. 860880 7 rniwa 2013-03-21 16:51:40 -0700 It seems like this was a temporary fluke :(