11286 2006-10-13 18:29:28 -0700 Allocator mismatch in CookieJarWin 2006-10-31 10:52:32 -0800 1 1 1 Unclassified WebKit Platform 420+ PC Windows XP RESOLVED FIXED P2 Trivial --- 1 fishd fishd oldest_to_newest 53290 0 fishd 2006-10-13 18:29:28 -0700 Allocator mismatch in CookieJarWin: UChar* buffer = new UChar[count]; ... delete buffer; That should be "delete[] buffer" though this surely doesn't cause any real problem since UChar doesn't have a destructor. Anyways, patch coming up... 53291 1 11084 fishd 2006-10-13 18:31:00 -0700 Created attachment 11084 patch 48412 2 11084 mjs 2006-10-31 04:42:13 -0800 Comment on attachment 11084 patch r=me Thanks also for cleaning up the style issues. This should be clear to land. 48224 3 ap 2006-10-31 10:52:32 -0800 Committed revision 17485. 11084 2006-10-13 18:31:00 -0700 2006-10-31 04:42:13 -0800 patch fix-1.diff text/plain 1614 fishd SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDE3MDUy KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDYtMTAt MTMgIE1vcmdhbkwgIDxtb3JnYW5sLndlYmtpdEB5YWhvby5jb20+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4ZXMgaHR0cDovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEyODYKKyAgICAgICAgSW5jbHVkZXMgc29tZSBDUkxGIC0+ IExGIGZpeHVwcy4KKworICAgICAgICAqIHBsYXRmb3JtL3dpbi9Db29raWVKYXJXaW4uY3BwOgor ICAgICAgICAoV2ViQ29yZTo6Y29va2llcyk6CisKIDIwMDYtMTAtMTMgIEJldGggRGFraW4gIDxi ZGFraW5AYXBwbGUuY29tPgogCiAgICAgICAgIFBhdGNoIHdyaXR0ZW4gbW9zdGx5IGJ5IEtlbiBL cmFpc2xlciwgYnV0IGFsc28gYnkgbWUuCkluZGV4OiBwbGF0Zm9ybS93aW4vQ29va2llSmFyV2lu LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBwbGF0Zm9ybS93aW4vQ29va2llSmFyV2luLmNwcAkocmV2aXNp b24gMTcwMDEpCisrKyBwbGF0Zm9ybS93aW4vQ29va2llSmFyV2luLmNwcAkod29ya2luZyBjb3B5 KQpAQCAtNDksMTUgKzQ5LDE1IEBAIFN0cmluZyBjb29raWVzKGNvbnN0IEtVUkwmIHVybCkKICAg ICBzdHIuYXBwZW5kKChVQ2hhciknXDAnKTsKIAogICAgIERXT1JEIGNvdW50OwotICAgIEludGVy bmV0R2V0Q29va2llKChVQ2hhciopc3RyLnVuaWNvZGUoKSwgMCwgMCwgJmNvdW50KTsNCi0gICAg aWYgKGNvdW50IDw9IDEpIC8vIE51bGwgdGVybWluYXRvciBjb3VudHMgYXMgMS4NCi0gICAgICAg IHJldHVybiBTdHJpbmcoKTsNCi0NCi0gICAgVUNoYXIqIGJ1ZmZlciA9IG5ldyBVQ2hhcltjb3Vu dF07DQotICAgIEludGVybmV0R2V0Q29va2llKChVQ2hhciopc3RyLnVuaWNvZGUoKSwgMCwgYnVm ZmVyLCAmY291bnQpOw0KLSAgICBTdHJpbmcmIHJlc3VsdCA9IFN0cmluZyhidWZmZXIsIGNvdW50 LTEpOyAvLyBJZ25vcmUgdGhlIG51bGwgdGVybWluYXRvci4NCi0gICAgZGVsZXRlIGJ1ZmZlcjsN Ci0gICAgcmV0dXJuIHJlc3VsdDsNCisgICAgSW50ZXJuZXRHZXRDb29raWUoKFVDaGFyKilzdHIu dW5pY29kZSgpLCAwLCAwLCAmY291bnQpOworICAgIGlmIChjb3VudCA8PSAxKSAvLyBOdWxsIHRl cm1pbmF0b3IgY291bnRzIGFzIDEuCisgICAgICAgIHJldHVybiBTdHJpbmcoKTsKKworICAgIFVD aGFyKiBidWZmZXIgPSBuZXcgVUNoYXJbY291bnRdOworICAgIEludGVybmV0R2V0Q29va2llKChV Q2hhciopc3RyLnVuaWNvZGUoKSwgMCwgYnVmZmVyLCAmY291bnQpOworICAgIFN0cmluZyYgcmVz dWx0ID0gU3RyaW5nKGJ1ZmZlciwgY291bnQtMSk7IC8vIElnbm9yZSB0aGUgbnVsbCB0ZXJtaW5h dG9yLgorICAgIGRlbGV0ZVtdIGJ1ZmZlcjsKKyAgICByZXR1cm4gcmVzdWx0OwogfQogCiBib29s IGNvb2tpZXNFbmFibGVkKCkK