112848 2013-03-20 14:51:52 -0700 dialog-enabled.html and dialog-disabled.html don't really test what they think they do 2013-03-20 16:07:11 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 112191 1 tsepez tsepez abarth webkit.review.bot oldest_to_newest 859760 0 tsepez 2013-03-20 14:51:52 -0700 This was kicked loose by the V8 Binding Integrity work. In these tests, there is HTML <dialog id="mydialog"></dialog> before the script that does: if (window.internals) internals.settings.setDialogElementEnabled(true); and thus HTMLElementFactory.cpp's dialogConstructor() returns 0, and an HTMLUnknownElement with name "dialog" is created. To fix the test, we must set the setting before parsing the <dialog> element. 859791 1 194132 tsepez 2013-03-20 15:19:43 -0700 Created attachment 194132 Patch. Only tests changed. 859838 2 194132 webkit.review.bot 2013-03-20 16:07:07 -0700 Comment on attachment 194132 Patch. Clearing flags on attachment: 194132 Committed r146406: <http://trac.webkit.org/changeset/146406> 859839 3 webkit.review.bot 2013-03-20 16:07:11 -0700 All reviewed patches have been landed. Closing bug. 194132 2013-03-20 15:19:43 -0700 2013-03-20 16:07:07 -0700 Patch. patch_112848.txt text/plain 2486 tsepez SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDE0NjM5NikKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDEzLTAzLTIwICBUb20gU2VwZXogIDx0c2Vw ZXpAY2hyb21pdW0ub3JnPgorCisgICAgICAgIGRpYWxvZy1lbmFibGVkLmh0bWwgYW5kIGRpYWxv Zy1kaXNhYmxlZC5odG1sIGRvbid0IHJlYWxseSB0ZXN0IHdoYXQgdGhleSB0aGluayB0aGV5IGRv CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTI4NDgK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGZhc3Qv ZG9tL0hUTUxEaWFsb2dFbGVtZW50L2RpYWxvZy1kaXNhYmxlZC5odG1sOgorICAgICAgICAqIGZh c3QvZG9tL0hUTUxEaWFsb2dFbGVtZW50L2RpYWxvZy1lbmFibGVkLmh0bWw6CisgICAgICAgIFNl dCB0aGUgZGlhbG9nIGVsZW1lbnQgZW5hYmxlZCBzZXR0aW5nIGJlZm9yZSBwYXJzaW5nIDxkaWFs b2c+IGVsZW1lbnQuCisKIDIwMTMtMDMtMjAgIEtlbnQgVGFtdXJhICA8dGtlbnRAY2hyb21pdW0u b3JnPgogCiAgICAgICAgIENyYXNoIGluIERvY3VtZW50OjpzZXRGb2N1c2VkTm9kZSBpZiB0aGUg ZnJhbWUgb2YgbmV3IGZvY3VzZWQgbm9kZSBpcyBkZXRhY2hlZCBpbiAnY2hhbmdlJyBldmVudCBo YW5kbGVyCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2RvbS9IVE1MRGlhbG9nRWxlbWVudC9kaWFs b2ctZGlzYWJsZWQuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2RvbS9IVE1M RGlhbG9nRWxlbWVudC9kaWFsb2ctZGlzYWJsZWQuaHRtbAkocmV2aXNpb24gMTQ2Mzk0KQorKysg TGF5b3V0VGVzdHMvZmFzdC9kb20vSFRNTERpYWxvZ0VsZW1lbnQvZGlhbG9nLWRpc2FibGVkLmh0 bWwJKHdvcmtpbmcgY29weSkKQEAgLTEsMTQgKzEsMTYgQEAKIDwhRE9DVFlQRSBodG1sPgogPGh0 bWw+CiA8aGVhZD4KKzxzY3JpcHQ+CitpZiAod2luZG93LmludGVybmFscykKKyAgICBpbnRlcm5h bHMuc2V0dGluZ3Muc2V0RGlhbG9nRWxlbWVudEVuYWJsZWQoZmFsc2UpOworPC9zY3JpcHQ+CiA8 c2NyaXB0IHNyYz0iLi4vLi4vanMvcmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48L3NjcmlwdD4K IDwvaGVhZD4KIDxib2R5PgogPGRpYWxvZyBpZD0ibXlkaWFsb2ciPjwvZGlhbG9nPgogPHNjcmlw dD4KIGRlc2NyaXB0aW9uKCJUaGUgRElBTE9HIGVsZW1lbnQgc2hvdWxkIG5vdCBiZSByZWNvZ25p emVkIGlmIHRoZSBkaWFsb2cgZmVhdHVyZSBpcyBvZmYuIik7Ci1pZiAod2luZG93LmludGVybmFs cykKLSAgICBpbnRlcm5hbHMuc2V0dGluZ3Muc2V0RGlhbG9nRWxlbWVudEVuYWJsZWQoZmFsc2Up OwogZGlhbG9nID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ215ZGlhbG9nJyk7CiBzaG91bGRC ZVRydWUoInR5cGVvZiBkaWFsb2cuc2hvdyA9PSAndW5kZWZpbmVkJyIpOwogPC9zY3JpcHQ+Cklu ZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2RvbS9IVE1MRGlhbG9nRWxlbWVudC9kaWFsb2ctZW5hYmxl ZC5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvZG9tL0hUTUxEaWFsb2dFbGVt ZW50L2RpYWxvZy1lbmFibGVkLmh0bWwJKHJldmlzaW9uIDE0NjM5NCkKKysrIExheW91dFRlc3Rz L2Zhc3QvZG9tL0hUTUxEaWFsb2dFbGVtZW50L2RpYWxvZy1lbmFibGVkLmh0bWwJKHdvcmtpbmcg Y29weSkKQEAgLTEsMTQgKzEsMTYgQEAKIDwhRE9DVFlQRSBodG1sPgogPGh0bWw+CiA8aGVhZD4K KzxzY3JpcHQ+CitpZiAod2luZG93LmludGVybmFscykKKyAgICBpbnRlcm5hbHMuc2V0dGluZ3Mu c2V0RGlhbG9nRWxlbWVudEVuYWJsZWQodHJ1ZSk7Cis8L3NjcmlwdD4KIDxzY3JpcHQgc3JjPSIu Li8uLi9qcy9yZXNvdXJjZXMvanMtdGVzdC1wcmUuanMiPjwvc2NyaXB0PgogPC9oZWFkPgogPGJv ZHk+CiA8ZGlhbG9nIGlkPSJteWRpYWxvZyI+PC9kaWFsb2c+CiA8c2NyaXB0PgogZGVzY3JpcHRp b24oIlRoZSBESUFMT0cgZWxlbWVudCBzaG91bGQgYmUgcmVjb2duaXplZCBpZiB0aGUgZGlhbG9n IGZlYXR1cmUgaXMgb24uIik7Ci1pZiAod2luZG93LmludGVybmFscykKLSAgICBpbnRlcm5hbHMu c2V0dGluZ3Muc2V0RGlhbG9nRWxlbWVudEVuYWJsZWQodHJ1ZSk7CiBkaWFsb2cgPSBkb2N1bWVu dC5nZXRFbGVtZW50QnlJZCgnbXlkaWFsb2cnKTsKIHNob3VsZEJlVHJ1ZSgidHlwZW9mIGRpYWxv Zy5zaG93ID09ICdmdW5jdGlvbiciKTsKIDwvc2NyaXB0Pgo=