112846 2013-03-20 14:40:08 -0700 Remove obsolete conditionals around calling SkTypeface::getUnitsPerEm() 2013-03-21 14:41:21 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 reed reed d-r peter senorblanco webkit.review.bot oldest_to_newest 859749 0 reed 2013-03-20 14:40:08 -0700 Remove obsolete conditionals around calling SkTypeface::getUnitsPerEm() 859750 1 194126 reed 2013-03-20 14:41:13 -0700 Created attachment 194126 Patch 859753 2 194126 senorblanco 2013-03-20 14:45:08 -0700 Comment on attachment 194126 Patch If the bots like it, I like it. r=me 860252 3 194126 webkit.review.bot 2013-03-21 05:52:11 -0700 Comment on attachment 194126 Patch Clearing flags on attachment: 194126 Committed r146456: <http://trac.webkit.org/changeset/146456> 860253 4 webkit.review.bot 2013-03-21 05:52:14 -0700 All reviewed patches have been landed. Closing bug. 860714 5 wangxianzhu 2013-03-21 14:41:21 -0700 *** Bug 75961 has been marked as a duplicate of this bug. *** 194126 2013-03-20 14:41:13 -0700 2013-03-21 05:52:10 -0700 Patch bug-112846-20130320173703.patch text/plain 1813 reed SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0NjM5MSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEzLTAzLTIwICBNaWtlIFJl ZWQgIDxyZWVkQGdvb2dsZS5jb20+CisKKyAgICAgICAgUmVtb3ZlIG9ic29sZXRlIGNvbmRpdGlv bmFscyBhcm91bmQgY2FsbGluZyBTa1R5cGVmYWNlOjpnZXRVbml0c1BlckVtKCkKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMjg0NgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEV4aXN0aW5nIGNvbXBsZXgt dGV4dCBsYXlvdXR0ZXN0cyBleGVyY2lzZSB0aGlzIGNvZGUuCisKKyAgICAgICAgKiBwbGF0Zm9y bS9ncmFwaGljcy9oYXJmYnV6ei9Gb250UGxhdGZvcm1EYXRhSGFyZkJ1enouY3BwOgorICAgICAg ICAoV2ViQ29yZTo6Rm9udFBsYXRmb3JtRGF0YTo6ZW1TaXplSW5Gb250VW5pdHMpOgorCiAyMDEz LTAzLTIwICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAgICAgICAgIEFzc2Vy dGlvbiBpbiBMZWdhY3lXZWJBcmNoaXZlOjpjcmVhdGUoKSBpbiBlZGl0aW5nIHRlc3RzCkluZGV4 OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9oYXJmYnV6ei9Gb250UGxhdGZvcm1E YXRhSGFyZkJ1enouY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL2hhcmZidXp6L0ZvbnRQbGF0Zm9ybURhdGFIYXJmQnV6ei5jcHAJKHJldmlzaW9uIDE0 NjM4NikKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2hhcmZidXp6L0ZvbnRQ bGF0Zm9ybURhdGFIYXJmQnV6ei5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE2NSwxNyArMTY1LDcg QEAgaW50IEZvbnRQbGF0Zm9ybURhdGE6OmVtU2l6ZUluRm9udFVuaXRzKAogICAgIGlmIChtX2Vt U2l6ZUluRm9udFVuaXRzKQogICAgICAgICByZXR1cm4gbV9lbVNpemVJbkZvbnRVbml0czsKIAot ICAgIC8vIEZJWE1FOiBTd2l0Y2ggdG8gdGhlIFNrVHlwZWZhY2U6OkdldFVuaXRzUGVyRW0gQVBJ IG9uY2UgdGhpcyBiZWNvbWVzIGF2YWlsYWJsZS4KLSAgICAvLyBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzU5NjEKLSNpZiBPUyhBTkRST0lEKQotICAgIC8vIEFuZHJv aWQgZG9lc24ndCBjdXJyZW50bHkgc3VwcG9ydCBTa2lhJ3MgZ2V0QWR2YW5jZWRUeXBlZmFjZU1l dHJpY3MoKSwKLSAgICAvLyBidXQgaXQgaGFzIGFjY2VzcyB0byBhbm90aGVyIG1ldGhvZCB0byBy ZXBsYWNlIHRoaXMgZnVuY3Rpb25hbGl0eS4KICAgICBtX2VtU2l6ZUluRm9udFVuaXRzID0gbV90 eXBlZmFjZS0+Z2V0VW5pdHNQZXJFbSgpOwotI2Vsc2UKLSAgICBTa0FkdmFuY2VkVHlwZWZhY2VN ZXRyaWNzKiBtZXRyaWNzID0gbV90eXBlZmFjZS0+Z2V0QWR2YW5jZWRUeXBlZmFjZU1ldHJpY3Mo U2tBZHZhbmNlZFR5cGVmYWNlTWV0cmljczo6a05vX1BlckdseXBoSW5mbyk7Ci0gICAgbV9lbVNp emVJbkZvbnRVbml0cyA9IG1ldHJpY3MtPmZFbVNpemU7Ci0gICAgbWV0cmljcy0+dW5yZWYoKTsK LSNlbmRpZgogICAgIHJldHVybiBtX2VtU2l6ZUluRm9udFVuaXRzOwogfQogCg==