112817 2013-03-20 09:03:24 -0700 [V8] Rename DOMDataStore::isMainWorldObject 2013-03-20 09:58:11 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 marja marja abarth dcarney haraken japhet webkit.review.bot oldest_to_newest 859469 0 marja 2013-03-20 09:03:24 -0700 ... and it's not needed in DOMDataStore::getWrapperForMainWorld. 859470 1 194072 marja 2013-03-20 09:05:16 -0700 Created attachment 194072 Patch 859472 2 194072 jochen 2013-03-20 09:08:21 -0700 Comment on attachment 194072 Patch what about canExistInWorker() instead? 859475 3 194073 marja 2013-03-20 09:12:47 -0700 Created attachment 194073 Patch 859510 4 194073 webkit.review.bot 2013-03-20 09:58:08 -0700 Comment on attachment 194073 Patch Clearing flags on attachment: 194073 Committed r146357: <http://trac.webkit.org/changeset/146357> 859511 5 webkit.review.bot 2013-03-20 09:58:11 -0700 All reviewed patches have been landed. Closing bug. 194072 2013-03-20 09:05:16 -0700 2013-03-20 09:12:43 -0700 Patch bug-112817-20130320170105.patch text/plain 3828 marja U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ2MzUwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDgzMzJhMGQ1MDlkNjI3 OWZlZjA4NDZlZGU2ODEyM2RmMTJhZGQxNy4uZTliMjMwZDUyMmRiODIwYTk0M2NiNjY5MjhiNzRj OTJhN2ExMDIzOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEzLTAzLTIwICBNYXJq YSBIw7ZsdHTDpCAgPG1hcmphQGNocm9taXVtLm9yZz4KKworICAgICAgICBbVjhdIFJlbmFtZSBE T01EYXRhU3RvcmU6OmlzTWFpbldvcmxkT2JqZWN0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTI4MTcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMgKG5vIGNoYW5nZXMgaW4gZnVuY3Rp b25hbGl0eSkuCisKKyAgICAgICAgKiBiaW5kaW5ncy92OC9ET01EYXRhU3RvcmUuaDoKKyAgICAg ICAgKFdlYkNvcmU6OkRPTURhdGFTdG9yZTo6Z2V0V3JhcHBlckZhc3QpOgorICAgICAgICAoV2Vi Q29yZTo6RE9NRGF0YVN0b3JlOjpnZXRXcmFwcGVyKToKKyAgICAgICAgKFdlYkNvcmU6OkRPTURh dGFTdG9yZTo6Z2V0V3JhcHBlckZvck1haW5Xb3JsZCk6CisgICAgICAgIChXZWJDb3JlOjpET01E YXRhU3RvcmU6OnNldFdyYXBwZXIpOgorICAgICAgICAoV2ViQ29yZTo6RE9NRGF0YVN0b3JlOjpj YW5Pbmx5RXhpc3RJbk1haW5UaHJlYWQpOgorCiAyMDEzLTAzLTIwICBNaWtlIFdlc3QgIDxta3dz dEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgRHJvcCBmdWxsIFVSTHMgZnJvbSBjcm9zcy1kb21h aW4gYWNjZXNzIGVycm9ycyBjYXVzZWQgYnkgJ2RvY3VtZW50LmRvbWFpbicgbWlzbWF0Y2hlcy4K ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L0RPTURhdGFTdG9yZS5oIGIv U291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvRE9NRGF0YVN0b3JlLmgKaW5kZXggNDQxNWQ4NTM1 NTNjNmNhMjI4ZWEzY2FhMjIyMDdlMDIyYzZhZTMzYS4uNjZlYmJlZjU4MTQ0ODdjYmMyOGQ0OThi OTk2NTQ5OTk0NmZjNWQwNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvdjgv RE9NRGF0YVN0b3JlLmgKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvRE9NRGF0YVN0 b3JlLmgKQEAgLTY1LDcgKzY1LDcgQEAgcHVibGljOgogICAgICAgICAvLyBpcyBhbiBvYmplY3Qg dGhhdCBjYW4gZXhpc3QgaW4gdGhlIG1haW4gd29ybGQuIFRoZSBzZWNvbmQgZmFzdGVzdAogICAg ICAgICAvLyB3YXkgaXMgdG8gY2hlY2sgd2hldGhlciB0aGUgd3JhcHBhYmxlJ3Mgd3JhcHBlciBp cyB0aGUgc2FtZSBhcwogICAgICAgICAvLyB0aGUgaG9sZGVyLgotICAgICAgICBpZiAoKCFET01X cmFwcGVyV29ybGQ6Omlzb2xhdGVkV29ybGRzRXhpc3QoKSAmJiBpc01haW5Xb3JsZE9iamVjdChv YmplY3QpKSB8fCBob2xkZXJDb250YWluc1dyYXBwZXIoY29udGFpbmVyLCBob2xkZXIpKSB7Cisg ICAgICAgIGlmICgoIURPTVdyYXBwZXJXb3JsZDo6aXNvbGF0ZWRXb3JsZHNFeGlzdCgpICYmIGNh bk9ubHlFeGlzdEluTWFpblRocmVhZChvYmplY3QpKSB8fCBob2xkZXJDb250YWluc1dyYXBwZXIo Y29udGFpbmVyLCBob2xkZXIpKSB7CiAgICAgICAgICAgICBpZiAobWFpbldvcmxkV3JhcHBlcklz U3RvcmVkSW5PYmplY3Qob2JqZWN0KSkKICAgICAgICAgICAgICAgICByZXR1cm4gZ2V0V3JhcHBl ckZyb21PYmplY3Qob2JqZWN0KTsKICAgICAgICAgICAgIHJldHVybiBtYWluV29ybGRTdG9yZSgp LT5tX3dyYXBwZXJNYXAuZ2V0KG9iamVjdCk7CkBAIC03Niw3ICs3Niw3IEBAIHB1YmxpYzoKICAg ICB0ZW1wbGF0ZTx0eXBlbmFtZSBUPgogICAgIHN0YXRpYyB2ODo6SGFuZGxlPHY4OjpPYmplY3Q+ IGdldFdyYXBwZXIoVCogb2JqZWN0LCB2ODo6SXNvbGF0ZSogaXNvbGF0ZSkKICAgICB7Ci0gICAg ICAgIGlmIChtYWluV29ybGRXcmFwcGVySXNTdG9yZWRJbk9iamVjdChvYmplY3QpICYmIGlzTWFp bldvcmxkT2JqZWN0KG9iamVjdCkpIHsKKyAgICAgICAgaWYgKG1haW5Xb3JsZFdyYXBwZXJJc1N0 b3JlZEluT2JqZWN0KG9iamVjdCkgJiYgY2FuT25seUV4aXN0SW5NYWluVGhyZWFkKG9iamVjdCkp IHsKICAgICAgICAgICAgIGlmIChMSUtFTFkoIURPTVdyYXBwZXJXb3JsZDo6aXNvbGF0ZWRXb3Js ZHNFeGlzdCgpKSkKICAgICAgICAgICAgICAgICByZXR1cm4gZ2V0V3JhcHBlckZyb21PYmplY3Qo b2JqZWN0KTsKICAgICAgICAgfQpAQCAtODYsNyArODYsNyBAQCBwdWJsaWM6CiAgICAgdGVtcGxh dGU8dHlwZW5hbWUgVD4KICAgICBzdGF0aWMgdjg6OkhhbmRsZTx2ODo6T2JqZWN0PiBnZXRXcmFw cGVyRm9yTWFpbldvcmxkKFQqIG9iamVjdCkKICAgICB7Ci0gICAgICAgIGlmIChtYWluV29ybGRX cmFwcGVySXNTdG9yZWRJbk9iamVjdChvYmplY3QpICYmIGlzTWFpbldvcmxkT2JqZWN0KG9iamVj dCkpCisgICAgICAgIGlmIChtYWluV29ybGRXcmFwcGVySXNTdG9yZWRJbk9iamVjdChvYmplY3Qp KQogICAgICAgICAgICAgcmV0dXJuIGdldFdyYXBwZXJGcm9tT2JqZWN0KG9iamVjdCk7CiAgICAg ICAgIHJldHVybiBtYWluV29ybGRTdG9yZSgpLT5nZXQob2JqZWN0KTsKICAgICB9CkBAIC05NCw3 ICs5NCw3IEBAIHB1YmxpYzoKICAgICB0ZW1wbGF0ZTx0eXBlbmFtZSBUPgogICAgIHN0YXRpYyB2 b2lkIHNldFdyYXBwZXIoVCogb2JqZWN0LCB2ODo6SGFuZGxlPHY4OjpPYmplY3Q+IHdyYXBwZXIs IHY4OjpJc29sYXRlKiBpc29sYXRlLCBjb25zdCBXcmFwcGVyQ29uZmlndXJhdGlvbiYgY29uZmln dXJhdGlvbikKICAgICB7Ci0gICAgICAgIGlmIChtYWluV29ybGRXcmFwcGVySXNTdG9yZWRJbk9i amVjdChvYmplY3QpICYmIGlzTWFpbldvcmxkT2JqZWN0KG9iamVjdCkpIHsKKyAgICAgICAgaWYg KG1haW5Xb3JsZFdyYXBwZXJJc1N0b3JlZEluT2JqZWN0KG9iamVjdCkgJiYgY2FuT25seUV4aXN0 SW5NYWluVGhyZWFkKG9iamVjdCkpIHsKICAgICAgICAgICAgIGlmIChMSUtFTFkoIURPTVdyYXBw ZXJXb3JsZDo6aXNvbGF0ZWRXb3JsZHNFeGlzdCgpKSkgewogICAgICAgICAgICAgICAgIHNldFdy YXBwZXJJbk9iamVjdChvYmplY3QsIHdyYXBwZXIsIGlzb2xhdGUsIGNvbmZpZ3VyYXRpb24pOwog ICAgICAgICAgICAgICAgIHJldHVybjsKQEAgLTEzMSw4ICsxMzEsOCBAQCBwcml2YXRlOgogICAg IHN0YXRpYyBib29sIG1haW5Xb3JsZFdyYXBwZXJJc1N0b3JlZEluT2JqZWN0KHZvaWQqKSB7IHJl dHVybiBmYWxzZTsgfQogICAgIHN0YXRpYyBib29sIG1haW5Xb3JsZFdyYXBwZXJJc1N0b3JlZElu T2JqZWN0KFNjcmlwdFdyYXBwYWJsZSopIHsgcmV0dXJuIHRydWU7IH0KIAotICAgIHN0YXRpYyBi b29sIGlzTWFpbldvcmxkT2JqZWN0KHZvaWQqKSB7IHJldHVybiBmYWxzZTsgfQotICAgIHN0YXRp YyBib29sIGlzTWFpbldvcmxkT2JqZWN0KE5vZGUqKSB7IHJldHVybiB0cnVlOyB9CisgICAgc3Rh dGljIGJvb2wgY2FuT25seUV4aXN0SW5NYWluVGhyZWFkKHZvaWQqKSB7IHJldHVybiBmYWxzZTsg fQorICAgIHN0YXRpYyBib29sIGNhbk9ubHlFeGlzdEluTWFpblRocmVhZChOb2RlKikgeyByZXR1 cm4gdHJ1ZTsgfQogCiAgICAgdGVtcGxhdGU8dHlwZW5hbWUgSG9sZGVyQ29udGFpbmVyPgogICAg IHN0YXRpYyBib29sIGhvbGRlckNvbnRhaW5zV3JhcHBlcihjb25zdCBIb2xkZXJDb250YWluZXIm LCB2b2lkKikK 194073 2013-03-20 09:12:47 -0700 2013-03-20 09:58:08 -0700 Patch bug-112817-20130320170836.patch text/plain 3783 marja U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ2MzUwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDgzMzJhMGQ1MDlkNjI3 OWZlZjA4NDZlZGU2ODEyM2RmMTJhZGQxNy4uZjUxOTJlZTc4MGJkOGFkYjc3ODA1OTY4ODU2Nzgz YjNlYzU5ZmEzYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEzLTAzLTIwICBNYXJq YSBIw7ZsdHTDpCAgPG1hcmphQGNocm9taXVtLm9yZz4KKworICAgICAgICBbVjhdIFJlbmFtZSBE T01EYXRhU3RvcmU6OmlzTWFpbldvcmxkT2JqZWN0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTI4MTcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMgKG5vIGNoYW5nZXMgaW4gZnVuY3Rp b25hbGl0eSkuCisKKyAgICAgICAgKiBiaW5kaW5ncy92OC9ET01EYXRhU3RvcmUuaDoKKyAgICAg ICAgKFdlYkNvcmU6OkRPTURhdGFTdG9yZTo6Z2V0V3JhcHBlckZhc3QpOgorICAgICAgICAoV2Vi Q29yZTo6RE9NRGF0YVN0b3JlOjpnZXRXcmFwcGVyKToKKyAgICAgICAgKFdlYkNvcmU6OkRPTURh dGFTdG9yZTo6Z2V0V3JhcHBlckZvck1haW5Xb3JsZCk6CisgICAgICAgIChXZWJDb3JlOjpET01E YXRhU3RvcmU6OnNldFdyYXBwZXIpOgorICAgICAgICAoV2ViQ29yZTo6RE9NRGF0YVN0b3JlOjpj YW5FeGlzdEluV29ya2VyKToKKwogMjAxMy0wMy0yMCAgTWlrZSBXZXN0ICA8bWt3c3RAY2hyb21p dW0ub3JnPgogCiAgICAgICAgIERyb3AgZnVsbCBVUkxzIGZyb20gY3Jvc3MtZG9tYWluIGFjY2Vz cyBlcnJvcnMgY2F1c2VkIGJ5ICdkb2N1bWVudC5kb21haW4nIG1pc21hdGNoZXMuCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9ET01EYXRhU3RvcmUuaCBiL1NvdXJjZS9X ZWJDb3JlL2JpbmRpbmdzL3Y4L0RPTURhdGFTdG9yZS5oCmluZGV4IDQ0MTVkODUzNTUzYzZjYTIy OGVhM2NhYTIyMjA3ZTAyMmM2YWUzM2EuLjRmZGI1NmUzOTQ3ZjRjZGM5MDMwZmU4YmIyZmRhZWE1 M2Y5NGVlODUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L0RPTURhdGFT dG9yZS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L0RPTURhdGFTdG9yZS5oCkBA IC02NSw3ICs2NSw3IEBAIHB1YmxpYzoKICAgICAgICAgLy8gaXMgYW4gb2JqZWN0IHRoYXQgY2Fu IGV4aXN0IGluIHRoZSBtYWluIHdvcmxkLiBUaGUgc2Vjb25kIGZhc3Rlc3QKICAgICAgICAgLy8g d2F5IGlzIHRvIGNoZWNrIHdoZXRoZXIgdGhlIHdyYXBwYWJsZSdzIHdyYXBwZXIgaXMgdGhlIHNh bWUgYXMKICAgICAgICAgLy8gdGhlIGhvbGRlci4KLSAgICAgICAgaWYgKCghRE9NV3JhcHBlcldv cmxkOjppc29sYXRlZFdvcmxkc0V4aXN0KCkgJiYgaXNNYWluV29ybGRPYmplY3Qob2JqZWN0KSkg fHwgaG9sZGVyQ29udGFpbnNXcmFwcGVyKGNvbnRhaW5lciwgaG9sZGVyKSkgeworICAgICAgICBp ZiAoKCFET01XcmFwcGVyV29ybGQ6Omlzb2xhdGVkV29ybGRzRXhpc3QoKSAmJiAhY2FuRXhpc3RJ bldvcmtlcihvYmplY3QpKSB8fCBob2xkZXJDb250YWluc1dyYXBwZXIoY29udGFpbmVyLCBob2xk ZXIpKSB7CiAgICAgICAgICAgICBpZiAobWFpbldvcmxkV3JhcHBlcklzU3RvcmVkSW5PYmplY3Qo b2JqZWN0KSkKICAgICAgICAgICAgICAgICByZXR1cm4gZ2V0V3JhcHBlckZyb21PYmplY3Qob2Jq ZWN0KTsKICAgICAgICAgICAgIHJldHVybiBtYWluV29ybGRTdG9yZSgpLT5tX3dyYXBwZXJNYXAu Z2V0KG9iamVjdCk7CkBAIC03Niw3ICs3Niw3IEBAIHB1YmxpYzoKICAgICB0ZW1wbGF0ZTx0eXBl bmFtZSBUPgogICAgIHN0YXRpYyB2ODo6SGFuZGxlPHY4OjpPYmplY3Q+IGdldFdyYXBwZXIoVCog b2JqZWN0LCB2ODo6SXNvbGF0ZSogaXNvbGF0ZSkKICAgICB7Ci0gICAgICAgIGlmIChtYWluV29y bGRXcmFwcGVySXNTdG9yZWRJbk9iamVjdChvYmplY3QpICYmIGlzTWFpbldvcmxkT2JqZWN0KG9i amVjdCkpIHsKKyAgICAgICAgaWYgKG1haW5Xb3JsZFdyYXBwZXJJc1N0b3JlZEluT2JqZWN0KG9i amVjdCkgJiYgIWNhbkV4aXN0SW5Xb3JrZXIob2JqZWN0KSkgewogICAgICAgICAgICAgaWYgKExJ S0VMWSghRE9NV3JhcHBlcldvcmxkOjppc29sYXRlZFdvcmxkc0V4aXN0KCkpKQogICAgICAgICAg ICAgICAgIHJldHVybiBnZXRXcmFwcGVyRnJvbU9iamVjdChvYmplY3QpOwogICAgICAgICB9CkBA IC04Niw3ICs4Niw3IEBAIHB1YmxpYzoKICAgICB0ZW1wbGF0ZTx0eXBlbmFtZSBUPgogICAgIHN0 YXRpYyB2ODo6SGFuZGxlPHY4OjpPYmplY3Q+IGdldFdyYXBwZXJGb3JNYWluV29ybGQoVCogb2Jq ZWN0KQogICAgIHsKLSAgICAgICAgaWYgKG1haW5Xb3JsZFdyYXBwZXJJc1N0b3JlZEluT2JqZWN0 KG9iamVjdCkgJiYgaXNNYWluV29ybGRPYmplY3Qob2JqZWN0KSkKKyAgICAgICAgaWYgKG1haW5X b3JsZFdyYXBwZXJJc1N0b3JlZEluT2JqZWN0KG9iamVjdCkpCiAgICAgICAgICAgICByZXR1cm4g Z2V0V3JhcHBlckZyb21PYmplY3Qob2JqZWN0KTsKICAgICAgICAgcmV0dXJuIG1haW5Xb3JsZFN0 b3JlKCktPmdldChvYmplY3QpOwogICAgIH0KQEAgLTk0LDcgKzk0LDcgQEAgcHVibGljOgogICAg IHRlbXBsYXRlPHR5cGVuYW1lIFQ+CiAgICAgc3RhdGljIHZvaWQgc2V0V3JhcHBlcihUKiBvYmpl Y3QsIHY4OjpIYW5kbGU8djg6Ok9iamVjdD4gd3JhcHBlciwgdjg6Oklzb2xhdGUqIGlzb2xhdGUs IGNvbnN0IFdyYXBwZXJDb25maWd1cmF0aW9uJiBjb25maWd1cmF0aW9uKQogICAgIHsKLSAgICAg ICAgaWYgKG1haW5Xb3JsZFdyYXBwZXJJc1N0b3JlZEluT2JqZWN0KG9iamVjdCkgJiYgaXNNYWlu V29ybGRPYmplY3Qob2JqZWN0KSkgeworICAgICAgICBpZiAobWFpbldvcmxkV3JhcHBlcklzU3Rv cmVkSW5PYmplY3Qob2JqZWN0KSAmJiAhY2FuRXhpc3RJbldvcmtlcihvYmplY3QpKSB7CiAgICAg ICAgICAgICBpZiAoTElLRUxZKCFET01XcmFwcGVyV29ybGQ6Omlzb2xhdGVkV29ybGRzRXhpc3Qo KSkpIHsKICAgICAgICAgICAgICAgICBzZXRXcmFwcGVySW5PYmplY3Qob2JqZWN0LCB3cmFwcGVy LCBpc29sYXRlLCBjb25maWd1cmF0aW9uKTsKICAgICAgICAgICAgICAgICByZXR1cm47CkBAIC0x MzEsOCArMTMxLDggQEAgcHJpdmF0ZToKICAgICBzdGF0aWMgYm9vbCBtYWluV29ybGRXcmFwcGVy SXNTdG9yZWRJbk9iamVjdCh2b2lkKikgeyByZXR1cm4gZmFsc2U7IH0KICAgICBzdGF0aWMgYm9v bCBtYWluV29ybGRXcmFwcGVySXNTdG9yZWRJbk9iamVjdChTY3JpcHRXcmFwcGFibGUqKSB7IHJl dHVybiB0cnVlOyB9CiAKLSAgICBzdGF0aWMgYm9vbCBpc01haW5Xb3JsZE9iamVjdCh2b2lkKikg eyByZXR1cm4gZmFsc2U7IH0KLSAgICBzdGF0aWMgYm9vbCBpc01haW5Xb3JsZE9iamVjdChOb2Rl KikgeyByZXR1cm4gdHJ1ZTsgfQorICAgIHN0YXRpYyBib29sIGNhbkV4aXN0SW5Xb3JrZXIodm9p ZCopIHsgcmV0dXJuIHRydWU7IH0KKyAgICBzdGF0aWMgYm9vbCBjYW5FeGlzdEluV29ya2VyKE5v ZGUqKSB7IHJldHVybiBmYWxzZTsgfQogCiAgICAgdGVtcGxhdGU8dHlwZW5hbWUgSG9sZGVyQ29u dGFpbmVyPgogICAgIHN0YXRpYyBib29sIGhvbGRlckNvbnRhaW5zV3JhcHBlcihjb25zdCBIb2xk ZXJDb250YWluZXImLCB2b2lkKikK