112810 2013-03-20 07:28:42 -0700 [Qt][WK2] Use C API to enable Navigator Qt Object. 2013-04-09 04:47:35 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 michael.bruning michael.bruning abecsi cmarcelo menard webkit.review.bot oldest_to_newest 859378 0 michael.bruning 2013-03-20 07:28:42 -0700 [Qt][WK2] Use C API to enable Navigator Qt Object. 859399 1 194053 michael.bruning 2013-03-20 07:46:21 -0700 Created attachment 194053 Patch 859400 2 194053 kenneth 2013-03-20 07:48:12 -0700 Comment on attachment 194053 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=194053&action=review > Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:845 > + static WKStringRef messageName = WKStringCreateWithUTF8CString("SetNavigatorQtObjectEnabled"); > + WKRetainPtr<WKBooleanRef> enabledRef = adoptWK(WKBooleanCreate(enabled)); > + WKPagePostMessageToInjectedBundle(webPage.get(), messageName, enabledRef.get()); Why is this static? why not use WKRetainPtr = adoptWK...? 859405 3 michael.bruning 2013-03-20 07:51:13 -0700 (In reply to comment #2) > (From update of attachment 194053 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=194053&action=review > > > Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:845 > > + static WKStringRef messageName = WKStringCreateWithUTF8CString("SetNavigatorQtObjectEnabled"); > > + WKRetainPtr<WKBooleanRef> enabledRef = adoptWK(WKBooleanCreate(enabled)); > > + WKPagePostMessageToInjectedBundle(webPage.get(), messageName, enabledRef.get()); > > Why is this static? why not use WKRetainPtr = adoptWK...? To prevent reinitialization and to follow the same pattern used in https://bugs.webkit.org/show_bug.cgi?id=108826 . 860314 4 194053 jturcotte 2013-03-21 07:23:59 -0700 Comment on attachment 194053 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=194053&action=review > Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:844 > + WKRetainPtr<WKBooleanRef> enabledRef = adoptWK(WKBooleanCreate(enabled)); Nit: Maybe call it wkEnabled (since it's actually a WKRetainPtr). Otherwise LGTM 860318 5 194258 michael.bruning 2013-03-21 07:30:05 -0700 Created attachment 194258 Patch 871617 6 michael.bruning 2013-04-09 04:47:35 -0700 Committed r148008: <http://trac.webkit.org/changeset/148008> 194053 2013-03-20 07:46:21 -0700 2013-03-21 07:30:02 -0700 Patch bug-112810-20130320154209.patch text/plain 2189 michael.bruning U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ2MzM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZGNjYmJjYmMxYmIyMTQ1 ODIwNzJjODhkZGQ0NGRjNTAwNTU0ZGY0OS4uOGI1Y2JiM2IwMGFmMWU5ZjM1OTI3N2M3NTY5ODMw MWY1NzI1YTJmYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEzLTAzLTIwICBNaWNo YWVsIEJyw7xuaW5nICA8bWljaGFlbC5icnVuaW5nQGRpZ2lhLmNvbT4KKworICAgICAgICBbUXRd W1dLMl0gVXNlIEMgQVBJIHRvIGVuYWJsZSBOYXZpZ2F0b3IgUXQgT2JqZWN0LgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEyODEwCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVwbGFjZSB0aGUgZGlyZWN0 IHJlZmVyZW5jZSB0byB0aGUgV2ViUGFnZVByb3h5IHdpdGggdXNlIG9mCisgICAgICAgIEMgQVBJ LgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9xdC9xcXVpY2t3ZWJ2aWV3LmNwcDoKKyAgICAg ICAgKFFRdWlja1dlYlZpZXdQcml2YXRlOjpzZXROYXZpZ2F0b3JRdE9iamVjdEVuYWJsZWQpOgor CiAyMDEzLTAzLTE5ICBLZW5uZXRoIFJvaGRlIENocmlzdGlhbnNlbiAgPGtlbm5ldGhAd2Via2l0 Lm9yZz4gYW5kIE1pa2hhaWwgUG96ZG55YWtvdiAgPG1pa2hhaWwucG96ZG55YWtvdkBpbnRlbC5j b20+CiAKICAgICAgICAgW0VGTF1bV0syXSBTZXBhcmF0ZSBXZWJWaWV3IGZ1cnRoZXIgZnJvbSBF d2tWaWV3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3FxdWlj a3dlYnZpZXcuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xcXVpY2t3ZWJ2 aWV3LmNwcAppbmRleCA3Mzc1ZDU0MTI4OWVjM2RiNDQ5YjkyNDY2M2VkYzU2ZjMwOWRkZmQ5Li5k YjJhNjY0OWRhZGMzMjdlZTkzNTdmNGIzY2Q1NTY1NDJlMTQ1NGNmIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3FxdWlja3dlYnZpZXcuY3BwCisrKyBiL1NvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcXF1aWNrd2Vidmlldy5jcHAKQEAgLTY2LDYgKzY2 LDcgQEAKICNpbmNsdWRlIDxRdENvcmUvUUZpbGU+CiAjaW5jbHVkZSA8UXRRbWwvUUpTVmFsdWU+ CiAjaW5jbHVkZSA8UXRRdWljay9RUXVpY2tWaWV3PgorI2luY2x1ZGUgPFdLTnVtYmVyLmg+CiAj aW5jbHVkZSA8V0tPcGVuUGFuZWxSZXN1bHRMaXN0ZW5lci5oPgogI2luY2x1ZGUgPFdLUGFnZUdy b3VwLmg+CiAjaW5jbHVkZSA8V0tQcmVmZXJlbmNlcy5oPgpAQCAtODM5LDkgKzg0MCw5IEBAIHZv aWQgUVF1aWNrV2ViVmlld1ByaXZhdGU6OnNldE5hdmlnYXRvclF0T2JqZWN0RW5hYmxlZChib29s IGVuYWJsZWQpCiAgICAgLy8gRklYTUU6IEN1cnJlbnRseSB3ZSBoYXZlIHRvIGtlZXAgdGhpcyBp bmZvcm1hdGlvbiBpbiBib3RoIHByb2Nlc3NlcyBhbmQgdGhlIHNldHRpbmcgaXMgYXN5bmNocm9u b3VzLgogICAgIG1fbmF2aWdhdG9yUXRPYmplY3RFbmFibGVkID0gZW5hYmxlZDsKIAotICAgIHN0 YXRpYyBTdHJpbmcgbWVzc2FnZU5hbWUoIlNldE5hdmlnYXRvclF0T2JqZWN0RW5hYmxlZCIpOwot ICAgIFJlZlB0cjxXZWJCb29sZWFuPiB3ZWJFbmFibGVkID0gV2ViQm9vbGVhbjo6Y3JlYXRlKGVu YWJsZWQpOwotICAgIHdlYlBhZ2VQcm94eS0+cG9zdE1lc3NhZ2VUb0luamVjdGVkQnVuZGxlKG1l c3NhZ2VOYW1lLCB3ZWJFbmFibGVkLmdldCgpKTsKKyAgICBzdGF0aWMgV0tTdHJpbmdSZWYgbWVz c2FnZU5hbWUgPSBXS1N0cmluZ0NyZWF0ZVdpdGhVVEY4Q1N0cmluZygiU2V0TmF2aWdhdG9yUXRP YmplY3RFbmFibGVkIik7CisgICAgV0tSZXRhaW5QdHI8V0tCb29sZWFuUmVmPiBlbmFibGVkUmVm ID0gYWRvcHRXSyhXS0Jvb2xlYW5DcmVhdGUoZW5hYmxlZCkpOworICAgIFdLUGFnZVBvc3RNZXNz YWdlVG9JbmplY3RlZEJ1bmRsZSh3ZWJQYWdlLmdldCgpLCBtZXNzYWdlTmFtZSwgZW5hYmxlZFJl Zi5nZXQoKSk7CiB9CiAKIHN0YXRpYyBXS1JldGFpblB0cjxXS1N0cmluZ1JlZj4gcmVhZFVzZXJT Y3JpcHQoY29uc3QgUVVybCYgdXJsKQo= 194258 2013-03-21 07:30:05 -0700 2013-04-09 03:59:43 -0700 Patch bug-112810-20130321152553.patch text/plain 2173 michael.bruning U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ2NDYzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZGVjZTNhZjI1ZTVlNDc3 ZDk5MWRlYThiNjMyNTg3ZjUyZGJiNTA5Ni4uMThhZjlmNzQzNTIyYjNmYmNhMDNlOGVmYWRiNjAw NzcyOWU5NWI0MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEzLTAzLTIxICBNaWNo YWVsIEJyw7xuaW5nICA8bWljaGFlbC5icnVuaW5nQGRpZ2lhLmNvbT4KKworICAgICAgICBbUXRd W1dLMl0gVXNlIEMgQVBJIHRvIGVuYWJsZSBOYXZpZ2F0b3IgUXQgT2JqZWN0LgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEyODEwCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVwbGFjZSB0aGUgZGlyZWN0 IHJlZmVyZW5jZSB0byB0aGUgV2ViUGFnZVByb3h5IHdpdGggdXNlIG9mCisgICAgICAgIEMgQVBJ LgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9xdC9xcXVpY2t3ZWJ2aWV3LmNwcDoKKyAgICAg ICAgKFFRdWlja1dlYlZpZXdQcml2YXRlOjpzZXROYXZpZ2F0b3JRdE9iamVjdEVuYWJsZWQpOgor CiAyMDEzLTAzLTIxICBUaW0gSG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgogCiAg ICAgICAgIFRpbGVkIHBhZ2Ugb3ZlcmxheSBsYXllcnMgZG9uJ3QgY3JlYXRlIHRpbGVzIHVudGls IHRoZSBmaXJzdCBmbHVzaCBhZnRlciB0aGV5IHN3aXRjaCB0byBiZWluZyB0aWxlZApkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xcXVpY2t3ZWJ2aWV3LmNwcCBi L1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcXF1aWNrd2Vidmlldy5jcHAKaW5kZXgg NzM3NWQ1NDEyODllYzNkYjQ0OWI5MjQ2NjNlZGM1NmYzMDlkZGZkOS4uYjQ5ODA3NGVjNDg1ZTkw M2JmZjMzM2RiMDBmZTkxNTY1ZTE5ZmEyNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL0FQSS9xdC9xcXVpY2t3ZWJ2aWV3LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvQVBJL3F0L3FxdWlja3dlYnZpZXcuY3BwCkBAIC02Niw2ICs2Niw3IEBACiAjaW5jbHVk ZSA8UXRDb3JlL1FGaWxlPgogI2luY2x1ZGUgPFF0UW1sL1FKU1ZhbHVlPgogI2luY2x1ZGUgPFF0 UXVpY2svUVF1aWNrVmlldz4KKyNpbmNsdWRlIDxXS051bWJlci5oPgogI2luY2x1ZGUgPFdLT3Bl blBhbmVsUmVzdWx0TGlzdGVuZXIuaD4KICNpbmNsdWRlIDxXS1BhZ2VHcm91cC5oPgogI2luY2x1 ZGUgPFdLUHJlZmVyZW5jZXMuaD4KQEAgLTgzOSw5ICs4NDAsOSBAQCB2b2lkIFFRdWlja1dlYlZp ZXdQcml2YXRlOjpzZXROYXZpZ2F0b3JRdE9iamVjdEVuYWJsZWQoYm9vbCBlbmFibGVkKQogICAg IC8vIEZJWE1FOiBDdXJyZW50bHkgd2UgaGF2ZSB0byBrZWVwIHRoaXMgaW5mb3JtYXRpb24gaW4g Ym90aCBwcm9jZXNzZXMgYW5kIHRoZSBzZXR0aW5nIGlzIGFzeW5jaHJvbm91cy4KICAgICBtX25h dmlnYXRvclF0T2JqZWN0RW5hYmxlZCA9IGVuYWJsZWQ7CiAKLSAgICBzdGF0aWMgU3RyaW5nIG1l c3NhZ2VOYW1lKCJTZXROYXZpZ2F0b3JRdE9iamVjdEVuYWJsZWQiKTsKLSAgICBSZWZQdHI8V2Vi Qm9vbGVhbj4gd2ViRW5hYmxlZCA9IFdlYkJvb2xlYW46OmNyZWF0ZShlbmFibGVkKTsKLSAgICB3 ZWJQYWdlUHJveHktPnBvc3RNZXNzYWdlVG9JbmplY3RlZEJ1bmRsZShtZXNzYWdlTmFtZSwgd2Vi RW5hYmxlZC5nZXQoKSk7CisgICAgc3RhdGljIFdLU3RyaW5nUmVmIG1lc3NhZ2VOYW1lID0gV0tT dHJpbmdDcmVhdGVXaXRoVVRGOENTdHJpbmcoIlNldE5hdmlnYXRvclF0T2JqZWN0RW5hYmxlZCIp OworICAgIFdLUmV0YWluUHRyPFdLQm9vbGVhblJlZj4gd2tFbmFibGVkID0gYWRvcHRXSyhXS0Jv b2xlYW5DcmVhdGUoZW5hYmxlZCkpOworICAgIFdLUGFnZVBvc3RNZXNzYWdlVG9JbmplY3RlZEJ1 bmRsZSh3ZWJQYWdlLmdldCgpLCBtZXNzYWdlTmFtZSwgd2tFbmFibGVkLmdldCgpKTsKIH0KIAog c3RhdGljIFdLUmV0YWluUHRyPFdLU3RyaW5nUmVmPiByZWFkVXNlclNjcmlwdChjb25zdCBRVXJs JiB1cmwpCg==