112808 2013-03-20 07:00:00 -0700 [Qt] Define MODULE_VERSION 2013-03-20 10:58:37 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jturcotte jturcotte allan.jensen hausmann jturcotte vestbo webkit.review.bot oldest_to_newest 859363 0 jturcotte 2013-03-20 07:00:00 -0700 [Qt] Define MODULE_VERSION 859366 1 194047 jturcotte 2013-03-20 07:02:35 -0700 Created attachment 194047 Patch 859413 2 jturcotte 2013-03-20 08:01:47 -0700 Humm I can't push that yet, the headers are sometimes using the qtbase module version for private headers and sometimes the qtwebkit one. So we need to MODULE_VERSION to be defined the same as qtbase until this is fixed. 859547 3 194047 jturcotte 2013-03-20 10:50:12 -0700 Comment on attachment 194047 Patch This depends on https://codereview.qt-project.org/51591 but I'll commit it now since it won't break anything more than it is now. 859552 4 194047 webkit.review.bot 2013-03-20 10:58:34 -0700 Comment on attachment 194047 Patch Clearing flags on attachment: 194047 Committed r146363: <http://trac.webkit.org/changeset/146363> 859553 5 webkit.review.bot 2013-03-20 10:58:37 -0700 All reviewed patches have been landed. Closing bug. 194047 2013-03-20 07:02:35 -0700 2013-03-20 10:58:34 -0700 Patch bug-112808-20130320145823.patch text/plain 1052 jturcotte U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ2MzIxCmRpZmYgLS1naXQgYS8ucW1ha2UuY29uZiBiLy5x bWFrZS5jb25mCmluZGV4IDY0NmRjMGNlMGJiNjYxZTYwMzQ0OThmYjI2NDdiNTM5MzA2NzJhODMu LjI3NjNjYmI1OGQ2YzYwOTIzODRjOWFlYzVhOTNlODgyMDE0ZmIwZDYgMTAwNjQ0Ci0tLSBhLy5x bWFrZS5jb25mCisrKyBiLy5xbWFrZS5jb25mCkBAIC0yLDMgKzIsNSBAQAogTU9EVUxFX1FNQUtF X09VVERJUiA9ICQkc2hhZG93ZWQoJCRQV0QvVG9vbHMvcW1ha2UpCiBRTUFLRVBBVEggKz0gJCRQ V0QvVG9vbHMvcW1ha2UgJCRNT0RVTEVfUU1BS0VfT1VURElSCiBsb2FkKHF0X2J1aWxkX2NvbmZp ZykKKworTU9EVUxFX1ZFUlNJT04gPSA1LjIuMApkaWZmIC0tZ2l0IGEvQ2hhbmdlTG9nIGIvQ2hh bmdlTG9nCmluZGV4IDllZDVjYjhmMDNkNGVlMmNmMDU2MjhlMzhkNjNiM2QyYTE0NzQ1NzEuLmVj Y2U1OWM1NjYzMTJhYjljNjgyN2FmYjA5NWE4ZGRhNmYxMGE0MmQgMTAwNjQ0Ci0tLSBhL0NoYW5n ZUxvZworKysgYi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMy0wMy0yMCAgSm9jZWx5 biBUdXJjb3R0ZSAgPGpvY2VseW4udHVyY290dGVAZGlnaWEuY29tPgorCisgICAgICAgIFtRdF0g RGVmaW5lIE1PRFVMRV9WRVJTSU9OCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xMTI4MDgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBVcHN0cmVhbSBodHRwOi8vY29kZXJldmlldy5xdC1wcm9qZWN0Lm9yZy80 OTA1MgorICAgICAgICBVc2UgNS4yLjAgYXMgdGhpcyBpcyB0aGUgbmV4dCByZWxlYXNlIHRoYXQg d2lsbCBiZSBicmFuY2hlZCBmcm9tIHRydW5rLgorCisgICAgICAgICogLnFtYWtlLmNvbmY6CisK IDIwMTMtMDMtMjAgIEp1bmdKaWsgTGVlICA8anVuZ2ppay5sZWVAc2Ftc3VuZy5jb20+CiAKICAg ICAgICAgW0VGTF0gRGlzYWJsZSBSRVFVRVNUX0FOSU1BVElPTl9GUkFNRV9USU1FUiB0byByZW5k ZXIgYSBuZXcgYW5pbWF0aW9uIGZyYW1lLgo=