112806 2013-03-20 06:42:03 -0700 [BlackBerry] compositing/iframes/scroll-fixed-transformed-element.html fails in manual testing 2013-03-21 02:14:55 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED http://jquerymobile.com P2 Normal --- 1 anilsson anilsson anilsson efidler jpetsovits mifenton rwlbuis tonikitoo webkit.review.bot oldest_to_newest 859350 0 anilsson 2013-03-20 06:42:03 -0700 PR 283363 When visiting jquerymobile.com, or manually scrolling around LayoutTests/compositing/iframes/scroll-fixed-transformed-element.html, you can see that in the BlackBerry port, fixed positioned elements inside an iframe are positioned correctly only when you scroll that iframe, not when you scroll the main frame. When scrolling the iframe, the fixed pos element is positioned as if it was fixed with respect to the iframe's viewport. When scrolling the main frame, the fixed pos element is positioned as if it was fixed with respect to the main frame's viewport. The effects of the bug are only visual, i.e. not detectable by DRT. 859353 1 anilsson 2013-03-20 06:46:13 -0700 "LayoutTests/" superfluous 859357 2 194043 anilsson 2013-03-20 06:53:27 -0700 Created attachment 194043 Patch 859541 3 194043 tonikitoo 2013-03-20 10:43:34 -0700 Comment on attachment 194043 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=194043&action=review > Source/WebCore/ChangeLog:14 > + When scrolling the iframe, the position: fixed element is correctly > + positioned, that is, as if it was fixed with respect to the iframe's > + viewport. When scrolling the main frame however, the fixed pos element > + was positioned as if it was fixed with respect to the main frame's > + viewport. That was left over in my TODO list :) 859559 4 194043 anilsson 2013-03-20 11:07:26 -0700 Comment on attachment 194043 Patch Thanks Antonio, I hoped you would remember this code :) 859576 5 194043 webkit.review.bot 2013-03-20 11:23:21 -0700 Comment on attachment 194043 Patch Clearing flags on attachment: 194043 Committed r146366: <http://trac.webkit.org/changeset/146366> 859577 6 webkit.review.bot 2013-03-20 11:23:24 -0700 All reviewed patches have been landed. Closing bug. 860152 7 anilsson 2013-03-21 02:14:55 -0700 Hmm, it wasn't quite this simple - it's now picking up the iframe code path for mainframe position: fixed divs =D 194043 2013-03-20 06:53:27 -0700 2013-03-20 11:23:21 -0700 Patch bug-112806-20130320144916.patch text/plain 4293 anilsson U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ2MzIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWI5YzVmY2Q3Nzg3NWIz NzM1NWJjNTM5OTU3ZDA5ZDZlODBjOGZjZi4uZmFkYTI0NjI2ZjZjOWIyN2Q1MGFlOWYzYjM2ZDEx ZWI5OTI1ZTAzNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDMyIEBACiAyMDEzLTAzLTIwICBBcnZp ZCBOaWxzc29uICA8YW5pbHNzb25AcmltLmNvbT4KIAorICAgICAgICBbQmxhY2tCZXJyeV0gY29t cG9zaXRpbmcvaWZyYW1lcy9zY3JvbGwtZml4ZWQtdHJhbnNmb3JtZWQtZWxlbWVudC5odG1sIGZh aWxzIGluIG1hbnVhbCB0ZXN0aW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xMTI4MDYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBQUiAyODMzNjMKKworICAgICAgICBXaGVuIHNjcm9sbGluZyB0aGUgaWZy YW1lLCB0aGUgcG9zaXRpb246IGZpeGVkIGVsZW1lbnQgaXMgY29ycmVjdGx5CisgICAgICAgIHBv c2l0aW9uZWQsIHRoYXQgaXMsIGFzIGlmIGl0IHdhcyBmaXhlZCB3aXRoIHJlc3BlY3QgdG8gdGhl IGlmcmFtZSdzCisgICAgICAgIHZpZXdwb3J0LiBXaGVuIHNjcm9sbGluZyB0aGUgbWFpbiBmcmFt ZSBob3dldmVyLCB0aGUgZml4ZWQgcG9zIGVsZW1lbnQKKyAgICAgICAgd2FzIHBvc2l0aW9uZWQg YXMgaWYgaXQgd2FzIGZpeGVkIHdpdGggcmVzcGVjdCB0byB0aGUgbWFpbiBmcmFtZSdzCisgICAg ICAgIHZpZXdwb3J0LgorCisgICAgICAgIEZpeGVkIGJ5IGZhbGxpbmcgYmFjayB0byB1c2luZyB0 aGUgV2ViS2l0LXRocmVhZCBzY3JvbGwgcG9zaXRpb24gZm9yCisgICAgICAgIGZpeGVkIHBvc2l0 aW9uaW5nIGluIExheWVyUmVuZGVyZXIsIGlmIHRoZSBvdmVycmlkZSBkb2Vzbid0IGhhdmUgYQor ICAgICAgICBwb3NpdGlvbiBjdXJyZW50bHkgc2V0LCBpLmUuIGlmIHdlIGFyZSBub3QgY3VycmVu dGx5IHNjcm9sbGluZyB0aGUKKyAgICAgICAgaWZyYW1lLgorCisgICAgICAgIFRoZSBlZmZlY3Rz IG9mIHRoZSBidWcgYXJlIG9ubHkgdmlzdWFsLCBpLmUuIG5vdCBkZXRlY3RhYmxlIGJ5IERSVC4K KworICAgICAgICBNYW51YWxseSB0ZXN0YWJsZSB1c2luZyBjb21wb3NpdGluZy9pZnJhbWVzL3Nj cm9sbC1maXhlZC10cmFuc2Zvcm1lZC1lbGVtZW50Lmh0bWwKKworICAgICAgICAqIHBsYXRmb3Jt L2dyYXBoaWNzL2JsYWNrYmVycnkvTGF5ZXJSZW5kZXJlci5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpMYXllclJlbmRlcmVyOjp1cGRhdGVMYXllcnNSZWN1cnNpdmUpOgorCisyMDEzLTAzLTIwICBB cnZpZCBOaWxzc29uICA8YW5pbHNzb25AcmltLmNvbT4KKwogICAgICAgICBbQmxhY2tCZXJyeV0g RW5hYmxlIGFwcHJvcHJpYXRlIHZlcnRleCBhdHRyaWJ1dGUgYXJyYXlzIGluIExheWVyUmVuZGVy ZXI6OnVzZVByb2dyYW0oKQogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTEyNzU3CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL2JsYWNrYmVycnkvTGF5ZXJSZW5kZXJlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9ibGFja2JlcnJ5L0xheWVyUmVuZGVyZXIuY3BwCmluZGV4IDMzNTVlZDAz MzFhZGI1ZTQ3MzgwNjAxZmYyYzI0YmMzMTY2ZTcyNTMuLjdlYzMyYzk5MWYzNDk5YjM2YjkxM2I2 ZDc0OTYyYjg2OGI5MWJlMGYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL2JsYWNrYmVycnkvTGF5ZXJSZW5kZXJlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvYmxhY2tiZXJyeS9MYXllclJlbmRlcmVyLmNwcApAQCAtNjg1LDE4 ICs2ODUsMjMgQEAgdm9pZCBMYXllclJlbmRlcmVyOjp1cGRhdGVMYXllcnNSZWN1cnNpdmUoTGF5 ZXJDb21wb3NpdGluZ1RocmVhZCogbGF5ZXIsIGNvbnN0IFQKICAgICAgICAgRmxvYXRSZWN0IHZp c2libGVSZWN0ID0gbV92aXNpYmxlUmVjdDsKICAgICAgICAgZm9yIChMYXllckNvbXBvc2l0aW5n VGhyZWFkKiBjdXJyID0gbGF5ZXItPnN1cGVybGF5ZXIoKTsgY3VycjsgY3VyciA9IGN1cnItPnN1 cGVybGF5ZXIoKSkgewogCi0gICAgICAgICAgICAvLyBJZiB3ZSByZWFjaCBhIGNvbnRhaW5lciBm b3IgZml4ZWQgcG9zaXRpb24gbGF5ZXJzLCBhbmQgaXQgaGFzIGl0cyBvdmVycmlkZSdzIHBvc2l0 aW9uIHNldCwgaXQgbWVhbnMgaXQgaXMgYSBzY3JvbGxhYmxlIGlmcmFtZQotICAgICAgICAgICAg aWYgKGN1cnItPmlzQ29udGFpbmVyRm9yRml4ZWRQb3NpdGlvbkxheWVycygpICYmIGN1cnItPm92 ZXJyaWRlKCktPmlzUG9zaXRpb25TZXQoKSkgeworICAgICAgICAgICAgaWYgKGN1cnItPmlzQ29u dGFpbmVyRm9yRml4ZWRQb3NpdGlvbkxheWVycygpKSB7CiAgICAgICAgICAgICAgICAgbGF5b3V0 UmVjdCA9IGN1cnItPmZyYW1lVmlzaWJsZVJlY3QoKTsKICAgICAgICAgICAgICAgICBjb250ZW50 c1NpemUgPSBjdXJyLT5mcmFtZUNvbnRlbnRzU2l6ZSgpOwogCi0gICAgICAgICAgICAgICAgLy8g SW52ZXJ0ZWQgbG9naWMgb2YKLSAgICAgICAgICAgICAgICAvLyBGbG9hdFBvaW50IGxheWVyUG9z aXRpb24oLXNjcm9sbFBvc2l0aW9uLngoKSArIGFuY2hvci54KCkgKiBib3VuZHMud2lkdGgoKSwK LSAgICAgICAgICAgICAgICAvLyAgICAgICAgICAgICAgICAgICAgICAgICAgLXNjcm9sbFBvc2l0 aW9uLnkoKSArIGFuY2hvci55KCkgKiBib3VuZHMuaGVpZ2h0KCkpOwotICAgICAgICAgICAgICAg IEZsb2F0UG9pbnQgc2Nyb2xsUG9zaXRpb24oCi0gICAgICAgICAgICAgICAgICAgIC0oY3Vyci0+ b3ZlcnJpZGUoKS0+cG9zaXRpb24oKS54KCkgLSAoY3Vyci0+YW5jaG9yUG9pbnQoKS54KCkgKiBj dXJyLT5ib3VuZHMoKS53aWR0aCgpKSksCi0gICAgICAgICAgICAgICAgICAgIC0oY3Vyci0+b3Zl cnJpZGUoKS0+cG9zaXRpb24oKS55KCkgLSAoY3Vyci0+YW5jaG9yUG9pbnQoKS55KCkgKiBjdXJy LT5ib3VuZHMoKS5oZWlnaHQoKSkpKTsKLSAgICAgICAgICAgICAgICB2aXNpYmxlUmVjdCA9IEZs b2F0UmVjdChzY3JvbGxQb3NpdGlvbiwgbGF5b3V0UmVjdC5zaXplKCkpOworICAgICAgICAgICAg ICAgIC8vIElmIHdlIHJlYWNoIGEgY29udGFpbmVyIGZvciBmaXhlZCBwb3NpdGlvbiBsYXllcnMs IGFuZCBpdCBoYXMgaXRzIG92ZXJyaWRlJ3MgcG9zaXRpb24gc2V0LCBpdCBtZWFucyBpdCBpcyBh IHNjcm9sbGFibGUgaWZyYW1lCisgICAgICAgICAgICAgICAgLy8gY3VycmVudGx5IGJlaW5nIHNj cm9sbGVkLiBPdGhlcndpc2UsIHVzZSB0aGUgV2ViS2l0LXRocmVhZCBzY3JvbGwgcG9zaXRpb24g c3RvcmVkIGluIGZyYW1lVmlzaWJsZVJlY3QoKS4KKyAgICAgICAgICAgICAgICBpZiAoY3Vyci0+ b3ZlcnJpZGUoKS0+aXNQb3NpdGlvblNldCgpKSB7CisgICAgICAgICAgICAgICAgICAgIC8vIElu dmVydGVkIGxvZ2ljIG9mCisgICAgICAgICAgICAgICAgICAgIC8vIEZsb2F0UG9pbnQgbGF5ZXJQ b3NpdGlvbigtc2Nyb2xsUG9zaXRpb24ueCgpICsgYW5jaG9yLngoKSAqIGJvdW5kcy53aWR0aCgp LAorICAgICAgICAgICAgICAgICAgICAvLyAgICAgICAgICAgICAgICAgICAgICAgICAgLXNjcm9s bFBvc2l0aW9uLnkoKSArIGFuY2hvci55KCkgKiBib3VuZHMuaGVpZ2h0KCkpOworICAgICAgICAg ICAgICAgICAgICBGbG9hdFBvaW50IHNjcm9sbFBvc2l0aW9uKAorICAgICAgICAgICAgICAgICAg ICAgICAgLShjdXJyLT5vdmVycmlkZSgpLT5wb3NpdGlvbigpLngoKSAtIChjdXJyLT5hbmNob3JQ b2ludCgpLngoKSAqIGN1cnItPmJvdW5kcygpLndpZHRoKCkpKSwKKyAgICAgICAgICAgICAgICAg ICAgICAgIC0oY3Vyci0+b3ZlcnJpZGUoKS0+cG9zaXRpb24oKS55KCkgLSAoY3Vyci0+YW5jaG9y UG9pbnQoKS55KCkgKiBjdXJyLT5ib3VuZHMoKS5oZWlnaHQoKSkpKTsKKyAgICAgICAgICAgICAg ICAgICAgdmlzaWJsZVJlY3QgPSBGbG9hdFJlY3Qoc2Nyb2xsUG9zaXRpb24sIGxheW91dFJlY3Qu c2l6ZSgpKTsKKyAgICAgICAgICAgICAgICB9IGVsc2UKKyAgICAgICAgICAgICAgICAgICAgdmlz aWJsZVJlY3QgPSBsYXlvdXRSZWN0OworCiAgICAgICAgICAgICAgICAgYnJlYWs7CiAgICAgICAg ICAgICB9CiAgICAgICAgIH0K