112794 2013-03-20 05:58:55 -0700 [EFL][WK2] Do not allow passing null pointers for *Ref types 2017-03-11 10:37:12 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED WONTFIX P2 Normal --- 107820 1 kenneth kenneth ap benjamin cdumez gyuyoung.kim kling lucas.de.marchi mcatanzaro mikhail.pozdnyakov rakuco webkit.review.bot oldest_to_newest 859291 0 kenneth 2013-03-20 05:58:55 -0700 SSIA 859294 1 194028 kenneth 2013-03-20 06:00:33 -0700 Created attachment 194028 Patch 859301 2 kenneth 2013-03-20 06:06:30 -0700 *** Bug 109276 has been marked as a duplicate of this bug. *** 859303 3 194028 mikhail.pozdnyakov 2013-03-20 06:07:05 -0700 Comment on attachment 194028 Patch LGTM 859305 4 194028 mikhail.pozdnyakov 2013-03-20 06:07:42 -0700 Comment on attachment 194028 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=194028&action=review > Source/WebKit2/UIProcess/API/C/efl/WKView.h:53 > +WK_EXPORT WKViewRef WKViewCreateWithPageGroup(WKContextRef context, WKPageGroupRef pageGroup); nit: variable names can be omitted 859308 5 194028 cdumez 2013-03-20 06:09:07 -0700 Comment on attachment 194028 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=194028&action=review > Source/WebKit2/UIProcess/API/C/efl/WKView.cpp:41 > RefPtr<WebView> webView = WebView::create(toImpl(contextRef), toImpl(pageGroupRef)); How about null-check assertions for args? 859314 6 kenneth 2013-03-20 06:12:35 -0700 > How about null-check assertions for args? I don't mind and I can do that if a reviewer thinks that makes sense. The asserts could also be in toImpl/toAPI instead. 859318 7 cdumez 2013-03-20 06:13:35 -0700 (In reply to comment #6) > > How about null-check assertions for args? > > I don't mind and I can do that if a reviewer thinks that makes sense. The asserts could also be in toImpl/toAPI instead. Right, other C API code does not usually use assertions either. LGTM then. 859329 8 kenneth 2013-03-20 06:20:36 -0700 Ping owner review/sign off. 889971 9 194028 cdumez 2013-05-16 13:06:26 -0700 Comment on attachment 194028 Patch Entirely port specific so it should no longer require owner review. r=me. 1286336 10 mcatanzaro 2017-03-11 10:37:12 -0800 Closing this bug because the EFL port has been removed from trunk. If you feel this bug applies to a different upstream WebKit port and was closed in error, please either update the title and reopen the bug, or leave a comment to request this. 194028 2013-03-20 06:00:33 -0700 2013-05-16 13:06:25 -0700 Patch bug-112794-20130320135558.patch text/plain 3543 kenneth U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ2MzEyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZGNjYmJjYmMxYmIyMTQ1 ODIwNzJjODhkZGQ0NGRjNTAwNTU0ZGY0OS4uMzc3NDMyMzVhNzUwNjU4ZWQ0YzU1YjcyZTYwN2U1 OGUzMTMxZDZlOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEzLTAzLTIwICBLZW5u ZXRoIFJvaGRlIENocmlzdGlhbnNlbiAgPGtlbm5ldGhAd2Via2l0Lm9yZz4KKworICAgICAgICBb RUZMXVtXSzJdIERvIG5vdCBhbGxvdyBwYXNzaW5nIG51bGwgcG9pbnRlcnMgZm9yICpSZWYgdHlw ZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMjc5 NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbmFt ZSBXS1ZpZXdDcmVhdGUgdG8gV0tWaWV3Q3JlYXRlV2l0aFBhZ2VHcm91cCwgYW5kIGFkZAorICAg ICAgICBhIG5ldyBXS1ZpZXdDcmVhdGUgbWV0aG9kIHdoaWNoIGRvZXNuJ3QgdGFrZSBhIFBhZ2VH cm91cFJlZi4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvQy9lZmwvV0tWaWV3LmNwcDoKKyAg ICAgICAgKFdLVmlld0NyZWF0ZSk6CisgICAgICAgIChXS1ZpZXdDcmVhdGVXaXRoUGFnZUdyb3Vw KToKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL0MvZWZsL1dLVmlldy5oOgorICAgICAgICAqIFVJ UHJvY2Vzcy9BUEkvZWZsL2V3a192aWV3LmNwcDoKKyAgICAgICAgKEVXS1ZpZXdDcmVhdGUpOgor CiAyMDEzLTAzLTE5ICBLZW5uZXRoIFJvaGRlIENocmlzdGlhbnNlbiAgPGtlbm5ldGhAd2Via2l0 Lm9yZz4gYW5kIE1pa2hhaWwgUG96ZG55YWtvdiAgPG1pa2hhaWwucG96ZG55YWtvdkBpbnRlbC5j b20+CiAKICAgICAgICAgW0VGTF1bV0syXSBTZXBhcmF0ZSBXZWJWaWV3IGZ1cnRoZXIgZnJvbSBF d2tWaWV3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0MvZWZsL1dL Vmlldy5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0MvZWZsL1dLVmlldy5jcHAK aW5kZXggNjkxZjZhMWExMzVmNTE3MDY4ODhiMWMxN2I0ZWVmMWE5Yzk1YzJmOS4uYzEyMzUwZGY3 NzUwOWNlOTBkYjkxZmY1MWNlODk5ZWVkYzllNDZlYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL0FQSS9DL2VmbC9XS1ZpZXcuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9BUEkvQy9lZmwvV0tWaWV3LmNwcApAQCAtMjksNyArMjksMTQgQEAKIAogdXNpbmcg bmFtZXNwYWNlIFdlYktpdDsKIAotV0tWaWV3UmVmIFdLVmlld0NyZWF0ZShXS0NvbnRleHRSZWYg Y29udGV4dFJlZiwgV0tQYWdlR3JvdXBSZWYgcGFnZUdyb3VwUmVmKQorV0tWaWV3UmVmIFdLVmll d0NyZWF0ZShXS0NvbnRleHRSZWYgY29udGV4dFJlZikKK3sKKyAgICAvLyBEZWZhdWx0IHBhZ2Ug Z3JvdXAgd2lsbCBiZSBzZXQgZ2l2ZW4gbnVsbCBwb2ludGVyLgorICAgIFJlZlB0cjxXZWJWaWV3 PiB3ZWJWaWV3ID0gV2ViVmlldzo6Y3JlYXRlKHRvSW1wbChjb250ZXh0UmVmKSwgMCk7CisgICAg cmV0dXJuIHRvQVBJKHdlYlZpZXcucmVsZWFzZSgpLmxlYWtSZWYoKSk7Cit9CisKK1dLVmlld1Jl ZiBXS1ZpZXdDcmVhdGVXaXRoUGFnZUdyb3VwKFdLQ29udGV4dFJlZiBjb250ZXh0UmVmLCBXS1Bh Z2VHcm91cFJlZiBwYWdlR3JvdXBSZWYpCiB7CiAgICAgUmVmUHRyPFdlYlZpZXc+IHdlYlZpZXcg PSBXZWJWaWV3OjpjcmVhdGUodG9JbXBsKGNvbnRleHRSZWYpLCB0b0ltcGwocGFnZUdyb3VwUmVm KSk7CiAgICAgcmV0dXJuIHRvQVBJKHdlYlZpZXcucmVsZWFzZSgpLmxlYWtSZWYoKSk7CmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0MvZWZsL1dLVmlldy5oIGIvU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9DL2VmbC9XS1ZpZXcuaAppbmRleCBjYTM0YmE0MTY5 ZmJmMjIyYzVkY2Y3ODY3ZTVhMzkzZjFmYTMzMjkxLi4yNjZhZWViOWE1MWFkOGVmM2IxOTdjYWU3 YTBjODliM2MxMjE3M2VjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJ L0MvZWZsL1dLVmlldy5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQy9lZmwv V0tWaWV3LmgKQEAgLTQ5LDcgKzQ5LDggQEAgdHlwZWRlZiBzdHJ1Y3QgV0tWaWV3Q2xpZW50IFdL Vmlld0NsaWVudDsKIAogZW51bSB7IGtXS1ZpZXdDbGllbnRDdXJyZW50VmVyc2lvbiA9IDAgfTsK IAotV0tfRVhQT1JUIFdLVmlld1JlZiBXS1ZpZXdDcmVhdGUoV0tDb250ZXh0UmVmIGNvbnRleHQs IFdLUGFnZUdyb3VwUmVmIHBhZ2VHcm91cCk7CitXS19FWFBPUlQgV0tWaWV3UmVmIFdLVmlld0Ny ZWF0ZShXS0NvbnRleHRSZWYgY29udGV4dCk7CitXS19FWFBPUlQgV0tWaWV3UmVmIFdLVmlld0Ny ZWF0ZVdpdGhQYWdlR3JvdXAoV0tDb250ZXh0UmVmIGNvbnRleHQsIFdLUGFnZUdyb3VwUmVmIHBh Z2VHcm91cCk7CiAKIFdLX0VYUE9SVCB2b2lkIFdLVmlld0luaXRpYWxpemUoV0tWaWV3UmVmKTsK IFdLX0VYUE9SVCB2b2lkIFdLVmlld1NldFZpZXdDbGllbnQoV0tWaWV3UmVmLCBjb25zdCBXS1Zp ZXdDbGllbnQqKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZs L2V3a192aWV3LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a192aWV3 LmNwcAppbmRleCBjMTViOGRhOTNkYWUwMWE2Mzk2MmFlNGEyMzNlZTA4YWE5YzgzODAxLi5lM2Mw NDY4YTU3M2Q5NWZkNzZhZjJjMTQ1OTg2MTQxMzA0OTdiZGEzIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tfdmlldy5jcHAKKysrIGIvU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3ZpZXcuY3BwCkBAIC05MSw3ICs5MSw3IEBAIEVpbmFf Qm9vbCBld2tfdmlld19zbWFydF9jbGFzc19zZXQoRXdrX1ZpZXdfU21hcnRfQ2xhc3MqIGFwaSkK IAogRXZhc19PYmplY3QqIEVXS1ZpZXdDcmVhdGUoV0tDb250ZXh0UmVmIGNvbnRleHQsIFdLUGFn ZUdyb3VwUmVmIHBhZ2VHcm91cCwgRXZhcyogY2FudmFzLCBFdmFzX1NtYXJ0KiBzbWFydCkKIHsK LSAgICBXS1JldGFpblB0cjxXS1ZpZXdSZWY+IHdrVmlldyA9IGFkb3B0V0soV0tWaWV3Q3JlYXRl KGNvbnRleHQsIHBhZ2VHcm91cCkpOworICAgIFdLUmV0YWluUHRyPFdLVmlld1JlZj4gd2tWaWV3 ID0gYWRvcHRXSyhXS1ZpZXdDcmVhdGVXaXRoUGFnZUdyb3VwKGNvbnRleHQsIHBhZ2VHcm91cCkp OwogICAgIFdLUGFnZVNldFVzZUZpeGVkTGF5b3V0KFdLVmlld0dldFBhZ2Uod2tWaWV3LmdldCgp KSwgdHJ1ZSk7CiAgICAgaWYgKEV3a1ZpZXcqIGV3a1ZpZXcgPSBFd2tWaWV3OjpjcmVhdGUod2tW aWV3LmdldCgpLCBjYW52YXMsIHNtYXJ0KSkKICAgICAgICAgcmV0dXJuIGV3a1ZpZXctPmV2YXNP YmplY3QoKTsK