112793 2013-03-20 05:51:08 -0700 Modify checkLayout to receive the log container as an optional parameter 2013-05-14 05:51:28 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 abucur abucur commit-queue dglazkov jchaffraix WebkitBugTracker webkit.review.bot oldest_to_newest 859284 0 abucur 2013-03-20 05:51:08 -0700 checkLayout in check-layout.js automatically selects the logging container based on the source node (the node or its parent). In some cases this is undesirable because it may modify the elements getting measured (if they are nested). 859299 1 194030 abucur 2013-03-20 06:06:20 -0700 Created attachment 194030 Patch 859389 2 194030 webkit.review.bot 2013-03-20 07:35:27 -0700 Comment on attachment 194030 Patch Attachment 194030 did not pass chromium-ews (chromium-xvfb): Output: http://webkit-commit-queue.appspot.com/results/17195388 New failing tests: css3/flexbox/box-sizing.html css3/flexbox/multiline-justify-content.html css3/flexbox/flex-flow-margins.html fast/block/margin-collapse/self-collapsing-block-with-float-children.html http/tests/cache/subresource-failover-to-network.html css3/flexbox/multiline-align-content-horizontal-column.html css3/flexbox/flex-align.html css3/flexbox/preferred-widths-orthogonal.html css3/flexbox/preferred-widths.html css3/flexbox/line-wrapping.html css3/flexbox/flex-align-vertical-writing-mode.html css3/flexbox/intrinsic-min-width-applies-with-fixed-width.html css3/flexbox/flex-item-min-size.html fast/css-grid-layout/auto-content-resolution-columns.html css3/flexbox/flex-flow-margins-auto-size.html css3/flexbox/position-absolute-child.html css3/flexbox/flex-flow-auto-margins.html css3/flexbox/flex-flow-padding.html css3/flexbox/multiline.html css3/flexbox/multiline-align-self.html css3/flexbox/flex-align-end.html css3/flexbox/flex-flow-orientations.html css3/flexbox/position-absolute-children.html css3/flexbox/flex-flow-overflow.html css3/flexbox/flexitem.html css3/flexbox/nested-stretch.html css3/flexbox/flex-flow-auto-margins-no-available-space.html css3/flexbox/true-centering.html css3/flexbox/flex-flow-border.html fast/block/min-max-height-percent-height-child.html 859464 3 194071 abucur 2013-03-20 09:01:08 -0700 Created attachment 194071 Patch 859497 4 194080 abucur 2013-03-20 09:44:24 -0700 Created attachment 194080 Test case using a complex checkLayout() 888625 5 194071 darin 2013-05-13 18:25:51 -0700 Comment on attachment 194071 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=194071&action=review > LayoutTests/resources/check-layout.js:187 > + var container = overrideContainer; > + if (!overrideContainer) > + container = node.parentNode.className == 'container' ? node.parentNode : node; This can also be written: var container = overrideContainer || (node.parentNode.className == 'container' ? node.parentNode : node); 888626 6 194071 darin 2013-05-13 18:26:11 -0700 Comment on attachment 194071 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=194071&action=review > LayoutTests/ChangeLog:12 > + (.): Seriously, don’t leave lines like this in ChangeLog unless you want me to cry. 888705 7 194071 abucur 2013-05-13 23:11:18 -0700 Comment on attachment 194071 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=194071&action=review >> LayoutTests/ChangeLog:12 >> + (.): > > Seriously, don’t leave lines like this in ChangeLog unless you want me to cry. Hold your tears :). I've started removing them once people told me to do it. The patch is just a bit older than that. 888706 8 194071 abucur 2013-05-13 23:11:52 -0700 Comment on attachment 194071 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=194071&action=review >>> LayoutTests/ChangeLog:12 >>> + (.): >> >> Seriously, don’t leave lines like this in ChangeLog unless you want me to cry. > > Hold your tears :). I've started removing them once people told me to do it. The patch is just a bit older than that. Oh, and thanks for the review! 888708 9 201681 abucur 2013-05-13 23:41:25 -0700 Created attachment 201681 Patch for landing 888710 10 201682 abucur 2013-05-13 23:43:47 -0700 Created attachment 201682 Patch for landing w/ reviewer 888800 11 201682 commit-queue 2013-05-14 05:51:25 -0700 Comment on attachment 201682 Patch for landing w/ reviewer Clearing flags on attachment: 201682 Committed r150067: <http://trac.webkit.org/changeset/150067> 888801 12 commit-queue 2013-05-14 05:51:28 -0700 All reviewed patches have been landed. Closing bug. 194030 2013-03-20 06:06:20 -0700 2013-03-20 09:01:03 -0700 Patch bug-112793-20130320150209.patch text/plain 1838 abucur U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ2MzMyCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNDYxZjBjMjRjNmI5NDA4N2M3YmRi ZDU2NjgwY2EwOGY2NmQ3NDdiMS4uMThkMjIzYjA1OGYyYWFmZDlkNzBkMzQ5OGIyYTJlODI0NThm MjdlMCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEzLTAzLTIwICBBbmRyZWkgQnVjdXIgIDxh YnVjdXJAYWRvYmUuY29tPgorCisgICAgICAgIE1vZGlmeSBjaGVja0xheW91dCB0byByZWNlaXZl IHRoZSBsb2cgY29udGFpbmVyIGFzIGFuIG9wdGlvbmFsIHBhcmFtZXRlcgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEyNzkzCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIGEgd2F5IHRvIHNwZWNpZnkg dGhlIGNvbnRhaW5lciBtYW51YWxseSBmb3IgY2hlY2tMYXlvdXQuIFRoaXMgaXMgaGVscGZ1bCB0 byBtZWFzdXJlIHJlZ2lvbnMgZm9yIG5lc3RlZAorICAgICAgICBuYW1lZCBmbG93cy4KKworICAg ICAgICAqIHJlc291cmNlcy9jaGVjay1sYXlvdXQuanM6CisgICAgICAgICguKToKKwogMjAxMy0w My0yMCAgQWxsYW4gU2FuZGZlbGQgSmVuc2VuICA8YWxsYW4uamVuc2VuQGRpZ2lhLmNvbT4KIAog ICAgICAgICBbUXRdIE5ldyBmYXN0L3RleHQvd29yZC1zcGFjZS13aXRoLWtlcm5pbmctMy5odG1s IGZhaWxzIG9uIFF0CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9yZXNvdXJjZXMvY2hlY2stbGF5 b3V0LmpzIGIvTGF5b3V0VGVzdHMvcmVzb3VyY2VzL2NoZWNrLWxheW91dC5qcwppbmRleCBmMjAy OWNiYTFkNzA3MGZiNTEzN2RmNjBhZDZlMTg3YTY1MDQ4ZWU1Li45NzVjN2U4YjEyMjZmYzRlYjRh ODEzZGIzMDVhOTg0YzI2ZDAxOTBlIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9yZXNvdXJjZXMv Y2hlY2stbGF5b3V0LmpzCisrKyBiL0xheW91dFRlc3RzL3Jlc291cmNlcy9jaGVjay1sYXlvdXQu anMKQEAgLTE2OCw3ICsxNjgsNyBAQCBmdW5jdGlvbiBjaGVja0V4cGVjdGVkVmFsdWVzKG5vZGUs IGZhaWx1cmVzKQogICAgIH0KIH0KIAotd2luZG93LmNoZWNrTGF5b3V0ID0gZnVuY3Rpb24oc2Vs ZWN0b3JMaXN0KQord2luZG93LmNoZWNrTGF5b3V0ID0gZnVuY3Rpb24oc2VsZWN0b3JMaXN0LCBj b250YWluZXIpCiB7CiAgICAgaWYgKCFzZWxlY3Rvckxpc3QpIHsKICAgICAgICAgY29uc29sZS5l cnJvcigiWW91IG11c3QgcHJvdmlkZSBhIENTUyBzZWxlY3RvciBvZiBub2RlcyB0byBjaGVjay4i KTsKQEAgLTE4Miw3ICsxODIsOCBAQCB3aW5kb3cuY2hlY2tMYXlvdXQgPSBmdW5jdGlvbihzZWxl Y3Rvckxpc3QpCiAgICAgICAgIGNoZWNrRXhwZWN0ZWRWYWx1ZXMobm9kZS5wYXJlbnROb2RlLCBm YWlsdXJlcyk7CiAgICAgICAgIGNoZWNrU3VidHJlZUV4cGVjdGVkVmFsdWVzKG5vZGUsIGZhaWx1 cmVzKTsKIAotICAgICAgICB2YXIgY29udGFpbmVyID0gbm9kZS5wYXJlbnROb2RlLmNsYXNzTmFt ZSA9PSAnY29udGFpbmVyJyA/IG5vZGUucGFyZW50Tm9kZSA6IG5vZGU7CisgICAgICAgIGlmICgh Y29udGFpbmVyKQorICAgICAgICAgICAgY29udGFpbmVyID0gbm9kZS5wYXJlbnROb2RlLmNsYXNz TmFtZSA9PSAnY29udGFpbmVyJyA/IG5vZGUucGFyZW50Tm9kZSA6IG5vZGU7CiAKICAgICAgICAg dmFyIHByZSA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoJ3ByZScpOwogICAgICAgICBpZiAoZmFp bHVyZXMubGVuZ3RoKQo= 194071 2013-03-20 09:01:08 -0700 2013-05-13 23:41:20 -0700 Patch bug-112793-20130320175657.patch text/plain 1898 abucur U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ2MzMyCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNDYxZjBjMjRjNmI5NDA4N2M3YmRi ZDU2NjgwY2EwOGY2NmQ3NDdiMS4uMThkMjIzYjA1OGYyYWFmZDlkNzBkMzQ5OGIyYTJlODI0NThm MjdlMCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEzLTAzLTIwICBBbmRyZWkgQnVjdXIgIDxh YnVjdXJAYWRvYmUuY29tPgorCisgICAgICAgIE1vZGlmeSBjaGVja0xheW91dCB0byByZWNlaXZl IHRoZSBsb2cgY29udGFpbmVyIGFzIGFuIG9wdGlvbmFsIHBhcmFtZXRlcgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEyNzkzCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIGEgd2F5IHRvIHNwZWNpZnkg dGhlIGNvbnRhaW5lciBtYW51YWxseSBmb3IgY2hlY2tMYXlvdXQuIFRoaXMgaXMgaGVscGZ1bCB0 byBtZWFzdXJlIHJlZ2lvbnMgZm9yIG5lc3RlZAorICAgICAgICBuYW1lZCBmbG93cy4KKworICAg ICAgICAqIHJlc291cmNlcy9jaGVjay1sYXlvdXQuanM6CisgICAgICAgICguKToKKwogMjAxMy0w My0yMCAgQWxsYW4gU2FuZGZlbGQgSmVuc2VuICA8YWxsYW4uamVuc2VuQGRpZ2lhLmNvbT4KIAog ICAgICAgICBbUXRdIE5ldyBmYXN0L3RleHQvd29yZC1zcGFjZS13aXRoLWtlcm5pbmctMy5odG1s IGZhaWxzIG9uIFF0CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9yZXNvdXJjZXMvY2hlY2stbGF5 b3V0LmpzIGIvTGF5b3V0VGVzdHMvcmVzb3VyY2VzL2NoZWNrLWxheW91dC5qcwppbmRleCBmMjAy OWNiYTFkNzA3MGZiNTEzN2RmNjBhZDZlMTg3YTY1MDQ4ZWU1Li40OTAyN2Q4MTdjODhkY2IxODJk ZDZmYzE0OTVhNWVkZTNhNGE5YWE4IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9yZXNvdXJjZXMv Y2hlY2stbGF5b3V0LmpzCisrKyBiL0xheW91dFRlc3RzL3Jlc291cmNlcy9jaGVjay1sYXlvdXQu anMKQEAgLTE2OCw3ICsxNjgsNyBAQCBmdW5jdGlvbiBjaGVja0V4cGVjdGVkVmFsdWVzKG5vZGUs IGZhaWx1cmVzKQogICAgIH0KIH0KIAotd2luZG93LmNoZWNrTGF5b3V0ID0gZnVuY3Rpb24oc2Vs ZWN0b3JMaXN0KQord2luZG93LmNoZWNrTGF5b3V0ID0gZnVuY3Rpb24oc2VsZWN0b3JMaXN0LCBv dmVycmlkZUNvbnRhaW5lcikKIHsKICAgICBpZiAoIXNlbGVjdG9yTGlzdCkgewogICAgICAgICBj b25zb2xlLmVycm9yKCJZb3UgbXVzdCBwcm92aWRlIGEgQ1NTIHNlbGVjdG9yIG9mIG5vZGVzIHRv IGNoZWNrLiIpOwpAQCAtMTgyLDcgKzE4Miw5IEBAIHdpbmRvdy5jaGVja0xheW91dCA9IGZ1bmN0 aW9uKHNlbGVjdG9yTGlzdCkKICAgICAgICAgY2hlY2tFeHBlY3RlZFZhbHVlcyhub2RlLnBhcmVu dE5vZGUsIGZhaWx1cmVzKTsKICAgICAgICAgY2hlY2tTdWJ0cmVlRXhwZWN0ZWRWYWx1ZXMobm9k ZSwgZmFpbHVyZXMpOwogCi0gICAgICAgIHZhciBjb250YWluZXIgPSBub2RlLnBhcmVudE5vZGUu Y2xhc3NOYW1lID09ICdjb250YWluZXInID8gbm9kZS5wYXJlbnROb2RlIDogbm9kZTsKKyAgICAg ICAgdmFyIGNvbnRhaW5lciA9IG92ZXJyaWRlQ29udGFpbmVyOworICAgICAgICBpZiAoIW92ZXJy aWRlQ29udGFpbmVyKQorICAgICAgICAgICAgY29udGFpbmVyID0gbm9kZS5wYXJlbnROb2RlLmNs YXNzTmFtZSA9PSAnY29udGFpbmVyJyA/IG5vZGUucGFyZW50Tm9kZSA6IG5vZGU7CiAKICAgICAg ICAgdmFyIHByZSA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoJ3ByZScpOwogICAgICAgICBpZiAo ZmFpbHVyZXMubGVuZ3RoKQo= 194080 2013-03-20 09:44:24 -0700 2013-03-20 09:44:24 -0700 Test case using a complex checkLayout() autoheight-mixed-nested-regions.html text/html 3330 abucur PGh0bWw+CjxoZWFkPgogICAgPHN0eWxlPgogICAgICAgIC5jb250ZW50IHsKICAgICAgICAgICAg Zm9udC1mYW1pbHk6IEFoZW07CiAgICAgICAgICAgIGZvbnQtc2l6ZTogMTBweDsKICAgICAgICB9 CgogICAgICAgICNjb250ZW50MSB7CiAgICAgICAgICAgIC13ZWJraXQtZmxvdy1pbnRvOiBmbG93 MTsKICAgICAgICB9CgogICAgICAgICNjb250ZW50MiB7CiAgICAgICAgICAgIC13ZWJraXQtZmxv dy1pbnRvOiBmbG93MjsKICAgICAgICB9CgogICAgICAgICNjb250ZW50MyB7CiAgICAgICAgICAg IC13ZWJraXQtZmxvdy1pbnRvOiBmbG93MzsKICAgICAgICB9CgogICAgICAgIC5yZWdpb24xIHsK ICAgICAgICAgICAgYm9yZGVyOiB0aGljayBzb2xpZCBibHVlOwogICAgICAgICAgICAtd2Via2l0 LWZsb3ctZnJvbTogZmxvdzE7CiAgICAgICAgfQoKICAgICAgICAucmVnaW9uMiB7CiAgICAgICAg ICAgIGJvcmRlcjogdGhpY2sgc29saWQgcmVkOwogICAgICAgICAgICAtd2Via2l0LWZsb3ctZnJv bTogZmxvdzI7CiAgICAgICAgfQoKICAgICAgICAucmVnaW9uMyB7CiAgICAgICAgICAgIGJvcmRl cjogdGhpY2sgc29saWQgZ3JlZW47CiAgICAgICAgICAgIC13ZWJraXQtZmxvdy1mcm9tOiBmbG93 MzsKICAgICAgICB9CgogICAgICAgICNyZWdpb24xIHsKICAgICAgICAgICAgd2lkdGg6IDUwMHB4 OwogICAgICAgIH0KCiAgICAgICAgI3JlZ2lvbjIgewogICAgICAgICAgICBtYXgtaGVpZ2h0OiAx MDFweAogICAgICAgIH0KCiAgICAgICAgI3JlZ2lvbjMgewogICAgICAgICAgICBtYXgtaGVpZ2h0 OiA1MHB4OwogICAgICAgIH0KCiAgICAgICAgI3JlZ2lvbjQgewogICAgICAgICAgICBtYXgtaGVp Z2h0OiAyMHB4OwogICAgICAgIH0KCiAgICAgICAgI3JlZ2lvbjUgewogICAgICAgICAgICBtYXgt aGVpZ2h0OiAxMTFweDsKICAgICAgICB9CiAgICA8L3N0eWxlPgogICAgPHNjcmlwdCBzcmM9Ii4u Ly4uL3Jlc291cmNlcy9jaGVjay1sYXlvdXQuanMiPjwvc2NyaXB0Pgo8L2hlYWQ+Cjxib2R5IG9u bG9hZD0ieGNoZWNrTGF5b3V0KCdib2R5IGRpdicpIj4KICAgIDxkaXYgY2xhc3M9ImNvbnRlbnQi IGlkPSJjb250ZW50MSIgZGF0YS1leHBlY3RlZC1oZWlnaHQ9NDEyPkxvcmVtIGlwc3VtIGRvbG9y IHNpdCBhbWV0LCBjb25zZWN0ZXR1ciBhZGlwaXNjaW5nIGVsaXQuIEFlbmVhbiB1cm5hIG9yY2ks IGNvbnNlcXVhdCBzZWQgbG9ib3J0aXMgaW4sIGNvbnZhbGxpcyBldCB2ZWxpdC4gPGRpdiBjbGFz cz0icmVnaW9uMyIgaWQ9InJlZ2lvbjUiIGRhdGEtZXhwZWN0ZWQtaGVpZ2h0PTEyMT48L2Rpdj4g VXQgZWxlbWVudHVtIGxhY3VzIGFjIGR1aSB2ZXN0aWJ1bHVtIGV1IGNvbmRpbWVudHVtIG1pIGx1 Y3R1cy4gRnVzY2UgcGhhcmV0cmEgdHVycGlzIGlkIGVyYXQgY29uZ3VlIG5lYyBhbGlxdWFtIGxl byB2ZW5lbmF0aXMuIEN1bSBzb2NpaXMgbmF0b3F1ZSBwZW5hdGlidXMgZXQgbWFnbmlzIGRpcyBw YXJ0dXJpZW50IG1vbnRlcywgbmFzY2V0dXIgcmlkaWN1bHVzIG11cy48ZGl2IGNsYXNzPSJyZWdp b24yIiBpZD0icmVnaW9uMiIgZGF0YS1leHBlY3RlZC1oZWlnaHQ9MTExPjwvZGl2PkNsYXNzIGFw dGVudCB0YWNpdGkgc29jaW9zcXUgYWQgbGl0b3JhIHRvcnF1ZW50IHBlciBjb251YmlhIG5vc3Ry YSwgcGVyIGluY2VwdG9zIGhpbWVuYWVvcy4gU2VkIGVnZXN0YXMgdWx0cmljZXMgbWF1cmlzIHNl ZCB0ZW1wb3IuIE1hZWNlbmFzIHZpdGFlIGxpYmVybyB1dCBuaXNsIGdyYXZpZGEgZWxlaWZlbmQg YmxhbmRpdCBub24gcmlzdXMuPGRpdiBjbGFzcz0icmVnaW9uMiIgaWQ9InJlZ2lvbjMiIGRhdGEt ZXhwZWN0ZWQtaGVpZ2h0PTUwPjwvZGl2PkZ1c2NlIGdyYXZpZGEgdmVuZW5hdGlzIGRvbG9yIGV1 IGltcGVyZGlldC4KICAgIDwvZGl2PgogICAgPGRpdiBjbGFzcz0iY29udGVudCIgaWQ9ImNvbnRl bnQyIiBkYXRhLWV4cGVjdGVkLWhlaWdodD0xNDE+VXQgYXQgdG9ydG9yIGxpZ3VsYS4gQ3JhcyB0 ZW1wb3Igc2VtIHNlZCB0ZWxsdXMgY29udmFsbGlzIHRpbmNpZHVudCBlZ2V0IGVnZXQgZG9sb3Iu IEluIGZhY2lsaXNpcyBhbnRlIGF0IHR1cnBpcyBzZW1wZXIgc2VtcGVyLiBGdXNjZSBkdWkgZG9s b3IsIHJob25jdXMgZXQgY3Vyc3VzIGluLCBtYWxlc3VhZGEgaW4ganVzdG8uIDxkaXYgY2xhc3M9 InJlZ2lvbjMiIGlkPSJyZWdpb240IiBkYXRhLWV4cGVjdGVkLWhlaWdodD0zMD48L2Rpdj5DdXJh Yml0dXIgdnVscHV0YXRlIGFsaXF1ZXQgdGluY2lkdW50LiBRdWlzcXVlIHNpdCBhbWV0IG1hc3Nh IGp1c3RvLCBpbiBiaWJlbmR1bSBsZW8uIEFsaXF1YW0gbGFjaW5pYSBwaGFyZXRyYSBqdXN0by4g U3VzcGVuZGlzc2UgcmhvbmN1cyBqdXN0byBuZWMgZGlhbSBjdXJzdXMgdWxsYW1jb3JwZXIuIE5h bSBwb3J0dGl0b3IgcG9ydHRpdG9yIGxpYmVybywgY29udmFsbGlzIHNvbGxpY2l0dWRpbiBudW5j IGV1aXNtb2QgYXQuIFByb2luIHRlbXB1cyBhdWN0b3IgdHVycGlzIHV0IGNvbmd1ZS4gTnVsbGFt IG9ybmFyZSBpbnRlcmR1bSBlcm9zIHNlZCBzdXNjaXBpdC4KICAgIDwvZGl2PgogICAgPGRpdiBj bGFzcz0iY29udGVudCIgaWQ9ImNvbnRlbnQzIiBkYXRhLWV4cGVjdGVkLWhlaWdodD0xMzE+U2Vk IG5lYyBqdXN0byBtYWduYS4gTnVsbGFtIGFjY3Vtc2FuIGFyY3UgZXQgZW5pbSBibGFuZGl0IHNh Z2l0dGlzLiBJbiBzY2VsZXJpc3F1ZSwgZmVsaXMgYWMgZmVybWVudHVtIHNjZWxlcmlzcXVlLCBw dXJ1cyB2ZWxpdCBhbGlxdWV0IGR1aSwgbm9uIHZpdmVycmEgZXJvcyBlcm9zIHZlbCBzZW0uIEFl bmVhbiB0dXJwaXMgbGVjdHVzLCBtb2xlc3RpZSBzb2RhbGVzIGFkaXBpc2Npbmcgbm9uLCByaG9u Y3VzIGV1IGp1c3RvLiBOdWxsYW0gbW9sZXN0aWUgZW5pbSBhYyBudWxsYSBjdXJzdXMgZnJpbmdp bGxhLiBFdGlhbSBzZWQgbWV0dXMgbGVjdHVzLiBBbGlxdWFtIGVyYXQgdm9sdXRwYXQuIFF1aXNx dWUgcHVsdmluYXIgaGVuZHJlcml0IHVybmEgbm9uIHZhcml1cy4gRG9uZWMgaW1wZXJkaWV0LCBt YXNzYSBpbiBzZW1wZXIgaGVuZHJlcml0LCB1cm5hIG51bGxhIGRhcGlidXMgdGVsbHVzLCBhYyBk aWduaXNzaW0gZW5pbSBuZXF1ZSB1dCBvZGlvLiBJbiBzYWdpdHRpcywgZXN0IGluIGZyaW5naWxs YSBhY2N1bXNhbiwgb2RpbyBqdXN0byBsYWNpbmlhIGR1aSwgc2VkIHB1bHZpbmFyIHVybmEgbG9y ZW0gbm9uIGR1aS48L2Rpdj4KICAgIDxkaXYgY2xhc3M9InJlZ2lvbjEiIGlkPSJyZWdpb24xIiBk YXRhLWV4cGVjdGVkLWhlaWdodD00MjI+CiAgICA8L2Rpdj4KICAgIDxkaXYgaWQ9ImNvbnNvbGUi PjwvZGl2Pgo8L2JvZHk+CjwvaHRtbD4K 201681 2013-05-13 23:41:25 -0700 2013-05-13 23:43:42 -0700 Patch for landing bug-112793-20130514094022.patch text/plain 1933 abucur U3VidmVyc2lvbiBSZXZpc2lvbjogMTUwMDA0CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNTllMGFlMjIzNWY4NjdiYWFjYmEx NDVlNzlhNjc0ZWZhZjNkNWU0Mi4uMWIwMzM2YmRjYzM0MDJmNjgwNTM5MmQ2MGEyNDRlN2Q0ZGQ2 ZDdlYyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEzLTA1LTE0ICBBbmRyZWkgQnVjdXIgIDxh YnVjdXJAYWRvYmUuY29tPgorCisgICAgICAgIE1vZGlmeSBjaGVja0xheW91dCB0byByZWNlaXZl IHRoZSBsb2cgY29udGFpbmVyIGFzIGFuIG9wdGlvbmFsIHBhcmFtZXRlcgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEyNzkzCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIGEgd2F5IHRvIHNwZWNpZnkg dGhlIGNvbnRhaW5lciBtYW51YWxseSBmb3IgY2hlY2tMYXlvdXQuIFRoaXMgaXMgaGVscGZ1bCB0 byBtZWFzdXJlIHJlZ2lvbnMgZm9yIG5lc3RlZAorICAgICAgICBuYW1lZCBmbG93cyAoYW5kIHBy b2JhYmx5IG90aGVyIGNhc2VzIGFzIHdlbGwpLgorCisgICAgICAgICogcmVzb3VyY2VzL2NoZWNr LWxheW91dC5qczogQWRkZWQgYW4gb3B0aW9uYWwgcGFyYW1ldGVyIHRvIHdpbmRvdy5jaGVja0xh eW91dC4KKwogMjAxMy0wNS0xMyAgQ2hyaXN0b3BoZSBEdW1leiAgPGNoLmR1bWV6QHNpc2Euc2Ft c3VuZy5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCBFRkwgZ2FyZGVuaW5nLgpkaWZmIC0tZ2l0 IGEvTGF5b3V0VGVzdHMvcmVzb3VyY2VzL2NoZWNrLWxheW91dC5qcyBiL0xheW91dFRlc3RzL3Jl c291cmNlcy9jaGVjay1sYXlvdXQuanMKaW5kZXggMTY5YmUzMWMzYmRkZmVlMzgzZTQ4MDlmMGI0 NzU2NTJlMzA4NTNjNS4uMDVlNmFmZDQ4ODhiOWIxNGRlZjQ4ODJjMjFhYjQzMTI1NzRjZjE0MyAx MDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcmVzb3VyY2VzL2NoZWNrLWxheW91dC5qcworKysgYi9M YXlvdXRUZXN0cy9yZXNvdXJjZXMvY2hlY2stbGF5b3V0LmpzCkBAIC0xNzksNyArMTc5LDcgQEAg ZnVuY3Rpb24gY2hlY2tFeHBlY3RlZFZhbHVlcyhub2RlLCBmYWlsdXJlcykKICAgICByZXR1cm4g b3V0cHV0LmNoZWNrZWQ7CiB9CiAKLXdpbmRvdy5jaGVja0xheW91dCA9IGZ1bmN0aW9uKHNlbGVj dG9yTGlzdCkKK3dpbmRvdy5jaGVja0xheW91dCA9IGZ1bmN0aW9uKHNlbGVjdG9yTGlzdCwgb3Zl cnJpZGVDb250YWluZXIpCiB7CiAgICAgaWYgKCFzZWxlY3Rvckxpc3QpIHsKICAgICAgICAgY29u c29sZS5lcnJvcigiWW91IG11c3QgcHJvdmlkZSBhIENTUyBzZWxlY3RvciBvZiBub2RlcyB0byBj aGVjay4iKTsKQEAgLTE5NCw3ICsxOTQsNyBAQCB3aW5kb3cuY2hlY2tMYXlvdXQgPSBmdW5jdGlv bihzZWxlY3Rvckxpc3QpCiAgICAgICAgIGNoZWNrZWRMYXlvdXQgfD0gY2hlY2tFeHBlY3RlZFZh bHVlcyhub2RlLnBhcmVudE5vZGUsIGZhaWx1cmVzKTsKICAgICAgICAgY2hlY2tlZExheW91dCB8 PSBjaGVja1N1YnRyZWVFeHBlY3RlZFZhbHVlcyhub2RlLCBmYWlsdXJlcyk7CiAKLSAgICAgICAg dmFyIGNvbnRhaW5lciA9IG5vZGUucGFyZW50Tm9kZS5jbGFzc05hbWUgPT0gJ2NvbnRhaW5lcicg PyBub2RlLnBhcmVudE5vZGUgOiBub2RlOworICAgICAgICB2YXIgY29udGFpbmVyID0gb3ZlcnJp ZGVDb250YWluZXIgfHwgKG5vZGUucGFyZW50Tm9kZS5jbGFzc05hbWUgPT0gJ2NvbnRhaW5lcicg PyBub2RlLnBhcmVudE5vZGUgOiBub2RlKTsKIAogICAgICAgICB2YXIgcHJlID0gZG9jdW1lbnQu Y3JlYXRlRWxlbWVudCgncHJlJyk7CiAgICAgICAgIGlmIChmYWlsdXJlcy5sZW5ndGgpCg== 201682 2013-05-13 23:43:47 -0700 2013-05-14 05:51:25 -0700 Patch for landing w/ reviewer bug-112793-20130514094244.patch text/plain 1930 abucur U3VidmVyc2lvbiBSZXZpc2lvbjogMTUwMDA0CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNTllMGFlMjIzNWY4NjdiYWFjYmEx NDVlNzlhNjc0ZWZhZjNkNWU0Mi4uMTk0MGNiZTkyOWNlOWMwNmNkNTc1YmE4YzFhNmI5ZWI3NTUw OTE3MiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEzLTA1LTE0ICBBbmRyZWkgQnVjdXIgIDxh YnVjdXJAYWRvYmUuY29tPgorCisgICAgICAgIE1vZGlmeSBjaGVja0xheW91dCB0byByZWNlaXZl IHRoZSBsb2cgY29udGFpbmVyIGFzIGFuIG9wdGlvbmFsIHBhcmFtZXRlcgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEyNzkzCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCisKKyAgICAgICAgQWRkIGEgd2F5IHRvIHNwZWNpZnkgdGhl IGNvbnRhaW5lciBtYW51YWxseSBmb3IgY2hlY2tMYXlvdXQuIFRoaXMgaXMgaGVscGZ1bCB0byBt ZWFzdXJlIHJlZ2lvbnMgZm9yIG5lc3RlZAorICAgICAgICBuYW1lZCBmbG93cyAoYW5kIHByb2Jh Ymx5IG90aGVyIGNhc2VzIGFzIHdlbGwpLgorCisgICAgICAgICogcmVzb3VyY2VzL2NoZWNrLWxh eW91dC5qczogQWRkZWQgYW4gb3B0aW9uYWwgcGFyYW1ldGVyIHRvIHdpbmRvdy5jaGVja0xheW91 dC4KKwogMjAxMy0wNS0xMyAgQ2hyaXN0b3BoZSBEdW1leiAgPGNoLmR1bWV6QHNpc2Euc2Ftc3Vu Zy5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCBFRkwgZ2FyZGVuaW5nLgpkaWZmIC0tZ2l0IGEv TGF5b3V0VGVzdHMvcmVzb3VyY2VzL2NoZWNrLWxheW91dC5qcyBiL0xheW91dFRlc3RzL3Jlc291 cmNlcy9jaGVjay1sYXlvdXQuanMKaW5kZXggMTY5YmUzMWMzYmRkZmVlMzgzZTQ4MDlmMGI0NzU2 NTJlMzA4NTNjNS4uMDVlNmFmZDQ4ODhiOWIxNGRlZjQ4ODJjMjFhYjQzMTI1NzRjZjE0MyAxMDA2 NDQKLS0tIGEvTGF5b3V0VGVzdHMvcmVzb3VyY2VzL2NoZWNrLWxheW91dC5qcworKysgYi9MYXlv dXRUZXN0cy9yZXNvdXJjZXMvY2hlY2stbGF5b3V0LmpzCkBAIC0xNzksNyArMTc5LDcgQEAgZnVu Y3Rpb24gY2hlY2tFeHBlY3RlZFZhbHVlcyhub2RlLCBmYWlsdXJlcykKICAgICByZXR1cm4gb3V0 cHV0LmNoZWNrZWQ7CiB9CiAKLXdpbmRvdy5jaGVja0xheW91dCA9IGZ1bmN0aW9uKHNlbGVjdG9y TGlzdCkKK3dpbmRvdy5jaGVja0xheW91dCA9IGZ1bmN0aW9uKHNlbGVjdG9yTGlzdCwgb3ZlcnJp ZGVDb250YWluZXIpCiB7CiAgICAgaWYgKCFzZWxlY3Rvckxpc3QpIHsKICAgICAgICAgY29uc29s ZS5lcnJvcigiWW91IG11c3QgcHJvdmlkZSBhIENTUyBzZWxlY3RvciBvZiBub2RlcyB0byBjaGVj ay4iKTsKQEAgLTE5NCw3ICsxOTQsNyBAQCB3aW5kb3cuY2hlY2tMYXlvdXQgPSBmdW5jdGlvbihz ZWxlY3Rvckxpc3QpCiAgICAgICAgIGNoZWNrZWRMYXlvdXQgfD0gY2hlY2tFeHBlY3RlZFZhbHVl cyhub2RlLnBhcmVudE5vZGUsIGZhaWx1cmVzKTsKICAgICAgICAgY2hlY2tlZExheW91dCB8PSBj aGVja1N1YnRyZWVFeHBlY3RlZFZhbHVlcyhub2RlLCBmYWlsdXJlcyk7CiAKLSAgICAgICAgdmFy IGNvbnRhaW5lciA9IG5vZGUucGFyZW50Tm9kZS5jbGFzc05hbWUgPT0gJ2NvbnRhaW5lcicgPyBu b2RlLnBhcmVudE5vZGUgOiBub2RlOworICAgICAgICB2YXIgY29udGFpbmVyID0gb3ZlcnJpZGVD b250YWluZXIgfHwgKG5vZGUucGFyZW50Tm9kZS5jbGFzc05hbWUgPT0gJ2NvbnRhaW5lcicgPyBu b2RlLnBhcmVudE5vZGUgOiBub2RlKTsKIAogICAgICAgICB2YXIgcHJlID0gZG9jdW1lbnQuY3Jl YXRlRWxlbWVudCgncHJlJyk7CiAgICAgICAgIGlmIChmYWlsdXJlcy5sZW5ndGgpCg==