112773 2013-03-19 20:19:30 -0700 Move repaint methods from RenderObject to RenderBox 2013-03-20 12:24:45 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ojan ojan buildbot eae eric esprehn+autocc jchaffraix leviw ojan.autocc pdr rniwa schenney tony webkit.review.bot oldest_to_newest 859009 0 ojan 2013-03-19 20:19:30 -0700 Move repaint methods from RenderObject to RenderBox 859011 1 193973 ojan 2013-03-19 20:21:12 -0700 Created attachment 193973 Patch 859017 2 193973 eric 2013-03-19 20:32:42 -0700 Comment on attachment 193973 Patch OK. What about SVG? IIRC repaintDuringLayoutIfMoved is part of the layoutDelta stuff? 859024 3 193973 buildbot 2013-03-19 20:35:04 -0700 Comment on attachment 193973 Patch Attachment 193973 did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-commit-queue.appspot.com/results/17193407 859026 4 ojan 2013-03-19 20:37:56 -0700 (In reply to comment #2) > (From update of attachment 193973 [details]) > OK. What about SVG? IIRC repaintDuringLayoutIfMoved is part of the layoutDelta stuff? Nope, that's the very similarly named, but different repaintAfterLayoutIfNeeded, which is used by LayoutRepainter. There's also checkForRepaintDuringLayout, which is used by SVG as well as other RenderObject subclasses. 859036 5 193978 ojan 2013-03-19 20:55:04 -0700 Created attachment 193978 fix mac build 859479 6 193978 jchaffraix 2013-03-20 09:16:32 -0700 Comment on attachment 193978 fix mac build View in context: https://bugs.webkit.org/attachment.cgi?id=193978&action=review > Source/WebCore/rendering/RenderBox.h:381 > + virtual void repaintOverhangingFloats(bool) { }; We should switch that function to using an enum or at least keep the parameter name. Not providing it makes it hard to see what this bool is supposed to be. 859538 7 193978 ojan 2013-03-20 10:34:39 -0700 Comment on attachment 193978 fix mac build View in context: https://bugs.webkit.org/attachment.cgi?id=193978&action=review >> Source/WebCore/rendering/RenderBox.h:381 >> + virtual void repaintOverhangingFloats(bool) { }; > > We should switch that function to using an enum or at least keep the parameter name. Not providing it makes it hard to see what this bool is supposed to be. Yeah, I should switch it to an enum...I guess I'll just do that. Keeping the parameter name doesn't work because then the Mac build complains about an unused variable name. 859542 8 193978 tony 2013-03-20 10:44:28 -0700 Comment on attachment 193978 fix mac build View in context: https://bugs.webkit.org/attachment.cgi?id=193978&action=review Can you add OVERRIDE to RenderBlock::repaintOverhangingFloats? >>> Source/WebCore/rendering/RenderBox.h:381 >>> + virtual void repaintOverhangingFloats(bool) { }; >> >> We should switch that function to using an enum or at least keep the parameter name. Not providing it makes it hard to see what this bool is supposed to be. > > Yeah, I should switch it to an enum...I guess I'll just do that. Keeping the parameter name doesn't work because then the Mac build complains about an unused variable name. You could use the UNUSED_PARAM macro and switch to an enum in a separate patch. You could also not inline it since it's already virtual. 859590 9 194093 ojan 2013-03-20 11:55:18 -0700 Created attachment 194093 Patch for landing 859608 10 194093 webkit.review.bot 2013-03-20 12:24:41 -0700 Comment on attachment 194093 Patch for landing Clearing flags on attachment: 194093 Committed r146377: <http://trac.webkit.org/changeset/146377> 859609 11 webkit.review.bot 2013-03-20 12:24:45 -0700 All reviewed patches have been landed. Closing bug. 193973 2013-03-19 20:21:12 -0700 2013-03-19 20:55:02 -0700 Patch bug-112773-20130319201702.patch text/plain 3662 ojan U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ2Mjk2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTk0ZTg0ZDk5Zjc5NTk5 OTFhMGJjM2FhNzNlY2YwZTYwZTc3NTExZi4uZmExYmY5MTc5OGY5ZWZjMDNkZWQ5NzkzNzgyMzFj YjgyMzBiYWQ3OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEzLTAzLTE5ICBPamFu IFZhZmFpICA8b2phbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgTW92ZSByZXBhaW50IG1ldGhv ZHMgZnJvbSBSZW5kZXJPYmplY3QgdG8gUmVuZGVyQm94CisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTI3NzMKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICByZXBhaW50T3ZlcmhhbmdpbmdGbG9hdHMgYW5kIHJl cGFpbnREdXJpbmdMYXlvdXRJZk1vdmVkIGFyZSBvbmx5IGV2ZXIgY2FsbGVkCisgICAgICAgIG9u IFJlbmRlckJveGVzLCBzbyBkb24ndCBuZWVkIHRvIGJlIG9uIFJlbmRlck9iamVjdC4gVGhpcyBh bHNvIGxldHMgdXMKKyAgICAgICAgZGV2aXJ0dWFsaXplIHJlcGFpbnREdXJpbmdMYXlvdXRJZk1v dmVkLgorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckJveC5oOgorICAgICAgICAoV2ViQ29y ZTo6UmVuZGVyQm94OjpyZXBhaW50T3ZlcmhhbmdpbmdGbG9hdHMpOgorICAgICAgICAqIHJlbmRl cmluZy9SZW5kZXJPYmplY3QuY3BwOgorICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJPYmplY3Qu aDoKKwogMjAxMy0wMy0xOSAgQW5rdXIgVGFseSAgPGF0YWx5QGdvb2dsZS5jb20+CiAKICAgICAg ICAgQ2FjaGUgYSBwb2ludGVyIHRvIFY4RE9NQWN0aXZpdHlMb2dnZXIgaW4gUGVyQ29udGV4dERh dGEuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQm94LmggYi9T b3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQm94LmgKaW5kZXggOTM3MmViNWIxYzhjYzYy NmZhYzU2NDNlZWI2NTQ1NjNkMzdlNTljZi4uM2Q4NWRiNjhiMzNkMDFlNDQ0OGZhOGJmNjExZThj YTM4ZTI5MjY1ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJv eC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCb3guaApAQCAtMzc3LDgg KzM3Nyw4IEBAIHB1YmxpYzoKIAogICAgIHZpcnR1YWwgTGF5b3V0UmVjdCBjbGlwcGVkT3ZlcmZs b3dSZWN0Rm9yUmVwYWludChjb25zdCBSZW5kZXJMYXllck1vZGVsT2JqZWN0KiByZXBhaW50Q29u dGFpbmVyKSBjb25zdCBPVkVSUklERTsKICAgICB2aXJ0dWFsIHZvaWQgY29tcHV0ZVJlY3RGb3JS ZXBhaW50KGNvbnN0IFJlbmRlckxheWVyTW9kZWxPYmplY3QqIHJlcGFpbnRDb250YWluZXIsIExh eW91dFJlY3QmLCBib29sIGZpeGVkID0gZmFsc2UpIGNvbnN0IE9WRVJSSURFOwotCi0gICAgdmly dHVhbCB2b2lkIHJlcGFpbnREdXJpbmdMYXlvdXRJZk1vdmVkKGNvbnN0IExheW91dFJlY3QmKTsK KyAgICB2b2lkIHJlcGFpbnREdXJpbmdMYXlvdXRJZk1vdmVkKGNvbnN0IExheW91dFJlY3QmKTsK KyAgICB2aXJ0dWFsIHZvaWQgcmVwYWludE92ZXJoYW5naW5nRmxvYXRzKGJvb2wgcGFpbnRBbGxE ZXNjZW5kYW50cyA9IGZhbHNlKSB7IH07CiAKICAgICB2aXJ0dWFsIExheW91dFVuaXQgY29udGFp bmluZ0Jsb2NrTG9naWNhbFdpZHRoRm9yQ29udGVudCgpIGNvbnN0OwogICAgIExheW91dFVuaXQg Y29udGFpbmluZ0Jsb2NrTG9naWNhbEhlaWdodEZvckNvbnRlbnQoQXZhaWxhYmxlTG9naWNhbEhl aWdodFR5cGUpIGNvbnN0OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1Jl bmRlck9iamVjdC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyT2JqZWN0LmNw cAppbmRleCA1NDcwM2NmYWMwNTUyNTUxNDEwMjUxOWU0ZGMwYjUzYmM1ZGFhMDQwLi5iNDY5MTJh M2VhNGI4OTdmN2EwOTVlMzlkNDIyZmE3MGE5ODcwNWFkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9yZW5kZXJpbmcvUmVuZGVyT2JqZWN0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5k ZXJpbmcvUmVuZGVyT2JqZWN0LmNwcApAQCAtMTUxMCwxNCArMTUxMCw2IEBAIGJvb2wgUmVuZGVy T2JqZWN0OjpyZXBhaW50QWZ0ZXJMYXlvdXRJZk5lZWRlZChjb25zdCBSZW5kZXJMYXllck1vZGVs T2JqZWN0KiByZXBhCiAgICAgcmV0dXJuIGZhbHNlOwogfQogCi12b2lkIFJlbmRlck9iamVjdDo6 cmVwYWludER1cmluZ0xheW91dElmTW92ZWQoY29uc3QgTGF5b3V0UmVjdCYpCi17Ci19Ci0KLXZv aWQgUmVuZGVyT2JqZWN0OjpyZXBhaW50T3ZlcmhhbmdpbmdGbG9hdHMoYm9vbCkKLXsKLX0KLQog Ym9vbCBSZW5kZXJPYmplY3Q6OmNoZWNrRm9yUmVwYWludER1cmluZ0xheW91dCgpIGNvbnN0CiB7 CiAgICAgcmV0dXJuICFkb2N1bWVudCgpLT52aWV3KCktPm5lZWRzRnVsbFJlcGFpbnQoKSAmJiAh aGFzTGF5ZXIoKSAmJiBldmVySGFkTGF5b3V0KCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9yZW5kZXJpbmcvUmVuZGVyT2JqZWN0LmggYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVu ZGVyT2JqZWN0LmgKaW5kZXggNzNiYzdmZWFiODQxZDEzZTdhNDc0YzQ2ZWM3NjVmNTliN2UzMmVj ZC4uZDJlZWM5MmZhNjAxNWJmMzUzY2U0N2JjMWExMDkwYzhhODM0M2ZiMCAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck9iamVjdC5oCisrKyBiL1NvdXJjZS9XZWJD b3JlL3JlbmRlcmluZy9SZW5kZXJPYmplY3QuaApAQCAtODQ0LDEyICs4NDQsNiBAQCBwdWJsaWM6 CiAgICAgLy8gUmVwYWludCBvbmx5IGlmIG91ciBvbGQgYm91bmRzIGFuZCBuZXcgYm91bmRzIGFy ZSBkaWZmZXJlbnQuIFRoZSBjYWxsZXIgbWF5IHBhc3MgaW4gbmV3Qm91bmRzIGFuZCBuZXdPdXRs aW5lQm94IGlmIHRoZXkgYXJlIGtub3duLgogICAgIGJvb2wgcmVwYWludEFmdGVyTGF5b3V0SWZO ZWVkZWQoY29uc3QgUmVuZGVyTGF5ZXJNb2RlbE9iamVjdCogcmVwYWludENvbnRhaW5lciwgY29u c3QgTGF5b3V0UmVjdCYgb2xkQm91bmRzLCBjb25zdCBMYXlvdXRSZWN0JiBvbGRPdXRsaW5lQm94 LCBjb25zdCBMYXlvdXRSZWN0KiBuZXdCb3VuZHNQdHIgPSAwLCBjb25zdCBMYXlvdXRSZWN0KiBu ZXdPdXRsaW5lQm94UHRyID0gMCk7CiAKLSAgICAvLyBSZXBhaW50IG9ubHkgaWYgdGhlIG9iamVj dCBtb3ZlZC4KLSAgICB2aXJ0dWFsIHZvaWQgcmVwYWludER1cmluZ0xheW91dElmTW92ZWQoY29u c3QgTGF5b3V0UmVjdCYpOwotCi0gICAgLy8gQ2FsbGVkIHRvIHJlcGFpbnQgYSBibG9jaydzIGZs b2F0cy4KLSAgICB2aXJ0dWFsIHZvaWQgcmVwYWludE92ZXJoYW5naW5nRmxvYXRzKGJvb2wgcGFp bnRBbGxEZXNjZW5kYW50cyA9IGZhbHNlKTsKLQogICAgIGJvb2wgY2hlY2tGb3JSZXBhaW50RHVy aW5nTGF5b3V0KCkgY29uc3Q7CiAKICAgICAvLyBSZXR1cm5zIHRoZSByZWN0IHRoYXQgc2hvdWxk IGJlIHJlcGFpbnRlZCB3aGVuZXZlciB0aGlzIG9iamVjdCBjaGFuZ2VzLiAgVGhlIHJlY3QgaXMg aW4gdGhlIHZpZXcncwo= 193978 2013-03-19 20:55:04 -0700 2013-03-20 11:55:14 -0700 fix mac build bug-112773-20130319205055.patch text/plain 4441 ojan U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ2Mjk2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTk0ZTg0ZDk5Zjc5NTk5 OTFhMGJjM2FhNzNlY2YwZTYwZTc3NTExZi4uZmExYmY5MTc5OGY5ZWZjMDNkZWQ5NzkzNzgyMzFj YjgyMzBiYWQ3OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEzLTAzLTE5ICBPamFu IFZhZmFpICA8b2phbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgTW92ZSByZXBhaW50IG1ldGhv ZHMgZnJvbSBSZW5kZXJPYmplY3QgdG8gUmVuZGVyQm94CisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTI3NzMKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICByZXBhaW50T3ZlcmhhbmdpbmdGbG9hdHMgYW5kIHJl cGFpbnREdXJpbmdMYXlvdXRJZk1vdmVkIGFyZSBvbmx5IGV2ZXIgY2FsbGVkCisgICAgICAgIG9u IFJlbmRlckJveGVzLCBzbyBkb24ndCBuZWVkIHRvIGJlIG9uIFJlbmRlck9iamVjdC4gVGhpcyBh bHNvIGxldHMgdXMKKyAgICAgICAgZGV2aXJ0dWFsaXplIHJlcGFpbnREdXJpbmdMYXlvdXRJZk1v dmVkLgorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckJveC5oOgorICAgICAgICAoV2ViQ29y ZTo6UmVuZGVyQm94OjpyZXBhaW50T3ZlcmhhbmdpbmdGbG9hdHMpOgorICAgICAgICAqIHJlbmRl cmluZy9SZW5kZXJPYmplY3QuY3BwOgorICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJPYmplY3Qu aDoKKwogMjAxMy0wMy0xOSAgQW5rdXIgVGFseSAgPGF0YWx5QGdvb2dsZS5jb20+CiAKICAgICAg ICAgQ2FjaGUgYSBwb2ludGVyIHRvIFY4RE9NQWN0aXZpdHlMb2dnZXIgaW4gUGVyQ29udGV4dERh dGEuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2suY3Bw IGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrLmNwcAppbmRleCA5MDc1ZTEw YTUxZWNmYjQ5MDM1Yjg4OTZjZmY5Njc4M2ZjZDRlM2VjLi4zN2IxMDNlMmRkN2ExMjJiNzQ4OWQx YTQ1YTQzOGI4MTE0Zjk2ZTkxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcv UmVuZGVyQmxvY2suY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9j ay5jcHAKQEAgLTI4NDUsNyArMjg0NSw3IEBAIHZvaWQgUmVuZGVyQmxvY2s6OnJlcGFpbnRPdmVy aGFuZ2luZ0Zsb2F0cyhib29sIHBhaW50QWxsRGVzY2VuZGFudHMpCiAgICAgICAgIC8vIGNvbmRp dGlvbiBpcyByZXBsYWNlZCB3aXRoIGJlaW5nIGEgZGVzY2VuZGFudCBvZiB1cy4KICAgICAgICAg aWYgKGxvZ2ljYWxCb3R0b21Gb3JGbG9hdChyKSA+IGxvZ2ljYWxIZWlnaHQoKSAmJiAoKHBhaW50 QWxsRGVzY2VuZGFudHMgJiYgci0+bV9yZW5kZXJlci0+aXNEZXNjZW5kYW50T2YodGhpcykpIHx8 IHItPnNob3VsZFBhaW50KCkpICYmICFyLT5tX3JlbmRlcmVyLT5oYXNTZWxmUGFpbnRpbmdMYXll cigpKSB7CiAgICAgICAgICAgICByLT5tX3JlbmRlcmVyLT5yZXBhaW50KCk7Ci0gICAgICAgICAg ICByLT5tX3JlbmRlcmVyLT5yZXBhaW50T3ZlcmhhbmdpbmdGbG9hdHMoKTsKKyAgICAgICAgICAg IHItPm1fcmVuZGVyZXItPnJlcGFpbnRPdmVyaGFuZ2luZ0Zsb2F0cyhmYWxzZSk7CiAgICAgICAg IH0KICAgICB9CiB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy Qm94LmggYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQm94LmgKaW5kZXggOTM3MmVi NWIxYzhjYzYyNmZhYzU2NDNlZWI2NTQ1NjNkMzdlNTljZi4uNTA4ZDFiNDU1NTFkYWQyZjk2ODEz ODYyYzBmZTQ3N2ViYWMxMDY0NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlckJveC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCb3guaApA QCAtMzc3LDggKzM3Nyw4IEBAIHB1YmxpYzoKIAogICAgIHZpcnR1YWwgTGF5b3V0UmVjdCBjbGlw cGVkT3ZlcmZsb3dSZWN0Rm9yUmVwYWludChjb25zdCBSZW5kZXJMYXllck1vZGVsT2JqZWN0KiBy ZXBhaW50Q29udGFpbmVyKSBjb25zdCBPVkVSUklERTsKICAgICB2aXJ0dWFsIHZvaWQgY29tcHV0 ZVJlY3RGb3JSZXBhaW50KGNvbnN0IFJlbmRlckxheWVyTW9kZWxPYmplY3QqIHJlcGFpbnRDb250 YWluZXIsIExheW91dFJlY3QmLCBib29sIGZpeGVkID0gZmFsc2UpIGNvbnN0IE9WRVJSSURFOwot Ci0gICAgdmlydHVhbCB2b2lkIHJlcGFpbnREdXJpbmdMYXlvdXRJZk1vdmVkKGNvbnN0IExheW91 dFJlY3QmKTsKKyAgICB2b2lkIHJlcGFpbnREdXJpbmdMYXlvdXRJZk1vdmVkKGNvbnN0IExheW91 dFJlY3QmKTsKKyAgICB2aXJ0dWFsIHZvaWQgcmVwYWludE92ZXJoYW5naW5nRmxvYXRzKGJvb2wp IHsgfTsKIAogICAgIHZpcnR1YWwgTGF5b3V0VW5pdCBjb250YWluaW5nQmxvY2tMb2dpY2FsV2lk dGhGb3JDb250ZW50KCkgY29uc3Q7CiAgICAgTGF5b3V0VW5pdCBjb250YWluaW5nQmxvY2tMb2dp Y2FsSGVpZ2h0Rm9yQ29udGVudChBdmFpbGFibGVMb2dpY2FsSGVpZ2h0VHlwZSkgY29uc3Q7CmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyT2JqZWN0LmNwcCBiL1Nv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJPYmplY3QuY3BwCmluZGV4IDU0NzAzY2ZhYzA1 NTI1NTE0MTAyNTE5ZTRkYzBiNTNiYzVkYWEwNDAuLmI0NjkxMmEzZWE0Yjg5N2Y3YTA5NWUzOWQ0 MjJmYTcwYTk4NzA1YWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5k ZXJPYmplY3QuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJPYmplY3Qu Y3BwCkBAIC0xNTEwLDE0ICsxNTEwLDYgQEAgYm9vbCBSZW5kZXJPYmplY3Q6OnJlcGFpbnRBZnRl ckxheW91dElmTmVlZGVkKGNvbnN0IFJlbmRlckxheWVyTW9kZWxPYmplY3QqIHJlcGEKICAgICBy ZXR1cm4gZmFsc2U7CiB9CiAKLXZvaWQgUmVuZGVyT2JqZWN0OjpyZXBhaW50RHVyaW5nTGF5b3V0 SWZNb3ZlZChjb25zdCBMYXlvdXRSZWN0JikKLXsKLX0KLQotdm9pZCBSZW5kZXJPYmplY3Q6OnJl cGFpbnRPdmVyaGFuZ2luZ0Zsb2F0cyhib29sKQotewotfQotCiBib29sIFJlbmRlck9iamVjdDo6 Y2hlY2tGb3JSZXBhaW50RHVyaW5nTGF5b3V0KCkgY29uc3QKIHsKICAgICByZXR1cm4gIWRvY3Vt ZW50KCktPnZpZXcoKS0+bmVlZHNGdWxsUmVwYWludCgpICYmICFoYXNMYXllcigpICYmIGV2ZXJI YWRMYXlvdXQoKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJP YmplY3QuaCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJPYmplY3QuaAppbmRleCA3 M2JjN2ZlYWI4NDFkMTNlN2E0NzRjNDZlYzc2NWY1OWI3ZTMyZWNkLi5kMmVlYzkyZmE2MDE1YmYz NTNjZTQ3YmMxYTEwOTBjOGE4MzQzZmIwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5k ZXJpbmcvUmVuZGVyT2JqZWN0LmgKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRl ck9iamVjdC5oCkBAIC04NDQsMTIgKzg0NCw2IEBAIHB1YmxpYzoKICAgICAvLyBSZXBhaW50IG9u bHkgaWYgb3VyIG9sZCBib3VuZHMgYW5kIG5ldyBib3VuZHMgYXJlIGRpZmZlcmVudC4gVGhlIGNh bGxlciBtYXkgcGFzcyBpbiBuZXdCb3VuZHMgYW5kIG5ld091dGxpbmVCb3ggaWYgdGhleSBhcmUg a25vd24uCiAgICAgYm9vbCByZXBhaW50QWZ0ZXJMYXlvdXRJZk5lZWRlZChjb25zdCBSZW5kZXJM YXllck1vZGVsT2JqZWN0KiByZXBhaW50Q29udGFpbmVyLCBjb25zdCBMYXlvdXRSZWN0JiBvbGRC b3VuZHMsIGNvbnN0IExheW91dFJlY3QmIG9sZE91dGxpbmVCb3gsIGNvbnN0IExheW91dFJlY3Qq IG5ld0JvdW5kc1B0ciA9IDAsIGNvbnN0IExheW91dFJlY3QqIG5ld091dGxpbmVCb3hQdHIgPSAw KTsKIAotICAgIC8vIFJlcGFpbnQgb25seSBpZiB0aGUgb2JqZWN0IG1vdmVkLgotICAgIHZpcnR1 YWwgdm9pZCByZXBhaW50RHVyaW5nTGF5b3V0SWZNb3ZlZChjb25zdCBMYXlvdXRSZWN0Jik7Ci0K LSAgICAvLyBDYWxsZWQgdG8gcmVwYWludCBhIGJsb2NrJ3MgZmxvYXRzLgotICAgIHZpcnR1YWwg dm9pZCByZXBhaW50T3ZlcmhhbmdpbmdGbG9hdHMoYm9vbCBwYWludEFsbERlc2NlbmRhbnRzID0g ZmFsc2UpOwotCiAgICAgYm9vbCBjaGVja0ZvclJlcGFpbnREdXJpbmdMYXlvdXQoKSBjb25zdDsK IAogICAgIC8vIFJldHVybnMgdGhlIHJlY3QgdGhhdCBzaG91bGQgYmUgcmVwYWludGVkIHdoZW5l dmVyIHRoaXMgb2JqZWN0IGNoYW5nZXMuICBUaGUgcmVjdCBpcyBpbiB0aGUgdmlldydzCg== 194093 2013-03-20 11:55:18 -0700 2013-03-20 12:24:41 -0700 Patch for landing bug-112773-20130320115107.patch text/plain 5896 ojan U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ2Mjk2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTk0ZTg0ZDk5Zjc5NTk5 OTFhMGJjM2FhNzNlY2YwZTYwZTc3NTExZi4uY2Q4ZDI2NjAyMzU0OGU4OTBlYzA2NjE5YzE2MTQx MmMzZTgzODRjNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEzLTAzLTE5ICBPamFu IFZhZmFpICA8b2phbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgTW92ZSByZXBhaW50IG1ldGhv ZHMgZnJvbSBSZW5kZXJPYmplY3QgdG8gUmVuZGVyQm94CisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTI3NzMKKworICAgICAgICBSZXZpZXdlZCBieSBK dWxpZW4gQ2hhZmZyYWl4LgorCisgICAgICAgIHJlcGFpbnRPdmVyaGFuZ2luZ0Zsb2F0cyBhbmQg cmVwYWludER1cmluZ0xheW91dElmTW92ZWQgYXJlIG9ubHkgZXZlciBjYWxsZWQKKyAgICAgICAg b24gUmVuZGVyQm94ZXMsIHNvIGRvbid0IG5lZWQgdG8gYmUgb24gUmVuZGVyT2JqZWN0LiBUaGlz IGFsc28gbGV0cyB1cworICAgICAgICBkZXZpcnR1YWxpemUgcmVwYWludER1cmluZ0xheW91dElm TW92ZWQuCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyQm94Lmg6CisgICAgICAgIChXZWJD b3JlOjpSZW5kZXJCb3g6OnJlcGFpbnRPdmVyaGFuZ2luZ0Zsb2F0cyk6CisgICAgICAgICogcmVu ZGVyaW5nL1JlbmRlck9iamVjdC5jcHA6CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlck9iamVj dC5oOgorCiAyMDEzLTAzLTE5ICBBbmt1ciBUYWx5ICA8YXRhbHlAZ29vZ2xlLmNvbT4KIAogICAg ICAgICBDYWNoZSBhIHBvaW50ZXIgdG8gVjhET01BY3Rpdml0eUxvZ2dlciBpbiBQZXJDb250ZXh0 RGF0YS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9jay5j cHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2suY3BwCmluZGV4IDkwNzVl MTBhNTFlY2ZiNDkwMzViODg5NmNmZjk2NzgzZmNkNGUzZWMuLjM3YjEwM2UyZGQ3YTEyMmI3NDg5 ZDFhNDVhNDM4YjgxMTRmOTZlOTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmlu Zy9SZW5kZXJCbG9jay5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJs b2NrLmNwcApAQCAtMjg0NSw3ICsyODQ1LDcgQEAgdm9pZCBSZW5kZXJCbG9jazo6cmVwYWludE92 ZXJoYW5naW5nRmxvYXRzKGJvb2wgcGFpbnRBbGxEZXNjZW5kYW50cykKICAgICAgICAgLy8gY29u ZGl0aW9uIGlzIHJlcGxhY2VkIHdpdGggYmVpbmcgYSBkZXNjZW5kYW50IG9mIHVzLgogICAgICAg ICBpZiAobG9naWNhbEJvdHRvbUZvckZsb2F0KHIpID4gbG9naWNhbEhlaWdodCgpICYmICgocGFp bnRBbGxEZXNjZW5kYW50cyAmJiByLT5tX3JlbmRlcmVyLT5pc0Rlc2NlbmRhbnRPZih0aGlzKSkg fHwgci0+c2hvdWxkUGFpbnQoKSkgJiYgIXItPm1fcmVuZGVyZXItPmhhc1NlbGZQYWludGluZ0xh eWVyKCkpIHsKICAgICAgICAgICAgIHItPm1fcmVuZGVyZXItPnJlcGFpbnQoKTsKLSAgICAgICAg ICAgIHItPm1fcmVuZGVyZXItPnJlcGFpbnRPdmVyaGFuZ2luZ0Zsb2F0cygpOworICAgICAgICAg ICAgci0+bV9yZW5kZXJlci0+cmVwYWludE92ZXJoYW5naW5nRmxvYXRzKGZhbHNlKTsKICAgICAg ICAgfQogICAgIH0KIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5k ZXJCbG9jay5oIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrLmgKaW5kZXgg NzRiZDUzNzM0MDg1MmUwZGY5ZDVlY2E5YTk3ZWFlMTI4ODhjNDIwMS4uMDZlZjM4MzA0MzA1MTFm Njg1ZGUxY2MxNGUzY2Q2YjViMTBjYzdjNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVu ZGVyaW5nL1JlbmRlckJsb2NrLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRl ckJsb2NrLmgKQEAgLTYxMiw3ICs2MTIsNyBAQCBwcml2YXRlOgogICAgIHZpcnR1YWwgTGF5b3V0 VW5pdCBjb2xsYXBzZWRNYXJnaW5CZWZvcmUoKSBjb25zdCB7IHJldHVybiBtYXhQb3NpdGl2ZU1h cmdpbkJlZm9yZSgpIC0gbWF4TmVnYXRpdmVNYXJnaW5CZWZvcmUoKTsgfQogICAgIHZpcnR1YWwg TGF5b3V0VW5pdCBjb2xsYXBzZWRNYXJnaW5BZnRlcigpIGNvbnN0IHsgcmV0dXJuIG1heFBvc2l0 aXZlTWFyZ2luQWZ0ZXIoKSAtIG1heE5lZ2F0aXZlTWFyZ2luQWZ0ZXIoKTsgfQogCi0gICAgdmly dHVhbCB2b2lkIHJlcGFpbnRPdmVyaGFuZ2luZ0Zsb2F0cyhib29sIHBhaW50QWxsRGVzY2VuZGFu dHMpOworICAgIHZpcnR1YWwgdm9pZCByZXBhaW50T3ZlcmhhbmdpbmdGbG9hdHMoYm9vbCBwYWlu dEFsbERlc2NlbmRhbnRzKSBPVkVSUklERTsKIAogICAgIHZvaWQgbGF5b3V0QmxvY2tDaGlsZHJl bihib29sIHJlbGF5b3V0Q2hpbGRyZW4sIExheW91dFVuaXQmIG1heEZsb2F0TG9naWNhbEJvdHRv bSk7CiAgICAgdm9pZCBsYXlvdXRJbmxpbmVDaGlsZHJlbihib29sIHJlbGF5b3V0Q2hpbGRyZW4s IExheW91dFVuaXQmIHJlcGFpbnRMb2dpY2FsVG9wLCBMYXlvdXRVbml0JiByZXBhaW50TG9naWNh bEJvdHRvbSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQm94 LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCb3guY3BwCmluZGV4IDRlMWNm NTg3ZTNjZjVjODhlMmUzZDE4NDNkZjhmY2Y1MWM2ZDFlMDUuLjgxYWM5Yzg3NDQzYWEzMzI3N2U3 NDg2OGZkNWFjOTkyNzAyMDRlMWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmlu Zy9SZW5kZXJCb3guY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCb3gu Y3BwCkBAIC0yMDEzLDYgKzIwMTMsMTAgQEAgdm9pZCBSZW5kZXJCb3g6OnJlcGFpbnREdXJpbmdM YXlvdXRJZk1vdmVkKGNvbnN0IExheW91dFJlY3QmIG9sZFJlY3QpCiAgICAgfQogfQogCit2b2lk IFJlbmRlckJveDo6cmVwYWludE92ZXJoYW5naW5nRmxvYXRzKGJvb2wpCit7Cit9CisKIHZvaWQg UmVuZGVyQm94Ojp1cGRhdGVMb2dpY2FsV2lkdGgoKQogewogICAgIExvZ2ljYWxFeHRlbnRDb21w dXRlZFZhbHVlcyBjb21wdXRlZFZhbHVlczsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9SZW5kZXJCb3guaCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCb3gu aAppbmRleCA5MzcyZWI1YjFjOGNjNjI2ZmFjNTY0M2VlYjY1NDU2M2QzN2U1OWNmLi5jNjUzOGRj MjQ1MWY2YWNlYjc1ZTJjMTA0ZmFhYzljMDc2MjI0ZTk4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9yZW5kZXJpbmcvUmVuZGVyQm94LmgKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlckJveC5oCkBAIC0zNzcsOCArMzc3LDggQEAgcHVibGljOgogCiAgICAgdmlydHVhbCBM YXlvdXRSZWN0IGNsaXBwZWRPdmVyZmxvd1JlY3RGb3JSZXBhaW50KGNvbnN0IFJlbmRlckxheWVy TW9kZWxPYmplY3QqIHJlcGFpbnRDb250YWluZXIpIGNvbnN0IE9WRVJSSURFOwogICAgIHZpcnR1 YWwgdm9pZCBjb21wdXRlUmVjdEZvclJlcGFpbnQoY29uc3QgUmVuZGVyTGF5ZXJNb2RlbE9iamVj dCogcmVwYWludENvbnRhaW5lciwgTGF5b3V0UmVjdCYsIGJvb2wgZml4ZWQgPSBmYWxzZSkgY29u c3QgT1ZFUlJJREU7Ci0KLSAgICB2aXJ0dWFsIHZvaWQgcmVwYWludER1cmluZ0xheW91dElmTW92 ZWQoY29uc3QgTGF5b3V0UmVjdCYpOworICAgIHZvaWQgcmVwYWludER1cmluZ0xheW91dElmTW92 ZWQoY29uc3QgTGF5b3V0UmVjdCYpOworICAgIHZpcnR1YWwgdm9pZCByZXBhaW50T3Zlcmhhbmdp bmdGbG9hdHMoYm9vbCBwYWludEFsbERlc2NlbmRhbnRzKTsKIAogICAgIHZpcnR1YWwgTGF5b3V0 VW5pdCBjb250YWluaW5nQmxvY2tMb2dpY2FsV2lkdGhGb3JDb250ZW50KCkgY29uc3Q7CiAgICAg TGF5b3V0VW5pdCBjb250YWluaW5nQmxvY2tMb2dpY2FsSGVpZ2h0Rm9yQ29udGVudChBdmFpbGFi bGVMb2dpY2FsSGVpZ2h0VHlwZSkgY29uc3Q7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9y ZW5kZXJpbmcvUmVuZGVyT2JqZWN0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5k ZXJPYmplY3QuY3BwCmluZGV4IDU0NzAzY2ZhYzA1NTI1NTE0MTAyNTE5ZTRkYzBiNTNiYzVkYWEw NDAuLmI0NjkxMmEzZWE0Yjg5N2Y3YTA5NWUzOWQ0MjJmYTcwYTk4NzA1YWQgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJPYmplY3QuY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJPYmplY3QuY3BwCkBAIC0xNTEwLDE0ICsxNTEwLDYgQEAg Ym9vbCBSZW5kZXJPYmplY3Q6OnJlcGFpbnRBZnRlckxheW91dElmTmVlZGVkKGNvbnN0IFJlbmRl ckxheWVyTW9kZWxPYmplY3QqIHJlcGEKICAgICByZXR1cm4gZmFsc2U7CiB9CiAKLXZvaWQgUmVu ZGVyT2JqZWN0OjpyZXBhaW50RHVyaW5nTGF5b3V0SWZNb3ZlZChjb25zdCBMYXlvdXRSZWN0JikK LXsKLX0KLQotdm9pZCBSZW5kZXJPYmplY3Q6OnJlcGFpbnRPdmVyaGFuZ2luZ0Zsb2F0cyhib29s KQotewotfQotCiBib29sIFJlbmRlck9iamVjdDo6Y2hlY2tGb3JSZXBhaW50RHVyaW5nTGF5b3V0 KCkgY29uc3QKIHsKICAgICByZXR1cm4gIWRvY3VtZW50KCktPnZpZXcoKS0+bmVlZHNGdWxsUmVw YWludCgpICYmICFoYXNMYXllcigpICYmIGV2ZXJIYWRMYXlvdXQoKTsKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJPYmplY3QuaCBiL1NvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9SZW5kZXJPYmplY3QuaAppbmRleCA3M2JjN2ZlYWI4NDFkMTNlN2E0NzRjNDZlYzc2 NWY1OWI3ZTMyZWNkLi5kMmVlYzkyZmE2MDE1YmYzNTNjZTQ3YmMxYTEwOTBjOGE4MzQzZmIwIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyT2JqZWN0LmgKKysrIGIv U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck9iamVjdC5oCkBAIC04NDQsMTIgKzg0NCw2 IEBAIHB1YmxpYzoKICAgICAvLyBSZXBhaW50IG9ubHkgaWYgb3VyIG9sZCBib3VuZHMgYW5kIG5l dyBib3VuZHMgYXJlIGRpZmZlcmVudC4gVGhlIGNhbGxlciBtYXkgcGFzcyBpbiBuZXdCb3VuZHMg YW5kIG5ld091dGxpbmVCb3ggaWYgdGhleSBhcmUga25vd24uCiAgICAgYm9vbCByZXBhaW50QWZ0 ZXJMYXlvdXRJZk5lZWRlZChjb25zdCBSZW5kZXJMYXllck1vZGVsT2JqZWN0KiByZXBhaW50Q29u dGFpbmVyLCBjb25zdCBMYXlvdXRSZWN0JiBvbGRCb3VuZHMsIGNvbnN0IExheW91dFJlY3QmIG9s ZE91dGxpbmVCb3gsIGNvbnN0IExheW91dFJlY3QqIG5ld0JvdW5kc1B0ciA9IDAsIGNvbnN0IExh eW91dFJlY3QqIG5ld091dGxpbmVCb3hQdHIgPSAwKTsKIAotICAgIC8vIFJlcGFpbnQgb25seSBp ZiB0aGUgb2JqZWN0IG1vdmVkLgotICAgIHZpcnR1YWwgdm9pZCByZXBhaW50RHVyaW5nTGF5b3V0 SWZNb3ZlZChjb25zdCBMYXlvdXRSZWN0Jik7Ci0KLSAgICAvLyBDYWxsZWQgdG8gcmVwYWludCBh IGJsb2NrJ3MgZmxvYXRzLgotICAgIHZpcnR1YWwgdm9pZCByZXBhaW50T3ZlcmhhbmdpbmdGbG9h dHMoYm9vbCBwYWludEFsbERlc2NlbmRhbnRzID0gZmFsc2UpOwotCiAgICAgYm9vbCBjaGVja0Zv clJlcGFpbnREdXJpbmdMYXlvdXQoKSBjb25zdDsKIAogICAgIC8vIFJldHVybnMgdGhlIHJlY3Qg dGhhdCBzaG91bGQgYmUgcmVwYWludGVkIHdoZW5ldmVyIHRoaXMgb2JqZWN0IGNoYW5nZXMuICBU aGUgcmVjdCBpcyBpbiB0aGUgdmlldydzCg==