112760 2013-03-19 17:54:40 -0700 do not use string reference for enum support in CodeGeneratorJS.pm 2013-03-20 10:55:35 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 a.renevier a.renevier abarth darin haraken japhet webkit.review.bot oldest_to_newest 858917 0 a.renevier 2013-03-19 17:54:40 -0700 Hi, as discussed in bug #112475 comment 13, this is about not using String reference in generated binding for enum values. 858920 1 193958 a.renevier 2013-03-19 17:56:27 -0700 Created attachment 193958 patch proposal 858926 2 193958 haraken 2013-03-19 18:03:30 -0700 Comment on attachment 193958 patch proposal Thanks for the quick fix. 858982 3 193958 webkit.review.bot 2013-03-19 19:13:44 -0700 Comment on attachment 193958 patch proposal Clearing flags on attachment: 193958 Committed r146292: <http://trac.webkit.org/changeset/146292> 858983 4 webkit.review.bot 2013-03-19 19:13:47 -0700 All reviewed patches have been landed. Closing bug. 859550 5 193958 darin 2013-03-20 10:55:35 -0700 Comment on attachment 193958 patch proposal View in context: https://bugs.webkit.org/attachment.cgi?id=193958&action=review > Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:2147 > + push(@implContent, " const String string = value.isEmpty() ? String() : value.toString(exec)->value(exec);\n"); Not sure why the const is here. It’s OK, but unneeded. > Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:2789 > + push(@$outputArray, " const String ${name}(${argValue}.isEmpty() ? String() : ${argValue}.toString(exec)->value(exec));\n"); Ditto. 193958 2013-03-19 17:56:27 -0700 2013-03-20 10:55:35 -0700 patch proposal bug-112760-20130319175215.patch text/plain 4334 a.renevier U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ2MjgyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjAwOTA5OGEyMjA4YWZm Nzc3OGY5YjJjZDc2YmM0MjMwN2ZkMjU5ZC4uMmE3ZTVlM2FhZjgxNzJmYjRmNjAxZGQ4N2YzMWY5 NGIxZWY2NTEyYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEzLTAzLTE5ICBBcm5h dWQgUmVuZXZpZXIgIDxhLnJlbmV2aWVyQHNpc2Euc2Ftc3VuZy5jb20+CisKKyAgICAgICAgZG8g bm90IHVzZSBzdHJpbmcgcmVmZXJlbmNlIGZvciBlbnVtIHN1cHBvcnQgaW4gQ29kZUdlbmVyYXRv ckpTLnBtCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x MTI3NjAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBE byB1c2Ugc3RyaW5nIHJlZmVyZW5jZXMgaW4gZ2VuZXJhdGVkIEpTIGJpbmRpbmdzIGZvciBlbnVt IHZhbHVlcy4KKworICAgICAgICBUZXN0OiBiaW5kaW5ncy9zY3JpcHRzL3Rlc3QvVGVzdE9iai5p ZGwKKworICAgICAgICAqIGJpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckpTLnBtOgorICAg ICAgICAoR2VuZXJhdGVJbXBsZW1lbnRhdGlvbik6CisgICAgICAgIChHZW5lcmF0ZVBhcmFtZXRl cnNDaGVjayk6CisgICAgICAgICogYmluZGluZ3Mvc2NyaXB0cy90ZXN0L0pTL0pTVGVzdE9iai5j cHA6CisgICAgICAgIChXZWJDb3JlOjpzZXRKU1Rlc3RPYmpFbnVtQXR0cik6CisgICAgICAgIChX ZWJDb3JlOjpqc1Rlc3RPYmpQcm90b3R5cGVGdW5jdGlvbk1ldGhvZFdpdGhFbnVtQXJnKToKKwog MjAxMy0wMy0xMSAgQXJuYXVkIFJlbmV2aWVyICA8YS5yZW5ldmllckBzaXNhLnNhbXN1bmcuY29t PgogCiAgICAgICAgIFdoaXRlc3BhY2UgaW4gcGFydGljdWxhciBzb3VyY2UgY29kZSBjaGFuZ2Vz IHJlbmRlcmluZzsgZG9lcyBub3QgaW4gRmlyZWZveApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9ySlMucG0gYi9Tb3VyY2UvV2ViQ29yZS9i aW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JKUy5wbQppbmRleCAyNzBkMmJiNjM4YTVjOWQ3 YzgwMTliNzBiNjk0NTlhMmY5MWRlNDYyLi44MDYyZWJmNzhhYmIzNWIxOWY2OTU0MzFiZjQ1MTJl ZTlmNzgwNDA3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0Nv ZGVHZW5lcmF0b3JKUy5wbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0Nv ZGVHZW5lcmF0b3JKUy5wbQpAQCAtMjE0NCw3ICsyMTQ0LDcgQEAgc3ViIEdlbmVyYXRlSW1wbGVt ZW50YXRpb24KIAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBteSAkbmF0aXZlVmFs dWU7CiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGlmICgkY29kZUdlbmVyYXRvci0+ SXNFbnVtVHlwZSgkdHlwZSkpIHsKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IHB1c2goQGltcGxDb250ZW50LCAiICAgIFN0cmluZyYgc3RyaW5nID0gdmFsdWUuaXNFbXB0eSgp ID8gU3RyaW5nKCkgOiB2YWx1ZS50b1N0cmluZyhleGVjKS0+dmFsdWUoZXhlYyk7XG4iKTsKKyAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHB1c2goQGltcGxDb250ZW50LCAiICAg IGNvbnN0IFN0cmluZyBzdHJpbmcgPSB2YWx1ZS5pc0VtcHR5KCkgPyBTdHJpbmcoKSA6IHZhbHVl LnRvU3RyaW5nKGV4ZWMpLT52YWx1ZShleGVjKTtcbiIpOwogICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgcHVzaChAaW1wbENvbnRlbnQsICIgICAgaWYgKGV4ZWMtPmhhZEV4Y2Vw dGlvbigpKVxuIik7CiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBwdXNoKEBp bXBsQ29udGVudCwgIiAgICAgICAgcmV0dXJuO1xuIik7CiAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICBteSBAZW51bVZhbHVlcyA9ICRjb2RlR2VuZXJhdG9yLT5WYWxpZEVudW1W YWx1ZXMoJHR5cGUpOwpAQCAtMjc4Niw3ICsyNzg2LDcgQEAgc3ViIEdlbmVyYXRlUGFyYW1ldGVy c0NoZWNrCiAgICAgICAgICAgICAkaW1wbEluY2x1ZGVzeyI8cnVudGltZS9FcnJvci5oPiJ9ID0g MTsKIAogICAgICAgICAgICAgbXkgJGFyZ1ZhbHVlID0gImV4ZWMtPmFyZ3VtZW50KCRhcmdzSW5k ZXgpIjsKLSAgICAgICAgICAgIHB1c2goQCRvdXRwdXRBcnJheSwgIiAgICBjb25zdCBTdHJpbmcm ICR7bmFtZX0oJHthcmdWYWx1ZX0uaXNFbXB0eSgpID8gU3RyaW5nKCkgOiAke2FyZ1ZhbHVlfS50 b1N0cmluZyhleGVjKS0+dmFsdWUoZXhlYykpO1xuIik7CisgICAgICAgICAgICBwdXNoKEAkb3V0 cHV0QXJyYXksICIgICAgY29uc3QgU3RyaW5nICR7bmFtZX0oJHthcmdWYWx1ZX0uaXNFbXB0eSgp ID8gU3RyaW5nKCkgOiAke2FyZ1ZhbHVlfS50b1N0cmluZyhleGVjKS0+dmFsdWUoZXhlYykpO1xu Iik7CiAgICAgICAgICAgICBwdXNoKEAkb3V0cHV0QXJyYXksICIgICAgaWYgKGV4ZWMtPmhhZEV4 Y2VwdGlvbigpKVxuIik7CiAgICAgICAgICAgICBwdXNoKEAkb3V0cHV0QXJyYXksICIgICAgICAg IHJldHVybiBKU1ZhbHVlOjplbmNvZGUoanNVbmRlZmluZWQoKSk7XG4iKTsKIApkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy90ZXN0L0pTL0pTVGVzdE9iai5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL3Rlc3QvSlMvSlNUZXN0T2JqLmNwcApp bmRleCBhOWQ0OTkyZjEwZDI5Mjk5ZGYwOThkNDM2M2E0MjcyYjJkN2JmZTVkLi5mMGE3YmQ3ZDY1 MDVkYmFjMjgwMTk1OWMyYWNlZjQ3ODU4NzczZjU3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9iaW5kaW5ncy9zY3JpcHRzL3Rlc3QvSlMvSlNUZXN0T2JqLmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9iaW5kaW5ncy9zY3JpcHRzL3Rlc3QvSlMvSlNUZXN0T2JqLmNwcApAQCAtMTA4NSw3ICsx MDg1LDcgQEAgdm9pZCBzZXRKU1Rlc3RPYmpFbnVtQXR0cihFeGVjU3RhdGUqIGV4ZWMsIEpTT2Jq ZWN0KiB0aGlzT2JqZWN0LCBKU1ZhbHVlIHZhbHVlKQogICAgIFVOVVNFRF9QQVJBTShleGVjKTsK ICAgICBKU1Rlc3RPYmoqIGNhc3RlZFRoaXMgPSBqc0Nhc3Q8SlNUZXN0T2JqKj4odGhpc09iamVj dCk7CiAgICAgVGVzdE9iaiogaW1wbCA9IHN0YXRpY19jYXN0PFRlc3RPYmoqPihjYXN0ZWRUaGlz LT5pbXBsKCkpOwotICAgIFN0cmluZyYgc3RyaW5nID0gdmFsdWUuaXNFbXB0eSgpID8gU3RyaW5n KCkgOiB2YWx1ZS50b1N0cmluZyhleGVjKS0+dmFsdWUoZXhlYyk7CisgICAgY29uc3QgU3RyaW5n IHN0cmluZyA9IHZhbHVlLmlzRW1wdHkoKSA/IFN0cmluZygpIDogdmFsdWUudG9TdHJpbmcoZXhl YyktPnZhbHVlKGV4ZWMpOwogICAgIGlmIChleGVjLT5oYWRFeGNlcHRpb24oKSkKICAgICAgICAg cmV0dXJuOwogICAgIGlmIChzdHJpbmcgIT0gIiIgJiYgc3RyaW5nICE9ICJFbnVtVmFsdWUxIiAm JiBzdHJpbmcgIT0gIkVudW1WYWx1ZTIiICYmIHN0cmluZyAhPSAiRW51bVZhbHVlMyIpCkBAIC0x NzAxLDcgKzE3MDEsNyBAQCBFbmNvZGVkSlNWYWx1ZSBKU0NfSE9TVF9DQUxMIGpzVGVzdE9ialBy b3RvdHlwZUZ1bmN0aW9uTWV0aG9kV2l0aEVudW1BcmcoRXhlY1N0YQogICAgIFRlc3RPYmoqIGlt cGwgPSBzdGF0aWNfY2FzdDxUZXN0T2JqKj4oY2FzdGVkVGhpcy0+aW1wbCgpKTsKICAgICBpZiAo ZXhlYy0+YXJndW1lbnRDb3VudCgpIDwgMSkKICAgICAgICAgcmV0dXJuIHRocm93Vk1FcnJvcihl eGVjLCBjcmVhdGVOb3RFbm91Z2hBcmd1bWVudHNFcnJvcihleGVjKSk7Ci0gICAgY29uc3QgU3Ry aW5nJiBlbnVtQXJnKGV4ZWMtPmFyZ3VtZW50KDApLmlzRW1wdHkoKSA/IFN0cmluZygpIDogZXhl Yy0+YXJndW1lbnQoMCkudG9TdHJpbmcoZXhlYyktPnZhbHVlKGV4ZWMpKTsKKyAgICBjb25zdCBT dHJpbmcgZW51bUFyZyhleGVjLT5hcmd1bWVudCgwKS5pc0VtcHR5KCkgPyBTdHJpbmcoKSA6IGV4 ZWMtPmFyZ3VtZW50KDApLnRvU3RyaW5nKGV4ZWMpLT52YWx1ZShleGVjKSk7CiAgICAgaWYgKGV4 ZWMtPmhhZEV4Y2VwdGlvbigpKQogICAgICAgICByZXR1cm4gSlNWYWx1ZTo6ZW5jb2RlKGpzVW5k ZWZpbmVkKCkpOwogICAgIGlmIChlbnVtQXJnICE9ICIiICYmIGVudW1BcmcgIT0gIkVudW1WYWx1 ZTEiICYmIGVudW1BcmcgIT0gIkVudW1WYWx1ZTIiICYmIGVudW1BcmcgIT0gIkVudW1WYWx1ZTMi KQo=