112745 2013-03-19 14:40:51 -0700 REGRESSION(r146223): chromium asserts/crashes in DocumentLoader 2013-03-19 18:17:37 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 112593 112765 1 japhet japhet abarth kbr koivisto webkit.review.bot oldest_to_newest 858748 0 japhet 2013-03-19 14:40:51 -0700 Issues with r146223: * DocumentLoader::cancelMainResourceLoader() is called directly by the WebKit layer, where ports might send in a null ResourceError. Don't assume the error parameter is non-null. * m_frame->page()->defersLoading() isn't safe in all functions, turns out at least some of these checks can happen after detach. * responseReceived() needs its RefPtr back. 858753 1 193926 japhet 2013-03-19 14:44:29 -0700 Created attachment 193926 patch 858759 2 193926 kbr 2013-03-19 14:47:21 -0700 Comment on attachment 193926 patch Just confirming: these definitely fix the assertion failures? 858766 3 japhet 2013-03-19 14:51:10 -0700 (In reply to comment #2) > (From update of attachment 193926 [details]) > Just confirming: these definitely fix the assertion failures? Ran cr-linux debug locally, had 2 crashes in plugin tests that appear completely unrelated and aren't crashing on the buildbots. So I'm going to say Yes :) 858773 4 193926 kbr 2013-03-19 14:55:06 -0700 Comment on attachment 193926 patch OK, let's get this in the tree and see whether the bots turn green. 858792 5 193926 webkit.review.bot 2013-03-19 15:18:42 -0700 Comment on attachment 193926 patch Clearing flags on attachment: 193926 Committed r146267: <http://trac.webkit.org/changeset/146267> 858793 6 webkit.review.bot 2013-03-19 15:18:45 -0700 All reviewed patches have been landed. Closing bug. 193926 2013-03-19 14:44:29 -0700 2013-03-19 15:18:42 -0700 patch dl.txt text/plain 3379 japhet SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0NjI2MCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDEzLTAzLTE5ICBOYXRlIENo YXBpbiAgPGphcGhldEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUkVHUkVTU0lPTihyMTQ2MjIz KTogY2hyb21pdW0gYXNzZXJ0cy9jcmFzaGVzIGluIERvY3VtZW50TG9hZGVyCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTI3NDUKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXhlcyBsYXlvdXQgdGVzdHMg b24gY2hyb21pdW0gZGVidWcKKworICAgICAgICAqIGxvYWRlci9Eb2N1bWVudExvYWRlci5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpEb2N1bWVudExvYWRlcjo6bWFpblJlY2VpdmVkRXJyb3IpOiBG cmFtZSBtaWdodCBiZSBkZXRhY2hlZCwgZ2V0CisgICAgICAgICAgICBkZWZlcnNMb2FkaW5nKCkg ZnJvbSBtYWluUmVzb3VyY2VMb2FkZXIoKS4KKyAgICAgICAgKFdlYkNvcmU6OkRvY3VtZW50TG9h ZGVyOjpyZXNwb25zZVJlY2VpdmVkKTogUmVmUHRyIGdvdCBkcm9wcGVkLCBpdCdzIHJlYWxseSBu ZWVkZWQuCisgICAgICAgIChXZWJDb3JlOjpEb2N1bWVudExvYWRlcjo6cmVjZWl2ZWREYXRhKTog RnJhbWUgbWlnaHQgYmUgZGV0YWNoZWQsIGdldAorICAgICAgICAgICAgZGVmZXJzTG9hZGluZygp IGZyb20gbWFpblJlc291cmNlTG9hZGVyKCkuCisgICAgICAgIChXZWJDb3JlOjpEb2N1bWVudExv YWRlcjo6Y2FuY2VsTWFpblJlc291cmNlTG9hZCk6IFRoZSBSZXNvdXJjZUVycm9yIHBhcmFtZXRl cgorICAgICAgICAgICAgY2FuIGJlIG51bGwgaWYgY29taW5nIGZyb20gdGhlIFdlYktpdCBsYXll ciwgd2Ugc2hvdWxkIGhhdmUgYSBkZWZhdWx0IGp1c3QgaW4gY2FzZS4KKwogMjAxMy0wMy0xOSAg QmV0aCBEYWtpbiAgPGJkYWtpbkBhcHBsZS5jb20+CiAKICAgICAgICAgUmVuZGVyTGF5ZXI6OnNj cm9sbFRvKCkgc2hvdWxkIGNhbGwgRnJhbWVMb2FkZXJDbGllbnQ6OmRpZENoYW5nZVNjcm9sbE9m ZnNldCgpCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9sb2FkZXIvRG9jdW1lbnRMb2FkZXIuY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2xvYWRlci9Eb2N1bWVudExvYWRlci5jcHAJKHJl dmlzaW9uIDE0NjI1MikKKysrIFNvdXJjZS9XZWJDb3JlL2xvYWRlci9Eb2N1bWVudExvYWRlci5j cHAJKHdvcmtpbmcgY29weSkKQEAgLTIzMCw3ICsyMzAsNyBAQAogICAgIC8vIFRoZXJlIGlzIGEg YnVnIGluIENGTmV0d29yayB3aGVyZSBjYWxsYmFja3MgY2FuIGJlIGRpc3BhdGNoZWQgZXZlbiB3 aGVuIGxvYWRzIGFyZSBkZWZlcnJlZC4KICAgICAvLyBTZWUgPHJkYXI6Ly9wcm9ibGVtLzYzMDQ2 MDA+IGZvciBtb3JlIGRldGFpbHMuCiAjaWYgIVVTRShDRikKLSAgICBBU1NFUlQoIW1fZnJhbWUt PnBhZ2UoKS0+ZGVmZXJzTG9hZGluZygpKTsKKyAgICBBU1NFUlQoIW1haW5SZXNvdXJjZUxvYWRl cigpIHx8ICFtYWluUmVzb3VyY2VMb2FkZXIoKS0+ZGVmZXJzTG9hZGluZygpKTsKICNlbmRpZgog CiAgICAgbV9hcHBsaWNhdGlvbkNhY2hlSG9zdC0+ZmFpbGVkTG9hZGluZ01haW5SZXNvdXJjZSgp OwpAQCAtNTI2LDYgKzUyNiw3IEBACiAKIHZvaWQgRG9jdW1lbnRMb2FkZXI6OnJlc3BvbnNlUmVj ZWl2ZWQoY29uc3QgUmVzb3VyY2VSZXNwb25zZSYgcmVzcG9uc2UpCiB7CisgICAgUmVmUHRyPERv Y3VtZW50TG9hZGVyPiBwcm90ZWN0KHRoaXMpOwogICAgIGJvb2wgd2lsbExvYWRGYWxsYmFjayA9 IG1fYXBwbGljYXRpb25DYWNoZUhvc3QtPm1heWJlTG9hZEZhbGxiYWNrRm9yTWFpblJlc3BvbnNl KHJlcXVlc3QoKSwgcmVzcG9uc2UpOwogCiAgICAgLy8gVGhlIG1lbW9yeSBjYWNoZSBkb2Vzbid0 IHVuZGVyc3RhbmQgdGhlIGFwcGxpY2F0aW9uIGNhY2hlIG9yIGl0cyBjYWNoaW5nIHJ1bGVzLiBT byBpZiBhIG1haW4gcmVzb3VyY2UgaXMgc2VydmVkCkBAIC01NjAsNyArNTYxLDcgQEAKICAgICAv LyBUaGVyZSBpcyBhIGJ1ZyBpbiBDRk5ldHdvcmsgd2hlcmUgY2FsbGJhY2tzIGNhbiBiZSBkaXNw YXRjaGVkIGV2ZW4gd2hlbiBsb2FkcyBhcmUgZGVmZXJyZWQuCiAgICAgLy8gU2VlIDxyZGFyOi8v cHJvYmxlbS82MzA0NjAwPiBmb3IgbW9yZSBkZXRhaWxzLgogI2lmICFVU0UoQ0YpCi0gICAgQVNT RVJUKCFtX2ZyYW1lLT5wYWdlKCktPmRlZmVyc0xvYWRpbmcoKSk7CisgICAgQVNTRVJUKCFtYWlu UmVzb3VyY2VMb2FkZXIoKSB8fCAhbWFpblJlc291cmNlTG9hZGVyKCktPmRlZmVyc0xvYWRpbmco KSk7CiAjZW5kaWYKIAogICAgIGlmIChtX2lzTG9hZGluZ011bHRpcGFydENvbnRlbnQpIHsKQEAg LTgwMiw3ICs4MDMsNyBAQAogICAgIC8vIFRoZXJlIGlzIGEgYnVnIGluIENGTmV0d29yayB3aGVy ZSBjYWxsYmFja3MgY2FuIGJlIGRpc3BhdGNoZWQgZXZlbiB3aGVuIGxvYWRzIGFyZSBkZWZlcnJl ZC4KICAgICAvLyBTZWUgPHJkYXI6Ly9wcm9ibGVtLzYzMDQ2MDA+IGZvciBtb3JlIGRldGFpbHMu CiAjaWYgIVVTRShDRikKLSAgICBBU1NFUlQoIW1fZnJhbWUtPnBhZ2UoKS0+ZGVmZXJzTG9hZGlu ZygpKTsKKyAgICBBU1NFUlQoIW1haW5SZXNvdXJjZUxvYWRlcigpIHx8ICFtYWluUmVzb3VyY2VM b2FkZXIoKS0+ZGVmZXJzTG9hZGluZygpKTsKICNlbmRpZgogCiAjaWYgVVNFKENPTlRFTlRfRklM VEVSSU5HKQpAQCAtMTM5MSwxMCArMTM5MiwxMCBAQAogICAgIHNldFJlcXVlc3QocmVxdWVzdCk7 CiB9CiAKLXZvaWQgRG9jdW1lbnRMb2FkZXI6OmNhbmNlbE1haW5SZXNvdXJjZUxvYWQoY29uc3Qg UmVzb3VyY2VFcnJvciYgZXJyb3IpCit2b2lkIERvY3VtZW50TG9hZGVyOjpjYW5jZWxNYWluUmVz b3VyY2VMb2FkKGNvbnN0IFJlc291cmNlRXJyb3ImIHJlc291cmNlRXJyb3IpCiB7Ci0gICAgQVNT RVJUKCFlcnJvci5pc051bGwoKSk7CiAgICAgUmVmUHRyPERvY3VtZW50TG9hZGVyPiBwcm90ZWN0 KHRoaXMpOworICAgIFJlc291cmNlRXJyb3IgZXJyb3IgPSByZXNvdXJjZUVycm9yLmlzTnVsbCgp ID8gZnJhbWVMb2FkZXIoKS0+Y2FuY2VsbGVkRXJyb3IobV9yZXF1ZXN0KSA6IHJlc291cmNlRXJy b3I7CiAKICAgICBtX2RhdGFMb2FkVGltZXIuc3RvcCgpOwogICAgIGlmIChtX3dhaXRpbmdGb3JD b250ZW50UG9saWN5KSB7Cg==