112740 2013-03-19 13:49:10 -0700 Add a feature observer for RenderDeprecatedFlexibleBox 2013-03-21 13:30:41 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 112958 1 cbiesinger cbiesinger abarth eric esprehn+autocc ojan.autocc ojan tony webkit.review.bot oldest_to_newest 858700 0 cbiesinger 2013-03-19 13:49:10 -0700 Add a feature observer for RenderDeprecatedFlexibleBox 858703 1 193914 cbiesinger 2013-03-19 13:51:53 -0700 Created attachment 193914 Patch 858705 2 abarth 2013-03-19 13:54:06 -0700 LGTM, but Ojan should give you the official review. 858714 3 193914 tony 2013-03-19 14:10:31 -0700 Comment on attachment 193914 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=193914&action=review > Source/WebCore/page/FeatureObserver.h:104 > + DeprecatedFlexbox, Nit: I would probably name this DeprecatedFlexboxWebContent or something. 858835 4 193944 cbiesinger 2013-03-19 16:03:37 -0700 Created attachment 193944 Patch 859035 5 eric 2013-03-19 20:54:27 -0700 Ojan was telling me today that FeatureObserver depends on normal-page shutdown, which is not how chromium renderers commonly shut down? Suggesting we're not getting very good data from these metrics? 859037 6 193944 webkit.review.bot 2013-03-19 20:56:57 -0700 Comment on attachment 193944 Patch Rejecting attachment 193944 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', '--bot-id=gce-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 193944, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue Last 500 characters of output: ebkit-commit-queue Parsed 3 diffs from patch file(s). patching file Source/WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/page/FeatureObserver.h Hunk #1 FAILED at 101. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/page/FeatureObserver.h.rej patching file Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue Full output: http://webkit-commit-queue.appspot.com/results/17191542 859039 7 ojan 2013-03-19 20:59:37 -0700 (In reply to comment #5) > Ojan was telling me today that FeatureObserver depends on normal-page shutdown, which is not how chromium renderers commonly shut down? Suggesting we're not getting very good data from these metrics? Chrome only does normal shutdown of the page if is being navigated to a same-domain page, it has beforeunload/unload listeners registered or there are multiple pages in the same render process (in all other cases, we can safely just kill the render process). It's kind of a bummer, but I'm not sure how we would be able to get better metrics. Hopefully this doesn't skew our numbers too much. 859586 8 194092 cbiesinger 2013-03-20 11:45:38 -0700 Created attachment 194092 Patch Rebased 859604 9 194092 webkit.review.bot 2013-03-20 12:22:17 -0700 Comment on attachment 194092 Patch Clearing flags on attachment: 194092 Committed r146375: <http://trac.webkit.org/changeset/146375> 859605 10 webkit.review.bot 2013-03-20 12:22:21 -0700 All reviewed patches have been landed. Closing bug. 193914 2013-03-19 13:51:53 -0700 2013-03-19 16:03:35 -0700 Patch bug-112740-20130319134744.patch text/plain 2889 cbiesinger U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ2MTI3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzAyYWNiOTMzZDdkZjhm MjQ0Zjg3NDRlZTI4OTQ2OWIzZDQ4Nzc5ZC4uNzBhYmNiYjkyYzYyNWI3MTllZjkwYzE2NzhjYzNk OTA0ZDNlZGUwMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEzLTAzLTE5ICBDaHJp c3RpYW4gQmllc2luZ2VyICA8Y2JpZXNpbmdlckBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgQWRk IGEgZmVhdHVyZSBvYnNlcnZlciBmb3IgUmVuZGVyRGVwcmVjYXRlZEZsZXhpYmxlQm94CisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTI3NDAKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMg LSBvbmx5IGFkZGluZyBtZWFzdXJlbWVudHMuCisKKyAgICAgICAgKiBwYWdlL0ZlYXR1cmVPYnNl cnZlci5oOgorICAgICAgICBBZGQgY29uc3RhbnRzIGZvciBSZW5kZXJEZXByZWNhdGVkRmxleGli bGVCb3gsIGFuZCBhZGQgc2VwYXJhdGUKKyAgICAgICAgY29uc3RhbnRzIGZvciBpdHMgdXNlIGlu IHRoZSBVSSBhbmQgaW4gZXh0ZW5zaW9ucy4KKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyRGVw cmVjYXRlZEZsZXhpYmxlQm94LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckRlcHJlY2F0 ZWRGbGV4aWJsZUJveDo6UmVuZGVyRGVwcmVjYXRlZEZsZXhpYmxlQm94KToKKyAgICAgICAgQ2Fs bCBGZWF0dXJlT2JzZXJ2ZXIuIENoZWNrIHRoZSBkb2N1bWVudCgpLT51cmwoKSB0byBzZWUgd2hp Y2gKKyAgICAgICAgY29uc3RhbnQgdG8gdXNlLgorCiAyMDEzLTAzLTE4ICBIYW5zIFdlbm5ib3Jn ICA8aGFuc0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgRml4IEdyaWRUcmFja1NpemU6Om9wZXJh dG9yPT0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRmVhdHVyZU9ic2VydmVyLmgg Yi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZlYXR1cmVPYnNlcnZlci5oCmluZGV4IDYzNTBhNWJiM2E4 ODc1OWYwOGUxNjBmZmJjODdjMjM2YmJiMTMxMjkuLjRlNzgxNWU2MjgwOTk0NDg1NWM4ZGRjYmVk MDI0ZjgyZDhiMGYwMDMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRmVhdHVyZU9i c2VydmVyLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9GZWF0dXJlT2JzZXJ2ZXIuaApAQCAt MTAxLDYgKzEwMSw5IEBAIHB1YmxpYzoKICAgICAgICAgUmVmbGVjdGlvbiwKICAgICAgICAgQ3Vy c29yVmlzaWJpbGl0eSwKICAgICAgICAgU3RvcmFnZUluZm8sCisgICAgICAgIERlcHJlY2F0ZWRG bGV4Ym94LAorICAgICAgICBEZXByZWNhdGVkRmxleGJveENocm9tZSwKKyAgICAgICAgRGVwcmVj YXRlZEZsZXhib3hDaHJvbWVFeHRlbnNpb24sCiAgICAgICAgIC8vIEFkZCBuZXcgZmVhdHVyZXMg YWJvdmUgdGhpcyBsaW5lLiBEb24ndCBjaGFuZ2UgYXNzaWduZWQgbnVtYmVycyBvZiBlYWNoIGl0 ZW1zLgogICAgICAgICBOdW1iZXJPZkZlYXR1cmVzLCAvLyBUaGlzIGVudW0gdmFsdWUgbXVzdCBi ZSBsYXN0LgogICAgIH07CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVu ZGVyRGVwcmVjYXRlZEZsZXhpYmxlQm94LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9S ZW5kZXJEZXByZWNhdGVkRmxleGlibGVCb3guY3BwCmluZGV4IDg0NWQ4MzEzMzI1MGFhZjdjZDI0 ZjdiNjk0ZTI5MGFmNzVmZGU1NGQuLjUxYmNjN2I3MDUwNmQxNDYwYjgwYmVhOTI3YzRkY2U2NTZk OTlmYTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJEZXByZWNh dGVkRmxleGlibGVCb3guY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJE ZXByZWNhdGVkRmxleGlibGVCb3guY3BwCkBAIC0yNSw2ICsyNSw3IEBACiAjaW5jbHVkZSAiY29u ZmlnLmgiCiAjaW5jbHVkZSAiUmVuZGVyRGVwcmVjYXRlZEZsZXhpYmxlQm94LmgiCiAKKyNpbmNs dWRlICJGZWF0dXJlT2JzZXJ2ZXIuaCIKICNpbmNsdWRlICJGb250LmgiCiAjaW5jbHVkZSAiTGF5 b3V0UmVwYWludGVyLmgiCiAjaW5jbHVkZSAiUmVuZGVyTGF5ZXIuaCIKQEAgLTEyNCw2ICsxMjUs MTMgQEAgUmVuZGVyRGVwcmVjYXRlZEZsZXhpYmxlQm94OjpSZW5kZXJEZXByZWNhdGVkRmxleGli bGVCb3goRWxlbWVudCogZWxlbWVudCkKIHsKICAgICBzZXRDaGlsZHJlbklubGluZShmYWxzZSk7 IC8vIEFsbCBvZiBvdXIgY2hpbGRyZW4gbXVzdCBiZSBibG9jay1sZXZlbAogICAgIG1fc3RyZXRj aGluZ0NoaWxkcmVuID0gZmFsc2U7CisgICAgY29uc3QgS1VSTCYgdXJsID0gZG9jdW1lbnQoKS0+ dXJsKCk7CisgICAgaWYgKHVybC5wcm90b2NvbElzKCJjaHJvbWUiKSkKKyAgICAgICAgRmVhdHVy ZU9ic2VydmVyOjpvYnNlcnZlKGRvY3VtZW50KCksIEZlYXR1cmVPYnNlcnZlcjo6RGVwcmVjYXRl ZEZsZXhib3hDaHJvbWUpOworICAgIGVsc2UgaWYgKHVybC5wcm90b2NvbElzKCJjaHJvbWUtZXh0 ZW5zaW9uIikpCisgICAgICAgIEZlYXR1cmVPYnNlcnZlcjo6b2JzZXJ2ZShkb2N1bWVudCgpLCBG ZWF0dXJlT2JzZXJ2ZXI6OkRlcHJlY2F0ZWRGbGV4Ym94Q2hyb21lRXh0ZW5zaW9uKTsKKyAgICBl bHNlCisgICAgICAgIEZlYXR1cmVPYnNlcnZlcjo6b2JzZXJ2ZShkb2N1bWVudCgpLCBGZWF0dXJl T2JzZXJ2ZXI6OkRlcHJlY2F0ZWRGbGV4Ym94KTsKIH0KIAogUmVuZGVyRGVwcmVjYXRlZEZsZXhp YmxlQm94Ojp+UmVuZGVyRGVwcmVjYXRlZEZsZXhpYmxlQm94KCkK 193944 2013-03-19 16:03:37 -0700 2013-03-20 11:45:36 -0700 Patch bug-112740-20130319155928.patch text/plain 2905 cbiesinger U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ2MTI3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzAyYWNiOTMzZDdkZjhm MjQ0Zjg3NDRlZTI4OTQ2OWIzZDQ4Nzc5ZC4uZWQ5YjZjZmE3YjZlYmJiMTY0OTFiYzJlYWYyOGZm MDNiNzNiYjk4MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEzLTAzLTE5ICBDaHJp c3RpYW4gQmllc2luZ2VyICA8Y2JpZXNpbmdlckBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgQWRk IGEgZmVhdHVyZSBvYnNlcnZlciBmb3IgUmVuZGVyRGVwcmVjYXRlZEZsZXhpYmxlQm94CisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTI3NDAKKworICAg ICAgICBSZXZpZXdlZCBieSBUb255IENoYW5nLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyAtIG9u bHkgYWRkaW5nIG1lYXN1cmVtZW50cy4KKworICAgICAgICAqIHBhZ2UvRmVhdHVyZU9ic2VydmVy Lmg6CisgICAgICAgIEFkZCBjb25zdGFudHMgZm9yIFJlbmRlckRlcHJlY2F0ZWRGbGV4aWJsZUJv eCwgYW5kIGFkZCBzZXBhcmF0ZQorICAgICAgICBjb25zdGFudHMgZm9yIGl0cyB1c2UgaW4gdGhl IFVJIGFuZCBpbiBleHRlbnNpb25zLgorICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJEZXByZWNh dGVkRmxleGlibGVCb3guY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyRGVwcmVjYXRlZEZs ZXhpYmxlQm94OjpSZW5kZXJEZXByZWNhdGVkRmxleGlibGVCb3gpOgorICAgICAgICBDYWxsIEZl YXR1cmVPYnNlcnZlci4gQ2hlY2sgdGhlIGRvY3VtZW50KCktPnVybCgpIHRvIHNlZSB3aGljaAor ICAgICAgICBjb25zdGFudCB0byB1c2UuCisKIDIwMTMtMDMtMTggIEhhbnMgV2VubmJvcmcgIDxo YW5zQGNocm9taXVtLm9yZz4KIAogICAgICAgICBGaXggR3JpZFRyYWNrU2l6ZTo6b3BlcmF0b3I9 PQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9GZWF0dXJlT2JzZXJ2ZXIuaCBiL1Nv dXJjZS9XZWJDb3JlL3BhZ2UvRmVhdHVyZU9ic2VydmVyLmgKaW5kZXggNjM1MGE1YmIzYTg4NzU5 ZjA4ZTE2MGZmYmM4N2MyMzZiYmIxMzEyOS4uOGVlNDg3ODVjZDEzZTAzMmI0YmI1ZDI5YTUxODhi N2JjMWZkYzcwZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9GZWF0dXJlT2JzZXJ2 ZXIuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZlYXR1cmVPYnNlcnZlci5oCkBAIC0xMDEs NiArMTAxLDkgQEAgcHVibGljOgogICAgICAgICBSZWZsZWN0aW9uLAogICAgICAgICBDdXJzb3JW aXNpYmlsaXR5LAogICAgICAgICBTdG9yYWdlSW5mbywKKyAgICAgICAgRGVwcmVjYXRlZEZsZXhi b3hXZWJDb250ZW50LAorICAgICAgICBEZXByZWNhdGVkRmxleGJveENocm9tZSwKKyAgICAgICAg RGVwcmVjYXRlZEZsZXhib3hDaHJvbWVFeHRlbnNpb24sCiAgICAgICAgIC8vIEFkZCBuZXcgZmVh dHVyZXMgYWJvdmUgdGhpcyBsaW5lLiBEb24ndCBjaGFuZ2UgYXNzaWduZWQgbnVtYmVycyBvZiBl YWNoIGl0ZW1zLgogICAgICAgICBOdW1iZXJPZkZlYXR1cmVzLCAvLyBUaGlzIGVudW0gdmFsdWUg bXVzdCBiZSBsYXN0LgogICAgIH07CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJp bmcvUmVuZGVyRGVwcmVjYXRlZEZsZXhpYmxlQm94LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRl cmluZy9SZW5kZXJEZXByZWNhdGVkRmxleGlibGVCb3guY3BwCmluZGV4IDg0NWQ4MzEzMzI1MGFh ZjdjZDI0ZjdiNjk0ZTI5MGFmNzVmZGU1NGQuLjdkZjNjNzBlNjAyZDk5ZmJjYTdhNzQzZDliZWMy N2E1ODk5OWQ3MTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJE ZXByZWNhdGVkRmxleGlibGVCb3guY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9S ZW5kZXJEZXByZWNhdGVkRmxleGlibGVCb3guY3BwCkBAIC0yNSw2ICsyNSw3IEBACiAjaW5jbHVk ZSAiY29uZmlnLmgiCiAjaW5jbHVkZSAiUmVuZGVyRGVwcmVjYXRlZEZsZXhpYmxlQm94LmgiCiAK KyNpbmNsdWRlICJGZWF0dXJlT2JzZXJ2ZXIuaCIKICNpbmNsdWRlICJGb250LmgiCiAjaW5jbHVk ZSAiTGF5b3V0UmVwYWludGVyLmgiCiAjaW5jbHVkZSAiUmVuZGVyTGF5ZXIuaCIKQEAgLTEyNCw2 ICsxMjUsMTMgQEAgUmVuZGVyRGVwcmVjYXRlZEZsZXhpYmxlQm94OjpSZW5kZXJEZXByZWNhdGVk RmxleGlibGVCb3goRWxlbWVudCogZWxlbWVudCkKIHsKICAgICBzZXRDaGlsZHJlbklubGluZShm YWxzZSk7IC8vIEFsbCBvZiBvdXIgY2hpbGRyZW4gbXVzdCBiZSBibG9jay1sZXZlbAogICAgIG1f c3RyZXRjaGluZ0NoaWxkcmVuID0gZmFsc2U7CisgICAgY29uc3QgS1VSTCYgdXJsID0gZG9jdW1l bnQoKS0+dXJsKCk7CisgICAgaWYgKHVybC5wcm90b2NvbElzKCJjaHJvbWUiKSkKKyAgICAgICAg RmVhdHVyZU9ic2VydmVyOjpvYnNlcnZlKGRvY3VtZW50KCksIEZlYXR1cmVPYnNlcnZlcjo6RGVw cmVjYXRlZEZsZXhib3hDaHJvbWUpOworICAgIGVsc2UgaWYgKHVybC5wcm90b2NvbElzKCJjaHJv bWUtZXh0ZW5zaW9uIikpCisgICAgICAgIEZlYXR1cmVPYnNlcnZlcjo6b2JzZXJ2ZShkb2N1bWVu dCgpLCBGZWF0dXJlT2JzZXJ2ZXI6OkRlcHJlY2F0ZWRGbGV4Ym94Q2hyb21lRXh0ZW5zaW9uKTsK KyAgICBlbHNlCisgICAgICAgIEZlYXR1cmVPYnNlcnZlcjo6b2JzZXJ2ZShkb2N1bWVudCgpLCBG ZWF0dXJlT2JzZXJ2ZXI6OkRlcHJlY2F0ZWRGbGV4Ym94V2ViQ29udGVudCk7CiB9CiAKIFJlbmRl ckRlcHJlY2F0ZWRGbGV4aWJsZUJveDo6flJlbmRlckRlcHJlY2F0ZWRGbGV4aWJsZUJveCgpCg== 194092 2013-03-20 11:45:38 -0700 2013-03-20 12:22:17 -0700 Patch bug-112740-20130320114128.patch text/plain 3011 cbiesinger U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ2MzY3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDRkOGY2ZGFlZDNiYjk5 ZmQwYWU2ZjU4YTJiNjdjNmI5NmU1NzYzYS4uY2QwZmFiNWEyNDE3NDczYTVjZDg3ZDA0OTcwNGMz ZWVjMzBhY2QwYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEzLTAzLTIwICBDaHJp c3RpYW4gQmllc2luZ2VyICA8Y2JpZXNpbmdlckBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgQWRk IGEgZmVhdHVyZSBvYnNlcnZlciBmb3IgUmVuZGVyRGVwcmVjYXRlZEZsZXhpYmxlQm94CisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTI3NDAKKworICAg ICAgICBSZXZpZXdlZCBieSBUb255IENoYW5nLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyAtIG9u bHkgYWRkaW5nIG1lYXN1cmVtZW50cy4KKworICAgICAgICAqIHBhZ2UvRmVhdHVyZU9ic2VydmVy Lmg6CisgICAgICAgIEFkZCBjb25zdGFudHMgZm9yIFJlbmRlckRlcHJlY2F0ZWRGbGV4aWJsZUJv eCwgYW5kIGFkZCBzZXBhcmF0ZQorICAgICAgICBjb25zdGFudHMgZm9yIGl0cyB1c2UgaW4gdGhl IFVJIGFuZCBpbiBleHRlbnNpb25zLgorICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJEZXByZWNh dGVkRmxleGlibGVCb3guY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyRGVwcmVjYXRlZEZs ZXhpYmxlQm94OjpSZW5kZXJEZXByZWNhdGVkRmxleGlibGVCb3gpOgorICAgICAgICBDYWxsIEZl YXR1cmVPYnNlcnZlci4gQ2hlY2sgdGhlIGRvY3VtZW50KCktPnVybCgpIHRvIHNlZSB3aGljaAor ICAgICAgICBjb25zdGFudCB0byB1c2UuCisKIDIwMTMtMDMtMjAgIEFydmlkIE5pbHNzb24gIDxh bmlsc3NvbkByaW0uY29tPgogCiAgICAgICAgIFtCbGFja0JlcnJ5XSBjb21wb3NpdGluZy9pZnJh bWVzL3Njcm9sbC1maXhlZC10cmFuc2Zvcm1lZC1lbGVtZW50Lmh0bWwgZmFpbHMgaW4gbWFudWFs IHRlc3RpbmcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRmVhdHVyZU9ic2VydmVy LmggYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZlYXR1cmVPYnNlcnZlci5oCmluZGV4IDAzM2Y5NjRj MTg1MzBiODNkODExNmU4NmU5YzA3Yzc0MmQzYjllYzUuLmNkMzY4MzdiYTgzOTI4MWFlNjk3M2Fk ZDZlODRjMTZmZGE4NDM4MzQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRmVhdHVy ZU9ic2VydmVyLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9GZWF0dXJlT2JzZXJ2ZXIuaApA QCAtMTA0LDYgKzEwNCw5IEBAIHB1YmxpYzoKICAgICAgICAgWEZyYW1lT3B0aW9ucywKICAgICAg ICAgWEZyYW1lT3B0aW9uc1NhbWVPcmlnaW4sCiAgICAgICAgIFhGcmFtZU9wdGlvbnNTYW1lT3Jp Z2luV2l0aEJhZEFuY2VzdG9yQ2hhaW4sCisgICAgICAgIERlcHJlY2F0ZWRGbGV4Ym94V2ViQ29u dGVudCwKKyAgICAgICAgRGVwcmVjYXRlZEZsZXhib3hDaHJvbWUsCisgICAgICAgIERlcHJlY2F0 ZWRGbGV4Ym94Q2hyb21lRXh0ZW5zaW9uLAogICAgICAgICAvLyBBZGQgbmV3IGZlYXR1cmVzIGFi b3ZlIHRoaXMgbGluZS4gRG9uJ3QgY2hhbmdlIGFzc2lnbmVkIG51bWJlcnMgb2YgZWFjaCBpdGVt cy4KICAgICAgICAgTnVtYmVyT2ZGZWF0dXJlcywgLy8gVGhpcyBlbnVtIHZhbHVlIG11c3QgYmUg bGFzdC4KICAgICB9OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRl ckRlcHJlY2F0ZWRGbGV4aWJsZUJveC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVu ZGVyRGVwcmVjYXRlZEZsZXhpYmxlQm94LmNwcAppbmRleCA4NDVkODMxMzMyNTBhYWY3Y2QyNGY3 YjY5NGUyOTBhZjc1ZmRlNTRkLi43ZGYzYzcwZTYwMmQ5OWZiY2E3YTc0M2Q5YmVjMjdhNTg5OTlk NzEyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyRGVwcmVjYXRl ZEZsZXhpYmxlQm94LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyRGVw cmVjYXRlZEZsZXhpYmxlQm94LmNwcApAQCAtMjUsNiArMjUsNyBAQAogI2luY2x1ZGUgImNvbmZp Zy5oIgogI2luY2x1ZGUgIlJlbmRlckRlcHJlY2F0ZWRGbGV4aWJsZUJveC5oIgogCisjaW5jbHVk ZSAiRmVhdHVyZU9ic2VydmVyLmgiCiAjaW5jbHVkZSAiRm9udC5oIgogI2luY2x1ZGUgIkxheW91 dFJlcGFpbnRlci5oIgogI2luY2x1ZGUgIlJlbmRlckxheWVyLmgiCkBAIC0xMjQsNiArMTI1LDEz IEBAIFJlbmRlckRlcHJlY2F0ZWRGbGV4aWJsZUJveDo6UmVuZGVyRGVwcmVjYXRlZEZsZXhpYmxl Qm94KEVsZW1lbnQqIGVsZW1lbnQpCiB7CiAgICAgc2V0Q2hpbGRyZW5JbmxpbmUoZmFsc2UpOyAv LyBBbGwgb2Ygb3VyIGNoaWxkcmVuIG11c3QgYmUgYmxvY2stbGV2ZWwKICAgICBtX3N0cmV0Y2hp bmdDaGlsZHJlbiA9IGZhbHNlOworICAgIGNvbnN0IEtVUkwmIHVybCA9IGRvY3VtZW50KCktPnVy bCgpOworICAgIGlmICh1cmwucHJvdG9jb2xJcygiY2hyb21lIikpCisgICAgICAgIEZlYXR1cmVP YnNlcnZlcjo6b2JzZXJ2ZShkb2N1bWVudCgpLCBGZWF0dXJlT2JzZXJ2ZXI6OkRlcHJlY2F0ZWRG bGV4Ym94Q2hyb21lKTsKKyAgICBlbHNlIGlmICh1cmwucHJvdG9jb2xJcygiY2hyb21lLWV4dGVu c2lvbiIpKQorICAgICAgICBGZWF0dXJlT2JzZXJ2ZXI6Om9ic2VydmUoZG9jdW1lbnQoKSwgRmVh dHVyZU9ic2VydmVyOjpEZXByZWNhdGVkRmxleGJveENocm9tZUV4dGVuc2lvbik7CisgICAgZWxz ZQorICAgICAgICBGZWF0dXJlT2JzZXJ2ZXI6Om9ic2VydmUoZG9jdW1lbnQoKSwgRmVhdHVyZU9i c2VydmVyOjpEZXByZWNhdGVkRmxleGJveFdlYkNvbnRlbnQpOwogfQogCiBSZW5kZXJEZXByZWNh dGVkRmxleGlibGVCb3g6On5SZW5kZXJEZXByZWNhdGVkRmxleGlibGVCb3goKQo=