112731 2013-03-19 12:12:04 -0700 Changes to VS2010 project files should only trigger builds on Windows bots. 2013-03-19 14:43:45 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Windows 7 RESOLVED FIXED P2 Normal --- 1 roger_fong webkit-unassigned thorton oldest_to_newest 858585 0 193894 roger_fong 2013-03-19 12:12:04 -0700 Created attachment 193894 patch Make builds only trigger for windows bots when changes are made to vcxproj, props or filters files. 858653 1 193894 thorton 2013-03-19 13:04:51 -0700 Comment on attachment 193894 patch View in context: https://bugs.webkit.org/attachment.cgi?id=193894&action=review > BuildSlaveSupport/build.webkit.org-config/wkbuild.py:97 > + (r"\.(?:vcproj|vsprops|sln|vcxproj|props|filters)$", ["win"]), This won't match any folders! Note the $. > BuildSlaveSupport/build.webkit.org-config/wkbuild.py:-102 > - (r"\.vcproj/", ["win"]), This needs to stay. And vcxproj needs to be here too! 858655 2 193904 roger_fong 2013-03-19 13:07:57 -0700 Created attachment 193904 patch v2 858744 3 193904 thorton 2013-03-19 14:35:01 -0700 Comment on attachment 193904 patch v2 View in context: https://bugs.webkit.org/attachment.cgi?id=193904&action=review > BuildSlaveSupport/build.webkit.org-config/wkbuild.py:97 > + (r"\.(?:vcproj|vsprops|sln|vcxproj|props|filters)$", ["win"]), Assuming these extensions are actually unique to your platform. > BuildSlaveSupport/build.webkit.org-config/wkbuild.py:102 > + (r"\.(?:vcproj/|vcxproj/)", ["win"]), You could put the slash outside of the or :P 858752 4 roger_fong 2013-03-19 14:43:45 -0700 http://trac.webkit.org/changeset/146261 193894 2013-03-19 12:12:04 -0700 2013-03-19 13:07:57 -0700 patch patch.patch text/plain 1341 roger_fong SW5kZXg6IEJ1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3drYnVpbGQu cHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25m aWcvd2tidWlsZC5weQkocmV2aXNpb24gMTQ2MTMwKQorKysgQnVpbGRTbGF2ZVN1cHBvcnQvYnVp bGQud2Via2l0Lm9yZy1jb25maWcvd2tidWlsZC5weQkod29ya2luZyBjb3B5KQpAQCAtOTQsMTIg Kzk0LDExIEBACiAgICAgICAgIChyIig/Ol58LylHTlVtYWtlZmlsZVwuYW0kIiwgWyJndGsiXSks CiAgICAgICAgIChyIi9cdytDaHJvbWl1bVx3KlwuKD86Y3BwfGh8bW0pJCIsIFsiY2hyb21pdW0i XSksCiAgICAgICAgIChyIk1hY1wuKD86Y3BwfGh8bW0pJCIsIFsibWFjIl0pLAotICAgICAgICAo ciJcLig/OnZjcHJvanx2c3Byb3BzfHNsbikkIiwgWyJ3aW4iXSksCisgICAgICAgIChyIlwuKD86 dmNwcm9qfHZzcHJvcHN8c2xufHZjeHByb2p8cHJvcHN8ZmlsdGVycykkIiwgWyJ3aW4iXSksCiAg ICAgICAgIChyIlwuZXhwKD86XC5pbik/JCIsIFsibWFjIl0pLAogICAgICAgICAociJcLmd5cGk/ IiwgWyJjaHJvbWl1bSJdKSwKICAgICAgICAgKHIiXC5vcmRlciQiLCBbIm1hYyJdKSwKICAgICAg ICAgKHIiXC5wcltpb10kIiwgWyJxdCJdKSwKLSAgICAgICAgKHIiXC52Y3Byb2ovIiwgWyJ3aW4i XSksCiAgICAgICAgIChyIlwueGNjb25maWckIiwgWyJtYWMiXSksCiAgICAgICAgIChyIlwueGNv ZGVwcm9qLyIsIFsibWFjIl0pLAogICAgIF0KSW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBDaGFuZ2VMb2cJKHJldmlzaW9uIDE0NjIzMCkKKysrIENoYW5nZUxvZwkod29ya2luZyBjb3B5 KQpAQCAtMSwzICsxLDEwIEBACisyMDEzLTAzLTE5ICBSb2dlciBGb25nICA8cm9nZXJfZm9uZ0Bh cHBsZS5jb20+CisKKyAgICAgICAgQ2hhbmdlcyB0byBWUzIwMTAgcHJvamVjdCBmaWxlcyBzaG91 bGQgb25seSB0cmlnZ2VyIGJ1aWxkcyBvbiBXaW5kb3dzIGJvdHMuCisKKyAgICAgICAgKiBCdWls ZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy93a2J1aWxkLnB5OgorICAgICAg ICAoX3Nob3VsZF9maWxlX3RyaWdnZXJfYnVpbGQpOgorCiAyMDEzLTAzLTE5ICBBbGJlcnRvIEdh cmNpYSAgPGFnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBbQmxhY2tCZXJyeV0gRW5hYmxl IFVTRV9TWVNURU1fTUFMTE9DIGJ5IGRlZmF1bHQK 193904 2013-03-19 13:07:57 -0700 2013-03-19 14:35:01 -0700 patch v2 patch.patch text/plain 1463 roger_fong SW5kZXg6IEJ1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3drYnVpbGQu cHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25m aWcvd2tidWlsZC5weQkocmV2aXNpb24gMTQ2MjQxKQorKysgQnVpbGRTbGF2ZVN1cHBvcnQvYnVp bGQud2Via2l0Lm9yZy1jb25maWcvd2tidWlsZC5weQkod29ya2luZyBjb3B5KQpAQCAtOTQsMTIg Kzk0LDEyIEBACiAgICAgICAgIChyIig/Ol58LylHTlVtYWtlZmlsZVwuYW0kIiwgWyJndGsiXSks CiAgICAgICAgIChyIi9cdytDaHJvbWl1bVx3KlwuKD86Y3BwfGh8bW0pJCIsIFsiY2hyb21pdW0i XSksCiAgICAgICAgIChyIk1hY1wuKD86Y3BwfGh8bW0pJCIsIFsibWFjIl0pLAotICAgICAgICAo ciJcLig/OnZjcHJvanx2c3Byb3BzfHNsbikkIiwgWyJ3aW4iXSksCisgICAgICAgIChyIlwuKD86 dmNwcm9qfHZzcHJvcHN8c2xufHZjeHByb2p8cHJvcHN8ZmlsdGVycykkIiwgWyJ3aW4iXSksCiAg ICAgICAgIChyIlwuZXhwKD86XC5pbik/JCIsIFsibWFjIl0pLAogICAgICAgICAociJcLmd5cGk/ IiwgWyJjaHJvbWl1bSJdKSwKICAgICAgICAgKHIiXC5vcmRlciQiLCBbIm1hYyJdKSwKICAgICAg ICAgKHIiXC5wcltpb10kIiwgWyJxdCJdKSwKLSAgICAgICAgKHIiXC52Y3Byb2ovIiwgWyJ3aW4i XSksCisgICAgICAgIChyIlwuKD86dmNwcm9qL3x2Y3hwcm9qLykiLCBbIndpbiJdKSwKICAgICAg ICAgKHIiXC54Y2NvbmZpZyQiLCBbIm1hYyJdKSwKICAgICAgICAgKHIiXC54Y29kZXByb2ovIiwg WyJtYWMiXSksCiAgICAgXQpJbmRleDogQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIENoYW5nZUxv ZwkocmV2aXNpb24gMTQ2MjQxKQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTEgQEAKKzIwMTMtMDMtMTkgIFJvZ2VyIEZvbmcgIDxyb2dlcl9mb25nQGFwcGxlLmNvbT4K KworICAgICAgICBDaGFuZ2VzIHRvIFZTMjAxMCBwcm9qZWN0IGZpbGVzIHNob3VsZCBvbmx5IHRy aWdnZXIgYnVpbGRzIG9uIFdpbmRvd3MgYm90cy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTExMjczMQorCisgICAgICAgICogQnVpbGRTbGF2ZVN1cHBv cnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvd2tidWlsZC5weToKKyAgICAgICAgKF9zaG91bGRf ZmlsZV90cmlnZ2VyX2J1aWxkKToKKwogMjAxMy0wMy0xOSAgSmFtZXMgUm9iaW5zb24gIDxqYW1l c3JAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtjaHJvbWl1bV0gUmVtb3ZlIGNvbXBvc2l0b3Ig c2V0dGluZ3MgdGhhdCBkb24ndCBnbyB0aHJvdWdoIFdlYktpdAo=