112727 2013-03-19 11:43:55 -0700 [GTK] Add WebCoreHTML to the gyp build 2013-03-25 09:27:27 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 112638 112737 1 mrobinson mrobinson dpranke gustavo thakis oldest_to_newest 858542 0 mrobinson 2013-03-19 11:43:55 -0700 WebCoreHTML includes all the HTML files. HTML is useful for a web content rendering engine. 858548 1 193883 mrobinson 2013-03-19 11:46:58 -0700 Created attachment 193883 Patch 859013 2 193883 thakis 2013-03-19 20:25:17 -0700 Comment on attachment 193883 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=193883&action=review Makes sense. > Source/WebCore/WebCore.gyp/WebCoreGTK.gyp:921 > + 'type': 'none', Does linking to a none target that depends on two static_library targets do the right thing? (i.e. link in the two static libraries) 861973 3 mrobinson 2013-03-22 16:50:13 -0700 Committed r146680: <http://trac.webkit.org/changeset/146680> 862836 4 mrobinson 2013-03-25 09:27:27 -0700 (In reply to comment #2) > > Source/WebCore/WebCore.gyp/WebCoreGTK.gyp:921 > > + 'type': 'none', > > Does linking to a none target that depends on two static_library targets do the right thing? (i.e. link in the two static libraries) Hrm. I haven't built out to libwebkit (I'm pretty close now though), but this seems to be how the Chromium build is structured. 193883 2013-03-19 11:46:58 -0700 2013-03-19 20:25:16 -0700 Patch bug-112727-20130319114238.patch text/plain 4223 mrobinson U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ2MjEyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTM3Yzk2NzgwNzUxOTcx NmMwN2E3N2VkZmFhOTk3ZTU2NjRmZDM5OC4uMzc5NjI1Yzk3NmRmNTJiNjQ2OTE3ODVlMmQyNGYw NDQyNjMyZTE2MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE2IEBACiAyMDEzLTAzLTE5ICBNYXJ0 aW4gUm9iaW5zb24gIDxtcm9iaW5zb25AaWdhbGlhLmNvbT4KIAorICAgICAgICBbR1RLXSBBZGQg V2ViQ29yZUhUTUwgdG8gdGhlIGd5cCBidWlsZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEyNzI3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBXZWJDb3JlLmd5cC9XZWJDb3JlR1RLLmd5cDogQWRkIHN1 cHBvcnQgZm9yIGJ1aWxkaW5nIGFsbCBmaWxlcyB1bmRlcgorICAgICAgICB0aGUgSFRNTCBkaXJl Y3RvcnkuIFRoaXMgaW5jbHVkZXMgc3BsaXR0aW5nIG9mZiBjb21tb24gV2ViQ29yZSBkZXBlbmRl bmNpZXMKKyAgICAgICAgaW50byBhbiBhZ2dyZWdhdGUgdGFyZ2V0IGFuZCBhZGRpbmcgYSB0b3At bGV2ZWwgV2ViQ29yZSB0YXJnZXQuCisKKzIwMTMtMDMtMTkgIE1hcnRpbiBSb2JpbnNvbiAgPG1y b2JpbnNvbkBpZ2FsaWEuY29tPgorCiAgICAgICAgIFtHVEtdIEFkZCBzdXBwb3J0IGZvciBidWls ZGluZyB0aGUgV2ViQ29yZSBiaW5kaW5ncyB0byB0aGUgZ3lwIGJ1aWxkCiAgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTI2MzgKIApkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvV2ViQ29yZS5neXAvV2ViQ29yZUdUSy5neXAgYi9Tb3VyY2UvV2ViQ29y ZS9XZWJDb3JlLmd5cC9XZWJDb3JlR1RLLmd5cAppbmRleCBhZjBjZmUxYzkzM2I3MjI5YWFjMDNk YTUwNzI1YzRlYmNkNThlOTczLi5iNTcwYTY4ZmU1ZjFmNzU2MWE0ZDc5YzAyYjFlYjBlODg1ZmQx OGIxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9XZWJDb3JlLmd5cC9XZWJDb3JlR1RLLmd5 cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9XZWJDb3JlLmd5cC9XZWJDb3JlR1RLLmd5cApAQCAtNjks NiArNjksOCBAQAogICAgICAgJzwoV2ViQ29yZSkvcGxhdGZvcm0vdGV4dC9lbmNoYW50JywKICAg ICAgICc8KFdlYkNvcmUpL3BsdWdpbnMvd2luJywKICAgICAgICc8QCh3ZWJjb3JlX2luY2x1ZGVf ZGlycyknLAorICAgICAgJzwod2ViY29yZV9kZXJpdmVkX3NvdXJjZXNfZGlyZWN0b3J5KScsCisg ICAgICAnPCh3ZWJjb3JlX2Rlcml2ZWRfc291cmNlc19kaXJlY3RvcnkpL2JpbmRpbmdzJywKICAg ICBdLAogCiAgICAgJ2JpbmRpbmdzX2lkbF9maWxlcyc6IFsKQEAgLTg3LDYgKzg5LDMwIEBACiAK ICAgJ3RhcmdldHMnOiBbCiAgICAgeworICAgICAgJ3RhcmdldF9uYW1lJzogJ1dlYkNvcmVEZXBl bmRlbmNpZXMnLAorICAgICAgJ3R5cGUnOiAnbm9uZScsCisgICAgICAnZGVwZW5kZW5jaWVzJzog WyAKKyAgICAgICAgJzwoRGVwZW5kZW5jaWVzKTpnbGliJywKKyAgICAgICAgJzwoRGVwZW5kZW5j aWVzKTppY3UnLAorICAgICAgICAnPChEZXBlbmRlbmNpZXMpOmxpYnNvdXAnLAorICAgICAgICAn PChEZXBlbmRlbmNpZXMpOmNhaXJvJywKKyAgICAgICAgJzwoRGVwZW5kZW5jaWVzKTpmcmVldHlw ZScsCisgICAgICAgICc8KFNvdXJjZSkvSmF2YVNjcmlwdENvcmUvSmF2YVNjcmlwdENvcmUuZ3lw L0phdmFTY3JpcHRDb3JlR1RLLmd5cDpsaWJqYXZhc2NyaXB0Y29yZWd0aycsCisgICAgICAgICc8 KFNvdXJjZSkvV1RGL1dURi5neXAvV1RGR1RLLmd5cDp3dGYnLAorICAgICAgICAnPChTb3VyY2Up L1RoaXJkUGFydHkvQU5HTEUvQU5HTEUuZ3lwL0FOR0xFLmd5cDphbmdsZScsCisgICAgICBdLAor ICAgICAgJ2V4cG9ydF9kZXBlbmRlbnRfc2V0dGluZ3MnOiBbCisgICAgICAgICc8KERlcGVuZGVu Y2llcyk6Z2xpYicsCisgICAgICAgICc8KERlcGVuZGVuY2llcyk6aWN1JywKKyAgICAgICAgJzwo RGVwZW5kZW5jaWVzKTpsaWJzb3VwJywKKyAgICAgICAgJzwoRGVwZW5kZW5jaWVzKTpjYWlybycs CisgICAgICAgICc8KERlcGVuZGVuY2llcyk6ZnJlZXR5cGUnLAorICAgICAgICAnPChTb3VyY2Up L0phdmFTY3JpcHRDb3JlL0phdmFTY3JpcHRDb3JlLmd5cC9KYXZhU2NyaXB0Q29yZUdUSy5neXA6 bGliamF2YXNjcmlwdGNvcmVndGsnLAorICAgICAgICAnPChTb3VyY2UpL1dURi9XVEYuZ3lwL1dU RkdUSy5neXA6d3RmJywKKyAgICAgICAgJzwoU291cmNlKS9UaGlyZFBhcnR5L0FOR0xFL0FOR0xF Lmd5cC9BTkdMRS5neXA6YW5nbGUnLAorICAgICAgXSwKKyAgICB9LAorICAgIHsKICAgICAgICd0 YXJnZXRfbmFtZSc6ICdJbnNwZWN0b3JQcm90b2NvbFNvdXJjZXMnLAogICAgICAgJ3R5cGUnOiAn bm9uZScsCiAgICAgICAnZGVwZW5kZW5jaWVzJzogWwpAQCAtODUwLDI2ICs4NzYsMTUgQEAKICAg ICAgICd0eXBlJzogJ3N0YXRpY19saWJyYXJ5JywKICAgICAgICdoYXJkX2RlcGVuZGVuY3knOiAx LAogICAgICAgJ2RlcGVuZGVuY2llcyc6IFsKLSAgICAgICAgJzwoRGVwZW5kZW5jaWVzKTpnbGli JywKLSAgICAgICAgJzwoRGVwZW5kZW5jaWVzKTppY3UnLAotICAgICAgICAnPChEZXBlbmRlbmNp ZXMpOmxpYnNvdXAnLAotICAgICAgICAnPChEZXBlbmRlbmNpZXMpOmNhaXJvJywKLSAgICAgICAg JzwoRGVwZW5kZW5jaWVzKTpmcmVldHlwZScsCisgICAgICAgICdXZWJDb3JlRGVwZW5kZW5jaWVz JywKICAgICAgICAgJ1dlYkNvcmVCaW5kaW5nc1NvdXJjZXMnLAogICAgICAgICAnRGVidWdnZXJT Y3JpcHRTb3VyY2UnLAogICAgICAgICAnSW5qZWN0ZWRDYW52YXNTY3JpcHRTb3VyY2UnLAogICAg ICAgICAnSW5qZWN0ZWRTY3JpcHRTb3VyY2UnLAogICAgICAgICAnSW5zcGVjdG9yT3ZlcmxheVBh Z2UnLAogICAgICAgICAnSW5zcGVjdG9yUHJvdG9jb2xTb3VyY2VzJywKLSAgICAgICAgJzwoU291 cmNlKS9KYXZhU2NyaXB0Q29yZS9KYXZhU2NyaXB0Q29yZS5neXAvSmF2YVNjcmlwdENvcmVHVEsu Z3lwOmxpYmphdmFzY3JpcHRjb3JlZ3RrJywKLSAgICAgICAgJzwoU291cmNlKS9XVEYvV1RGLmd5 cC9XVEZHVEsuZ3lwOnd0ZicsCi0gICAgICAgICc8KFNvdXJjZSkvVGhpcmRQYXJ0eS9BTkdMRS9B TkdMRS5neXAvQU5HTEUuZ3lwOmFuZ2xlJywKLSAgICAgIF0sCi0gICAgICAnaW5jbHVkZV9kaXJz JzogWwotICAgICAgICAnPEAod2ViY29yZWd0a19pbmNsdWRlX2RpcnMpJywKLSAgICAgICAgJzwo d2ViY29yZV9kZXJpdmVkX3NvdXJjZXNfZGlyZWN0b3J5KScsCi0gICAgICAgICc8KHdlYmNvcmVf ZGVyaXZlZF9zb3VyY2VzX2RpcmVjdG9yeSkvYmluZGluZ3MnLAogICAgICAgXSwKKyAgICAgICdp bmNsdWRlX2RpcnMnOiBbICc8QCh3ZWJjb3JlZ3RrX2luY2x1ZGVfZGlycyknLCBdLAogICAgICAg J2RpcmVjdF9kZXBlbmRlbnRfc2V0dGluZ3MnOiB7CiAgICAgICAgICdpbmNsdWRlX2RpcnMnOiBb CiAgICAgICAgICAgJzwod2ViY29yZV9kZXJpdmVkX3NvdXJjZXNfZGlyZWN0b3J5KScsCkBAIC04 OTAsNyArOTA1LDI0IEBACiAgICAgICAgIH1dLAogICAgICAgXSwKICAgICB9LAotCisgICAgewor ICAgICAgJ3RhcmdldF9uYW1lJzogJ1dlYkNvcmVIVE1MJywKKyAgICAgICd0eXBlJzogJ3N0YXRp Y19saWJyYXJ5JywKKyAgICAgICdkZXBlbmRlbmNpZXMnOiBbICdXZWJDb3JlRGVwZW5kZW5jaWVz JywgXSwKKyAgICAgICdzb3VyY2VzJzogWyAnPEAod2ViY29yZV9odG1sX2ZpbGVzKScsIF0sCisg ICAgICAnc291cmNlcy8nOiBbCisgICAgICAgIFsnZXhjbHVkZScsICdBbGxJbk9uZVxcLmNwcCQn XSwKKyAgICAgICAgWydleGNsdWRlJywgJ0FuZHJvaWRcXC5jcHAkJ10sCisgICAgICBdLAorICAg ICAgJ2luY2x1ZGVfZGlycyc6IFsgJzxAKHdlYmNvcmVndGtfaW5jbHVkZV9kaXJzKScsIF0sCisg ICAgfSwKKyAgICB7CisgICAgICAndGFyZ2V0X25hbWUnOiAnV2ViQ29yZScsCisgICAgICAndHlw ZSc6ICdub25lJywKKyAgICAgICdkZXBlbmRlbmNpZXMnOiBbIAorICAgICAgICAnV2ViQ29yZUhU TUwnLAorICAgICAgICAnV2ViQ29yZUJpbmRpbmdzJywKKyAgICAgIF0sCisgICAgfSwKICAgXSwK IH0KLQo=