112719 2013-03-19 11:12:54 -0700 Cache a pointer to V8DOMActivityLogger in PerContextData 2013-03-19 19:41:18 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Enhancement --- 0 ataly webkit-unassigned abarth haraken japhet webkit.review.bot oldest_to_newest 858500 0 ataly 2013-03-19 11:12:54 -0700 Add a data member (and getter, setter methods) to V8PerContextData that holds a pointer to V8DOMActivityLogger. This member is set while initializing the context for a V8DOMWindowShell. Ownership of the pointer is still retained by the HashMap in DOMWrapperWorld. 858807 1 ataly 2013-03-19 15:25:57 -0700 Subsequent patches (addressing Bug: 107207) will then obtain a reference to the V8DOMActivityLogger directly from PerContextData attached to the current context. The assumption is that this is faster than getting the reference from the HashMap in DOMWrapperWorld 858899 2 193953 ataly 2013-03-19 17:29:48 -0700 Created attachment 193953 Patch 858907 3 193953 haraken 2013-03-19 17:39:23 -0700 Comment on attachment 193953 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=193953&action=review Looks OK > Source/WebCore/ChangeLog:16 > + Cache a pointer to V8DOMActivityLogger in PerContextData. > + Adds a data member (and getter, setter methods) to V8PerContextData > + that holds a pointer to a V8DOMActivityLogger. This member is set while > + initializing the context for a V8DOMWindowShell. Ownership of the pointer > + is still retained by the HashMap in DOMWrapperWorld. > + As a result of this patch, subsequent patches that will implement logging > + for DOM API access (See bug 107207) will be able to obtain a reference to > + the logger directly from PerContextData. This will benefit performance as it > + will be faster than looking up the logger in the HashMap in DOMWrapperWorld. > + https://bugs.webkit.org/show_bug.cgi?id=112719 > + > + Reviewed by NOBODY (OOPS!). > + > + There are no new tests as there is no change in behavior. Nit: In WebKit we write a bug title (which should be in one line), a bug URL, a bug description, and a test, in this order. Please fix it before landing. > Source/WebCore/bindings/v8/V8PerContextData.h:128 > + V8DOMActivityLogger* m_activityLogger; Would you add a comment about the lifetime? 858928 4 193960 ataly 2013-03-19 18:04:31 -0700 Created attachment 193960 Patch 858930 5 193960 haraken 2013-03-19 18:05:18 -0700 Comment on attachment 193960 Patch Thanks! 858997 6 193960 webkit.review.bot 2013-03-19 19:41:15 -0700 Comment on attachment 193960 Patch Clearing flags on attachment: 193960 Committed r146295: <http://trac.webkit.org/changeset/146295> 858998 7 webkit.review.bot 2013-03-19 19:41:18 -0700 All reviewed patches have been landed. Closing bug. 193953 2013-03-19 17:29:48 -0700 2013-03-19 18:04:27 -0700 Patch bug-112719-20130319172539.patch text/plain 3160 ataly SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0NjI3OCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI3IEBACisyMDEzLTAzLTE5ICBBbmt1ciBU YWx5ICA8YXRhbHlAZ29vZ2xlLmNvbT4KKworICAgICAgICBDYWNoZSBhIHBvaW50ZXIgdG8gVjhE T01BY3Rpdml0eUxvZ2dlciBpbiBQZXJDb250ZXh0RGF0YS4KKyAgICAgICAgQWRkcyBhIGRhdGEg bWVtYmVyIChhbmQgZ2V0dGVyLCBzZXR0ZXIgbWV0aG9kcykgdG8gVjhQZXJDb250ZXh0RGF0YQor ICAgICAgICB0aGF0IGhvbGRzIGEgcG9pbnRlciB0byBhIFY4RE9NQWN0aXZpdHlMb2dnZXIuIFRo aXMgbWVtYmVyIGlzIHNldCB3aGlsZQorICAgICAgICBpbml0aWFsaXppbmcgdGhlIGNvbnRleHQg Zm9yIGEgVjhET01XaW5kb3dTaGVsbC4gT3duZXJzaGlwIG9mIHRoZSBwb2ludGVyCisgICAgICAg IGlzIHN0aWxsIHJldGFpbmVkIGJ5IHRoZSBIYXNoTWFwIGluIERPTVdyYXBwZXJXb3JsZC4KKyAg ICAgICAgQXMgYSByZXN1bHQgb2YgdGhpcyBwYXRjaCwgc3Vic2VxdWVudCBwYXRjaGVzIHRoYXQg d2lsbCBpbXBsZW1lbnQgbG9nZ2luZworICAgICAgICBmb3IgRE9NIEFQSSBhY2Nlc3MgKFNlZSBi dWcgMTA3MjA3KSB3aWxsIGJlIGFibGUgdG8gb2J0YWluIGEgcmVmZXJlbmNlIHRvCisgICAgICAg IHRoZSBsb2dnZXIgZGlyZWN0bHkgZnJvbSBQZXJDb250ZXh0RGF0YS4gVGhpcyB3aWxsIGJlbmVm aXQgcGVyZm9ybWFuY2UgYXMgaXQKKyAgICAgICAgd2lsbCBiZSBmYXN0ZXIgdGhhbiBsb29raW5n IHVwIHRoZSBsb2dnZXIgaW4gdGhlIEhhc2hNYXAgaW4gRE9NV3JhcHBlcldvcmxkLgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEyNzE5CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlcmUgYXJlIG5vIG5l dyB0ZXN0cyBhcyB0aGVyZSBpcyBubyBjaGFuZ2UgaW4gYmVoYXZpb3IuCisKKyAgICAgICAgKiBi aW5kaW5ncy92OC9WOERPTVdpbmRvd1NoZWxsLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlY4RE9N V2luZG93U2hlbGw6OmluaXRpYWxpemVJZk5lZWRlZCk6CisgICAgICAgICogYmluZGluZ3Mvdjgv VjhQZXJDb250ZXh0RGF0YS5oOgorICAgICAgICAoV2ViQ29yZTo6VjhQZXJDb250ZXh0RGF0YTo6 YWN0aXZpdHlMb2dnZXIpOgorICAgICAgICAoVjhQZXJDb250ZXh0RGF0YSk6CisgICAgICAgIChX ZWJDb3JlOjpWOFBlckNvbnRleHREYXRhOjpzZXRBY3Rpdml0eUxvZ2dlcik6CisKIDIwMTMtMDMt MTkgIERvbWluaWMgTWF6em9uaSAgPGRtYXp6b25pQGdvb2dsZS5jb20+CiAKICAgICAgICAgSW1w bGVtZW50IFdlYiBTcGVlY2ggU3ludGhlc2lzIGZvciBDaHJvbWl1bQpJbmRleDogU291cmNlL1dl YkNvcmUvYmluZGluZ3MvdjgvVjhET01XaW5kb3dTaGVsbC5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhET01XaW5kb3dTaGVsbC5jcHAJKHJldmlzaW9uIDE0 NjI3OCkKKysrIFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4RE9NV2luZG93U2hlbGwuY3Bw CSh3b3JraW5nIGNvcHkpCkBAIC0yMzksNyArMjM5LDcgQEAgYm9vbCBWOERPTVdpbmRvd1NoZWxs Ojppbml0aWFsaXplSWZOZWVkZQogICAgICAgICBkaXNwb3NlQ29udGV4dCgpOwogICAgICAgICBy ZXR1cm4gZmFsc2U7CiAgICAgfQotCisgICAgbV9wZXJDb250ZXh0RGF0YS0+c2V0QWN0aXZpdHlM b2dnZXIoRE9NV3JhcHBlcldvcmxkOjphY3Rpdml0eUxvZ2dlcihtX3dvcmxkLT53b3JsZElkKCkp KTsKICAgICBpZiAoIWluc3RhbGxET01XaW5kb3coKSkgewogICAgICAgICBkaXNwb3NlQ29udGV4 dCgpOwogICAgICAgICByZXR1cm4gZmFsc2U7CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9iaW5kaW5n cy92OC9WOFBlckNvbnRleHREYXRhLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvYmlu ZGluZ3MvdjgvVjhQZXJDb250ZXh0RGF0YS5oCShyZXZpc2lvbiAxNDYyNzgpCisrKyBTb3VyY2Uv V2ViQ29yZS9iaW5kaW5ncy92OC9WOFBlckNvbnRleHREYXRhLmgJKHdvcmtpbmcgY29weSkKQEAg LTMyLDYgKzMyLDcgQEAKICNkZWZpbmUgVjhQZXJDb250ZXh0RGF0YV9oCiAKICNpbmNsdWRlICJT Y29wZWRQZXJzaXN0ZW50LmgiCisjaW5jbHVkZSAiVjhET01BY3Rpdml0eUxvZ2dlci5oIgogI2lu Y2x1ZGUgIldyYXBwZXJUeXBlSW5mby5oIgogI2luY2x1ZGUgPHY4Lmg+CiAjaW5jbHVkZSA8d3Rm L0hhc2hNYXAuaD4KQEAgLTkzLDYgKzk0LDE2IEBAIHB1YmxpYzoKICAgICAgICAgcmV0dXJuICZt X3Y4TlBPYmplY3RNYXA7CiAgICAgfQogCisgICAgVjhET01BY3Rpdml0eUxvZ2dlciogYWN0aXZp dHlMb2dnZXIoKQorICAgIHsKKyAgICAgICAgcmV0dXJuIG1fYWN0aXZpdHlMb2dnZXI7CisgICAg fQorCisgICAgdm9pZCBzZXRBY3Rpdml0eUxvZ2dlcihWOERPTUFjdGl2aXR5TG9nZ2VyKiBsb2dn ZXIpCisgICAgeworICAgICAgICBtX2FjdGl2aXR5TG9nZ2VyID0gbG9nZ2VyOworICAgIH0KKwog cHJpdmF0ZToKICAgICBleHBsaWNpdCBWOFBlckNvbnRleHREYXRhKHY4OjpQZXJzaXN0ZW50PHY4 OjpDb250ZXh0PiBjb250ZXh0KQogICAgICAgICA6IG1fY29udGV4dChjb250ZXh0KQpAQCAtMTE0 LDYgKzEyNSw3IEBAIHByaXZhdGU6CiAKICAgICBWOE5QT2JqZWN0TWFwIG1fdjhOUE9iamVjdE1h cDsKIAorICAgIFY4RE9NQWN0aXZpdHlMb2dnZXIqIG1fYWN0aXZpdHlMb2dnZXI7CiAgICAgdjg6 OlBlcnNpc3RlbnQ8djg6OkNvbnRleHQ+IG1fY29udGV4dDsKICAgICBTY29wZWRQZXJzaXN0ZW50 PHY4OjpWYWx1ZT4gbV9lcnJvclByb3RvdHlwZTsKICAgICBTY29wZWRQZXJzaXN0ZW50PHY4OjpW YWx1ZT4gbV9vYmplY3RQcm90b3R5cGU7Cg== 193960 2013-03-19 18:04:31 -0700 2013-03-19 19:41:15 -0700 Patch bug-112719-20130319180021.patch text/plain 3439 ataly SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0NjI3OCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI5IEBACisyMDEzLTAzLTE5ICBBbmt1ciBU YWx5ICA8YXRhbHlAZ29vZ2xlLmNvbT4KKworICAgICAgICBDYWNoZSBhIHBvaW50ZXIgdG8gVjhE T01BY3Rpdml0eUxvZ2dlciBpbiBQZXJDb250ZXh0RGF0YS4KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMjcxOQorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZHMgYSBkYXRhIG1lbWJlciAoYW5kIGdldHRl ciwgc2V0dGVyIG1ldGhvZHMpIHRvIFY4UGVyQ29udGV4dERhdGEKKyAgICAgICAgdGhhdCBob2xk cyBhIHBvaW50ZXIgdG8gYSBWOERPTUFjdGl2aXR5TG9nZ2VyLiBUaGlzIG1lbWJlciBpcyBzZXQg d2hpbGUKKyAgICAgICAgaW5pdGlhbGl6aW5nIHRoZSBjb250ZXh0IGZvciBhIFY4RE9NV2luZG93 U2hlbGwuIE93bmVyc2hpcCBvZiB0aGUgcG9pbnRlcgorICAgICAgICBpcyBzdGlsbCByZXRhaW5l ZCBieSB0aGUgSGFzaE1hcCBpbiBET01XcmFwcGVyV29ybGQuCisgICAgICAgIEFzIGEgcmVzdWx0 IG9mIHRoaXMgcGF0Y2gsIHN1YnNlcXVlbnQgcGF0Y2hlcyB0aGF0IHdpbGwgaW1wbGVtZW50IGxv Z2dpbmcKKyAgICAgICAgZm9yIERPTSBBUEkgYWNjZXNzIChTZWUgYnVnIDEwNzIwNykgd2lsbCBi ZSBhYmxlIHRvIG9idGFpbiBhIHJlZmVyZW5jZSB0bworICAgICAgICB0aGUgbG9nZ2VyIGRpcmVj dGx5IGZyb20gUGVyQ29udGV4dERhdGEuIFRoaXMgd2lsbCBiZW5lZml0IHBlcmZvcm1hbmNlIGFz IGl0CisgICAgICAgIHdpbGwgYmUgZmFzdGVyIHRoYW4gbG9va2luZyB1cCB0aGUgbG9nZ2VyIGlu IHRoZSBET01BY3Rpdml0eUxvZ2dlck1hcCBpbgorICAgICAgICBET01XcmFwcGVyV29ybGQuCisK KyAgICAgICAgVGhlcmUgYXJlIG5vIG5ldyB0ZXN0cyBhcyB0aGVyZSBpcyBubyBjaGFuZ2UgaW4g YmVoYXZpb3IuCisKKyAgICAgICAgKiBiaW5kaW5ncy92OC9WOERPTVdpbmRvd1NoZWxsLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OlY4RE9NV2luZG93U2hlbGw6OmluaXRpYWxpemVJZk5lZWRlZCk6 CisgICAgICAgICogYmluZGluZ3MvdjgvVjhQZXJDb250ZXh0RGF0YS5oOgorICAgICAgICAoV2Vi Q29yZTo6VjhQZXJDb250ZXh0RGF0YTo6YWN0aXZpdHlMb2dnZXIpOgorICAgICAgICAoVjhQZXJD b250ZXh0RGF0YSk6CisgICAgICAgIChXZWJDb3JlOjpWOFBlckNvbnRleHREYXRhOjpzZXRBY3Rp dml0eUxvZ2dlcik6CisKIDIwMTMtMDMtMTkgIERvbWluaWMgTWF6em9uaSAgPGRtYXp6b25pQGdv b2dsZS5jb20+CiAKICAgICAgICAgSW1wbGVtZW50IFdlYiBTcGVlY2ggU3ludGhlc2lzIGZvciBD aHJvbWl1bQpJbmRleDogU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhET01XaW5kb3dTaGVs bC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhET01XaW5k b3dTaGVsbC5jcHAJKHJldmlzaW9uIDE0NjI3OCkKKysrIFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdz L3Y4L1Y4RE9NV2luZG93U2hlbGwuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yMzksNyArMjM5LDcg QEAgYm9vbCBWOERPTVdpbmRvd1NoZWxsOjppbml0aWFsaXplSWZOZWVkZQogICAgICAgICBkaXNw b3NlQ29udGV4dCgpOwogICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgfQotCisgICAgbV9wZXJD b250ZXh0RGF0YS0+c2V0QWN0aXZpdHlMb2dnZXIoRE9NV3JhcHBlcldvcmxkOjphY3Rpdml0eUxv Z2dlcihtX3dvcmxkLT53b3JsZElkKCkpKTsKICAgICBpZiAoIWluc3RhbGxET01XaW5kb3coKSkg ewogICAgICAgICBkaXNwb3NlQ29udGV4dCgpOwogICAgICAgICByZXR1cm4gZmFsc2U7CkluZGV4 OiBTb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOFBlckNvbnRleHREYXRhLmgKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhQZXJDb250ZXh0RGF0YS5oCShyZXZp c2lvbiAxNDYyNzgpCisrKyBTb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOFBlckNvbnRleHRE YXRhLmgJKHdvcmtpbmcgY29weSkKQEAgLTMyLDYgKzMyLDcgQEAKICNkZWZpbmUgVjhQZXJDb250 ZXh0RGF0YV9oCiAKICNpbmNsdWRlICJTY29wZWRQZXJzaXN0ZW50LmgiCisjaW5jbHVkZSAiVjhE T01BY3Rpdml0eUxvZ2dlci5oIgogI2luY2x1ZGUgIldyYXBwZXJUeXBlSW5mby5oIgogI2luY2x1 ZGUgPHY4Lmg+CiAjaW5jbHVkZSA8d3RmL0hhc2hNYXAuaD4KQEAgLTkzLDYgKzk0LDE2IEBAIHB1 YmxpYzoKICAgICAgICAgcmV0dXJuICZtX3Y4TlBPYmplY3RNYXA7CiAgICAgfQogCisgICAgVjhE T01BY3Rpdml0eUxvZ2dlciogYWN0aXZpdHlMb2dnZXIoKQorICAgIHsKKyAgICAgICAgcmV0dXJu IG1fYWN0aXZpdHlMb2dnZXI7CisgICAgfQorCisgICAgdm9pZCBzZXRBY3Rpdml0eUxvZ2dlcihW OERPTUFjdGl2aXR5TG9nZ2VyKiBsb2dnZXIpCisgICAgeworICAgICAgICBtX2FjdGl2aXR5TG9n Z2VyID0gbG9nZ2VyOworICAgIH0KKwogcHJpdmF0ZToKICAgICBleHBsaWNpdCBWOFBlckNvbnRl eHREYXRhKHY4OjpQZXJzaXN0ZW50PHY4OjpDb250ZXh0PiBjb250ZXh0KQogICAgICAgICA6IG1f Y29udGV4dChjb250ZXh0KQpAQCAtMTEzLDcgKzEyNCwxMCBAQCBwcml2YXRlOgogICAgIENvbnN0 cnVjdG9yTWFwIG1fY29uc3RydWN0b3JNYXA7CiAKICAgICBWOE5QT2JqZWN0TWFwIG1fdjhOUE9i amVjdE1hcDsKLQorICAgIC8vIFdlIGNhY2hlIGEgcG9pbnRlciB0byB0aGUgVjhET01BY3Rpdml0 eUxvZ2dlciBhc3NvY2lhdGVkIHdpdGggdGhlIHdvcmxkCisgICAgLy8gY29ycmVzcG9uZGluZyB0 byB0aGlzIGNvbnRleHQuIFRoZSBvd25lcnNoaXAgb2YgdGhlIHBvaW50ZXIgaXMgcmV0YWluZWQK KyAgICAvLyBieSB0aGUgRE9NQWN0aXZpdHlMb2dnZXJNYXAgaW4gRE9NV3JhcHBlcldvcmxkLgor ICAgIFY4RE9NQWN0aXZpdHlMb2dnZXIqIG1fYWN0aXZpdHlMb2dnZXI7CiAgICAgdjg6OlBlcnNp c3RlbnQ8djg6OkNvbnRleHQ+IG1fY29udGV4dDsKICAgICBTY29wZWRQZXJzaXN0ZW50PHY4OjpW YWx1ZT4gbV9lcnJvclByb3RvdHlwZTsKICAgICBTY29wZWRQZXJzaXN0ZW50PHY4OjpWYWx1ZT4g bV9vYmplY3RQcm90b3R5cGU7Cg==