112707 2013-03-19 09:30:30 -0700 [BlackBerry] When selecting an object, assign focus to new node instead of clearing previous focused node 2013-03-19 11:33:30 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 andchen webkit-unassigned mifenton rwlbuis tonikitoo webkit.review.bot oldest_to_newest 858349 0 andchen 2013-03-19 09:30:30 -0700 Currently we clear focus if the select point is not inside the input field, then set focus to the new node when selectionChanged is called. This would cause unexpected behaviour for client. 858357 1 193844 andchen 2013-03-19 09:41:05 -0700 Created attachment 193844 Patch 858379 2 mifenton 2013-03-19 09:54:59 -0700 Looks good to me. 858475 3 193844 rwlbuis 2013-03-19 10:57:12 -0700 Comment on attachment 193844 Patch LGTM. 858521 4 193844 webkit.review.bot 2013-03-19 11:33:27 -0700 Comment on attachment 193844 Patch Clearing flags on attachment: 193844 Committed r146226: <http://trac.webkit.org/changeset/146226> 858522 5 webkit.review.bot 2013-03-19 11:33:30 -0700 All reviewed patches have been landed. Closing bug. 193844 2013-03-19 09:41:05 -0700 2013-03-19 11:33:26 -0700 Patch bug-112707-20130319123655.patch text/plain 3918 andchen U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ2MjA2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCA0NjVkNWIzYTkyNGVjY2VjNzMxMjFjZWQ4YzA1ODRlMjVlZjg0ZmI0Li4wOGI2ZjIxODJi ODA0NzE3ZDRmNjJlNGVjOTY1NTUxNjM2MTlmODk3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwyMyBAQAorMjAxMy0wMy0xOSAgQW5keSBDaGVuICA8YW5kY2hlbkBi bGFja2JlcnJ5LmNvbT4KKworICAgICAgICBbQmxhY2tCZXJyeV0gV2hlbiBzZWxlY3RpbmcgYW4g b2JqZWN0LCBhc3NpZ24gZm9jdXMgdG8gbmV3IG5vZGUgaW5zdGVhZCBvZiBjbGVhcmluZyBwcmV2 aW91cyBmb2N1c2VkIG5vZGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTExMjcwNworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIEluIFNlbGVjdGlvbkhhbmRsZXIsIHdoZW4gc2VsZWN0aW5nIGEgbmV3IG9iamVj dCwgd2Ugc2hvdWxkIHNldCBmb2N1cworICAgICAgICB0byB0aGUgYW5jaG9yIG5vZGUgb2Ygc2Vs ZWN0aW9uIGluc3RlYWQgb2YgcmVtb3ZpbmcgaXQgZnJvbSB0aGUgb2xkIGlucHV0LgorICAgICAg ICBJbiBJbnB1dEhhbmRsZXIsIHdoZW4gZm9jdXNlZE5vZGVDaGFuZ2VkIGlzIGNhbGxlZCwgaWYg dGhlIG5ldyBub2RlIGlzCisgICAgICAgIG5vdCBhbiBFbGVtZW50IG5vZGUsIHdlIG5lZWQgdG8g c2V0IGZvY3VzIHRvIGl0cyBFbGVtZW50IHBhcmVudCBub2RlLAorICAgICAgICBpbnN0ZWFkIG9m IHJlbW92aW5nIGZvY3VzIGZyb20gdGhlIG9sZCBub2RlLgorICAgICAgICBQUiAzMDQ2MzEKKyAg ICAgICAgSW50ZXJuYWxseSByZXZpZXdlZCBieSBNaWtlIEZlbnRvbi4KKworICAgICAgICAqIFdl YktpdFN1cHBvcnQvSW5wdXRIYW5kbGVyLmNwcDoKKyAgICAgICAgKEJsYWNrQmVycnk6OldlYktp dDo6SW5wdXRIYW5kbGVyOjpmb2N1c2VkTm9kZUNoYW5nZWQpOgorICAgICAgICAqIFdlYktpdFN1 cHBvcnQvU2VsZWN0aW9uSGFuZGxlci5jcHA6CisgICAgICAgIChCbGFja0JlcnJ5OjpXZWJLaXQ6 OlNlbGVjdGlvbkhhbmRsZXI6OnNlbGVjdE9iamVjdCk6CisKIDIwMTMtMDMtMTggIEFsYmVydG8g R2FyY2lhICA8YWdhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtCbGFja0JlcnJ5XSBQcmV2 ZW50IHRleHQgc2VsZWN0aW9uIGluc2lkZSBDb2xvdXIgYW5kIERhdGUvVGltZSBpbnB1dCBmaWVs ZHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L0lu cHV0SGFuZGxlci5jcHAgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9J bnB1dEhhbmRsZXIuY3BwCmluZGV4IGJiZDZiZDRlZjA5NDE3N2UxYTExMzk2NjgxYzc0OTU1NDNh Y2RjZDYuLjU4ZWJmYjdjN2E0MjRjNDcxOTBmMGE4NjhlZTQwNTFhODliNzNlOWUgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L0lucHV0SGFuZGxlci5j cHAKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYktpdFN1cHBvcnQvSW5wdXRIYW5k bGVyLmNwcApAQCAtNDQyLDYgKzQ0Miw5IEBAIHZvaWQgSW5wdXRIYW5kbGVyOjpmb2N1c2VkTm9k ZUNoYW5nZWQoKQogICAgICAgICAgICAgc2V0RWxlbWVudEZvY3VzZWQoZWxlbWVudCk7CiAgICAg ICAgICAgICByZXR1cm47CiAgICAgICAgIH0KKyAgICB9IGVsc2UgaWYgKG5vZGUgJiYgRE9NU3Vw cG9ydDo6aXNUZXh0QmFzZWRDb250ZW50RWRpdGFibGVFbGVtZW50KG5vZGUtPnBhcmVudEVsZW1l bnQoKSkpIHsKKyAgICAgICAgc2V0RWxlbWVudEZvY3VzZWQobm9kZS0+cGFyZW50RWxlbWVudCgp KTsKKyAgICAgICAgcmV0dXJuOwogICAgIH0KIAogICAgIGlmIChpc0FjdGl2ZVRleHRFZGl0KCkg JiYgbV9jdXJyZW50Rm9jdXNFbGVtZW50LT5pc0NvbnRlbnRFZGl0YWJsZSgpKSB7CmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9TZWxlY3Rpb25IYW5k bGVyLmNwcCBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L1NlbGVjdGlv bkhhbmRsZXIuY3BwCmluZGV4IGUwMmRkMGZlMTg2NTJiMTlmNTkxYWE0MjQzZDI1MmNmOTJkZDJi ODIuLjRiMjk2Y2Y0OTNiNzZkZWI0MzA3NmMyYjczZDY4NTI4OTllODQyNjMgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L1NlbGVjdGlvbkhhbmRsZXIu Y3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L1NlbGVjdGlv bkhhbmRsZXIuY3BwCkBAIC0yMywxMiArMjMsMTQgQEAKICNpbmNsdWRlICJEb2N1bWVudC5oIgog I2luY2x1ZGUgIkZhdEZpbmdlcnMuaCIKICNpbmNsdWRlICJGbG9hdFF1YWQuaCIKKyNpbmNsdWRl ICJGb2N1c0NvbnRyb2xsZXIuaCIKICNpbmNsdWRlICJGcmFtZS5oIgogI2luY2x1ZGUgIkZyYW1l U2VsZWN0aW9uLmgiCiAjaW5jbHVkZSAiRnJhbWVWaWV3LmgiCiAjaW5jbHVkZSAiSGl0VGVzdFJl c3VsdC5oIgogI2luY2x1ZGUgIklucHV0SGFuZGxlci5oIgogI2luY2x1ZGUgIkludFJlY3QuaCIK KyNpbmNsdWRlICJQYWdlLmgiCiAjaW5jbHVkZSAiUmVuZGVyTGF5ZXIuaCIKICNpbmNsdWRlICJT ZWxlY3Rpb25PdmVybGF5LmgiCiAjaW5jbHVkZSAiVG91Y2hFdmVudEhhbmRsZXIuaCIKQEAgLTg4 MCwxMyArODgyLDE0IEBAIHZvaWQgU2VsZWN0aW9uSGFuZGxlcjo6c2VsZWN0T2JqZWN0KGNvbnN0 IFdlYkNvcmU6OkludFBvaW50JiBsb2NhdGlvbiwgVGV4dEdyYW51CiAgICAgICAgIFBsYXRmb3Jt OjpJbnRQb2ludChsb2NhdGlvbikudG9TdHJpbmcoKS5jX3N0cigpKTsKIAogICAgIFdlYkNvcmU6 OkludFBvaW50IHJlbGF0aXZlUG9pbnQgPSBET01TdXBwb3J0Ojpjb252ZXJ0UG9pbnRUb0ZyYW1l KG1fd2ViUGFnZS0+bWFpbkZyYW1lKCksIGZvY3VzZWRGcmFtZSwgbG9jYXRpb24pOwotICAgIC8v IENsZWFyIGlucHV0IGZvY3VzIGlmIHdlJ3JlIG5vdCBzZWxlY3RpbmcgaW4gb2xkIGlucHV0IGZp ZWxkLgotICAgIGlmICghbV93ZWJQYWdlLT5tX2lucHV0SGFuZGxlci0+Ym91bmRpbmdCb3hGb3JJ bnB1dEZpZWxkKCkuY29udGFpbnMocmVsYXRpdmVQb2ludCkpCi0gICAgICAgIG1fd2ViUGFnZS0+ Y2xlYXJGb2N1c05vZGUoKTsKIAogICAgIFZpc2libGVQb3NpdGlvbiBwb2ludExvY2F0aW9uKGZv Y3VzZWRGcmFtZS0+dmlzaWJsZVBvc2l0aW9uRm9yUG9pbnQocmVsYXRpdmVQb2ludCkpOwogICAg IFZpc2libGVTZWxlY3Rpb24gc2VsZWN0aW9uID0gVmlzaWJsZVNlbGVjdGlvbihwb2ludExvY2F0 aW9uLCBwb2ludExvY2F0aW9uKTsKIAorICAgIC8vIE1vdmUgZm9jdXMgdG8gdGhlIG5ldyBub2Rl IGlmIHdlJ3JlIG5vdCBzZWxlY3RpbmcgaW4gb2xkIGlucHV0IGZpZWxkLgorICAgIGlmICghbV93 ZWJQYWdlLT5tX2lucHV0SGFuZGxlci0+Ym91bmRpbmdCb3hGb3JJbnB1dEZpZWxkKCkuY29udGFp bnMocmVsYXRpdmVQb2ludCkpCisgICAgICAgIG1fd2ViUGFnZS0+bV9wYWdlLT5mb2N1c0NvbnRy b2xsZXIoKS0+c2V0Rm9jdXNlZE5vZGUoc2VsZWN0aW9uLnN0YXJ0KCkuYW5jaG9yTm9kZSgpLCBm b2N1c2VkRnJhbWUpOworCiAgICAgbV9zZWxlY3Rpb25BY3RpdmUgPSBleHBhbmRTZWxlY3Rpb25U b0dyYW51bGFyaXR5KGZvY3VzZWRGcmFtZSwgc2VsZWN0aW9uLCBncmFudWxhcml0eSwgbV93ZWJQ YWdlLT5tX2lucHV0SGFuZGxlci0+aXNJbnB1dE1vZGUoKSk7CiB9CiAK