112699 2013-03-19 08:10:59 -0700 [Qt] Qt 4.8 Tool related stuff removal from Trunk. 2013-03-21 01:12:19 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kadam webkit-unassigned abarth allan.jensen dpranke eric hausmann ossy webkit.review.bot zarvai oldest_to_newest 858297 0 kadam 2013-03-19 08:10:59 -0700 Qt 4.8 stuff will be removed from Trunk. The patch is coming soon. 858480 1 193865 kadam 2013-03-19 11:00:21 -0700 Created attachment 193865 proposed patch 858604 2 abarth 2013-03-19 12:23:20 -0700 I presume you ran test-webkitpy. 859421 3 kadam 2013-03-20 08:07:22 -0700 Thanks for your review. yes, I did. They work fine. 859434 4 kadam 2013-03-20 08:13:36 -0700 Committed r146347: <http://trac.webkit.org/changeset/146347> 860127 5 kadam 2013-03-21 01:12:19 -0700 Qt 4.8 results removed from Trunk. http://trac.webkit.org/changeset/146352 193865 2013-03-19 11:00:21 -0700 2013-03-19 12:23:07 -0700 proposed patch removalqt4_8.patch text/plain 5444 kadam ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBmMzcz OTBlLi5hMGVjNGY3YiAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0No YW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEzLTAzLTE5ICDDgWTDoW0gS2FsbGFpICA8a2Fk YW1AaW5mLnUtc3plZ2VkLmh1PgorCisgICAgICAgIFtRdF0gUXQgNC44IHRvb2wgcmVsYXRlZCBz dHVmZiByZW1vdmFsIGZyb20gd2Via2l0cHkuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xMTI2OTkuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0 L3F0LnB5OgorICAgICAgICAoUXRQb3J0Ll9zZWFyY2hfcGF0aHMpOgorICAgICAgICAoUXRQb3J0 Ll9wb3J0X3NwZWNpZmljX2V4cGVjdGF0aW9uc19maWxlcyk6CisgICAgICAgICogU2NyaXB0cy93 ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9xdF91bml0dGVzdC5weToKKyAgICAgICAgKFF0UG9y dFRlc3QpOgorICAgICAgICAoUXRQb3J0VGVzdC5fYXNzZXJ0X3NlYXJjaF9wYXRoKToKKyAgICAg ICAgKFF0UG9ydFRlc3QuX2Fzc2VydF9leHBlY3RhdGlvbnNfZmlsZXMpOgorCiAyMDEzLTAzLTE5 ICBBbGxhbiBTYW5kZmVsZCBKZW5zZW4gIDxhbGxhbi5qZW5zZW5AZGlnaWEuY29tPgogCiAgICAg ICAgIFtRdF0gTWFrZSBJbWFnZURpZmYgc2ltaWxhciB0byBDaHJvbWl1bSdzIEltYWdlRGlmZgpk aWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9xdC5w eSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvcXQucHkKaW5kZXgg MDMyZjhlYS4uNDg0MDcyNSAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlv dXRfdGVzdHMvcG9ydC9xdC5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90 ZXN0cy9wb3J0L3F0LnB5CkBAIC0xMjIsOCArMTIyLDggQEAgY2xhc3MgUXRQb3J0KFBvcnQpOgog ICAgICAgICAjICAgICAgICAgICAgICAgIC8KICAgICAgICAgIyBxdC01LjAtd2sxICAgIHF0LTUu MC13azIKICAgICAgICAgIyAgICAgICAgICAgIFwvCi0gICAgICAgICMgICAgICAgICBxdC01LjAg ICAgcXQtNC44Ci0gICAgICAgICMgICAgICAgICAgICAgICAgXC8KKyAgICAgICAgIyAgICAgICAg IHF0LTUuMAorICAgICAgICAjICAgICAgICAgICAgICAgIFwKICAgICAgICAgIyAgICAocXQtbGlu dXh8cXQtbWFjfHF0LXdpbikKICAgICAgICAgIyAgICAgICAgICAgICAgICB8CiAgICAgICAgICMg ICAgICAgICAgICAgICBxdApAQCAtMTM2LDEwICsxMzYsOCBAQCBjbGFzcyBRdFBvcnQoUG9ydCk6 CiAgICAgICAgICAgICAgICAgc2VhcmNoX3BhdGhzLmFwcGVuZCgncXQtNS4wLXdrMicpCiAgICAg ICAgICAgICBlbHNlOgogICAgICAgICAgICAgICAgIHNlYXJjaF9wYXRocy5hcHBlbmQoJ3F0LTUu MC13azEnKQotICAgICAgICBpZiAnNC44JyBpbiB2ZXJzaW9uOgotICAgICAgICAgICAgc2VhcmNo X3BhdGhzLmFwcGVuZCgncXQtNC44JykKLSAgICAgICAgZWxpZiB2ZXJzaW9uOgotICAgICAgICAg ICAgc2VhcmNoX3BhdGhzLmFwcGVuZCgncXQtNS4wJykKKyAgICAgICAgc2VhcmNoX3BhdGhzLmFw cGVuZCgncXQtNS4wJykKKwogICAgICAgICBzZWFyY2hfcGF0aHMuYXBwZW5kKHNlbGYucG9ydF9u YW1lICsgJy0nICsgc2VsZi5vcGVyYXRpbmdfc3lzdGVtKCkpCiAgICAgICAgIHNlYXJjaF9wYXRo cy5hcHBlbmQoc2VsZi5wb3J0X25hbWUpCiAgICAgICAgIHJldHVybiBzZWFyY2hfcGF0aHMKQEAg LTE1Myw3ICsxNTEsNyBAQCBjbGFzcyBRdFBvcnQoUG9ydCk6CiAgICAgICAgICAgICBwYXRocy5h cHBlbmQoJ3drMicpCiAKICAgICAgICAgIyBleHBlY3RhdGlvbnNfZmlsZXMoKSB1c2VzIHRoZSBk aXJlY3RvcmllcyBsaXN0ZWQgaW4gX3NlYXJjaF9wYXRocyByZXZlcnNlZC4KLSAgICAgICAgIyBl LmcuIHF0IC0+IHF0LWxpbnV4IC0+IHF0LTQuOAorICAgICAgICAjIGUuZy4gcXQgLT4gcXQtbGlu dXggLT4gcXQtNS4wIC0+IHF0LTUuMC13azEKICAgICAgICAgcmV0dXJuIGxpc3QocmV2ZXJzZWQo W3NlbGYuX2ZpbGVzeXN0ZW0uam9pbihzZWxmLl93ZWJraXRfYmFzZWxpbmVfcGF0aChwKSwgJ1Rl c3RFeHBlY3RhdGlvbnMnKSBmb3IgcCBpbiBwYXRoc10pKQogCiAgICAgZGVmIHNldHVwX2Vudmly b25fZm9yX3NlcnZlcihzZWxmLCBzZXJ2ZXJfbmFtZT1Ob25lKToKZGlmZiAtLWdpdCBhL1Rvb2xz L1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvcXRfdW5pdHRlc3QucHkgYi9Ub29s cy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3F0X3VuaXR0ZXN0LnB5CmluZGV4 IDNiZmViOGMuLjJhZGZiYzEgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5 b3V0X3Rlc3RzL3BvcnQvcXRfdW5pdHRlc3QucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRw eS9sYXlvdXRfdGVzdHMvcG9ydC9xdF91bml0dGVzdC5weQpAQCAtNDIsMTQgKzQyLDYgQEAgY2xh c3MgUXRQb3J0VGVzdChwb3J0X3Rlc3RjYXNlLlBvcnRUZXN0Q2FzZSk6CiAgICAgcG9ydF9uYW1l ID0gJ3F0LW1hYycKICAgICBwb3J0X21ha2VyID0gUXRQb3J0CiAgICAgc2VhcmNoX3BhdGhzX2Nh c2VzID0gWwotICAgICAgICB7J3NlYXJjaF9wYXRocyc6WydxdC00LjgnLCAncXQtbWFjJywgJ3F0 J10sICdvc19uYW1lJzonbWFjJywgJ3VzZV93ZWJraXQyJzpGYWxzZSwgJ3F0X3ZlcnNpb24nOic0 LjgnfSwKLSAgICAgICAgeydzZWFyY2hfcGF0aHMnOlsncXQtNC44JywgJ3F0LXdpbicsICdxdCdd LCAnb3NfbmFtZSc6J3dpbicsICd1c2Vfd2Via2l0Mic6RmFsc2UsICdxdF92ZXJzaW9uJzonNC44 J30sCi0gICAgICAgIHsnc2VhcmNoX3BhdGhzJzpbJ3F0LTQuOCcsICdxdC1saW51eCcsICdxdCdd LCAnb3NfbmFtZSc6J2xpbnV4JywgJ3VzZV93ZWJraXQyJzpGYWxzZSwgJ3F0X3ZlcnNpb24nOic0 LjgnfSwKLQotICAgICAgICB7J3NlYXJjaF9wYXRocyc6WydxdC00LjgnLCAncXQtbWFjJywgJ3F0 J10sICdvc19uYW1lJzonbWFjJywgJ3VzZV93ZWJraXQyJzpGYWxzZX0sCi0gICAgICAgIHsnc2Vh cmNoX3BhdGhzJzpbJ3F0LTQuOCcsICdxdC13aW4nLCAncXQnXSwgJ29zX25hbWUnOid3aW4nLCAn dXNlX3dlYmtpdDInOkZhbHNlfSwKLSAgICAgICAgeydzZWFyY2hfcGF0aHMnOlsncXQtNC44Jywg J3F0LWxpbnV4JywgJ3F0J10sICdvc19uYW1lJzonbGludXgnLCAndXNlX3dlYmtpdDInOkZhbHNl fSwKLQogICAgICAgICB7J3NlYXJjaF9wYXRocyc6WydxdC01LjAtbWFjLXdrMicsICdxdC01LjAt d2syJywgJ3F0LTUuMCcsICdxdC1tYWMnLCAncXQnXSwgJ29zX25hbWUnOidtYWMnLCAndXNlX3dl YmtpdDInOlRydWUsICdxdF92ZXJzaW9uJzonNS4wJ30sCiAgICAgICAgIHsnc2VhcmNoX3BhdGhz JzpbJ3F0LTUuMC13azInLCAncXQtNS4wJywgJ3F0LXdpbicsICdxdCddLCAnb3NfbmFtZSc6J3dp bicsICd1c2Vfd2Via2l0Mic6VHJ1ZSwgJ3F0X3ZlcnNpb24nOic1LjAnfSwKICAgICAgICAgeydz ZWFyY2hfcGF0aHMnOlsncXQtNS4wLXdrMicsICdxdC01LjAnLCAncXQtbGludXgnLCAncXQnXSwg J29zX25hbWUnOidsaW51eCcsICd1c2Vfd2Via2l0Mic6VHJ1ZSwgJ3F0X3ZlcnNpb24nOic1LjAn fSwKQEAgLTU5LDcgKzUxLDcgQEAgY2xhc3MgUXRQb3J0VGVzdChwb3J0X3Rlc3RjYXNlLlBvcnRU ZXN0Q2FzZSk6CiAgICAgICAgIHsnc2VhcmNoX3BhdGhzJzpbJ3F0LTUuMC13azEnLCAncXQtNS4w JywgJ3F0LWxpbnV4JywgJ3F0J10sICdvc19uYW1lJzonbGludXgnLCAndXNlX3dlYmtpdDInOkZh bHNlLCAncXRfdmVyc2lvbic6JzUuMCd9LAogICAgIF0KIAotICAgIGRlZiBfYXNzZXJ0X3NlYXJj aF9wYXRoKHNlbGYsIHNlYXJjaF9wYXRocywgb3NfbmFtZSwgdXNlX3dlYmtpdDI9RmFsc2UsIHF0 X3ZlcnNpb249JzQuOCcpOgorICAgIGRlZiBfYXNzZXJ0X3NlYXJjaF9wYXRoKHNlbGYsIHNlYXJj aF9wYXRocywgb3NfbmFtZSwgdXNlX3dlYmtpdDI9RmFsc2UsIHF0X3ZlcnNpb249JzUuMCcpOgog ICAgICAgICAjIEZJWE1FOiBQb3J0IGNvbnN0cnVjdG9ycyBzaG91bGQgbm90ICJwYXJzZSIgdGhl IHBvcnQgbmFtZSwgYnV0CiAgICAgICAgICMgcmF0aGVyIGJlIHBhc3NlZCBjb21wb25lbnRzIChk aXJlY3RseSBvciB2aWEgc2V0dGVycykuICBPbmNlCiAgICAgICAgICMgd2UgZml4IHRoYXQsIHRo aXMgbWV0aG9kIHdpbGwgbmVlZCBhIHJlLXdyaXRlLgpAQCAtNzEsNyArNjMsNyBAQCBjbGFzcyBR dFBvcnRUZXN0KHBvcnRfdGVzdGNhc2UuUG9ydFRlc3RDYXNlKToKICAgICAgICAgYWJzb2x1dGVf c2VhcmNoX3BhdGhzID0gbWFwKHBvcnQuX3dlYmtpdF9iYXNlbGluZV9wYXRoLCBzZWFyY2hfcGF0 aHMpCiAgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwocG9ydC5iYXNlbGluZV9zZWFyY2hfcGF0aCgp LCBhYnNvbHV0ZV9zZWFyY2hfcGF0aHMpCiAKLSAgICBkZWYgX2Fzc2VydF9leHBlY3RhdGlvbnNf ZmlsZXMoc2VsZiwgc2VhcmNoX3BhdGhzLCBvc19uYW1lLCB1c2Vfd2Via2l0Mj1GYWxzZSwgcXRf dmVyc2lvbj0nNC44Jyk6CisgICAgZGVmIF9hc3NlcnRfZXhwZWN0YXRpb25zX2ZpbGVzKHNlbGYs IHNlYXJjaF9wYXRocywgb3NfbmFtZSwgdXNlX3dlYmtpdDI9RmFsc2UsIHF0X3ZlcnNpb249JzUu MCcpOgogICAgICAgICAjIEZJWE1FOiBQb3J0IGNvbnN0cnVjdG9ycyBzaG91bGQgbm90ICJwYXJz ZSIgdGhlIHBvcnQgbmFtZSwgYnV0CiAgICAgICAgICMgcmF0aGVyIGJlIHBhc3NlZCBjb21wb25l bnRzIChkaXJlY3RseSBvciB2aWEgc2V0dGVycykuICBPbmNlCiAgICAgICAgICMgd2UgZml4IHRo YXQsIHRoaXMgbWV0aG9kIHdpbGwgbmVlZCBhIHJlLXdyaXRlLgpAQCAtODMsOCArNzUsNiBAQCBj bGFzcyBRdFBvcnRUZXN0KHBvcnRfdGVzdGNhc2UuUG9ydFRlc3RDYXNlKToKICAgICAgICAgc2Vs Zi5hc3NlcnRFcXVhbChwb3J0LmV4cGVjdGF0aW9uc19maWxlcygpLCBzZWFyY2hfcGF0aHMpCiAK ICAgICBkZWYgX3F0X3ZlcnNpb24oc2VsZiwgcXRfdmVyc2lvbik6Ci0gICAgICAgIGlmIHF0X3Zl cnNpb24gaW4gJzQuOCc6Ci0gICAgICAgICAgICByZXR1cm4gJ1FNYWtlIHZlcnNpb24gMi4wMWFc blVzaW5nIFF0IHZlcnNpb24gNC44LjAgaW4gL3Vzci9sb2NhbC9Ucm9sbHRlY2gvUXQtNC44LjIv bGliJwogICAgICAgICBpZiBxdF92ZXJzaW9uIGluICc1LjAnOgogICAgICAgICAgICAgcmV0dXJu ICdRTWFrZSB2ZXJzaW9uIDIuMDFhXG5Vc2luZyBRdCB2ZXJzaW9uIDUuMC4wIGluIC91c3IvbG9j YWwvVHJvbGx0ZWNoL1F0LTUuMC4wL2xpYicKIAo=