112688 2013-03-19 06:21:16 -0700 [Qt] QStyle: Invalid rendering of button elements (missing enabled state) 2013-07-10 01:55:54 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 nowrep webkit-unassigned allan.jensen hausmann jturcotte pierre.rossi sfcheng webkit.review.bot oldest_to_newest 858211 0 193806 nowrep 2013-03-19 06:21:16 -0700 Created attachment 193806 Added State_Enabled as default There is an issue with rendering buttons, comboboxes, checkboxes (and I think also other elements) with QStyle. QStyle::State_Enabled is never set, so resulting buttons looks like disabled (except color of text). I'm using QGtkStyle, but I believe this issue is not related to it. Screenshots before/after the patch: https://dl.dropbox.com/u/42835431/qtwebkit/buttons-rendering.png In the attached patch, QStyleFacade::State_Enabled is set as a default state, which fixes this issue. 858212 1 193807 nowrep 2013-03-19 06:22:11 -0700 Created attachment 193807 Testing page 858232 2 jturcotte 2013-03-19 06:48:56 -0700 That might not really be useful information I'm seeing this bug with the GTK style, but not the fusion style. 858240 3 nowrep 2013-03-19 06:54:58 -0700 The same issue is also reproducible on Windows Vista style. I think the main problem here is that all elements are painted without State_Enabled flag set, even if they actually are enabled. It's possible that it makes no difference with Fusion style (I didn't test it with Qt 5), but it shouldn't break it. 858246 4 pierre.rossi 2013-03-19 07:04:23 -0700 (In reply to comment #0) > Created an attachment (id=193806) [details] > Added State_Enabled as default > > There is an issue with rendering buttons, comboboxes, checkboxes (and I think also other elements) with QStyle. > QStyle::State_Enabled is never set, so resulting buttons looks like disabled (except color of text). > > I'm using QGtkStyle, but I believe this issue is not related to it. > > Screenshots before/after the patch: https://dl.dropbox.com/u/42835431/qtwebkit/buttons-rendering.png > > In the attached patch, QStyleFacade::State_Enabled is set as a default state, which fixes this issue. Thanks for this patch. I think it would be nice to have for the sake of correctness. Could you just resubmit it with a Changelog entry so that it follows the guidelines please ? More reading here: http://www.webkit.org/coding/contributing.html (In reply to comment #2) > That might not really be useful information I'm seeing this bug with the GTK style, but not the fusion style. I suspect it's because most Qt styles don't base the button look on that state (only the text color is affected). 858279 5 193827 nowrep 2013-03-19 07:41:41 -0700 Created attachment 193827 Patch with changelog 858280 6 193828 nowrep 2013-03-19 07:42:59 -0700 Created attachment 193828 Patch with changelog 2 858283 7 193828 pierre.rossi 2013-03-19 07:47:09 -0700 Comment on attachment 193828 Patch with changelog 2 Looks reasonable to me. The other option was to add an else statement to the if (!isEnabled(o)) a bit below... I guess it's a matter of taste. 858304 8 193828 webkit.review.bot 2013-03-19 08:21:07 -0700 Comment on attachment 193828 Patch with changelog 2 Clearing flags on attachment: 193828 Committed r146205: <http://trac.webkit.org/changeset/146205> 858305 9 webkit.review.bot 2013-03-19 08:21:10 -0700 All reviewed patches have been landed. Closing bug. 907031 10 hausmann 2013-07-09 01:17:02 -0700 *** Bug 116804 has been marked as a duplicate of this bug. *** 907260 11 sfcheng 2013-07-09 20:31:41 -0700 Thanks for the fixing the bug, Simon. However, that's not the end of the story when it comes to the rendering of the controls. After I apply this patch, the control now appears enabled. However, both the checkbox and radio buttons are not properly rendered. Here is a test page: http://www.slimbrowser.net/testpages/testform.htm . In this page, the checkbox appears not checked even after a mouse click. If I hover the mouse on the checkbox, the radio becomes checked. When I hover the mouse on the radio button and then move the mouse button away, it looks like a stretched radio buttom bitmap is drawn in the background on the first edit box in the same form. I am using the Windows Vista style on Windows 7 for this test. I did some tracing myself here. It appears there is problem with the code inside this function in qwindowsvistastyle.cpp. void QWindowsVistaStyle::drawPrimitive(PrimitiveElement element, const QStyleOption *option,QPainter *painter, const QWidget *widget) const There seems to be issues related to the transition animation drawing. Even if there is no state change, the oldState and state are never the same. If I disable the transition animation, the rendering is ok for Windows vista style. If I switch to the Windows XP style, the edit box is rendered without border. I can provide more details and clues if you want. But I guess you might push this bug towards the QT guys since it's already outside the qtwebkit layer. David, can you produce the same issue? 907318 12 hausmann 2013-07-10 01:54:58 -0700 (In reply to comment #11) > Thanks for the fixing the bug, Simon. However, that's not the end of the story when it comes to the rendering of the controls. After I apply this patch, the control now appears enabled. However, both the checkbox and radio buttons are not properly rendered. Here is a test page: http://www.slimbrowser.net/testpages/testform.htm . In this page, the checkbox appears not checked even after a mouse click. If I hover the mouse on the checkbox, the radio becomes checked. When I hover the mouse on the radio button and then move the mouse button away, it looks like a stretched radio buttom bitmap is drawn in the background on the first edit box in the same form. I am using the Windows Vista style on Windows 7 for this test. > > I did some tracing myself here. It appears there is problem with the code inside this function in qwindowsvistastyle.cpp. > > void QWindowsVistaStyle::drawPrimitive(PrimitiveElement element, const QStyleOption *option,QPainter *painter, const QWidget *widget) const > > There seems to be issues related to the transition animation drawing. Even if there is no state change, the oldState and state are never the same. If I disable the transition animation, the rendering is ok for Windows vista style. > > If I switch to the Windows XP style, the edit box is rendered without border. > > I can provide more details and clues if you want. But I guess you might push this bug towards the QT guys since it's already outside the qtwebkit layer. Yes, if you can isolate this down to being a Qt issue, we should take it to the Qt project bug tracker. Pierre, can you think of anything from the WebKit side that would affect the animations/transition? Is the style perhaps issuing updates that we're not handling? 907319 13 hausmann 2013-07-10 01:55:54 -0700 (In reply to comment #11) > Thanks for the fixing the bug, Simon. However, that's not the end of the story when it comes to the rendering of the controls. After I apply this patch, the control now appears enabled. However, both the checkbox and radio buttons are not properly rendered. Here is a test page: http://www.slimbrowser.net/testpages/testform.htm . In this page, the checkbox appears not checked even after a mouse click. If I hover the mouse on the checkbox, the radio becomes checked. When I hover the mouse on the radio button and then move the mouse button away, it looks like a stretched radio buttom bitmap is drawn in the background on the first edit box in the same form. I am using the Windows Vista style on Windows 7 for this test. FWIW, this should be tracked in a different bug then. This bug (as the title says) is about the incorrect rendering as disabled state even though it's enabled, while the issue you're describing seems different. 193806 2013-03-19 06:21:16 -0700 2013-03-19 07:41:41 -0700 Added State_Enabled as default qstyle.patch text/plain 791 nowrep ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3F0L1JlbmRlclRoZW1lUVN0eWxl LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3F0L1JlbmRlclRoZW1lUVN0eWxlLmNwcApp bmRleCBmN2U4YmY1Li5lNTVjNzVjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9xdC9SZW5kZXJUaGVtZVFTdHlsZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v cXQvUmVuZGVyVGhlbWVRU3R5bGUuY3BwCkBAIC01MzgsOCArNTM4LDkgQEAgYm9vbCBSZW5kZXJU aGVtZVFTdHlsZTo6cGFpbnRJbm5lclNwaW5CdXR0b24oUmVuZGVyT2JqZWN0KiBvLCBjb25zdCBQ YWludEluZm8mIHAKIAogQ29udHJvbFBhcnQgUmVuZGVyVGhlbWVRU3R5bGU6OmluaXRpYWxpemVD b21tb25RU3R5bGVPcHRpb25zKFFTdHlsZUZhY2FkZU9wdGlvbiAmb3B0aW9uLCBSZW5kZXJPYmpl Y3QqIG8pIGNvbnN0CiB7Ci0gICAgLy8gRGVmYXVsdCBiaXRzOiBubyBmb2N1cywgbm8gbW91c2Ug b3ZlcgorICAgIC8vIERlZmF1bHQgYml0czogbm8gZm9jdXMsIG5vIG1vdXNlIG92ZXIsIGVuYWJs ZWQKICAgICBvcHRpb24uc3RhdGUgJj0gfihRU3R5bGVGYWNhZGU6OlN0YXRlX0hhc0ZvY3VzIHwg UVN0eWxlRmFjYWRlOjpTdGF0ZV9Nb3VzZU92ZXIpOworICAgIG9wdGlvbi5zdGF0ZSB8PSBRU3R5 bGVGYWNhZGU6OlN0YXRlX0VuYWJsZWQ7CiAKICAgICBpZiAoaXNSZWFkT25seUNvbnRyb2wobykp CiAgICAgICAgIC8vIFJlYWRvbmx5IGlzIHN1cHBvcnRlZCBvbiB0ZXh0ZmllbGRzLgo= 193807 2013-03-19 06:22:11 -0700 2013-03-19 06:22:11 -0700 Testing page buttons.html text/html 612 nowrep PGh0bWw+CjxoZWFkPgogIDxtZXRhIGh0dHAtZXF1aXY9ImNvbnRlbnQtdHlwZSIgY29udGVudD0i dGV4dC9odG1sOyBjaGFyc2V0PXV0Zi04Ij4KIDx0aXRsZT5Qb3B1cCB3aW5kb3dzIHRlc3Q8L3Rp dGxlPgo8L2hlYWQ+Cjxib2R5Pgo8aDI+QnV0dG9ucyB0ZXN0PC9oMj4KCjxiPkRlZmF1bHQgZW5h YmxlZDwvYj4KPHA+CjxidXR0b24+QnV0dG9uPC9idXR0b24+CjwvcD4KCjxwPgo8aW5wdXQgdHlw ZT0ic3VibWl0IiB2YWx1ZT0iU3VibWl0Ij4KPC9wPgoKPHA+CjxpbnB1dCB0eXBlPSJjaGVja2Jv eCI+CjwvcD4KCgo8cD4KPHNlbGVjdD4KPG9wdGlvbj5TZWxlY3Q8L29wdGlvbj4KPC9zZWxlY3Q+ CjwvcD4KCjxiPmRpc2FibGVkPXRydWU8L2I+CjxwPgo8YnV0dG9uIGRpc2FibGVkPXRydWU+QnV0 dG9uPC9idXR0b24+CjwvcD4KCjxwPgo8aW5wdXQgZGlzYWJsZWQ9dHJ1ZSB0eXBlPSJzdWJtaXQi IHZhbHVlPSJTdWJtaXQiPgo8L3A+CgoKPHA+CjxpbnB1dCBkaXNhYmxlZD10cnVlIHR5cGU9ImNo ZWNrYm94Ij4KPC9wPgoKCjxwPgo8c2VsZWN0IGRpc2FibGVkPXRydWU+CjxvcHRpb24+U2VsZWN0 PC9vcHRpb24+Cjwvc2VsZWN0Pgo8L3A+Cgo8L2JvZHk+CjwvaHRtbD4K 193827 2013-03-19 07:41:41 -0700 2013-03-19 07:42:59 -0700 Patch with changelog style.patch text/plain 1539 nowrep ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCAyYmNkN2U5Li45MzNlMGNl IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAK KzIwMTMtMDMtMTkgIERhdmlkIFJvc2NhICA8bm93cmVAZ21haWwuY29tPgorCisgICAgICAgIFtR dF0gUVN0eWxlOiBTZXQgU3RhdGVfRW5hYmxlZCBieSBkZWZhdWx0IHdoZW4gcGFpbnRpbmcgc3R5 bGUgd2lkZ2V0cy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTExMjY4OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIEFsbCBRdCBzdHlsZSB3aWRnZXRzIHdlcmUgcGFpbnRlZCB3aXRoIGEgZGlzYWJsZWQgc3Rh dGUsIGV2ZW4gd2hlbgorICAgICAgICB0aGV5IGFjdHVhbGx5IHdlcmUgZW5hYmxlZC4KKyAgICAg ICAgVGhpcyBjaGFuZ2UgZml4ZXMgaXQgYnkgc2V0dGluZyBTdGF0ZV9FbmFibGVkIGFzIGEgZGVm YXVsdCBzdGF0ZSwKKyAgICAgICAgd2hpY2ggaXMgdGhlbiBjb3JyZWN0bHkgcmVtb3ZlZCB3aGVu IGVsZW1lbnQgaXMgZGlzYWJsZWQuCisKKyAgICAgICAgKiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9xdC9SZW5kZXJUaGVtZVFTdHlsZS5jcHA6CisKIDIwMTItMTEtMzAgIFNpbW9uIEhhdXNtYW5u ICA8c2ltb24uaGF1c21hbm5AZGlnaWEuY29tPgogCiAgICAgICAgIFtRdF0gVW5yZXZpZXdlZCBk b2MgZml4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9xdC9SZW5kZXJUaGVt ZVFTdHlsZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9xdC9SZW5kZXJUaGVtZVFTdHls ZS5jcHAKaW5kZXggZjdlOGJmNS4uZTU1Yzc1YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vcXQvUmVuZGVyVGhlbWVRU3R5bGUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL3F0L1JlbmRlclRoZW1lUVN0eWxlLmNwcApAQCAtNTM4LDggKzUzOCw5IEBAIGJvb2wg UmVuZGVyVGhlbWVRU3R5bGU6OnBhaW50SW5uZXJTcGluQnV0dG9uKFJlbmRlck9iamVjdCogbywg Y29uc3QgUGFpbnRJbmZvJiBwCiAKIENvbnRyb2xQYXJ0IFJlbmRlclRoZW1lUVN0eWxlOjppbml0 aWFsaXplQ29tbW9uUVN0eWxlT3B0aW9ucyhRU3R5bGVGYWNhZGVPcHRpb24gJm9wdGlvbiwgUmVu ZGVyT2JqZWN0KiBvKSBjb25zdAogewotICAgIC8vIERlZmF1bHQgYml0czogbm8gZm9jdXMsIG5v IG1vdXNlIG92ZXIKKyAgICAvLyBEZWZhdWx0IGJpdHM6IG5vIGZvY3VzLCBubyBtb3VzZSBvdmVy LCBlbmFibGVkCiAgICAgb3B0aW9uLnN0YXRlICY9IH4oUVN0eWxlRmFjYWRlOjpTdGF0ZV9IYXNG b2N1cyB8IFFTdHlsZUZhY2FkZTo6U3RhdGVfTW91c2VPdmVyKTsKKyAgICBvcHRpb24uc3RhdGUg fD0gUVN0eWxlRmFjYWRlOjpTdGF0ZV9FbmFibGVkOwogCiAgICAgaWYgKGlzUmVhZE9ubHlDb250 cm9sKG8pKQogICAgICAgICAvLyBSZWFkb25seSBpcyBzdXBwb3J0ZWQgb24gdGV4dGZpZWxkcy4K 193828 2013-03-19 07:42:59 -0700 2013-03-19 08:21:07 -0700 Patch with changelog 2 style.patch text/plain 1540 nowrep ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCAyYmNkN2U5Li45MzNlMGNl IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAK KzIwMTMtMDMtMTkgIERhdmlkIFJvc2NhICA8bm93cmVwQGdtYWlsLmNvbT4KKworICAgICAgICBb UXRdIFFTdHlsZTogU2V0IFN0YXRlX0VuYWJsZWQgYnkgZGVmYXVsdCB3aGVuIHBhaW50aW5nIHN0 eWxlIHdpZGdldHMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMTI2ODgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBBbGwgUXQgc3R5bGUgd2lkZ2V0cyB3ZXJlIHBhaW50ZWQgd2l0aCBhIGRpc2FibGVkIHN0 YXRlLCBldmVuIHdoZW4KKyAgICAgICAgdGhleSBhY3R1YWxseSB3ZXJlIGVuYWJsZWQuCisgICAg ICAgIFRoaXMgY2hhbmdlIGZpeGVzIGl0IGJ5IHNldHRpbmcgU3RhdGVfRW5hYmxlZCBhcyBhIGRl ZmF1bHQgc3RhdGUsCisgICAgICAgIHdoaWNoIGlzIHRoZW4gY29ycmVjdGx5IHJlbW92ZWQgd2hl biBlbGVtZW50IGlzIGRpc2FibGVkLgorCisgICAgICAgICogU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vcXQvUmVuZGVyVGhlbWVRU3R5bGUuY3BwOgorCiAyMDEyLTExLTMwICBTaW1vbiBIYXVzbWFu biAgPHNpbW9uLmhhdXNtYW5uQGRpZ2lhLmNvbT4KIAogICAgICAgICBbUXRdIFVucmV2aWV3ZWQg ZG9jIGZpeApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vcXQvUmVuZGVyVGhl bWVRU3R5bGUuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vcXQvUmVuZGVyVGhlbWVRU3R5 bGUuY3BwCmluZGV4IGY3ZThiZjUuLmU1NWM3NWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL3F0L1JlbmRlclRoZW1lUVN0eWxlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9xdC9SZW5kZXJUaGVtZVFTdHlsZS5jcHAKQEAgLTUzOCw4ICs1MzgsOSBAQCBib29s IFJlbmRlclRoZW1lUVN0eWxlOjpwYWludElubmVyU3BpbkJ1dHRvbihSZW5kZXJPYmplY3QqIG8s IGNvbnN0IFBhaW50SW5mbyYgcAogCiBDb250cm9sUGFydCBSZW5kZXJUaGVtZVFTdHlsZTo6aW5p dGlhbGl6ZUNvbW1vblFTdHlsZU9wdGlvbnMoUVN0eWxlRmFjYWRlT3B0aW9uICZvcHRpb24sIFJl bmRlck9iamVjdCogbykgY29uc3QKIHsKLSAgICAvLyBEZWZhdWx0IGJpdHM6IG5vIGZvY3VzLCBu byBtb3VzZSBvdmVyCisgICAgLy8gRGVmYXVsdCBiaXRzOiBubyBmb2N1cywgbm8gbW91c2Ugb3Zl ciwgZW5hYmxlZAogICAgIG9wdGlvbi5zdGF0ZSAmPSB+KFFTdHlsZUZhY2FkZTo6U3RhdGVfSGFz Rm9jdXMgfCBRU3R5bGVGYWNhZGU6OlN0YXRlX01vdXNlT3Zlcik7CisgICAgb3B0aW9uLnN0YXRl IHw9IFFTdHlsZUZhY2FkZTo6U3RhdGVfRW5hYmxlZDsKIAogICAgIGlmIChpc1JlYWRPbmx5Q29u dHJvbChvKSkKICAgICAgICAgLy8gUmVhZG9ubHkgaXMgc3VwcG9ydGVkIG9uIHRleHRmaWVsZHMu Cg==