112687 2013-03-19 06:12:36 -0700 [EFL][WK2] Don't show the SearchBar by default when MiniBrowser opened 2013-03-20 05:28:48 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 naginenis naginenis cdumez jinwoo7.song kenneth laszlo.gombos lucas.de.marchi mikhail.pozdnyakov webkit.review.bot oldest_to_newest 858206 0 naginenis 2013-03-19 06:12:36 -0700 SearchBar at the bottom of the window should not be visible by default when MiniBrowser opened. 858269 1 193824 naginenis 2013-03-19 07:30:08 -0700 Created attachment 193824 Patch 858272 2 193824 cdumez 2013-03-19 07:34:18 -0700 Comment on attachment 193824 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=193824&action=review > Tools/MiniBrowser/efl/main.c:1475 > + search_box_hide(window); Does it still work if we move this line before the evas_object_show(window->elm_window) one? 858278 3 193824 naginenis 2013-03-19 07:38:28 -0700 Comment on attachment 193824 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=193824&action=review >> Tools/MiniBrowser/efl/main.c:1475 >> + search_box_hide(window); > > Does it still work if we move this line before the evas_object_show(window->elm_window) one? No. I tried already :) 858289 4 193824 mikhail.pozdnyakov 2013-03-19 08:00:15 -0700 Comment on attachment 193824 Patch LGTM :) 858292 5 193824 cdumez 2013-03-19 08:01:00 -0700 Comment on attachment 193824 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=193824&action=review >>> Tools/MiniBrowser/efl/main.c:1475 >>> + search_box_hide(window); >> >> Does it still work if we move this line before the evas_object_show(window->elm_window) one? > > No. I tried already :) Ok, then LGTM :) 858876 6 jinwoo7.song 2013-03-19 16:55:35 -0700 LGTM. Thanks, I missed it. :) 859279 7 193824 webkit.review.bot 2013-03-20 05:28:45 -0700 Comment on attachment 193824 Patch Clearing flags on attachment: 193824 Committed r146332: <http://trac.webkit.org/changeset/146332> 859280 8 webkit.review.bot 2013-03-20 05:28:48 -0700 All reviewed patches have been landed. Closing bug. 193824 2013-03-19 07:30:08 -0700 2013-03-20 05:28:44 -0700 Patch 112687.patch text/plain 1153 naginenis ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA0OTQ5 MzNiLi5mM2FjNjMyIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTMtMDMtMTkgIFN1ZGFyc2FuYSBOYWdpbmVuaSAg PHN1ZGFyc2FuYS5uYWdpbmVuaUBpbnRlbC5jb20+CisKKyAgICAgICAgW0VGTF1bV0syXSBEb24n dCBzaG93IHRoZSBTZWFyY2hCYXIgYnkgZGVmYXVsdCB3aGVuIE1pbmlCcm93c2VyIG9wZW5lZAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEyNjg3CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSGlkZSB0aGUg U2VhcmNoQmFyIGJ5IGRlZmF1bHQgb24gd2luZG93IGNyZWF0aW9uLgorCisgICAgICAgICogTWlu aUJyb3dzZXIvZWZsL21haW4uYzoKKyAgICAgICAgKHdpbmRvd19jcmVhdGUpOgorCiAyMDEzLTAz LTE4ICBBbmRyYXMgQmVjc2kgIDxhbmRyYXMuYmVjc2lAZGlnaWEuY29tPgogCiAgICAgICAgIFtR dF0gRml4IHRoZSBidWlsZCBvZiBRdFRlc3RCcm93c2VyIGlmIHRoZSBwcmludCBwcmV2aWV3IGRp YWxvZyBpcyBkaXNhYmxlZCBpbiBRdApkaWZmIC0tZ2l0IGEvVG9vbHMvTWluaUJyb3dzZXIvZWZs L21haW4uYyBiL1Rvb2xzL01pbmlCcm93c2VyL2VmbC9tYWluLmMKaW5kZXggNjAxMDZkNi4uNWY4 Yzk0OSAxMDA2NDQKLS0tIGEvVG9vbHMvTWluaUJyb3dzZXIvZWZsL21haW4uYworKysgYi9Ub29s cy9NaW5pQnJvd3Nlci9lZmwvbWFpbi5jCkBAIC0xNDcyLDYgKzE0NzIsNyBAQCBzdGF0aWMgQnJv d3Nlcl9XaW5kb3cgKndpbmRvd19jcmVhdGUoRXZhc19PYmplY3QgKm9wZW5lciwgY29uc3QgY2hh ciAqdXJsLCBpbnQgdwogCiAgICAgZXZhc19vYmplY3RfcmVzaXplKHdpbmRvdy0+ZWxtX3dpbmRv dywgd2lkdGggPyB3aWR0aCA6IHdpbmRvd193aWR0aCwgaGVpZ2h0ID8gaGVpZ2h0IDogd2luZG93 X2hlaWdodCk7CiAgICAgZXZhc19vYmplY3Rfc2hvdyh3aW5kb3ctPmVsbV93aW5kb3cpOworICAg IHNlYXJjaF9ib3hfaGlkZSh3aW5kb3cpOwogCiAgICAgdmlld19mb2N1c19zZXQod2luZG93LCBF SU5BX1RSVUUpOwogCg==