112683 2013-03-19 04:57:47 -0700 [BlackBerry] MathExtras: macros defined in math.h conflict with the real functions 2013-04-08 18:26:23 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 111729 0 berto webkit-unassigned benjamin cgarcia cmarcelo commit-queue ojan.autocc webkit.review.bot xan.lopez oldest_to_newest 858176 0 berto 2013-03-19 04:57:47 -0700 After calls to signbit and friends were prefixed with std:: in r143232, the BlackBerry port no longer compiles. The reason are the signbit / isnan / isinf / isfinite macros defined in math.h. They should be removed in order to use real functions instead. 858179 1 193796 berto 2013-03-19 04:59:46 -0700 Created attachment 193796 Patch 869617 2 berto 2013-04-05 01:07:18 -0700 Ping 871351 3 193796 commit-queue 2013-04-08 18:26:21 -0700 Comment on attachment 193796 Patch Clearing flags on attachment: 193796 Committed r147972: <http://trac.webkit.org/changeset/147972> 871352 4 commit-queue 2013-04-08 18:26:23 -0700 All reviewed patches have been landed. Closing bug. 193796 2013-03-19 04:59:46 -0700 2013-04-08 18:26:21 -0700 Patch 112683.diff text/plain 1307 berto ZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nIGIvU291cmNlL1dURi9DaGFuZ2VMb2cK aW5kZXggZDNiMDJmMS4uYjcyZDBhZSAxMDA2NDQKLS0tIGEvU291cmNlL1dURi9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dURi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMy0wMy0xOSAg QWxiZXJ0byBHYXJjaWEgIDxhZ2FyY2lhQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0JsYWNrQmVy cnldIE1hdGhFeHRyYXM6IG1hY3JvcyBkZWZpbmVkIGluIG1hdGguaCBjb25mbGljdCB3aXRoIHRo ZSByZWFsIGZ1bmN0aW9ucworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTEyNjgzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgQWZ0ZXIgY2FsbHMgdG8gc2lnbmJpdCBhbmQgZnJpZW5kcyB3ZXJlIHByZWZpeGVk IHdpdGggc3RkOjogaW4KKyAgICAgICAgcjE0MzIzMiwgdGhlIEJsYWNrQmVycnkgcG9ydCBubyBs b25nZXIgY29tcGlsZXMuCisKKyAgICAgICAgVGhlIHNvbHV0aW9uIGlzIHRvIGdldCByaWQgb2Yg dGhlIG1hY3JvcyBkZWZpbmVkIGluIG1hdGguaCBhbmQgdXNlCisgICAgICAgIHRoZSByZWFsIGZ1 bmN0aW9ucyBpbnN0ZWFkLgorCisgICAgICAgICogd3RmL01hdGhFeHRyYXMuaDoKKwogMjAxMy0w My0xOCAgQmVuamFtaW4gUG91bGFpbiAgPGJlbmphbWluQHdlYmtpdC5vcmc+CiAKICAgICAgICAg W2lPU10gTWFrZSBhIFVDaGFyIHN0cmluZyBlcXVhbCgpIGJhc2VkIG9uIHRoZSBMQ2hhciB2ZXJz aW9uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9NYXRoRXh0cmFzLmggYi9Tb3VyY2UvV1RG L3d0Zi9NYXRoRXh0cmFzLmgKaW5kZXggNDc0NDExMi4uYWU4NmMzNyAxMDA2NDQKLS0tIGEvU291 cmNlL1dURi93dGYvTWF0aEV4dHJhcy5oCisrKyBiL1NvdXJjZS9XVEYvd3RmL01hdGhFeHRyYXMu aApAQCAtNDgsNiArNDgsMTEgQEAKIC8vIG5hbWVzcGFjZS4gRm9yIG5vdywgd2UgaW5jbHVkZSBt YXRoLmggc2luY2UgdGhlIFFOWCBjbWF0aCBoZWFkZXIgb25seSBpbXBvcnRzIGl0cyBmdW5jdGlv bnMKIC8vIGludG8gdGhlIHN0YW5kYXJkIG5hbWVzcGFjZS4KICNpbmNsdWRlIDxtYXRoLmg+Cisv LyBUaGVzZSBtYWNyb3MgZnJvbSBtYXRoLmggY29uZmxpY3Qgd2l0aCB0aGUgcmVhbCBmdW5jdGlv bnMgaW4gdGhlIHN0ZCBuYW1lc3BhY2UuCisjdW5kZWYgc2lnbmJpdAorI3VuZGVmIGlzbmFuCisj dW5kZWYgaXNpbmYKKyN1bmRlZiBpc2Zpbml0ZQogI2VuZGlmCiAKICNpZm5kZWYgTV9QSQo=