112680 2013-03-19 04:13:38 -0700 REGRESSION(r146174): It made jquery/manipulation.html fail on 32 bit platforms 2014-07-31 10:59:27 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P1 Critical --- 79666 112609 1 ossy webkit-unassigned ap ggaren kadam msaboff ossy zarvai oldest_to_newest 858147 0 ossy 2013-03-19 04:13:38 -0700 http://trac.webkit.org/changeset/146174 and http://trac.webkit.org/changeset/146178 made jquery/manipulation.html fail on 32 bit platforms. At least on Qt, because only Qt has 32 bit tester bot. See this diff for details: http://build.webkit.sed.hu/results/x86-32%20Linux%20Qt%20Release%20NRWT/r146178%20%2830468%29/jquery/manipulation-pretty-diff.html 858218 1 kadam 2013-03-19 06:27:28 -0700 Skipped in: http://trac.webkit.org/changeset/146201 858314 2 msaboff 2013-03-19 08:35:18 -0700 (In reply to comment #0) > http://trac.webkit.org/changeset/146174 and http://trac.webkit.org/changeset/146178 made > jquery/manipulation.html fail on 32 bit platforms. At least on Qt, because only Qt > has 32 bit tester bot. See this diff for details: > > http://build.webkit.sed.hu/results/x86-32%20Linux%20Qt%20Release%20NRWT/r146178%20%2830468%29/jquery/manipulation-pretty-diff.html Was there a crash with backtrace as well? 858323 3 ossy 2013-03-19 08:50:13 -0700 No, It is only fail, not crash. 858681 4 msaboff 2013-03-19 13:28:58 -0700 Built r146178 32bit Mac WebKit and jquery/manipulation.html works fine for me. 1026006 5 ap 2014-07-31 10:29:21 -0700 This test is very slow, particularly in debug builds, but there doesn't appear to be anything 32-bit specific there any more. OK to close? 1026022 6 235831 ossy 2014-07-31 10:47:26 -0700 Created attachment 235831 diff from bot archive 1026023 7 ossy 2014-07-31 10:53:05 -0700 (In reply to comment #5) > This test is very slow, particularly in debug builds, but there doesn't appear to be anything 32-bit specific there any more. OK to close? It is ~1.5 years old bug, who knows what happened during this long period. There isn't QtWebKit anymore, there isn't any EFL or GTK 32 bit tester bot. We only know that it was a valid 32 bit regression (diff attached) caused by r146174 and r146178. And the test runtime wasn't slow at all, it ran on the bot in 2 seconds, so it wasn't related to slowness at all. 1026025 8 ossy 2014-07-31 10:59:27 -0700 I checked it on QtWebKit release branch (branched before removing from trunk) and it passes now, so I assume it is already fixed on trunk too. 235831 2014-07-31 10:47:26 -0700 2014-07-31 10:47:26 -0700 diff from bot archive manipulation-diff.txt text/plain 2907 ossy LS0tIC9yYW1kaXNrL3F0LWxpbnV4LTMyLXJlbGVhc2UtTlJXVC9idWlsZC9sYXlvdXQtdGVzdC1y ZXN1bHRzL2pxdWVyeS9tYW5pcHVsYXRpb24tZXhwZWN0ZWQudHh0CisrKyAvcmFtZGlzay9xdC1s aW51eC0zMi1yZWxlYXNlLU5SV1QvYnVpbGQvbGF5b3V0LXRlc3QtcmVzdWx0cy9qcXVlcnkvbWFu aXB1bGF0aW9uLWFjdHVhbC50eHQKQEAgLTEsMiArMSw3MyBAQAotQUxFUlQ6IDQ3MyB0ZXN0cyBv ZiA0NzMgcGFzc2VkLCAwIGZhaWxlZC4KK0NPTlNPTEUgTUVTU0FHRTogbGluZSA5MDA6IFRlc3Qg aHRtbChGdW5jdGlvbikgd2l0aCBpbmNvbWluZyB2YWx1ZSBkaWVkLCBleGNlcHRpb24gYW5kIHRl c3QgZm9sbG93cworQ09OU09MRSBNRVNTQUdFOiBsaW5lIDkwMTogVHlwZUVycm9yOiAnbnVsbCcg aXMgbm90IGFuIG9iamVjdCAoZXZhbHVhdGluZyAnbi5yZXBsYWNlJykKK0NPTlNPTEUgTUVTU0FH RTogbGluZSA5MDI6IGZ1bmN0aW9uICgpIHsKKwlleHBlY3QoMjApOwogCisJdmFyIGRpdiA9IGpR dWVyeSgiI21haW4gPiBkaXYiKSwgb2xkID0gZGl2Lm1hcChmdW5jdGlvbigpeyByZXR1cm4galF1 ZXJ5KHRoaXMpLmh0bWwoKSB9KTsKKworCWRpdi5odG1sKGZ1bmN0aW9uKGksIHZhbCkgeworCQll cXVhbHMoIHZhbCwgb2xkW2ldLCAiTWFrZSBzdXJlIHRoZSBpbmNvbWluZyB2YWx1ZSBpcyBjb3Jy ZWN0LiIgKTsKKwkJcmV0dXJuICI8Yj50ZXN0PC9iPiI7CisJfSk7CisKKwl2YXIgcGFzcyA9IHRy dWU7CisJZGl2LmVhY2goZnVuY3Rpb24oKXsKKwkJaWYgKCB0aGlzLmNoaWxkTm9kZXMubGVuZ3Ro ICE9PSAxICkgeworCQkJcGFzcyA9IGZhbHNlOworCQl9CisJfSkKKwlvayggcGFzcywgIlNldCBI VE1MIiApOworCisJUVVuaXQucmVzZXQoKTsKKwkvLyB1c2luZyBjb250ZW50cyB3aWxsIGdldCBj b21tZW50cyByZWd1bGFyLCB0ZXh0LCBhbmQgY29tbWVudCBub2RlcworCXZhciBqID0galF1ZXJ5 KCIjbm9ubm9kZXMiKS5jb250ZW50cygpOworCW9sZCA9IGoubWFwKGZ1bmN0aW9uKCl7IHJldHVy biBqUXVlcnkodGhpcykuaHRtbCgpOyB9KTsKKworCWouaHRtbChmdW5jdGlvbihpLCB2YWwpIHsK KwkJZXF1YWxzKCB2YWwsIG9sZFtpXSwgIk1ha2Ugc3VyZSB0aGUgaW5jb21pbmcgdmFsdWUgaXMg Y29ycmVjdC4iICk7CisJCXJldHVybiAiPGI+Ym9sZDwvYj4iOworCX0pOworCisJLy8gSGFuZGxl IHRoZSBjYXNlIHdoZXJlIG5vIGNvbW1lbnQgaXMgaW4gdGhlIGRvY3VtZW50CisJaWYgKCBqLmxl bmd0aCA9PT0gMiApIHsKKwkJZXF1YWxzKCBudWxsLCBudWxsLCAiTWFrZSBzdXJlIHRoZSBpbmNv bWluZyB2YWx1ZSBpcyBjb3JyZWN0LiIgKTsKKwl9CisKKwlqLmZpbmQoJ2InKS5yZW1vdmVEYXRh KCk7CisJZXF1YWxzKCBqLmh0bWwoKS5yZXBsYWNlKC8geG1sbnM9IlteIl0rIi9nLCAiIikudG9M b3dlckNhc2UoKSwgIjxiPmJvbGQ8L2I+IiwgIkNoZWNrIG5vZGUsdGV4dG5vZGUsY29tbWVudCB3 aXRoIGh0bWwoKSIgKTsKKworCXZhciAkZGl2ID0galF1ZXJ5KCc8ZGl2IC8+Jyk7CisKKwllcXVh bHMoICRkaXYuaHRtbChmdW5jdGlvbihpLCB2YWwpIHsKKwkJZXF1YWxzKCB2YWwsICIiLCAiTWFr ZSBzdXJlIHRoZSBpbmNvbWluZyB2YWx1ZSBpcyBjb3JyZWN0LiIgKTsKKwkJcmV0dXJuIDU7CisJ fSkuaHRtbCgpLCAnNScsICdTZXR0aW5nIGEgbnVtYmVyIGFzIGh0bWwnICk7CisKKwllcXVhbHMo ICRkaXYuaHRtbChmdW5jdGlvbihpLCB2YWwpIHsKKwkJZXF1YWxzKCB2YWwsICI1IiwgIk1ha2Ug c3VyZSB0aGUgaW5jb21pbmcgdmFsdWUgaXMgY29ycmVjdC4iICk7CisJCXJldHVybiAwOworCX0p Lmh0bWwoKSwgJzAnLCAnU2V0dGluZyBhIHplcm8gYXMgaHRtbCcgKTsKKworCXZhciAkZGl2MiA9 IGpRdWVyeSgnPGRpdi8+JyksIGluc2VydCA9ICImbHQ7ZGl2Jmd0O2hlbGxvMSZsdDsvZGl2Jmd0 OyI7CisJZXF1YWxzKCAkZGl2Mi5odG1sKGZ1bmN0aW9uKGksIHZhbCkgeworCQllcXVhbHMoIHZh bCwgIiIsICJNYWtlIHN1cmUgdGhlIGluY29taW5nIHZhbHVlIGlzIGNvcnJlY3QuIiApOworCQly ZXR1cm4gaW5zZXJ0OworCX0pLmh0bWwoKS5yZXBsYWNlKC8+L2csICImZ3Q7IiksIGluc2VydCwg IlZlcmlmeSBlc2NhcGVkIGluc2VydGlvbi4iICk7CisKKwllcXVhbHMoICRkaXYyLmh0bWwoZnVu Y3Rpb24oaSwgdmFsKSB7CisJCWVxdWFscyggdmFsLnJlcGxhY2UoLz4vZywgIiZndDsiKSwgaW5z ZXJ0LCAiTWFrZSBzdXJlIHRoZSBpbmNvbWluZyB2YWx1ZSBpcyBjb3JyZWN0LiIgKTsKKwkJcmV0 dXJuICJ4IiArIGluc2VydDsKKwl9KS5odG1sKCkucmVwbGFjZSgvPi9nLCAiJmd0OyIpLCAieCIg KyBpbnNlcnQsICJWZXJpZnkgZXNjYXBlZCBpbnNlcnRpb24uIiApOworCisJZXF1YWxzKCAkZGl2 Mi5odG1sKGZ1bmN0aW9uKGksIHZhbCkgeworCQllcXVhbHMoIHZhbC5yZXBsYWNlKC8+L2csICIm Z3Q7IiksICJ4IiArIGluc2VydCwgIk1ha2Ugc3VyZSB0aGUgaW5jb21pbmcgdmFsdWUgaXMgY29y cmVjdC4iICk7CisJCXJldHVybiAiICIgKyBpbnNlcnQ7CisJfSkuaHRtbCgpLnJlcGxhY2UoLz4v ZywgIiZndDsiKSwgIiAiICsgaW5zZXJ0LCAiVmVyaWZ5IGVzY2FwZWQgaW5zZXJ0aW9uLiIgKTsK K30KK0NPTlNPTEUgTUVTU0FHRTogbGluZSA5MDA6IFRlc3QgcmVtb3ZlKCkgZGllZCwgZXhjZXB0 aW9uIGFuZCB0ZXN0IGZvbGxvd3MKK0NPTlNPTEUgTUVTU0FHRTogbGluZSA5MDE6IFR5cGVFcnJv cjogJ3VuZGVmaW5lZCcgaXMgbm90IGFuIG9iamVjdCAoZXZhbHVhdGluZyAnbi5yZXBsYWNlJykK K0NPTlNPTEUgTUVTU0FHRTogbGluZSA5MDI6IGZ1bmN0aW9uICgpIHsKKwl0ZXN0UmVtb3ZlKCJy ZW1vdmUiKTsKK30KK0FMRVJUOiA0NTMgdGVzdHMgb2YgNDU3IHBhc3NlZCwgNCBmYWlsZWQuCisK