112667 2013-03-19 00:50:50 -0700 Web Inspector: [Settings] Add "storage" parameter to WebInspector.Setting 2013-03-20 02:11:21 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 112666 1 eustas eustas apavlov keishi loislo pfeldman pmuellr vsevik web-inspector-bugs webkit.review.bot yurys oldest_to_newest 858008 0 eustas 2013-03-19 00:50:50 -0700 "storage" parameter will allow more options on how long setting will persist. Possible options are: "window.localStorage", "window.sessionStorage" and "null". 858050 1 193756 eustas 2013-03-19 01:42:51 -0700 Created attachment 193756 Patch 859183 2 193756 webkit.review.bot 2013-03-20 02:11:18 -0700 Comment on attachment 193756 Patch Clearing flags on attachment: 193756 Committed r146317: <http://trac.webkit.org/changeset/146317> 859184 3 webkit.review.bot 2013-03-20 02:11:21 -0700 All reviewed patches have been landed. Closing bug. 193756 2013-03-19 01:42:51 -0700 2013-03-20 02:11:18 -0700 Patch bug-112667-20130319123842.patch text/plain 3266 eustas U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ2MTc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDlmYzkyZmYwMjc4YTg1 MTQzM2FiYzIwMDU0YTg4OWMyNTQ1Y2E3NS4uNjdiNmE3YWJmMGJiMjJhMTBiZGYyOGYwODFmZGYz OGI5OWE3N2M5NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEzLTAzLTE5ICBFdWdl bmUgS2x5dWNobmlrb3YgIDxldXN0YXNAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNw ZWN0b3I6IFtTZXR0aW5nc10gQWRkICJzdG9yYWdlIiBwYXJhbWV0ZXIgdG8gV2ViSW5zcGVjdG9y LlNldHRpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTExMjY2NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IE5ldyBwYXJhbWV0ZXIgd2lsbCBhbGxvdyBtb3JlIG9wdGlvbnMgb24gaG93IGxvbmcgc2V0dGlu ZyB3aWxsIHBlcnNpc3QuCisgICAgICAgIFBvc3NpYmxlIG9wdGlvbnMgYXJlOiBsb2NhbFN0b3Jh Z2UsIHNlc3Npb25TdG9yYWdlIGFuZCBuby1zdG9yYWdlLgorCisgICAgICAgIEFkZGl0aW9uYWwg Y2hhbmdlOiB1c2UgZGVsZXRlIGluc3RlYWQgb2YgLnJlbW92ZUl0ZW0gdG8gbWFrZSBpdCBwb3Nz aWJsZQorICAgICAgICB1c2UgYW55IG9iamVjdCBhcyBzdG9yYWdlLgorCisgICAgICAgICogaW5z cGVjdG9yL2Zyb250LWVuZC9TZXR0aW5ncy5qczoKKyAgICAgICAgQWRkZWQgInN0b3JhZ2UiIHBh cmFtZXRlciBhbmQgdXNlZCBpcyBpbnN0ZWFkIG9mICJ3aW5kb3cubG9jYWxTdG9yYWdlIi4KKwog MjAxMy0wMy0xOCAgRGF2aWQgS2lsemVyICA8ZGRraWx6ZXJAYXBwbGUuY29tPgogCiAgICAgICAg IEJVSUxEIEZJWCAocjE0NjA4OCk6IFJlc291cmNlUmVxdWVzdDo6Y2ZVUkxSZXF1ZXN0KCkgaXMg ZGVmaW5lZCB0d2ljZSBvbiBpT1MKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rv ci9mcm9udC1lbmQvU2V0dGluZ3MuanMgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQt ZW5kL1NldHRpbmdzLmpzCmluZGV4IGM4Nzc4YzEyZjRkZmNlOWY1ZWE5MGNhOTk2ODlhYWZlNDdh NmJkZmQuLjA2NDY5ZTkyMDAxN2E3ZjU0ODY1YmUxMWM3NjYzODdlZDIwOWM2YzYgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvU2V0dGluZ3MuanMKKysrIGIv U291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9TZXR0aW5ncy5qcwpAQCAtMTM1LDE4 ICsxMzUsMjMgQEAgV2ViSW5zcGVjdG9yLlNldHRpbmdzLnByb3RvdHlwZSA9IHsKICAgICAgKi8K ICAgICBjcmVhdGVTZXR0aW5nOiBmdW5jdGlvbihrZXksIGRlZmF1bHRWYWx1ZSkKICAgICB7Ci0g ICAgICAgIHJldHVybiBuZXcgV2ViSW5zcGVjdG9yLlNldHRpbmcoa2V5LCBkZWZhdWx0VmFsdWUs IHRoaXMuX2V2ZW50U3VwcG9ydCk7CisgICAgICAgIHJldHVybiBuZXcgV2ViSW5zcGVjdG9yLlNl dHRpbmcoa2V5LCBkZWZhdWx0VmFsdWUsIHRoaXMuX2V2ZW50U3VwcG9ydCwgd2luZG93LmxvY2Fs U3RvcmFnZSk7CiAgICAgfQogfQogCiAvKioKICAqIEBjb25zdHJ1Y3RvcgorICogQHBhcmFtIHtz dHJpbmd9IG5hbWUKKyAqIEBwYXJhbSB7Kn0gZGVmYXVsdFZhbHVlCisgKiBAcGFyYW0geyFXZWJJ bnNwZWN0b3IuT2JqZWN0fSBldmVudFN1cHBvcnQKKyAqIEBwYXJhbSB7P1N0b3JhZ2V9IHN0b3Jh Z2UKICAqLwotV2ViSW5zcGVjdG9yLlNldHRpbmcgPSBmdW5jdGlvbihuYW1lLCBkZWZhdWx0VmFs dWUsIGV2ZW50U3VwcG9ydCkKK1dlYkluc3BlY3Rvci5TZXR0aW5nID0gZnVuY3Rpb24obmFtZSwg ZGVmYXVsdFZhbHVlLCBldmVudFN1cHBvcnQsIHN0b3JhZ2UpCiB7CiAgICAgdGhpcy5fbmFtZSA9 IG5hbWU7CiAgICAgdGhpcy5fZGVmYXVsdFZhbHVlID0gZGVmYXVsdFZhbHVlOwogICAgIHRoaXMu X2V2ZW50U3VwcG9ydCA9IGV2ZW50U3VwcG9ydDsKKyAgICB0aGlzLl9zdG9yYWdlID0gc3RvcmFn ZTsKIH0KIAogV2ViSW5zcGVjdG9yLlNldHRpbmcucHJvdG90eXBlID0gewpAQCAtMTcxLDIyICsx NzYsMjUgQEAgV2ViSW5zcGVjdG9yLlNldHRpbmcucHJvdG90eXBlID0gewogICAgICAgICAgICAg cmV0dXJuIHRoaXMuX3ZhbHVlOwogCiAgICAgICAgIHRoaXMuX3ZhbHVlID0gdGhpcy5fZGVmYXVs dFZhbHVlOwotICAgICAgICBpZiAod2luZG93LmxvY2FsU3RvcmFnZSAhPSBudWxsICYmIHRoaXMu X25hbWUgaW4gd2luZG93LmxvY2FsU3RvcmFnZSkgeworICAgICAgICBpZiAodGhpcy5fc3RvcmFn ZSAmJiB0aGlzLl9uYW1lIGluIHRoaXMuX3N0b3JhZ2UpIHsKICAgICAgICAgICAgIHRyeSB7Ci0g ICAgICAgICAgICAgICAgdGhpcy5fdmFsdWUgPSBKU09OLnBhcnNlKHdpbmRvdy5sb2NhbFN0b3Jh Z2VbdGhpcy5fbmFtZV0pOworICAgICAgICAgICAgICAgIHRoaXMuX3ZhbHVlID0gSlNPTi5wYXJz ZSh0aGlzLl9zdG9yYWdlW3RoaXMuX25hbWVdKTsKICAgICAgICAgICAgIH0gY2F0Y2goZSkgewot ICAgICAgICAgICAgICAgIHdpbmRvdy5sb2NhbFN0b3JhZ2UucmVtb3ZlSXRlbSh0aGlzLl9uYW1l KTsKKyAgICAgICAgICAgICAgICBkZWxldGUgdGhpcy5fc3RvcmFnZVt0aGlzLl9uYW1lXTsKICAg ICAgICAgICAgIH0KICAgICAgICAgfQogICAgICAgICByZXR1cm4gdGhpcy5fdmFsdWU7CiAgICAg fSwKIAorICAgIC8qKgorICAgICAqIEBwYXJhbSB7IU9iamVjdH0gdmFsdWUKKyAgICAgKi8KICAg ICBzZXQ6IGZ1bmN0aW9uKHZhbHVlKQogICAgIHsKICAgICAgICAgdGhpcy5fdmFsdWUgPSB2YWx1 ZTsKLSAgICAgICAgaWYgKHdpbmRvdy5sb2NhbFN0b3JhZ2UgIT0gbnVsbCkgeworICAgICAgICBp ZiAodGhpcy5fc3RvcmFnZSkgewogICAgICAgICAgICAgdHJ5IHsKLSAgICAgICAgICAgICAgICB3 aW5kb3cubG9jYWxTdG9yYWdlW3RoaXMuX25hbWVdID0gSlNPTi5zdHJpbmdpZnkodmFsdWUpOwor ICAgICAgICAgICAgICAgIHRoaXMuX3N0b3JhZ2VbdGhpcy5fbmFtZV0gPSBKU09OLnN0cmluZ2lm eSh2YWx1ZSk7CiAgICAgICAgICAgICB9IGNhdGNoKGUpIHsKICAgICAgICAgICAgICAgICBjb25z b2xlLmVycm9yKCJFcnJvciBzYXZpbmcgc2V0dGluZyB3aXRoIG5hbWU6IiArIHRoaXMuX25hbWUp OwogICAgICAgICAgICAgfQo=