112658 2013-03-18 22:27:57 -0700 DFG should optimize StringObject.length and StringOrStringObject.length 2013-04-25 13:41:57 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 fpizlo fpizlo barraclough ggaren mark.lam mhahnenberg msaboff oliver sam oldest_to_newest 857939 0 fpizlo 2013-03-18 22:27:57 -0700 Patch forthcoming. 857943 1 193730 fpizlo 2013-03-18 22:30:42 -0700 Created attachment 193730 the patch 857945 2 193731 fpizlo 2013-03-18 22:31:36 -0700 Created attachment 193731 the patch fix style 858635 3 193731 mhahnenberg 2013-03-19 12:46:55 -0700 Comment on attachment 193731 the patch r=me. Any sort of perf impact? 881540 4 fpizlo 2013-04-25 13:41:57 -0700 Landed in http://trac.webkit.org/changeset/146247 193730 2013-03-18 22:30:42 -0700 2013-03-18 22:31:36 -0700 the patch blah.patch text/plain 4148 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTQ2MTc5KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBA CisyMDEzLTAzLTE4ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg REZHIHNob3VsZCBvcHRpbWl6ZSBTdHJpbmdPYmplY3QubGVuZ3RoIGFuZCBTdHJpbmdPclN0cmlu Z09iamVjdC5sZW5ndGgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTExMjY1OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorICAg ICAgICAKKyAgICAgICAgSW1wbGVtZW50ZWQgYnkgaW5qZWN0aW5nIGEgVG9TdHJpbmcoU3RyaW5n T2JqZWN0OkBhKSBvciBUb1N0cmluZyhTdHJpbmdPclN0cmluZ09iamVjdDpAYSkgcHJpb3IKKyAg ICAgICAgdG8gR2V0QXJyYXlMZW5ndGggd2l0aCBBcnJheU1vZGUoQXJyYXk6OlN0cmluZykgaWYg QGEgaXMgcHJlZGljdGVkIFN0cmluZ09iamVjdCBvcgorICAgICAgICBTdHJpbmdPclN0cmluZ09i amVjdC4KKworICAgICAgICAqIGRmZy9ERkdGaXh1cFBoYXNlLmNwcDoKKyAgICAgICAgKEpTQzo6 REZHOjpGaXh1cFBoYXNlOjpmaXh1cE5vZGUpOgorICAgICAgICAoSlNDOjpERkc6OkZpeHVwUGhh c2U6OmNyZWF0ZVRvU3RyaW5nKToKKyAgICAgICAgKEZpeHVwUGhhc2UpOgorICAgICAgICAoSlND OjpERkc6OkZpeHVwUGhhc2U6OmF0dGVtcHRUb0ZvcmNlU3RyaW5nQXJyYXlNb2RlQnlUb1N0cmlu Z0NvbnZlcnNpb24pOgorICAgICAgICAoSlNDOjpERkc6OkZpeHVwUGhhc2U6OmNvbnZlcnRTdHJp bmdBZGRVc2UpOgorCiAyMDEzLTAzLTE4ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+ CiAKICAgICAgICAgREZHIFRvU3RyaW5nIGdlbmVyaWMgY2FzZXMgc2hvdWxkIHdvcmsgY29ycmVj dGx5CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0ZpeHVwUGhhc2UuY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHRml4dXBQaGFzZS5jcHAJ KHJldmlzaW9uIDE0NjE3MSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHRml4dXBQ aGFzZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTcwOCw2ICs3MDgsNyBAQCBwcml2YXRlOgogICAg ICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICAgICAgaWYgKGNvZGVCbG9jaygpLT5pZGVudGlm aWVyKG5vZGUtPmlkZW50aWZpZXJOdW1iZXIoKSkgIT0gZ2xvYmFsRGF0YSgpLnByb3BlcnR5TmFt ZXMtPmxlbmd0aCkKICAgICAgICAgICAgICAgICBicmVhazsKKyAgICAgICAgICAgIAogICAgICAg ICAgICAgQXJyYXlQcm9maWxlKiBhcnJheVByb2ZpbGUgPSAKICAgICAgICAgICAgICAgICBtX2dy YXBoLmJhc2VsaW5lQ29kZUJsb2NrRm9yKG5vZGUtPmNvZGVPcmlnaW4pLT5nZXRBcnJheVByb2Zp bGUoCiAgICAgICAgICAgICAgICAgICAgIG5vZGUtPmNvZGVPcmlnaW4uYnl0ZWNvZGVJbmRleCk7 CkBAIC03MjMsOCArNzI0LDE5IEBAIHByaXZhdGU6CiAgICAgICAgICAgICAgICAgICAgICAgICBP cEluZm8obV9ncmFwaC5hZGRTdHJ1Y3R1cmVTZXQoYXJyYXlQcm9maWxlLT5leHBlY3RlZFN0cnVj dHVyZSgpKSksCiAgICAgICAgICAgICAgICAgICAgICAgICBub2RlLT5jaGlsZDEoKSk7CiAgICAg ICAgICAgICAgICAgfQotICAgICAgICAgICAgfSBlbHNlCisgICAgICAgICAgICB9IGVsc2Ugewog ICAgICAgICAgICAgICAgIGFycmF5TW9kZSA9IGFycmF5TW9kZS5yZWZpbmUobm9kZS0+Y2hpbGQx KCktPnByZWRpY3Rpb24oKSwgbm9kZS0+cHJlZGljdGlvbigpKTsKKyAgICAgICAgICAgICAgICAK KyAgICAgICAgICAgIH0KKyAgICAgICAgICAgIGlmIChhcnJheU1vZGUudHlwZSgpID09IEFycmF5 OjpHZW5lcmljKSB7CisgICAgICAgICAgICAgICAgLy8gQ2hlY2sgaWYgdGhlIGlucHV0IGlzIHNv bWV0aGluZyB0aGF0IHdlIGNhbid0IGdldCBhcnJheSBsZW5ndGggZm9yLCBidXQgZm9yIHdoaWNo IHdlCisgICAgICAgICAgICAgICAgLy8gY291bGQgaW5zZXJ0IHNvbWUgY29udmVyc2lvbnMgaW4g b3JkZXIgdG8gdHJhbnNmb3JtIGl0IGludG8gc29tZXRoaW5nIHRoYXQgd2UgY2FuIGRvIGl0Cisg ICAgICAgICAgICAgICAgLy8gZm9yLgorICAgICAgICAgICAgICAgIGlmIChub2RlLT5jaGlsZDEo KS0+c2hvdWxkU3BlY3VsYXRlU3RyaW5nT2JqZWN0KCkpCisgICAgICAgICAgICAgICAgICAgIGF0 dGVtcHRUb0ZvcmNlU3RyaW5nQXJyYXlNb2RlQnlUb1N0cmluZ0NvbnZlcnNpb248U3RyaW5nT2Jq ZWN0VXNlPihhcnJheU1vZGUsIG5vZGUpOworICAgICAgICAgICAgICAgIGVsc2UgaWYgKG5vZGUt PmNoaWxkMSgpLT5zaG91bGRTcGVjdWxhdGVTdHJpbmdPclN0cmluZ09iamVjdCgpKQorICAgICAg ICAgICAgICAgICAgICBhdHRlbXB0VG9Gb3JjZVN0cmluZ0FycmF5TW9kZUJ5VG9TdHJpbmdDb252 ZXJzaW9uPFN0cmluZ09yU3RyaW5nT2JqZWN0VXNlPihhcnJheU1vZGUsIG5vZGUpOworICAgICAg ICAgICAgfQogICAgICAgICAgICAgaWYgKCFhcnJheU1vZGUuc3VwcG9ydHNMZW5ndGgoKSkKICAg ICAgICAgICAgICAgICBicmVhazsKICAgICAgICAgICAgIG5vZGUtPnNldE9wKEdldEFycmF5TGVu Z3RoKTsKQEAgLTg4Nyw2ICs4OTksMjYgQEAgcHJpdmF0ZToKICAgICB9CiAgICAgCiAgICAgdGVt cGxhdGU8VXNlS2luZCB1c2VLaW5kPgorICAgIE5vZGUqIGNyZWF0ZVRvU3RyaW5nKE5vZGUqIG5v ZGUsIEVkZ2UgZWRnZSkKKyAgICB7CisgICAgICAgIHJldHVybiBtX2luc2VydGlvblNldC5pbnNl cnROb2RlKAorICAgICAgICAgICAgbV9pbmRleEluQmxvY2ssIFNwZWNTdHJpbmcsIFRvU3RyaW5n LCBub2RlLT5jb2RlT3JpZ2luLAorICAgICAgICAgICAgRWRnZShlZGdlLm5vZGUoKSwgdXNlS2lu ZCkpOworICAgIH0KKyAgICAKKyAgICB0ZW1wbGF0ZTxVc2VLaW5kIHVzZUtpbmQ+CisgICAgdm9p ZCBhdHRlbXB0VG9Gb3JjZVN0cmluZ0FycmF5TW9kZUJ5VG9TdHJpbmdDb252ZXJzaW9uKEFycmF5 TW9kZSYgYXJyYXlNb2RlLCBOb2RlKiBub2RlKQorICAgIHsKKyAgICAgICAgQVNTRVJUKGFycmF5 TW9kZSA9PSBBcnJheU1vZGUoQXJyYXk6OkdlbmVyaWMpKTsKKyAgICAgICAgCisgICAgICAgIGlm ICghY2FuT3B0aW1pemVTdHJpbmdPYmplY3RBY2Nlc3Mobm9kZS0+Y29kZU9yaWdpbikpCisgICAg ICAgICAgICByZXR1cm47CisgICAgICAgIAorICAgICAgICBub2RlLT5jaGlsZDEoKS5zZXROb2Rl KGNyZWF0ZVRvU3RyaW5nPHVzZUtpbmQ+KG5vZGUsIG5vZGUtPmNoaWxkMSgpKSk7CisgICAgICAg IGFycmF5TW9kZSA9IEFycmF5TW9kZShBcnJheTo6U3RyaW5nKTsKKyAgICB9CisgICAgCisgICAg dGVtcGxhdGU8VXNlS2luZCB1c2VLaW5kPgogICAgIGJvb2wgaXNTdHJpbmdPYmplY3RVc2UoKQog ICAgIHsKICAgICAgICAgc3dpdGNoICh1c2VLaW5kKSB7CkBAIC05MTYsOSArOTQ4LDcgQEAgcHJp dmF0ZToKICAgICAgICAgLy8gRklYTUU6IFdlIG91Z2h0IHRvIGJlIGFibGUgdG8gaGF2ZSBhIFRv UHJpbWl0aXZlVG9TdHJpbmcgbm9kZS4KICAgICAgICAgCiAgICAgICAgIG9ic2VydmVVc2VLaW5k T25Ob2RlPHVzZUtpbmQ+KGVkZ2Uubm9kZSgpKTsKLSAgICAgICAgZWRnZSA9IEVkZ2UobV9pbnNl cnRpb25TZXQuaW5zZXJ0Tm9kZSgKLSAgICAgICAgICAgIG1faW5kZXhJbkJsb2NrLCBTcGVjU3Ry aW5nLCBUb1N0cmluZywgbm9kZS0+Y29kZU9yaWdpbiwKLSAgICAgICAgICAgIEVkZ2UoZWRnZS5u b2RlKCksIHVzZUtpbmQpKSwgS25vd25TdHJpbmdVc2UpOworICAgICAgICBlZGdlID0gRWRnZShj cmVhdGVUb1N0cmluZzx1c2VLaW5kPihub2RlLCBlZGdlKSwgS25vd25TdHJpbmdVc2UpOwogICAg IH0KICAgICAKICAgICB0ZW1wbGF0ZTxVc2VLaW5kIGxlZnRVc2VLaW5kPgo= 193731 2013-03-18 22:31:36 -0700 2013-03-19 12:46:55 -0700 the patch blah.patch text/plain 3610 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTQ2MTc5KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBA CisyMDEzLTAzLTE4ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg REZHIHNob3VsZCBvcHRpbWl6ZSBTdHJpbmdPYmplY3QubGVuZ3RoIGFuZCBTdHJpbmdPclN0cmlu Z09iamVjdC5sZW5ndGgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTExMjY1OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorICAg ICAgICAKKyAgICAgICAgSW1wbGVtZW50ZWQgYnkgaW5qZWN0aW5nIGEgVG9TdHJpbmcoU3RyaW5n T2JqZWN0OkBhKSBvciBUb1N0cmluZyhTdHJpbmdPclN0cmluZ09iamVjdDpAYSkgcHJpb3IKKyAg ICAgICAgdG8gR2V0QXJyYXlMZW5ndGggd2l0aCBBcnJheU1vZGUoQXJyYXk6OlN0cmluZykgaWYg QGEgaXMgcHJlZGljdGVkIFN0cmluZ09iamVjdCBvcgorICAgICAgICBTdHJpbmdPclN0cmluZ09i amVjdC4KKworICAgICAgICAqIGRmZy9ERkdGaXh1cFBoYXNlLmNwcDoKKyAgICAgICAgKEpTQzo6 REZHOjpGaXh1cFBoYXNlOjpmaXh1cE5vZGUpOgorICAgICAgICAoSlNDOjpERkc6OkZpeHVwUGhh c2U6OmNyZWF0ZVRvU3RyaW5nKToKKyAgICAgICAgKEZpeHVwUGhhc2UpOgorICAgICAgICAoSlND OjpERkc6OkZpeHVwUGhhc2U6OmF0dGVtcHRUb0ZvcmNlU3RyaW5nQXJyYXlNb2RlQnlUb1N0cmlu Z0NvbnZlcnNpb24pOgorICAgICAgICAoSlNDOjpERkc6OkZpeHVwUGhhc2U6OmNvbnZlcnRTdHJp bmdBZGRVc2UpOgorCiAyMDEzLTAzLTE4ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+ CiAKICAgICAgICAgREZHIFRvU3RyaW5nIGdlbmVyaWMgY2FzZXMgc2hvdWxkIHdvcmsgY29ycmVj dGx5CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0ZpeHVwUGhhc2UuY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHRml4dXBQaGFzZS5jcHAJ KHJldmlzaW9uIDE0NjE3MSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHRml4dXBQ aGFzZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTcyNSw2ICs3MjUsMTcgQEAgcHJpdmF0ZToKICAg ICAgICAgICAgICAgICB9CiAgICAgICAgICAgICB9IGVsc2UKICAgICAgICAgICAgICAgICBhcnJh eU1vZGUgPSBhcnJheU1vZGUucmVmaW5lKG5vZGUtPmNoaWxkMSgpLT5wcmVkaWN0aW9uKCksIG5v ZGUtPnByZWRpY3Rpb24oKSk7CisgICAgICAgICAgICAKKyAgICAgICAgICAgIGlmIChhcnJheU1v ZGUudHlwZSgpID09IEFycmF5OjpHZW5lcmljKSB7CisgICAgICAgICAgICAgICAgLy8gQ2hlY2sg aWYgdGhlIGlucHV0IGlzIHNvbWV0aGluZyB0aGF0IHdlIGNhbid0IGdldCBhcnJheSBsZW5ndGgg Zm9yLCBidXQgZm9yIHdoaWNoIHdlCisgICAgICAgICAgICAgICAgLy8gY291bGQgaW5zZXJ0IHNv bWUgY29udmVyc2lvbnMgaW4gb3JkZXIgdG8gdHJhbnNmb3JtIGl0IGludG8gc29tZXRoaW5nIHRo YXQgd2UgY2FuIGRvIGl0CisgICAgICAgICAgICAgICAgLy8gZm9yLgorICAgICAgICAgICAgICAg IGlmIChub2RlLT5jaGlsZDEoKS0+c2hvdWxkU3BlY3VsYXRlU3RyaW5nT2JqZWN0KCkpCisgICAg ICAgICAgICAgICAgICAgIGF0dGVtcHRUb0ZvcmNlU3RyaW5nQXJyYXlNb2RlQnlUb1N0cmluZ0Nv bnZlcnNpb248U3RyaW5nT2JqZWN0VXNlPihhcnJheU1vZGUsIG5vZGUpOworICAgICAgICAgICAg ICAgIGVsc2UgaWYgKG5vZGUtPmNoaWxkMSgpLT5zaG91bGRTcGVjdWxhdGVTdHJpbmdPclN0cmlu Z09iamVjdCgpKQorICAgICAgICAgICAgICAgICAgICBhdHRlbXB0VG9Gb3JjZVN0cmluZ0FycmF5 TW9kZUJ5VG9TdHJpbmdDb252ZXJzaW9uPFN0cmluZ09yU3RyaW5nT2JqZWN0VXNlPihhcnJheU1v ZGUsIG5vZGUpOworICAgICAgICAgICAgfQorICAgICAgICAgICAgCiAgICAgICAgICAgICBpZiAo IWFycmF5TW9kZS5zdXBwb3J0c0xlbmd0aCgpKQogICAgICAgICAgICAgICAgIGJyZWFrOwogICAg ICAgICAgICAgbm9kZS0+c2V0T3AoR2V0QXJyYXlMZW5ndGgpOwpAQCAtODg3LDYgKzg5OCwyNiBA QCBwcml2YXRlOgogICAgIH0KICAgICAKICAgICB0ZW1wbGF0ZTxVc2VLaW5kIHVzZUtpbmQ+Cisg ICAgTm9kZSogY3JlYXRlVG9TdHJpbmcoTm9kZSogbm9kZSwgRWRnZSBlZGdlKQorICAgIHsKKyAg ICAgICAgcmV0dXJuIG1faW5zZXJ0aW9uU2V0Lmluc2VydE5vZGUoCisgICAgICAgICAgICBtX2lu ZGV4SW5CbG9jaywgU3BlY1N0cmluZywgVG9TdHJpbmcsIG5vZGUtPmNvZGVPcmlnaW4sCisgICAg ICAgICAgICBFZGdlKGVkZ2Uubm9kZSgpLCB1c2VLaW5kKSk7CisgICAgfQorICAgIAorICAgIHRl bXBsYXRlPFVzZUtpbmQgdXNlS2luZD4KKyAgICB2b2lkIGF0dGVtcHRUb0ZvcmNlU3RyaW5nQXJy YXlNb2RlQnlUb1N0cmluZ0NvbnZlcnNpb24oQXJyYXlNb2RlJiBhcnJheU1vZGUsIE5vZGUqIG5v ZGUpCisgICAgeworICAgICAgICBBU1NFUlQoYXJyYXlNb2RlID09IEFycmF5TW9kZShBcnJheTo6 R2VuZXJpYykpOworICAgICAgICAKKyAgICAgICAgaWYgKCFjYW5PcHRpbWl6ZVN0cmluZ09iamVj dEFjY2Vzcyhub2RlLT5jb2RlT3JpZ2luKSkKKyAgICAgICAgICAgIHJldHVybjsKKyAgICAgICAg CisgICAgICAgIG5vZGUtPmNoaWxkMSgpLnNldE5vZGUoY3JlYXRlVG9TdHJpbmc8dXNlS2luZD4o bm9kZSwgbm9kZS0+Y2hpbGQxKCkpKTsKKyAgICAgICAgYXJyYXlNb2RlID0gQXJyYXlNb2RlKEFy cmF5OjpTdHJpbmcpOworICAgIH0KKyAgICAKKyAgICB0ZW1wbGF0ZTxVc2VLaW5kIHVzZUtpbmQ+ CiAgICAgYm9vbCBpc1N0cmluZ09iamVjdFVzZSgpCiAgICAgewogICAgICAgICBzd2l0Y2ggKHVz ZUtpbmQpIHsKQEAgLTkxNiw5ICs5NDcsNyBAQCBwcml2YXRlOgogICAgICAgICAvLyBGSVhNRTog V2Ugb3VnaHQgdG8gYmUgYWJsZSB0byBoYXZlIGEgVG9QcmltaXRpdmVUb1N0cmluZyBub2RlLgog ICAgICAgICAKICAgICAgICAgb2JzZXJ2ZVVzZUtpbmRPbk5vZGU8dXNlS2luZD4oZWRnZS5ub2Rl KCkpOwotICAgICAgICBlZGdlID0gRWRnZShtX2luc2VydGlvblNldC5pbnNlcnROb2RlKAotICAg ICAgICAgICAgbV9pbmRleEluQmxvY2ssIFNwZWNTdHJpbmcsIFRvU3RyaW5nLCBub2RlLT5jb2Rl T3JpZ2luLAotICAgICAgICAgICAgRWRnZShlZGdlLm5vZGUoKSwgdXNlS2luZCkpLCBLbm93blN0 cmluZ1VzZSk7CisgICAgICAgIGVkZ2UgPSBFZGdlKGNyZWF0ZVRvU3RyaW5nPHVzZUtpbmQ+KG5v ZGUsIGVkZ2UpLCBLbm93blN0cmluZ1VzZSk7CiAgICAgfQogICAgIAogICAgIHRlbXBsYXRlPFVz ZUtpbmQgbGVmdFVzZUtpbmQ+Cg==