11265 2006-10-12 10:48:20 -0700 redirects from http to https fail 2006-11-05 19:22:53 -0800 1 1 1 Unclassified WebKit Platform 420+ PC Windows XP RESOLVED FIXED P2 Major --- 1 fishd fishd ap oldest_to_newest 53428 0 fishd 2006-10-12 10:48:20 -0700 redirects from http to https fail we need to pass INTERNET_FLAG_IGNORE_REDIRECT_TO_HTTPS in the flags parameter to InternetOpenUrlA. we probably want to specify INTERNET_FLAG_IGNORE_REDIRECT_TO_HTTP as well, and do so for POST requests as well as GET requests. 53437 1 11050 fishd 2006-10-12 11:50:53 -0700 Created attachment 11050 patch This patch helps a bunch, but there is still a failure case with redirected POST requests. For some reason those generate an error of ERROR_HTTP_REDIRECT_NEEDS_CONFIRMATION. I'm not sure yet how to deal with that error or how to suppress it. I'm going to file a new bug on it. 53180 2 ap 2006-10-15 02:54:51 -0700 (In reply to comment #1) > I'm not sure yet how to deal with that > error or how to suppress it. I'm going to file a new bug on it. Per the HTTP standard, the UA must request confirmation from the user via a dialog box when redirecting POST requests. However, many UAs (including WebKit/Mac) transform the request into a GET, thus avoiding the need to display a dialog box. See bug 11118 and bug 11119 for some discussion. 52447 3 fishd 2006-10-16 08:26:19 -0700 Right, I believe it is necessary to convert POST to GET for 302s in order to be compatible with the web. However, I'm not sure if that is something that WinInet can be configured to do, or if it is necessary for the app to read the 302 response and issue a fresh GET request. 46824 4 11050 mjs 2006-11-05 19:22:15 -0800 Comment on attachment 11050 patch r=me I'll commit this. 46826 5 mjs 2006-11-05 19:22:53 -0800 Committed. 11050 2006-10-12 11:50:53 -0700 2006-11-05 19:22:15 -0800 patch loader-1.diff text/plain 5624 fishd SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDE3MDEw KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDYtMTAt MTIgIE1vcmdhbkwgIDxtb3JnYW5sLndlYmtpdEB5YWhvby5jb20+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4ZXMgaHR0cDovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEyNjUKKworICAgICAgICAqIHBsYXRmb3JtL3dpbi9SZXNv dXJjZUxvYWRlcldpbi5jcHA6CisgICAgICAgIChXZWJDb3JlOjp0cmFuc2ZlckpvYlN0YXR1c0Nh bGxiYWNrKToKKyAgICAgICAgKFdlYkNvcmU6OlJlc291cmNlTG9hZGVyOjpzdGFydCk6CisKIDIw MDYtMTAtMTIgIFJvYiBCdWlzICA8YnVpc0BrZGUub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5 IE1pdHouCkluZGV4OiBwbGF0Zm9ybS93aW4vUmVzb3VyY2VMb2FkZXJXaW4uY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIHBsYXRmb3JtL3dpbi9SZXNvdXJjZUxvYWRlcldpbi5jcHAJKHJldmlzaW9uIDE3MDA5 KQorKysgcGxhdGZvcm0vd2luL1Jlc291cmNlTG9hZGVyV2luLmNwcAkod29ya2luZyBjb3B5KQpA QCAtMTUxLDcgKzE1MSwxMCBAQCB2b2lkIFJlc291cmNlTG9hZGVyOjpvbkhhbmRsZUNyZWF0ZWQo TFBBCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAi UE9TVCIsIHVybFN0ci5sYXRpbjEoKSwgMCwgMCwgYWNjZXB0LAogICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgSU5URVJORVRfRkxBR19LRUVQX0NPTk5F Q1RJT04gfCAKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIElOVEVSTkVUX0ZMQUdfRk9STVNfU1VCTUlUIHwKLSAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIElOVEVSTkVUX0ZMQUdfUkVMT0FEIHwgSU5URVJO RVRfRkxBR19OT19DQUNIRV9XUklURSwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIElOVEVSTkVUX0ZMQUdfUkVMT0FEIHwKKyAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIElOVEVSTkVUX0ZMQUdfTk9fQ0FD SEVfV1JJVEUgfAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgSU5URVJORVRfRkxBR19JR05PUkVfUkVESVJFQ1RfVE9fSFRUUFMgfAorICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgSU5URVJORVRfRkxBR19J R05PUkVfUkVESVJFQ1RfVE9fSFRUUCwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIChEV09SRF9QVFIpZC0+bV9qb2JJZCk7CiAgICAgICAgICAgICBp ZiAodXJsSGFuZGxlID09IElOVkFMSURfSEFORExFX1ZBTFVFKSB7CiAgICAgICAgICAgICAgICAg SW50ZXJuZXRDbG9zZUhhbmRsZShkLT5tX3Jlc291cmNlSGFuZGxlKTsKQEAgLTI1Nyw3ICsyNjAs NyBAQCB2b2lkIFJlc291cmNlTG9hZGVyOjpvblJlcXVlc3RDb21wbGV0ZShMCiAgICAgaWYgKGQt Pm1fc2Vjb25kYXJ5SGFuZGxlKQogICAgICAgICBJbnRlcm5ldENsb3NlSGFuZGxlKGQtPm1fc2Vj b25kYXJ5SGFuZGxlKTsKICAgICBJbnRlcm5ldENsb3NlSGFuZGxlKGQtPm1fcmVzb3VyY2VIYW5k bGUpOwotICAgIAorCiAgICAgY2xpZW50KCktPnJlY2VpdmVkQWxsRGF0YSh0aGlzLCAmcGxhdGZv cm1EYXRhKTsKICAgICBjbGllbnQoKS0+cmVjZWl2ZWRBbGxEYXRhKHRoaXMpOwogICAgIGRlbGV0 ZSB0aGlzOwpAQCAtMjY5LDYgKzI3MiwxMyBAQCBzdGF0aWMgdm9pZCBfX3N0ZGNhbGwgdHJhbnNm ZXJKb2JTdGF0dXNDCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICBMUFZPSUQgc3RhdHVzSW5mb3JtYXRpb24sCiAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICBEV09SRCBzdGF0dXNJbmZvcm1hdGlvbkxlbmd0aCkKIHsK KyNpZmRlZiBSRVNPVVJDRV9MT0FERVJfREVCVUcKKyAgICBjaGFyIGJ1Zls2NF07CisgICAgX3Nu cHJpbnRmKGJ1Ziwgc2l6ZW9mKGJ1ZiksICJzdGF0dXMtY2FsbGJhY2s6IHN0YXR1cz0ldSwgam9i PSVwXG4iLAorICAgICAgICAgICAgICBpbnRlcm5ldFN0YXR1cywgam9iSWQpOworICAgIE91dHB1 dERlYnVnU3RyaW5nQShidWYpOworI2VuZGlmCisKICAgICBVSU5UIG1zZzsKICAgICBMUEFSQU0g bFBhcmFtOwogCkBAIC0yNzksNiArMjg5LDEyIEBAIHN0YXRpYyB2b2lkIF9fc3RkY2FsbCB0cmFu c2ZlckpvYlN0YXR1c0MKICAgICAgICAgbFBhcmFtID0gKExQQVJBTSkgTFBJTlRFUk5FVF9BU1lO Q19SRVNVTFQoc3RhdHVzSW5mb3JtYXRpb24pLT5kd1Jlc3VsdDsKICAgICAgICAgYnJlYWs7CiAg ICAgY2FzZSBJTlRFUk5FVF9TVEFUVVNfUkVRVUVTVF9DT01QTEVURToKKyNpZmRlZiBSRVNPVVJD RV9MT0FERVJfREVCVUcKKyAgICAgICAgX3NucHJpbnRmKGJ1Ziwgc2l6ZW9mKGJ1ZiksICJyZXF1 ZXN0LWNvbXBsZXRlOiByZXN1bHQ9JXAsIGVycm9yPSV1XG4iLAorICAgICAgICAgICAgTFBJTlRF Uk5FVF9BU1lOQ19SRVNVTFQoc3RhdHVzSW5mb3JtYXRpb24pLT5kd1Jlc3VsdCwKKyAgICAgICAg ICAgIExQSU5URVJORVRfQVNZTkNfUkVTVUxUKHN0YXR1c0luZm9ybWF0aW9uKS0+ZHdFcnJvcik7 CisgICAgICAgIE91dHB1dERlYnVnU3RyaW5nQShidWYpOworI2VuZGlmCiAgICAgICAgIC8vIHRl bGwgdGhlIG1haW4gdGhyZWFkIHRoYXQgdGhlIHJlcXVlc3QgaXMgZG9uZQogICAgICAgICBtc2cg PSByZXF1ZXN0Q29tcGxldGVNZXNzYWdlOwogICAgICAgICBsUGFyYW0gPSAwOwpAQCAtMzM0LDIx ICszNTAsMzEgQEAgYm9vbCBSZXNvdXJjZUxvYWRlcjo6c3RhcnQoRG9jTG9hZGVyKiBkbwogICAg ICAgICAgICAgZGVsZXRlIHRoaXM7CiAgICAgICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgICAg IH0KLSAgICAgICAgc3RhdGljIElOVEVSTkVUX1NUQVRVU19DQUxMQkFDSyBjYWxsYmFja0hhbmRs ZSA9IEludGVybmV0U2V0U3RhdHVzQ2FsbGJhY2soaW50ZXJuZXRIYW5kbGUsIHRyYW5zZmVySm9i U3RhdHVzQ2FsbGJhY2spOworICAgICAgICBzdGF0aWMgSU5URVJORVRfU1RBVFVTX0NBTExCQUNL IGNhbGxiYWNrSGFuZGxlID0KKyAgICAgICAgICAgIEludGVybmV0U2V0U3RhdHVzQ2FsbGJhY2so aW50ZXJuZXRIYW5kbGUsIHRyYW5zZmVySm9iU3RhdHVzQ2FsbGJhY2spOwogCiAgICAgICAgIGlu aXRpYWxpemVPZmZTY3JlZW5SZXNvdXJjZUxvYWRlcldpbmRvdygpOwogICAgICAgICBkLT5tX2pv YklkID0gYWRkVG9PdXRzdGFuZGluZ0pvYnModGhpcyk7CiAKLSAgICAgICAgLy8gRm9yIGZvcm0g cG9zdGluZywgd2UgY2FuJ3QgdXNlIEludGVybmV0T3BlblVSTC4gIFdlIGhhdmUgdG8gdXNlIElu dGVybmV0Q29ubmVjdCBmb2xsb3dlZCBieQotICAgICAgICAvLyBIdHRwU2VuZFJlcXVlc3QuCisg ICAgICAgIERXT1JEIGZsYWdzID0KKyAgICAgICAgICAgIElOVEVSTkVUX0ZMQUdfS0VFUF9DT05O RUNUSU9OIHwKKyAgICAgICAgICAgIElOVEVSTkVUX0ZMQUdfSUdOT1JFX1JFRElSRUNUX1RPX0hU VFBTIHwKKyAgICAgICAgICAgIElOVEVSTkVUX0ZMQUdfSUdOT1JFX1JFRElSRUNUX1RPX0hUVFA7 CisKKyAgICAgICAgLy8gRm9yIGZvcm0gcG9zdGluZywgd2UgY2FuJ3QgdXNlIEludGVybmV0T3Bl blVSTC4gIFdlIGhhdmUgdG8gdXNlCisgICAgICAgIC8vIEludGVybmV0Q29ubmVjdCBmb2xsb3dl ZCBieSBIdHRwU2VuZFJlcXVlc3QuCiAgICAgICAgIEhJTlRFUk5FVCB1cmxIYW5kbGU7CiAgICAg ICAgIFN0cmluZyByZWZlcnJlciA9IGRvY0xvYWRlci0+ZnJhbWUoKS0+cmVmZXJyZXIoKTsKICAg ICAgICAgaWYgKG1ldGhvZCgpID09ICJQT1NUIikgewogICAgICAgICAgICAgZC0+bV9wb3N0UmVm ZXJyZXIgPSByZWZlcnJlcjsKICAgICAgICAgICAgIERlcHJlY2F0ZWRTdHJpbmcgaG9zdCA9IGQt PlVSTC5ob3N0KCk7CiAgICAgICAgICAgICBob3N0ICs9ICJcMCI7Ci0gICAgICAgICAgICB1cmxI YW5kbGUgPSBJbnRlcm5ldENvbm5lY3RBKGludGVybmV0SGFuZGxlLCBob3N0LmFzY2lpKCksIGQt PlVSTC5wb3J0KCksIDAsIDAsIAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICBJTlRFUk5FVF9TRVJWSUNFX0hUVFAsIDAsIChEV09SRF9QVFIpZC0+bV9qb2JJZCk7Cisg ICAgICAgICAgICB1cmxIYW5kbGUgPSBJbnRlcm5ldENvbm5lY3RBKGludGVybmV0SGFuZGxlLCBo b3N0LmFzY2lpKCksCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGQt PlVSTC5wb3J0KCksCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIE5V TEwsIC8vIG5vIHVzZXJuYW1lCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIE5VTEwsIC8vIG5vIHBhc3N3b3JkCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIElOVEVSTkVUX1NFUlZJQ0VfSFRUUCwKKyAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgZmxhZ3MsIChEV09SRF9QVFIpZC0+bV9qb2JJZCk7CiAgICAgICAg IH0gZWxzZSB7CiAgICAgICAgICAgICBEZXByZWNhdGVkU3RyaW5nIHVybFN0ciA9IGQtPlVSTC51 cmwoKTsKICAgICAgICAgICAgIGludCBmcmFnbWVudEluZGV4ID0gdXJsU3RyLmZpbmQoJyMnKTsK QEAgLTM1OCw4ICszODQsOSBAQCBib29sIFJlc291cmNlTG9hZGVyOjpzdGFydChEb2NMb2FkZXIq IGRvCiAgICAgICAgICAgICBpZiAoIXJlZmVycmVyLmlzRW1wdHkoKSkKICAgICAgICAgICAgICAg ICBoZWFkZXJzICs9IFN0cmluZygiUmVmZXJlcjogIikgKyByZWZlcnJlciArICJcclxuIjsKIAot ICAgICAgICAgICAgdXJsSGFuZGxlID0gSW50ZXJuZXRPcGVuVXJsQShpbnRlcm5ldEhhbmRsZSwg dXJsU3RyLmFzY2lpKCksIGhlYWRlcnMubGF0aW4xKCksIGhlYWRlcnMubGVuZ3RoKCksCi0gICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIElOVEVSTkVUX0ZMQUdfS0VFUF9D T05ORUNUSU9OLCAoRFdPUkRfUFRSKWQtPm1fam9iSWQpOworICAgICAgICAgICAgdXJsSGFuZGxl ID0gSW50ZXJuZXRPcGVuVXJsQShpbnRlcm5ldEhhbmRsZSwgdXJsU3RyLmFzY2lpKCksCisgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGhlYWRlcnMubGF0aW4xKCksIGhl YWRlcnMubGVuZ3RoKCksCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IGZsYWdzLCAoRFdPUkRfUFRSKWQtPm1fam9iSWQpOwogICAgICAgICB9CiAKICAgICAgICAgaWYg KHVybEhhbmRsZSA9PSBJTlZBTElEX0hBTkRMRV9WQUxVRSkgewo=