112644 2013-03-18 17:24:06 -0700 [v8] add IDL 'enum' in DOM methods 2013-03-19 17:23:34 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 a.renevier a.renevier abarth haraken japhet webkit.review.bot oldest_to_newest 857777 0 a.renevier 2013-03-18 17:24:06 -0700 This bug is to add support for idl for method arguments (similarly to what's been done for JavaScriptCore in bug #112475) 858832 1 193942 a.renevier 2013-03-19 15:58:04 -0700 Created attachment 193942 patch proposal 858869 2 193942 haraken 2013-03-19 16:48:32 -0700 Comment on attachment 193942 patch proposal Looks good. 858892 3 193942 webkit.review.bot 2013-03-19 17:23:30 -0700 Comment on attachment 193942 patch proposal Clearing flags on attachment: 193942 Committed r146281: <http://trac.webkit.org/changeset/146281> 858893 4 webkit.review.bot 2013-03-19 17:23:34 -0700 All reviewed patches have been landed. Closing bug. 193942 2013-03-19 15:58:04 -0700 2013-03-19 17:23:30 -0700 patch proposal bug-112644-20130319155353.patch text/plain 3485 a.renevier U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ1OTc0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzNlN2Q1YWM2YzcyNDI0 NzNhYjEwNmQ0Yjk1NDNjYTBjNzc1NGNlOS4uZGRmZThiM2MyYzNlNjk1MTliNjUyOWUyMzZmNzdl ODJkMmIzN2EyNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEzLTAzLTE5ICBBcm5h dWQgUmVuZXZpZXIgIDxhLnJlbmV2aWVyQHNpc2Euc2Ftc3VuZy5jb20+CisKKyAgICAgICAgW3Y4 XSBhZGQgSURMICdlbnVtJyBpbiBET00gbWV0aG9kcworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEyNjQ0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBhZGRzIFY4IHN1cHBvcnQgZm9yIGVudW1lcmF0 aW9ucyBpbiBtZXRob2QgcGFyYW1ldGVycy4KKworICAgICAgICBUZXN0OiBiaW5kaW5ncy9zY3Jp cHRzL3Rlc3QvVGVzdE9iai5pZGwKKworICAgICAgICAqIGJpbmRpbmdzL3NjcmlwdHMvQ29kZUdl bmVyYXRvclY4LnBtOgorICAgICAgICAoR2VuZXJhdGVQYXJhbWV0ZXJzQ2hlY2spOgorICAgICAg ICAqIGJpbmRpbmdzL3NjcmlwdHMvdGVzdC9WOC9WOFRlc3RPYmouY3BwOgorICAgICAgICAoV2Vi Q29yZTo6VGVzdE9ialY4SW50ZXJuYWw6Om1ldGhvZFdpdGhFbnVtQXJnTWV0aG9kKToKKwogMjAx My0wMy0xNSAgQXJuYXVkIFJlbmV2aWVyICA8YS5yZW5ldmllckBzaXNhLnNhbXN1bmcuY29tPgog CiAgICAgICAgIEFkZCBJREwgJ2VudW0nIHN1cHBvcnQgdG8gQ29kZUdlbmVyYXRvckpTLnBtCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JW OC5wbSBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4LnBt CmluZGV4IGRlMjE0NTVhZTA2Nzc1YjRiYjMzZjFjNzMwODM5NDVlMjU1MzZhMDEuLjdjMjYxMWYz M2U4NzliMGNmMWRmYjIxNjBjZGM5NGIxNTcyMmM1OGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4LnBtCisrKyBiL1NvdXJjZS9XZWJD b3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4LnBtCkBAIC0xOTAxLDYgKzE5MDEs MTcgQEAgc3ViIEdlbmVyYXRlUGFyYW1ldGVyc0NoZWNrCiAgICAgICAgIH0gZWxzaWYgKCRuYXRp dmVUeXBlID1+IC9eVjhTdHJpbmdSZXNvdXJjZS8pIHsKICAgICAgICAgICAgIG15ICR2YWx1ZSA9 IEpTVmFsdWVUb05hdGl2ZSgkcGFyYW1ldGVyLCAkb3B0aW9uYWwgJiYgJG9wdGlvbmFsIGVxICJE ZWZhdWx0SXNOdWxsU3RyaW5nIiA/ICJhcmd1bWVudE9yTnVsbChhcmdzLCAkcGFyYW1JbmRleCki IDogImFyZ3NbJHBhcmFtSW5kZXhdIiwgImFyZ3MuR2V0SXNvbGF0ZSgpIik7CiAgICAgICAgICAg ICAkcGFyYW1ldGVyQ2hlY2tTdHJpbmcgLj0gIiAgICAiIC4gQ29udmVydFRvVjhTdHJpbmdSZXNv dXJjZSgkcGFyYW1ldGVyLCAkbmF0aXZlVHlwZSwgJHBhcmFtZXRlck5hbWUsICR2YWx1ZSkgLiAi XG4iOworICAgICAgICAgICAgaWYgKCRjb2RlR2VuZXJhdG9yLT5Jc0VudW1UeXBlKCRwYXJhbWV0 ZXItPnR5cGUpKSB7CisgICAgICAgICAgICAgICAgbXkgQGVudW1WYWx1ZXMgPSAkY29kZUdlbmVy YXRvci0+VmFsaWRFbnVtVmFsdWVzKCRwYXJhbWV0ZXItPnR5cGUpOworICAgICAgICAgICAgICAg IG15IEB2YWxpZEVxdWFsaXRpZXMgPSAoKTsKKyAgICAgICAgICAgICAgICBmb3JlYWNoIG15ICRl bnVtVmFsdWUgKEBlbnVtVmFsdWVzKSB7CisgICAgICAgICAgICAgICAgICAgIHB1c2goQHZhbGlk RXF1YWxpdGllcywgInN0cmluZyA9PSBcIiRlbnVtVmFsdWVcIiIpOworICAgICAgICAgICAgICAg IH0KKyAgICAgICAgICAgICAgICBteSAkZW51bVZhbGlkYXRpb25FeHByZXNzaW9uID0gam9pbigi IHx8ICIsIEB2YWxpZEVxdWFsaXRpZXMpOworICAgICAgICAgICAgICAgICRwYXJhbWV0ZXJDaGVj a1N0cmluZyAuPSAgIiAgICBTdHJpbmcgc3RyaW5nID0gJHBhcmFtZXRlck5hbWU7XG4iOworICAg ICAgICAgICAgICAgICRwYXJhbWV0ZXJDaGVja1N0cmluZyAuPSAgIiAgICBpZiAoISgkZW51bVZh bGlkYXRpb25FeHByZXNzaW9uKSlcbiI7CisgICAgICAgICAgICAgICAgJHBhcmFtZXRlckNoZWNr U3RyaW5nIC49ICAiICAgICAgICByZXR1cm4gdGhyb3dUeXBlRXJyb3IoMCwgYXJncy5HZXRJc29s YXRlKCkpO1xuIjsKKyAgICAgICAgICAgIH0KICAgICAgICAgfSBlbHNlIHsKICAgICAgICAgICAg ICMgSWYgdGhlICJTdHJpY3RUeXBlQ2hlY2tpbmciIGV4dGVuZGVkIGF0dHJpYnV0ZSBpcyBwcmVz ZW50LCBhbmQgdGhlIGFyZ3VtZW50J3MgdHlwZSBpcyBhbgogICAgICAgICAgICAgIyBpbnRlcmZh Y2UgdHlwZSwgdGhlbiBpZiB0aGUgaW5jb21pbmcgdmFsdWUgZG9lcyBub3QgaW1wbGVtZW50IHRo YXQgaW50ZXJmYWNlLCBhIFR5cGVFcnJvcgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmlu ZGluZ3Mvc2NyaXB0cy90ZXN0L1Y4L1Y4VGVzdE9iai5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9iaW5k aW5ncy9zY3JpcHRzL3Rlc3QvVjgvVjhUZXN0T2JqLmNwcAppbmRleCBhZmM3NTIzMTMzZWNkMDEx NjBhZmViYjkwYTRhY2NjYTU5NWRiMTBkLi5mMDE5MDg1YWI5ZTUxYTY5ZmU5MzE0ZTZjMTgwNWE3 NThiYjE0NTQ3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL3Rl c3QvVjgvVjhUZXN0T2JqLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRz L3Rlc3QvVjgvVjhUZXN0T2JqLmNwcApAQCAtMTg4OCw2ICsxODg4LDkgQEAgc3RhdGljIHY4OjpI YW5kbGU8djg6OlZhbHVlPiBtZXRob2RXaXRoRW51bUFyZ01ldGhvZChjb25zdCB2ODo6QXJndW1l bnRzJiBhcmdzKQogICAgICAgICByZXR1cm4gdGhyb3dOb3RFbm91Z2hBcmd1bWVudHNFcnJvcihh cmdzLkdldElzb2xhdGUoKSk7CiAgICAgVGVzdE9iaiogaW1wID0gVjhUZXN0T2JqOjp0b05hdGl2 ZShhcmdzLkhvbGRlcigpKTsKICAgICBWOFRSWUNBVENIX0ZPUl9WOFNUUklOR1JFU09VUkNFKFY4 U3RyaW5nUmVzb3VyY2U8PiwgZW51bUFyZywgYXJnc1swXSk7CisgICAgU3RyaW5nIHN0cmluZyA9 IGVudW1Bcmc7CisgICAgaWYgKCEoc3RyaW5nID09ICIiIHx8IHN0cmluZyA9PSAiRW51bVZhbHVl MSIgfHwgc3RyaW5nID09ICJFbnVtVmFsdWUyIiB8fCBzdHJpbmcgPT0gIkVudW1WYWx1ZTMiKSkK KyAgICAgICAgcmV0dXJuIHRocm93VHlwZUVycm9yKDAsIGFyZ3MuR2V0SXNvbGF0ZSgpKTsKICAg ICBpbXAtPm1ldGhvZFdpdGhFbnVtQXJnKGVudW1BcmcpOwogICAgIHJldHVybiB2OFVuZGVmaW5l ZCgpOwogfQo=