112627 2013-03-18 14:36:44 -0700 MessagePort::disentangle() takes an ExceptionCode argument without any need 2013-03-18 15:24:42 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ap ap esprehn+autocc ojan.autocc webkit.review.bot oldest_to_newest 857569 0 ap 2013-03-18 14:36:44 -0700 MessagePort::disentangle() is called in two places. One has ASSERT_NO_EXCEPTION, and another fails to check the exception, but clearly cannot get one. This function is also not exposed to bindings. 857571 1 193657 ap 2013-03-18 14:39:15 -0700 Created attachment 193657 proposed patch 857585 2 193657 ggaren 2013-03-18 14:50:08 -0700 Comment on attachment 193657 proposed patch r=me 857632 3 193657 webkit.review.bot 2013-03-18 15:24:39 -0700 Comment on attachment 193657 proposed patch Clearing flags on attachment: 193657 Committed r146130: <http://trac.webkit.org/changeset/146130> 857633 4 webkit.review.bot 2013-03-18 15:24:42 -0700 All reviewed patches have been landed. Closing bug. 193657 2013-03-18 14:39:15 -0700 2013-03-18 15:24:39 -0700 proposed patch DisentangleException.txt text/plain 5472 ap SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0NjEyNSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBACisyMDEzLTAzLTE4ICBBbGV4ZXkg UHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTI2MjcKKyAgICAgICAgTWVzc2FnZVBvcnQ6OmRpc2Vu dGFuZ2xlKCkgdGFrZXMgYW4gRXhjZXB0aW9uQ29kZSBhcmd1bWVudCB3aXRob3V0IGFueSBuZWVk CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTWVzc2Fn ZVBvcnQ6OmRpc2VudGFuZ2xlKCkgaXMgY2FsbGVkIGluIHR3byBwbGFjZXMuIE9uZSBoYXMgQVNT RVJUX05PX0VYQ0VQVElPTiwKKyAgICAgICAgYW5kIGFub3RoZXIgZmFpbHMgdG8gY2hlY2sgdGhl IGV4Y2VwdGlvbiwgYnV0IGNsZWFybHkgY2Fubm90IGdldCBvbmUuCisKKyAgICAgICAgVGhpcyBm dW5jdGlvbiBpcyBhbHNvIG5vdCBleHBvc2VkIHRvIGJpbmRpbmdzLgorCisgICAgICAgICogZG9t L01lc3NhZ2VQb3J0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok1lc3NhZ2VQb3J0OjpkaXNlbnRh bmdsZSk6CisgICAgICAgIChXZWJDb3JlOjpNZXNzYWdlUG9ydDo6ZGlzZW50YW5nbGVQb3J0cyk6 CisgICAgICAgICogZG9tL01lc3NhZ2VQb3J0Lmg6CisgICAgICAgICogd29ya2Vycy9TaGFyZWRX b3JrZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U2hhcmVkV29ya2VyOjpjcmVhdGUpOgorICAg ICAgICBBbHNvIHJlbW92ZWQgc29tZSB1bmhlbHBmdWwgY29tbWVudHMuCisKIDIwMTMtMDMtMTgg IEhhbnMgV2VubmJvcmcgIDxoYW5zQGNocm9taXVtLm9yZz4KIAogICAgICAgICBGaXggR3JpZFRy YWNrU2l6ZTo6b3BlcmF0b3I9PQpJbmRleDogU291cmNlL1dlYkNvcmUvZG9tL01lc3NhZ2VQb3J0 LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9kb20vTWVzc2FnZVBvcnQuY3BwCShy ZXZpc2lvbiAxNDYxMTApCisrKyBTb3VyY2UvV2ViQ29yZS9kb20vTWVzc2FnZVBvcnQuY3BwCSh3 b3JraW5nIGNvcHkpCkBAIC04OCwxOCArODgsMTcgQEAgdm9pZCBNZXNzYWdlUG9ydDo6cG9zdE1l c3NhZ2UoUGFzc1JlZlB0cgogICAgIG1fZW50YW5nbGVkQ2hhbm5lbC0+cG9zdE1lc3NhZ2VUb1Jl bW90ZShNZXNzYWdlUG9ydENoYW5uZWw6OkV2ZW50RGF0YTo6Y3JlYXRlKG1lc3NhZ2UsIGNoYW5u ZWxzLnJlbGVhc2UoKSkpOwogfQogCi1QYXNzT3duUHRyPE1lc3NhZ2VQb3J0Q2hhbm5lbD4gTWVz c2FnZVBvcnQ6OmRpc2VudGFuZ2xlKEV4Y2VwdGlvbkNvZGUmIGVjKQorUGFzc093blB0cjxNZXNz YWdlUG9ydENoYW5uZWw+IE1lc3NhZ2VQb3J0OjpkaXNlbnRhbmdsZSgpCiB7Ci0gICAgaWYgKCFt X2VudGFuZ2xlZENoYW5uZWwpCi0gICAgICAgIGVjID0gSU5WQUxJRF9TVEFURV9FUlI7Ci0gICAg ZWxzZSB7Ci0gICAgICAgIG1fZW50YW5nbGVkQ2hhbm5lbC0+ZGlzZW50YW5nbGUoKTsKLQotICAg ICAgICAvLyBXZSBjYW4ndCByZWNlaXZlIGFueSBtZXNzYWdlcyBvciBnZW5lcmF0ZSBhbnkgZXZl bnRzLCBzbyByZW1vdmUgb3Vyc2VsdmVzIGZyb20gdGhlIGxpc3Qgb2YgYWN0aXZlIHBvcnRzLgot ICAgICAgICBBU1NFUlQobV9zY3JpcHRFeGVjdXRpb25Db250ZXh0KTsKLSAgICAgICAgbV9zY3Jp cHRFeGVjdXRpb25Db250ZXh0LT5kZXN0cm95ZWRNZXNzYWdlUG9ydCh0aGlzKTsKLSAgICAgICAg bV9zY3JpcHRFeGVjdXRpb25Db250ZXh0ID0gMDsKLSAgICB9CisgICAgQVNTRVJUKG1fZW50YW5n bGVkQ2hhbm5lbCk7CisKKyAgICBtX2VudGFuZ2xlZENoYW5uZWwtPmRpc2VudGFuZ2xlKCk7CisK KyAgICAvLyBXZSBjYW4ndCByZWNlaXZlIGFueSBtZXNzYWdlcyBvciBnZW5lcmF0ZSBhbnkgZXZl bnRzLCBzbyByZW1vdmUgb3Vyc2VsdmVzIGZyb20gdGhlIGxpc3Qgb2YgYWN0aXZlIHBvcnRzLgor ICAgIEFTU0VSVChtX3NjcmlwdEV4ZWN1dGlvbkNvbnRleHQpOworICAgIG1fc2NyaXB0RXhlY3V0 aW9uQ29udGV4dC0+ZGVzdHJveWVkTWVzc2FnZVBvcnQodGhpcyk7CisgICAgbV9zY3JpcHRFeGVj dXRpb25Db250ZXh0ID0gMDsKKwogICAgIHJldHVybiBtX2VudGFuZ2xlZENoYW5uZWwucmVsZWFz ZSgpOwogfQogCkBAIC0yMjEsNyArMjIwLDcgQEAgUGFzc093blB0cjxNZXNzYWdlUG9ydENoYW5u ZWxBcnJheT4gTWVzcwogICAgIC8vIFBhc3NlZC1pbiBwb3J0cyBwYXNzZWQgdmFsaWRpdHkgY2hl Y2tzLCBzbyB3ZSBjYW4gZGlzZW50YW5nbGUgdGhlbS4KICAgICBPd25QdHI8TWVzc2FnZVBvcnRD aGFubmVsQXJyYXk+IHBvcnRBcnJheSA9IGFkb3B0UHRyKG5ldyBNZXNzYWdlUG9ydENoYW5uZWxB cnJheShwb3J0cy0+c2l6ZSgpKSk7CiAgICAgZm9yICh1bnNpZ25lZCBpbnQgaSA9IDAgOyBpIDwg cG9ydHMtPnNpemUoKSA7ICsraSkgewotICAgICAgICBPd25QdHI8TWVzc2FnZVBvcnRDaGFubmVs PiBjaGFubmVsID0gKCpwb3J0cylbaV0tPmRpc2VudGFuZ2xlKEFTU0VSVF9OT19FWENFUFRJT04p OyAvLyBDYW4ndCBnZW5lcmF0ZSBleGNlcHRpb24gaGVyZSBpZiBwYXNzZWQgYWJvdmUgY2hlY2tz LgorICAgICAgICBPd25QdHI8TWVzc2FnZVBvcnRDaGFubmVsPiBjaGFubmVsID0gKCpwb3J0cylb aV0tPmRpc2VudGFuZ2xlKCk7CiAgICAgICAgICgqcG9ydEFycmF5KVtpXSA9IGNoYW5uZWwucmVs ZWFzZSgpOwogICAgIH0KICAgICByZXR1cm4gcG9ydEFycmF5LnJlbGVhc2UoKTsKSW5kZXg6IFNv dXJjZS9XZWJDb3JlL2RvbS9NZXNzYWdlUG9ydC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJD b3JlL2RvbS9NZXNzYWdlUG9ydC5oCShyZXZpc2lvbiAxNDYxMTApCisrKyBTb3VyY2UvV2ViQ29y ZS9kb20vTWVzc2FnZVBvcnQuaAkod29ya2luZyBjb3B5KQpAQCAtNDcsMTAgKzQ3LDYgQEAgbmFt ZXNwYWNlIFdlYkNvcmUgewogICAgIC8vIFRoZSBvdmVyd2hlbG1pbmdseSBjb21tb24gY2FzZSBp cyBzZW5kaW5nIGEgc2luZ2xlIHBvcnQsIHNvIGhhbmRsZSB0aGF0IGVmZmljaWVudGx5IHdpdGgg YW4gaW5saW5lIGJ1ZmZlciBvZiBzaXplIDEuCiAgICAgdHlwZWRlZiBWZWN0b3I8UmVmUHRyPE1l c3NhZ2VQb3J0PiwgMT4gTWVzc2FnZVBvcnRBcnJheTsKIAotICAgIC8vIEZJWE1FOiBUaGlzIGNs YXNzIHNob3VsZCBpbmhlcml0IGZyb20gQWN0aXZlRE9NT2JqZWN0IGFuZCB1c2UKLSAgICAvLyBz ZXRQZW5kaW5nQWN0aXZpdHkgLyB1bnNldFBlbmRpbmdBY3Rpdml0eSBpbnN0ZWFkIG9mIGR1cGxp Y2F0aW5nCi0gICAgLy8gQWN0aXZlRE9NT2JqZWN0J3MgZmVhdHVyZXMgYW5kIHJlbHlpbmcgb24g SmF2YVNjcmlwdCBnYXJiYWdlIGNvbGxlY3Rpb24KLSAgICAvLyB0byBnZXQgaXRzIGxpZmV0aW1l IHJpZ2h0LgogICAgIGNsYXNzIE1lc3NhZ2VQb3J0IDogcHVibGljIFJlZkNvdW50ZWQ8TWVzc2Fn ZVBvcnQ+LCBwdWJsaWMgRXZlbnRUYXJnZXQgewogICAgIHB1YmxpYzoKICAgICAgICAgc3RhdGlj IFBhc3NSZWZQdHI8TWVzc2FnZVBvcnQ+IGNyZWF0ZShTY3JpcHRFeGVjdXRpb25Db250ZXh0JiBz Y3JpcHRFeGVjdXRpb25Db250ZXh0KSB7IHJldHVybiBhZG9wdFJlZihuZXcgTWVzc2FnZVBvcnQo c2NyaXB0RXhlY3V0aW9uQ29udGV4dCkpOyB9CkBAIC02NCwxNCArNjAsMTEgQEAgbmFtZXNwYWNl IFdlYkNvcmUgewogICAgICAgICB2b2lkIGNsb3NlKCk7CiAKICAgICAgICAgdm9pZCBlbnRhbmds ZShQYXNzT3duUHRyPE1lc3NhZ2VQb3J0Q2hhbm5lbD4pOwotICAgICAgICBQYXNzT3duUHRyPE1l c3NhZ2VQb3J0Q2hhbm5lbD4gZGlzZW50YW5nbGUoRXhjZXB0aW9uQ29kZSYpOworICAgICAgICBQ YXNzT3duUHRyPE1lc3NhZ2VQb3J0Q2hhbm5lbD4gZGlzZW50YW5nbGUoKTsKIAotICAgICAgICAv LyBEaXNlbnRhbmdsZSBhbiBhcnJheSBvZiBwb3J0cywgcmV0dXJuaW5nIHRoZSBlbnRhbmdsZWQg Y2hhbm5lbHMuCi0gICAgICAgIC8vIFBlciBzZWN0aW9uIDguMy4zIG9mIHRoZSBIVE1MNSBzcGVj LCBnZW5lcmF0ZXMgYW4gSU5WQUxJRF9TVEFURV9FUlIgZXhjZXB0aW9uIGlmIGFueSBvZiB0aGUg cGFzc2VkIHBvcnRzIGFyZSBudWxsIG9yIG5vdCBlbnRhbmdsZWQuCiAgICAgICAgIC8vIFJldHVy bnMgMCBpZiB0aGVyZSBpcyBhbiBleGNlcHRpb24sIG9yIGlmIHRoZSBwYXNzZWQtaW4gYXJyYXkg aXMgMC9lbXB0eS4KICAgICAgICAgc3RhdGljIFBhc3NPd25QdHI8TWVzc2FnZVBvcnRDaGFubmVs QXJyYXk+IGRpc2VudGFuZ2xlUG9ydHMoY29uc3QgTWVzc2FnZVBvcnRBcnJheSosIEV4Y2VwdGlv bkNvZGUmKTsKIAotICAgICAgICAvLyBFbnRhbmdsZXMgYW4gYXJyYXkgb2YgY2hhbm5lbHMsIHJl dHVybmluZyBhbiBhcnJheSBvZiBNZXNzYWdlUG9ydHMgaW4gbWF0Y2hpbmcgb3JkZXIuCiAgICAg ICAgIC8vIFJldHVybnMgMCBpZiB0aGUgcGFzc2VkIGFycmF5IGlzIDAvZW1wdHkuCiAgICAgICAg IHN0YXRpYyBQYXNzT3duUHRyPE1lc3NhZ2VQb3J0QXJyYXk+IGVudGFuZ2xlUG9ydHMoU2NyaXB0 RXhlY3V0aW9uQ29udGV4dCYsIFBhc3NPd25QdHI8TWVzc2FnZVBvcnRDaGFubmVsQXJyYXk+KTsK IApJbmRleDogU291cmNlL1dlYkNvcmUvd29ya2Vycy9TaGFyZWRXb3JrZXIuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3dvcmtlcnMvU2hhcmVkV29ya2VyLmNwcAkocmV2aXNpb24g MTQ2MDcyKQorKysgU291cmNlL1dlYkNvcmUvd29ya2Vycy9TaGFyZWRXb3JrZXIuY3BwCSh3b3Jr aW5nIGNvcHkpCkBAIC02MSw3ICs2MSw3IEBAIFBhc3NSZWZQdHI8U2hhcmVkV29ya2VyPiBTaGFy ZWRXb3JrZXI6OmMKIAogICAgIFJlZlB0cjxNZXNzYWdlQ2hhbm5lbD4gY2hhbm5lbCA9IE1lc3Nh Z2VDaGFubmVsOjpjcmVhdGUoY29udGV4dCk7CiAgICAgd29ya2VyLT5tX3BvcnQgPSBjaGFubmVs LT5wb3J0MSgpOwotICAgIE93blB0cjxNZXNzYWdlUG9ydENoYW5uZWw+IHJlbW90ZVBvcnQgPSBj aGFubmVsLT5wb3J0MigpLT5kaXNlbnRhbmdsZShlYyk7CisgICAgT3duUHRyPE1lc3NhZ2VQb3J0 Q2hhbm5lbD4gcmVtb3RlUG9ydCA9IGNoYW5uZWwtPnBvcnQyKCktPmRpc2VudGFuZ2xlKCk7CiAg ICAgQVNTRVJUKHJlbW90ZVBvcnQpOwogCiAgICAgd29ya2VyLT5zdXNwZW5kSWZOZWVkZWQoKTsK