112603 2013-03-18 11:37:13 -0700 [chromium] fast/innerHTML/innerHTML-iframe.html is flaky 2013-03-18 14:38:42 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kbr kbr abarth eric jamesr oldest_to_newest 857362 0 kbr 2013-03-18 11:37:13 -0700 Layout test fast/innerHTML/innerHTML-iframe.html is flaky on all platforms. See: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20-%20chromium.org&showAllRuns=true&showExpectations=true&tests=fast%2FinnerHTML%2FinnerHTML-iframe.html Seems strange that the onload handler wouldn't be able to reference document.body. Could the new multithreaded parser have something to do with these failures? 857390 1 jamesr 2013-03-18 12:06:40 -0700 Hmm, I thought I fixed the document.body flake in r145857 but it looks like the setTimeout is still racing with onload. The failing diff now is: TypeError: Cannot set property 'innerHTML' of null PASS: body and iframe cleared without crashing. which means the setTimeout() blew away <div id="x"> before the onload fired. 857473 2 jamesr 2013-03-18 13:28:15 -0700 Perhaps the right fix is to set the timeout from inside the onload handler so it always happens after the .innerHTML. 857507 3 kbr 2013-03-18 13:54:00 -0700 Is the existing pattern in the test supposed to be guaranteed to work though? 857514 4 jamesr 2013-03-18 14:00:24 -0700 No, it's racy. 857521 5 kbr 2013-03-18 14:06:30 -0700 OK. I'll update the test. 857570 6 kbr 2013-03-18 14:38:42 -0700 Fixed the test in http://trac.webkit.org/changeset/146126 .