112600 2013-03-18 11:30:04 -0700 [GTK] Wrong guard USE(GLX) in RedirectedXCompositeWindow 2013-07-03 10:40:59 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 1 mario webkit-unassigned mrobinson tobiasmue oldest_to_newest 857344 0 mario 2013-03-18 11:30:04 -0700 I got the following error today when trying to build with GLES2 + EGL enabled: In file included from Source/WebKit/gtk/WebCoreSupport/AcceleratedCompositingContextClutter.cpp:21:0: Source/WebKit/gtk/WebCoreSupport/AcceleratedCompositingContext.h:85:12: error: 'RedirectedXCompositeWindow' is not a member of 'WebCore' Source/WebKit/gtk/WebCoreSupport/AcceleratedCompositingContext.h:85:12: error: 'RedirectedXCompositeWindow' is not a member of 'WebCore' Source/WebKit/gtk/WebCoreSupport/AcceleratedCompositingContext.h:85:47: error: template argument 1 is invalid As per a conversation with Martin, this should be made conditional on OPENGL and X11, not just in GLX, so it works both in combinations like EGL + X11 and GLX + X11. 857356 1 193616 mario 2013-03-18 11:35:18 -0700 Created attachment 193616 Patch proposal Here comes the patch 858103 2 mario 2013-03-19 03:08:03 -0700 Committed r146196: <http://trac.webkit.org/changeset/146196> 905920 3 svillar 2013-07-03 10:40:59 -0700 *** Bug 111861 has been marked as a duplicate of this bug. *** 193616 2013-03-18 11:35:18 -0700 2013-03-18 11:38:36 -0700 Patch proposal 0001-2013-03-18-Mario-Sanchez-Prada-mario.prada-samsung.c.patch text/plain 2938 mario RnJvbSBkYWY5NDM1NTlhYzk1MjFhYTc0ZDJhN2Y5NjM2YzE5YTczY2QxMjQzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJpbyBTYW5jaGV6IFByYWRhIDxtYXJpby5wcmFkYUBzYW1z dW5nLmNvbT4KRGF0ZTogTW9uLCAxOCBNYXIgMjAxMyAxODoyOTozMiArMDAwMApTdWJqZWN0OiBb UEFUQ0hdIDIwMTMtMDMtMTggIE1hcmlvIFNhbmNoZXogUHJhZGEgIDxtYXJpby5wcmFkYUBzYW1z dW5nLmNvbT4KCiAgICAgICAgW0dUS10gV3JvbmcgZ3VhcmQgVVNFKEdMWCkgaW4gUmVkaXJlY3Rl ZFhDb21wb3NpdGVXaW5kb3cKICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTEyNjAwCgogICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgoKICAg ICAgICBSZXBsYWNlIFVTRShHTFgpIGNvbmRpdGlvbiB3aXRoIFVTRShPUEVOR0wpICYmIFBMQVRG T1JNKFgxMSkuCgogICAgICAgICogcGxhdGZvcm0vZ3RrL1JlZGlyZWN0ZWRYQ29tcG9zaXRlV2lu ZG93LmNwcDogVXBkYXRlZCBndWFyZC4KICAgICAgICAqIHBsYXRmb3JtL2d0ay9SZWRpcmVjdGVk WENvbXBvc2l0ZVdpbmRvdy5oOiBEaXR0by4KLS0tCiBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgICAxMiArKysrKysrKysrKysKIFNv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9SZWRpcmVjdGVkWENvbXBvc2l0ZVdpbmRvdy5jcHAg fCAgICA0ICsrLS0KIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9SZWRpcmVjdGVkWENvbXBv c2l0ZVdpbmRvdy5oICAgfCAgICA0ICsrLS0KIDMgZmlsZXMgY2hhbmdlZCwgMTYgaW5zZXJ0aW9u cygrKSwgNCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VM b2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTE1N2M0ZS4uZGZjMzFjMSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEzLTAzLTE4ICBNYXJpbyBTYW5jaGV6IFByYWRh ICA8bWFyaW8ucHJhZGFAc2Ftc3VuZy5jb20+CisKKyAgICAgICAgW0dUS10gV3JvbmcgZ3VhcmQg VVNFKEdMWCkgaW4gUmVkaXJlY3RlZFhDb21wb3NpdGVXaW5kb3cKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMjYwMAorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlcGxhY2UgVVNFKEdMWCkgY29uZGl0aW9u IHdpdGggVVNFKE9QRU5HTCkgJiYgUExBVEZPUk0oWDExKS4KKworICAgICAgICAqIHBsYXRmb3Jt L2d0ay9SZWRpcmVjdGVkWENvbXBvc2l0ZVdpbmRvdy5jcHA6IFVwZGF0ZWQgZ3VhcmQuCisgICAg ICAgICogcGxhdGZvcm0vZ3RrL1JlZGlyZWN0ZWRYQ29tcG9zaXRlV2luZG93Lmg6IERpdHRvLgor CiAyMDEzLTAzLTE4ICBCcmFkeSBFaWRzb24gIDxiZWlkc29uQGFwcGxlLmNvbT4KIAogICAgICAg ICBOZXR3b3JrUHJvY2VzcyBzaG91bGQgc2VuZCB2bV9jb3BpZWQsIG1tYXAnZWQgbWVtb3J5IHRv IFdlYlByb2Nlc3NlcyB3aGVuIGEgCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ndGsvUmVkaXJlY3RlZFhDb21wb3NpdGVXaW5kb3cuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3RrL1JlZGlyZWN0ZWRYQ29tcG9zaXRlV2luZG93LmNwcAppbmRleCBhNDUyNThmLi5j OGU4MWU0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvUmVkaXJlY3Rl ZFhDb21wb3NpdGVXaW5kb3cuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9S ZWRpcmVjdGVkWENvbXBvc2l0ZVdpbmRvdy5jcHAKQEAgLTI3LDcgKzI3LDcgQEAKICNpbmNsdWRl ICJjb25maWcuaCIKICNpbmNsdWRlICJSZWRpcmVjdGVkWENvbXBvc2l0ZVdpbmRvdy5oIgogCi0j aWYgVVNFKEdMWCkKKyNpZiBVU0UoT1BFTkdMKSAmJiBQTEFURk9STShYMTEpCiAKICNpbmNsdWRl IDxYMTEvZXh0ZW5zaW9ucy9YY29tcG9zaXRlLmg+CiAjaW5jbHVkZSA8WDExL2V4dGVuc2lvbnMv WGRhbWFnZS5oPgpAQCAtMjY3LDQgKzI2Nyw0IEBAIHZvaWQgUmVkaXJlY3RlZFhDb21wb3NpdGVX aW5kb3c6OmNhbGxEYW1hZ2VOb3RpZnlDYWxsYmFjaygpCiAKIH0gLy8gbmFtZXNwYWNlIFdlYkNv cmUKIAotI2VuZGlmIC8vIFVTRShHTFgpCisjZW5kaWYgLy8gVVNFKE9QRU5HTCkgJiYgUExBVEZP Uk0oWDExKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL1JlZGlyZWN0 ZWRYQ29tcG9zaXRlV2luZG93LmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvUmVkaXJl Y3RlZFhDb21wb3NpdGVXaW5kb3cuaAppbmRleCBmZjJhNDhiLi4wZDQ3MzI2IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvUmVkaXJlY3RlZFhDb21wb3NpdGVXaW5kb3cu aAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvUmVkaXJlY3RlZFhDb21wb3NpdGVX aW5kb3cuaApAQCAtMjcsNyArMjcsNyBAQAogI2lmbmRlZiAgUmVkaXJlY3RlZFhDb21wb3NpdGVX aW5kb3dfaAogI2RlZmluZSAgUmVkaXJlY3RlZFhDb21wb3NpdGVXaW5kb3dfaAogCi0jaWYgVVNF KEdMWCkKKyNpZiBVU0UoT1BFTkdMKSAmJiBQTEFURk9STShYMTEpCiAKICNpbmNsdWRlICJHTENv bnRleHQuaCIKICNpbmNsdWRlICJJbnRTaXplLmgiCkBAIC04MCw2ICs4MCw2IEBAIHByaXZhdGU6 CiAKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUKIAotI2VuZGlmIC8vIFVTRShHTFgpCisjZW5kaWYg Ly8gVVNFKE9QRU5HTCkgJiYgUExBVEZPUk0oWDExKQogCiAjZW5kaWYgLy8gUmVkaXJlY3RlZFhD b21wb3NpdGVXaW5kb3dfaAotLSAKMS43LjEwLjQKCg==