112574 2013-03-18 08:41:10 -0700 [CSS Grid Layout] Fix StyleGridData::operator== 2013-03-18 12:07:03 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 60731 112501 1 jchaffraix jchaffraix eric esprehn+autocc hans ojan.autocc ojan tony webkit.review.bot xan.lopez oldest_to_newest 857147 0 jchaffraix 2013-03-18 08:41:10 -0700 Super obvious bug: bool operator==(const StyleGridData& o) const { return m_gridColumns == o.m_gridColumns && m_gridRows == o.m_gridRows && m_gridAutoFlow != o.m_gridAutoFlow; } 857169 1 193575 jchaffraix 2013-03-18 09:07:31 -0700 Created attachment 193575 Trivial fix + test. 857376 2 193575 jchaffraix 2013-03-18 11:47:55 -0700 Comment on attachment 193575 Trivial fix + test. Mac passed the EWS, not sure why it's being picked again for testing. 857391 3 193575 webkit.review.bot 2013-03-18 12:06:59 -0700 Comment on attachment 193575 Trivial fix + test. Clearing flags on attachment: 193575 Committed r146098: <http://trac.webkit.org/changeset/146098> 857392 4 webkit.review.bot 2013-03-18 12:07:03 -0700 All reviewed patches have been landed. Closing bug. 193575 2013-03-18 09:07:31 -0700 2013-03-18 12:06:59 -0700 Trivial fix + test. bug-112574-20130318090322.patch text/plain 5078 jchaffraix U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ2MDYyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2UzYjAyZTU4ZDA4ZmE2 MWNiNjRhZjI1NDc1MTE2M2ViOTkzZWE5Mi4uYzlmMDkzNjA4Y2Q1ZTZhNTNjMjI5YzI3YTBmZDEz NjM4MmYwNzU0MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEzLTAzLTE4ICBKdWxp ZW4gQ2hhZmZyYWl4ICA8amNoYWZmcmFpeEB3ZWJraXQub3JnPgorCisgICAgICAgIFtDU1MgR3Jp ZCBMYXlvdXRdIEZpeCBTdHlsZUdyaWREYXRhOjpvcGVyYXRvcj09CisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTI1NzQKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUZXN0OiBmYXN0L2Nzcy1ncmlkLWxheW91 dC9ncmlkLWF1dG8tZmxvdy11cGRhdGUuaHRtbAorCisgICAgICAgICogcmVuZGVyaW5nL3N0eWxl L1N0eWxlR3JpZERhdGEuaDoKKyAgICAgICAgKFdlYkNvcmU6OlN0eWxlR3JpZERhdGE6Om9wZXJh dG9yPT0pOgorICAgICAgICBGaXhlZCBhIGJhZCBjb21wYXJpc29uIHRoYXQgd291bGQgbWFrZSB1 cyBpZ25vcmUgZ3JpZC1hdXRvLWZsb3cgY2hhbmdlcy4KKwogMjAxMy0wMy0xOCAgVnNldm9sb2Qg Vmxhc292ICA8dnNldmlrQGNocm9taXVtLm9yZz4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBU YWJiZWRFZGl0b3JDb250YWluZXIgZG9lcyBub3QgcmVzdG9yZSBsYXN0IHNob3duIGZpbGUgb24g cmVsb2FkIHNvbWV0aW1lcy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9z dHlsZS9TdHlsZUdyaWREYXRhLmggYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3R5bGUvU3R5 bGVHcmlkRGF0YS5oCmluZGV4IDNmODEwZGM4NzMyMWU5MjMyZDhmMDAxMGJkZTg5ZWQ3NTY0ZGIy NzIuLjFiMjVmMjA1YWViOTdhMzMzYzgxYWMxYTVhYTY4MWUxMjMxMzhkZDggMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zdHlsZS9TdHlsZUdyaWREYXRhLmgKKysrIGIvU291 cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N0eWxlL1N0eWxlR3JpZERhdGEuaApAQCAtNDEsNyArNDEs NyBAQCBwdWJsaWM6CiAKICAgICBib29sIG9wZXJhdG9yPT0oY29uc3QgU3R5bGVHcmlkRGF0YSYg bykgY29uc3QKICAgICB7Ci0gICAgICAgIHJldHVybiBtX2dyaWRDb2x1bW5zID09IG8ubV9ncmlk Q29sdW1ucyAmJiBtX2dyaWRSb3dzID09IG8ubV9ncmlkUm93cyAmJiBtX2dyaWRBdXRvRmxvdyAh PSBvLm1fZ3JpZEF1dG9GbG93OworICAgICAgICByZXR1cm4gbV9ncmlkQ29sdW1ucyA9PSBvLm1f Z3JpZENvbHVtbnMgJiYgbV9ncmlkUm93cyA9PSBvLm1fZ3JpZFJvd3MgJiYgbV9ncmlkQXV0b0Zs b3cgPT0gby5tX2dyaWRBdXRvRmxvdzsKICAgICB9CiAKICAgICBib29sIG9wZXJhdG9yIT0oY29u c3QgU3R5bGVHcmlkRGF0YSYgbykgY29uc3QKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA1MGE3MGYxOGZkMmE4MDUyODIxYTlh NWQyMWEzZjJmYTcyOTliYTk5Li5lZWJkODcwMTA0OGY0NWU2NTNmMmVjYjQxZWMxMjQ2ODk5N2Zh MzRiIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTMtMDMtMTggIEp1bGllbiBDaGFmZnJhaXgg IDxqY2hhZmZyYWl4QHdlYmtpdC5vcmc+CisKKyAgICAgICAgW0NTUyBHcmlkIExheW91dF0gRml4 IFN0eWxlR3JpZERhdGE6Om9wZXJhdG9yPT0KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTExMjU3NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogZmFzdC9jc3MtZ3JpZC1sYXlvdXQvZ3JpZC1hdXRvLWZsb3ct dXBkYXRlLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogZmFzdC9jc3MtZ3JpZC1sYXlv dXQvZ3JpZC1hdXRvLWZsb3ctdXBkYXRlLmh0bWw6IEFkZGVkLgorCiAyMDEzLTAzLTE4ICBLdW5p aGlrbyBTYWthbW90byAgPGtzYWthbW90b0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgVGhlICdm b3Jtbm92YWxpZGF0ZScgYXR0cmlidXRlIGRvZXNuJ3Qgd29yayBjb3JyZWN0bHkgb24gYnV0dG9u IGVsZW1lbnRzIHdpdGggY2hpbGQgZWxlbWVudHMKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zh c3QvY3NzLWdyaWQtbGF5b3V0L2dyaWQtYXV0by1mbG93LXVwZGF0ZS1leHBlY3RlZC50eHQgYi9M YXlvdXRUZXN0cy9mYXN0L2Nzcy1ncmlkLWxheW91dC9ncmlkLWF1dG8tZmxvdy11cGRhdGUtZXhw ZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAuLjI4ZWRiMjA4MzhiYmQzMTUxNzNjNTgwM2MzZWYzMjFmZjdi MThmMjQKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2Nzcy1ncmlkLWxheW91 dC9ncmlkLWF1dG8tZmxvdy11cGRhdGUtZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsNiBAQAorVGhp cyB0ZXN0IGNoZWNrcyB0aGF0IHVwZGF0aW5nIHRoZSBncmlkJ3MgZWxlbWVudCdzIGdyaWQtYXV0 by1mbG93IHByb3BlcnR5IHJlY29tcHV0ZXMgdGhlIGdyaWQuCitQQVNTCitQQVNTCitQQVNTCitQ QVNTCitQQVNTCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2Nzcy1ncmlkLWxheW91dC9n cmlkLWF1dG8tZmxvdy11cGRhdGUuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvY3NzLWdyaWQtbGF5 b3V0L2dyaWQtYXV0by1mbG93LXVwZGF0ZS5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4 IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjM1YzMyYTM3MmFmY2Jh YTgwMTQwZmNlZmEzMzY0NTFmZjA4MjgwMmUKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0 cy9mYXN0L2Nzcy1ncmlkLWxheW91dC9ncmlkLWF1dG8tZmxvdy11cGRhdGUuaHRtbApAQCAtMCww ICsxLDQ4IEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1sPgorPHNjcmlwdD4KK2lmICh3aW5kb3cu dGVzdFJ1bm5lcikKKyAgICB0ZXN0UnVubmVyLm92ZXJyaWRlUHJlZmVyZW5jZSgiV2ViS2l0Q1NT R3JpZExheW91dEVuYWJsZWQiLCAxKTsKKzwvc2NyaXB0PgorPGxpbmsgaHJlZj0icmVzb3VyY2Vz L2dyaWQuY3NzIiByZWw9InN0eWxlc2hlZXQiPgorPHNjcmlwdCBzcmM9Ii4uLy4uL3Jlc291cmNl cy9jaGVjay1sYXlvdXQuanMiPjwvc2NyaXB0PgorPHN0eWxlPgorLmdyaWQgeworICAgIC13ZWJr aXQtZ3JpZC1jb2x1bW5zOiA1MHB4IDEwMHB4OworICAgIC13ZWJraXQtZ3JpZC1yb3dzOiA1MHB4 IDEwMHB4OworfQorPC9zdHlsZT4KKzxzY3JpcHQ+CitmdW5jdGlvbiB0ZXN0R3JpZChmbG93LCBw b3NpdGlvbkFuZFNpemUpCit7CisgICAgdmFyIGdyaWRFbGVtZW50ID0gZG9jdW1lbnQuZ2V0RWxl bWVudHNCeUNsYXNzTmFtZSgiZ3JpZCIpWzBdOworICAgIGdyaWRFbGVtZW50LnN0eWxlLndlYmtp dEdyaWRBdXRvRmxvdyA9IGZsb3c7CisgICAgdmFyIGdyaWRJdGVtID0gZG9jdW1lbnQuZ2V0RWxl bWVudEJ5SWQoImF1dG9JdGVtIik7CisgICAgZ3JpZEl0ZW0uc2V0QXR0cmlidXRlKCJkYXRhLW9m ZnNldC14IiwgcG9zaXRpb25BbmRTaXplLm9mZnNldFgpOworICAgIGdyaWRJdGVtLnNldEF0dHJp YnV0ZSgiZGF0YS1vZmZzZXQteSIsIHBvc2l0aW9uQW5kU2l6ZS5vZmZzZXRZKTsKKyAgICBncmlk SXRlbS5zZXRBdHRyaWJ1dGUoImRhdGEtZXhwZWN0ZWQtd2lkdGgiLCBwb3NpdGlvbkFuZFNpemUu d2lkdGgpOworICAgIGdyaWRJdGVtLnNldEF0dHJpYnV0ZSgiZGF0YS1leHBlY3RlZC1oZWlnaHQi LCBwb3NpdGlvbkFuZFNpemUuaGVpZ2h0KTsKKyAgICBjaGVja0xheW91dCgiLmdyaWQiKTsKK30K KworZnVuY3Rpb24gdXBkYXRlQXV0b0Zsb3coKQoreworICAgIGNoZWNrTGF5b3V0KCIuZ3JpZCIp OworCisgICAgdGVzdEdyaWQoInJvdyIsIHsgJ29mZnNldFgnOiAnNTAnLCAnb2Zmc2V0WSc6ICcw JywgJ3dpZHRoJzogJzEwMCcsICdoZWlnaHQnOiAnNTAnIH0pOworICAgIHRlc3RHcmlkKCJjb2x1 bW4iLCB7ICdvZmZzZXRYJzogJzAnLCAnb2Zmc2V0WSc6ICc1MCcsICd3aWR0aCc6ICc1MCcsICdo ZWlnaHQnOiAnMTAwJyB9KTsKKyAgICB0ZXN0R3JpZCgiaW52YWxpZCIsIHsgJ29mZnNldFgnOiAn MCcsICdvZmZzZXRZJzogJzUwJywgJ3dpZHRoJzogJzUwJywgJ2hlaWdodCc6ICcxMDAnIH0pOwor ICAgIHRlc3RHcmlkKCJub25lIiwgeyAnb2Zmc2V0WCc6ICcwJywgJ29mZnNldFknOiAnMCcsICd3 aWR0aCc6ICc1MCcsICdoZWlnaHQnOiAnNTAnIH0pOworfQord2luZG93LmFkZEV2ZW50TGlzdGVu ZXIoImxvYWQiLCB1cGRhdGVBdXRvRmxvdywgZmFsc2UpOworPC9zY3JpcHQ+Cis8Ym9keT4KKzxk aXY+VGhpcyB0ZXN0IGNoZWNrcyB0aGF0IHVwZGF0aW5nIHRoZSBncmlkJ3MgZWxlbWVudCdzIGdy aWQtYXV0by1mbG93IHByb3BlcnR5IHJlY29tcHV0ZXMgdGhlIGdyaWQuPC9kaXY+Cis8ZGl2IHN0 eWxlPSJwb3NpdGlvbjogcmVsYXRpdmUiPgorICAgIDxkaXYgY2xhc3M9ImdyaWQiPgorICAgICAg ICA8ZGl2IGNsYXNzPSJzaXplZFRvR3JpZEFyZWEgYXV0b1Jvd0F1dG9Db2x1bW4iIGlkPSJhdXRv SXRlbSIgZGF0YS1vZmZzZXQteD0iMCIgZGF0YS1vZmZzZXQteT0iMCIgZGF0YS1leHBlY3RlZC13 aWR0aD0iNTAiIGRhdGEtZXhwZWN0ZWQtaGVpZ2h0PSI1MCI+PC9kaXY+CisgICAgICAgIDxkaXYg Y2xhc3M9InNpemVkVG9HcmlkQXJlYSBmaXJzdFJvd0ZpcnN0Q29sdW1uIiBkYXRhLW9mZnNldC14 PSIwIiBkYXRhLW9mZnNldC15PSIwIiBkYXRhLWV4cGVjdGVkLXdpZHRoPSI1MCIgZGF0YS1leHBl Y3RlZC1oZWlnaHQ9IjUwIj48L2Rpdj4KKyAgICA8L2Rpdj4KKzwvZGl2PgorPC9ib2R5PgorPC9o dG1sPgo=