112563 2013-03-18 06:17:58 -0700 HitTestRequest::AllowFrameScrollbars does not test main frame scrollbar 2013-04-11 02:16:12 -0700 1 1 1 Unclassified WebKit UI Events 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 allan.jensen allan.jensen eric esprehn+autocc ojan.autocc tonikitoo webkit.review.bot oldest_to_newest 857050 0 allan.jensen 2013-03-18 06:17:58 -0700 To preserve original behavior HitTestRequest::AllowFrameScrollbars only tested the scrollbars of child frame when introduced. This is however both confusing and unnecessary. The one remaining call site using the options also needs to hit test the main frame, and is currently forced to do that after a hit-test with HitTestRequest::AllowFrameScrollbars. 857053 1 193547 allan.jensen 2013-03-18 06:22:13 -0700 Created attachment 193547 Patch 872938 2 193547 tonikitoo 2013-04-10 10:40:30 -0700 Comment on attachment 193547 Patch Looks good. Could we use mock scrollbars to add some basic tests? 873039 3 allan.jensen 2013-04-10 11:24:33 -0700 (In reply to comment #2) > (From update of attachment 193547 [details]) > Looks good. Could we use mock scrollbars to add some basic tests? At this point it is just a refactoring and already covered by existing tests. 873631 4 193547 allan.jensen 2013-04-11 02:16:07 -0700 Comment on attachment 193547 Patch Clearing flags on attachment: 193547 Committed r148188: <http://trac.webkit.org/changeset/148188> 873632 5 allan.jensen 2013-04-11 02:16:12 -0700 All reviewed patches have been landed. Closing bug. 193547 2013-03-18 06:22:13 -0700 2013-04-11 02:16:07 -0700 Patch bug-112563-20130318141712.patch text/plain 4534 allan.jensen U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ2MDU1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTcxMmExMjYzOGQ3OGYy ZjZiMzQ0YmU2MjZhMDhmODg5Yzk3NGRiNy4uN2ExYTdkYmI0MDY3ODAyMDAwNDc3YzI2OWVlZTBi Y2U5ZDczOWJiOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI1IEBACiAyMDEzLTAzLTE4ICBBbGxh biBTYW5kZmVsZCBKZW5zZW4gIDxhbGxhbi5qZW5zZW5AZGlnaWEuY29tPgogCisgICAgICAgIEhp dFRlc3RSZXF1ZXN0OjpBbGxvd0ZyYW1lU2Nyb2xsYmFycyBkb2VzIG5vdCB0ZXN0IG1haW4gZnJh bWUgc2Nyb2xsYmFyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMTI1NjMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBNb3ZlIHRoZSBmcmFtZSBzY3JvbGxiYXIgdGVzdGluZyBmcm9tIFJlbmRlclBhcnQgdG8g UmVuZGVyVmlldywgc28gdGhhdCBpdCBpcworICAgICAgICB0ZXN0ZWQgYnkgYWxsIGZyYW1lIGFu ZCBub3QganVzdCBjaGlsZCBmcmFtZXMuIEF0IHRoZSBzYW1lIHRpbWUgcmVtb3ZlIHRoZSAKKyAg ICAgICAgbWFpbiBmcmFtZSB0ZXN0IGZyb20gdGhlIG9uZSBjdXJyZW50IGNhbGxzaXRlIHVzaW5n IHRoZSBvcHRpb24uCisKKyAgICAgICAgVGVzdGVkIGJ5IGZhc3QvZXZlbnRzL3RvdWNoL2dlc3R1 cmUvZ2VzdHVyZS1zY3JvbGxiYXIuaHRtbC4KKworICAgICAgICAqIHBhZ2UvRXZlbnRIYW5kbGVy LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkV2ZW50SGFuZGxlcjo6aGFuZGxlR2VzdHVyZUV2ZW50 KToKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyUGFydC5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpSZW5kZXJQYXJ0Ojpub2RlQXRQb2ludCk6CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlclZp ZXcuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyVmlldzo6aGl0VGVzdCk6CisKKzIwMTMt MDMtMTggIEFsbGFuIFNhbmRmZWxkIEplbnNlbiAgPGFsbGFuLmplbnNlbkBkaWdpYS5jb20+CisK ICAgICAgICAgQ2xlYW4gdXAgUmVuZGVyRnJhbWVTZXQ6Om5vZGVBdFBvaW50CiAgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTI0NTAKIApkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvcGFnZS9FdmVudEhhbmRsZXIuY3BwIGIvU291cmNlL1dlYkNvcmUv cGFnZS9FdmVudEhhbmRsZXIuY3BwCmluZGV4IGQ0NjkwMTE0ODhmMGM0ZjMwMmI4NTg1NDcxOWFk MjRlMjI4NjdjNTQuLjU5YjEwNzRmZGYxMjBjMDhhMjBkNWNjNGVjYTZlNGJjZWY3MTUyMDUgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRXZlbnRIYW5kbGVyLmNwcAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9wYWdlL0V2ZW50SGFuZGxlci5jcHAKQEAgLTI0ODcsMTAgKzI0ODcsNiBAQCBi b29sIEV2ZW50SGFuZGxlcjo6aGFuZGxlR2VzdHVyZUV2ZW50KGNvbnN0IFBsYXRmb3JtR2VzdHVy ZUV2ZW50JiBnZXN0dXJlRXZlbnQpCiAgICAgICAgIEludFBvaW50IGhpdFRlc3RQb2ludCA9IG1f ZnJhbWUtPnZpZXcoKS0+d2luZG93VG9Db250ZW50cyhhZGp1c3RlZFBvaW50KTsKICAgICAgICAg SGl0VGVzdFJlc3VsdCByZXN1bHQgPSBoaXRUZXN0UmVzdWx0QXRQb2ludChoaXRUZXN0UG9pbnQs IGhpdFR5cGUgfCBIaXRUZXN0UmVxdWVzdDo6QWxsb3dGcmFtZVNjcm9sbGJhcnMpOwogICAgICAg ICBldmVudFRhcmdldCA9IHJlc3VsdC50YXJnZXROb2RlKCk7Ci0gICAgICAgIGlmICghc2Nyb2xs YmFyKSB7Ci0gICAgICAgICAgICBGcmFtZVZpZXcqIHZpZXcgPSBtX2ZyYW1lLT52aWV3KCk7Ci0g ICAgICAgICAgICBzY3JvbGxiYXIgPSB2aWV3ID8gdmlldy0+c2Nyb2xsYmFyQXRQb2ludChnZXN0 dXJlRXZlbnQucG9zaXRpb24oKSkgOiAwOwotICAgICAgICB9CiAgICAgICAgIGlmICghc2Nyb2xs YmFyKQogICAgICAgICAgICAgc2Nyb2xsYmFyID0gcmVzdWx0LnNjcm9sbGJhcigpOwogICAgIH0K ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJQYXJ0LmNwcCBiL1Nv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJQYXJ0LmNwcAppbmRleCA2MGYzOTQ0ODE2MmJi YzNiNzlmNDA5NmMxNzhkNjg0MDliNTYyYzE4Li42YTI2OWVmYjE3NGRjODY5ZWRmMjcyMWJmMjY5 ODc5NjM0OWIzNWFjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy UGFydC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclBhcnQuY3BwCkBA IC0xMzQsMTUgKzEzNCw2IEBAIGJvb2wgUmVuZGVyUGFydDo6bm9kZUF0UG9pbnQoY29uc3QgSGl0 VGVzdFJlcXVlc3QmIHJlcXVlc3QsIEhpdFRlc3RSZXN1bHQmIHJlc3VsCiAKICAgICAgICAgaWYg KGlzSW5zaWRlQ2hpbGRGcmFtZSkKICAgICAgICAgICAgIHJldHVybiB0cnVlOwotCi0gICAgICAg IGlmIChyZXF1ZXN0LmFsbG93c0ZyYW1lU2Nyb2xsYmFycygpKSB7Ci0gICAgICAgICAgICAvLyBT Y3JvbGxWaWV3IHNjcm9sbGJhcnMgYXJlIG5vdCB0aGUgc2FtZSBhcyBSZW5kZXJMYXllciBzY3Jv bGxiYXJzIHRlc3RlZCBieSBSZW5kZXJMYXllcjo6aGl0VGVzdE92ZXJmbG93Q29udHJvbHMsCi0g ICAgICAgICAgICAvLyBzbyB3ZSBuZWVkIHRvIHRlc3QgU2Nyb2xsVmlldyBzY3JvbGxiYXJzIHNl cGFyYXRlbHkgaGVyZS4KLSAgICAgICAgICAgIC8vIEZJWE1FOiBDb25zaWRlciBpZiB0aGlzIHRl c3QgY291bGQgYmUgZG9uZSB1bmNvbmRpdGlvbmFsbHkuCi0gICAgICAgICAgICBTY3JvbGxiYXIq IGZyYW1lU2Nyb2xsYmFyID0gY2hpbGRGcmFtZVZpZXctPnNjcm9sbGJhckF0UG9pbnQobmV3SGl0 VGVzdExvY2F0aW9uLnJvdW5kZWRQb2ludCgpKTsKLSAgICAgICAgICAgIGlmIChmcmFtZVNjcm9s bGJhcikKLSAgICAgICAgICAgICAgICByZXN1bHQuc2V0U2Nyb2xsYmFyKGZyYW1lU2Nyb2xsYmFy KTsKLSAgICAgICAgfQogICAgIH0KIAogICAgIHJldHVybiBSZW5kZXJXaWRnZXQ6Om5vZGVBdFBv aW50KHJlcXVlc3QsIHJlc3VsdCwgbG9jYXRpb25JbkNvbnRhaW5lciwgYWNjdW11bGF0ZWRPZmZz ZXQsIGFjdGlvbik7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy Vmlldy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVmlldy5jcHAKaW5kZXgg MzIxNzM5NjcyN2Q1YzhjZTdlZmY1MDgxOGMyZjU3NDRkNWU4OWYxNy4uNmQ1Mzc5YTEzZGY3YWNk ZTI0YzA2NDIwYTM2N2UzMDUyZGQzZDJkMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVu ZGVyaW5nL1JlbmRlclZpZXcuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5k ZXJWaWV3LmNwcApAQCAtOTIsNyArOTIsMjEgQEAgYm9vbCBSZW5kZXJWaWV3OjpoaXRUZXN0KGNv bnN0IEhpdFRlc3RSZXF1ZXN0JiByZXF1ZXN0LCBIaXRUZXN0UmVzdWx0JiByZXN1bHQpCiAKIGJv b2wgUmVuZGVyVmlldzo6aGl0VGVzdChjb25zdCBIaXRUZXN0UmVxdWVzdCYgcmVxdWVzdCwgY29u c3QgSGl0VGVzdExvY2F0aW9uJiBsb2NhdGlvbiwgSGl0VGVzdFJlc3VsdCYgcmVzdWx0KQogewot ICAgIHJldHVybiBsYXllcigpLT5oaXRUZXN0KHJlcXVlc3QsIGxvY2F0aW9uLCByZXN1bHQpOwor ICAgIGlmIChsYXllcigpLT5oaXRUZXN0KHJlcXVlc3QsIGxvY2F0aW9uLCByZXN1bHQpKQorICAg ICAgICByZXR1cm4gdHJ1ZTsKKworICAgIC8vIEZJWE1FOiBDb25zaWRlciBpZiB0aGlzIHRlc3Qg c2hvdWxkIGJlIGRvbmUgdW5jb25kaXRpb25hbGx5LgorICAgIGlmIChyZXF1ZXN0LmFsbG93c0Zy YW1lU2Nyb2xsYmFycygpICYmIG1fZnJhbWVWaWV3KSB7CisgICAgICAgIC8vIFNjcm9sbFZpZXcg c2Nyb2xsYmFycyBhcmUgbm90IHRoZSBzYW1lIGFzIFJlbmRlckxheWVyIHNjcm9sbGJhcnMgdGVz dGVkIGJ5IFJlbmRlckxheWVyOjpoaXRUZXN0T3ZlcmZsb3dDb250cm9scywKKyAgICAgICAgLy8g c28gd2UgbmVlZCB0byB0ZXN0IFNjcm9sbFZpZXcgc2Nyb2xsYmFycyBzZXBhcmF0ZWx5IGhlcmUu CisgICAgICAgIFNjcm9sbGJhciogZnJhbWVTY3JvbGxiYXIgPSBtX2ZyYW1lVmlldy0+c2Nyb2xs YmFyQXRQb2ludChsb2NhdGlvbi5yb3VuZGVkUG9pbnQoKSk7CisgICAgICAgIGlmIChmcmFtZVNj cm9sbGJhcikgeworICAgICAgICAgICAgcmVzdWx0LnNldFNjcm9sbGJhcihmcmFtZVNjcm9sbGJh cik7CisgICAgICAgICAgICByZXR1cm4gdHJ1ZTsKKyAgICAgICAgfQorICAgIH0KKworICAgIHJl dHVybiBmYWxzZTsKIH0KIAogdm9pZCBSZW5kZXJWaWV3Ojpjb21wdXRlTG9naWNhbEhlaWdodChM YXlvdXRVbml0IGxvZ2ljYWxIZWlnaHQsIExheW91dFVuaXQsIExvZ2ljYWxFeHRlbnRDb21wdXRl ZFZhbHVlcyYgY29tcHV0ZWRWYWx1ZXMpIGNvbnN0Cg==