112560 2013-03-18 05:12:45 -0700 Fix unused parameter warnings in JITInlines.h 2013-03-26 04:54:35 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 ossy ossy barraclough loki oliver ossy thouraya.andolsi zherczeg oldest_to_newest 857008 0 ossy 2013-03-18 05:12:45 -0700 .../Source/JavaScriptCore/jit/JITInlines.h:147:48: warning: unused parameter 'insnSpace' [-Wunused-parameter] .../Source/JavaScriptCore/jit/JITInlines.h:147:48: warning: unused parameter 'constSpace' [-Wunused-parameter] This problem is come from the following very very old changesets: - http://trac.webkit.org/changeset/47186/trunk/JavaScriptCore/jit/JITInlineMethods.h - http://trac.webkit.org/changeset/83447/trunk/Source/JavaScriptCore/jit/JITInlineMethods.h Fix is coming soon. 857009 1 193537 ossy 2013-03-18 05:15:31 -0700 Created attachment 193537 Patch 857013 2 193537 ossy 2013-03-18 05:20:26 -0700 Comment on attachment 193537 Patch - I removed the redundant "#if defined(ASSEMBLER_HAS_CONSTANT_POOL) && ASSEMBLER_HAS_CONSTANT_POOL" guards, because beginUninterruptedSequence and endUninterruptedSequence are inside this kind of guard. - I added an "#ifndef NDEBUG" guard for endUninterruptedSequence function, because this function is for assertion check only and it is easiear to fix unused parameters in this way. If I didn't use this guard, I had to use ASSERT for CPU(SH4) and ASSERT_UNUSED for !CPU(SH4). 862644 3 ossy 2013-03-25 04:38:08 -0700 ping? 863494 4 loki 2013-03-26 02:46:00 -0700 Since I've done this a long time ago, I can give you an informal r+. I guess Zoltan, Filip or Oliver can give you the final flag. ;) 863496 5 thouraya.andolsi 2013-03-26 02:52:04 -0700 Hi, I'm not authorized to edit the attachment I give you an r+. (In reply to comment #3) > ping? Regards, Thouraya. 863543 6 193537 zherczeg 2013-03-26 04:20:13 -0700 Comment on attachment 193537 Patch r=me 863563 7 193537 ossy 2013-03-26 04:54:30 -0700 Comment on attachment 193537 Patch Clearing flags on attachment: 193537 Committed r146869: <http://trac.webkit.org/changeset/146869> 863564 8 ossy 2013-03-26 04:54:35 -0700 All reviewed patches have been landed. Closing bug. 193537 2013-03-18 05:15:31 -0700 2013-03-26 04:54:30 -0700 Patch bug-112560-20130318131216.patch text/plain 2849 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ2MDUyCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBj NGRiOTAzYzNkMmUzMGIxNjM0YTEzYjNjNGEzNDc1YmUxMjA2NTE5Li4yY2E5YzJlYTUxZjhjOTAw ZTM1YWYxZmY0OTdjMTMzM2Y0NDAyMmYyIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAxMy0wMy0xOCAgQ3NhYmEgT3N6dHJvZ29uw6FjICA8b3NzeUB3ZWJraXQu b3JnPgorCisgICAgICAgIEZpeCB1bnVzZWQgcGFyYW1ldGVyIHdhcm5pbmdzIGluIEpJVElubGlu ZXMuaAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEy NTYwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBq aXQvSklUSW5saW5lcy5oOgorICAgICAgICAoSlNDOjpKSVQ6OmJlZ2luVW5pbnRlcnJ1cHRlZFNl cXVlbmNlKToKKyAgICAgICAgKEpTQzo6SklUOjplbmRVbmludGVycnVwdGVkU2VxdWVuY2UpOgor ICAgICAgICAoSlNDKToKKwogMjAxMy0wMy0xNiAgUHJhdGlrIFNvbGFua2kgIDxwc29sYW5raUBh cHBsZS5jb20+CiAKICAgICAgICAgRGlzYWJsZSBIaWdoIERQSSBDYW52YXMgb24gaU9TCmRpZmYg LS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVElubGluZXMuaCBiL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9qaXQvSklUSW5saW5lcy5oCmluZGV4IGI5ZTUxNTI3NTAyNTA5ZWNlYmRi YTM0NWU3NjU2MTVlZTQ4MjBkYWMuLjA2ZTc4NzAxN2Y0MjE1M2FkZjk4MjU3YjhmMzFlZWRlODI3 NGY1NDQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklUSW5saW5lcy5o CisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklUSW5saW5lcy5oCkBAIC0xMzYsMTgg KzEzNiwxNSBAQCBBTFdBWVNfSU5MSU5FIHZvaWQgSklUOjpiZWdpblVuaW50ZXJydXB0ZWRTZXF1 ZW5jZShpbnQgaW5zblNwYWNlLCBpbnQgY29uc3RTcGFjZQogICAgIG1fYXNzZW1ibGVyLmVuc3Vy ZVNwYWNlKGluc25TcGFjZSArIG1fYXNzZW1ibGVyLm1heEluc3RydWN0aW9uU2l6ZSArIDIsIGNv bnN0U3BhY2UgKyA4KTsKICNlbmRpZgogCi0jaWYgZGVmaW5lZChBU1NFTUJMRVJfSEFTX0NPTlNU QU5UX1BPT0wpICYmIEFTU0VNQkxFUl9IQVNfQ09OU1RBTlRfUE9PTAogI2lmbmRlZiBOREVCVUcK ICAgICBtX3VuaW50ZXJydXB0ZWRJbnN0cnVjdGlvblNlcXVlbmNlQmVnaW4gPSBsYWJlbCgpOwog ICAgIG1fdW5pbnRlcnJ1cHRlZENvbnN0YW50U2VxdWVuY2VCZWdpbiA9IHNpemVPZkNvbnN0YW50 UG9vbCgpOwogI2VuZGlmCi0jZW5kaWYKIH0KIAogQUxXQVlTX0lOTElORSB2b2lkIEpJVDo6ZW5k VW5pbnRlcnJ1cHRlZFNlcXVlbmNlKGludCBpbnNuU3BhY2UsIGludCBjb25zdFNwYWNlLCBpbnQg ZHN0KQogewotICAgIFVOVVNFRF9QQVJBTShkc3QpOwotI2lmIGRlZmluZWQoQVNTRU1CTEVSX0hB U19DT05TVEFOVF9QT09MKSAmJiBBU1NFTUJMRVJfSEFTX0NPTlNUQU5UX1BPT0wKKyNpZm5kZWYg TkRFQlVHCiAgICAgLyogVGhlcmUgYXJlIHNldmVyYWwgY2FzZXMgd2hlbiB0aGUgdW5pbnRlcnJ1 cHRlZCBzZXF1ZW5jZSBpcyBsYXJnZXIgdGhhbgogICAgICAqIG1heGltdW0gcmVxdWlyZWQgb2Zm c2V0IGZvciBwYXRoaW5nIHRoZSBzYW1lIHNlcXVlbmNlLiBFZy46IGlmIGluIGEKICAgICAgKiB1 bmludGVycnVwdGVkIHNlcXVlbmNlIHRoZSBsYXN0IG1hY3JvYXNzZW1ibGVyJ3MgaW5zdHJ1Y3Rp b24gaXMgYSBzdHViCkBAIC0xNTUsNiArMTUyLDcgQEAgQUxXQVlTX0lOTElORSB2b2lkIEpJVDo6 ZW5kVW5pbnRlcnJ1cHRlZFNlcXVlbmNlKGludCBpbnNuU3BhY2UsIGludCBjb25zdFNwYWNlLAog ICAgICAqIGNhbGN1bGF0aW9uIG9mIGxlbmd0aCBvZiB1bmludGVycnVwdGVkIHNlcXVlbmNlLiBT bywgdGhlIGluc25TcGFjZSBhbmQKICAgICAgKiBjb25zdFNwYWNlIHNob3VsZCBiZSB1cHBlciBs aW1pdCBpbnN0ZWFkIG9mIGhhcmQgbGltaXQuCiAgICAgICovCisKICNpZiBDUFUoU0g0KQogICAg IGlmICgoZHN0ID4gMTUpIHx8IChkc3QgPCAtMTYpKSB7CiAgICAgICAgIGluc25TcGFjZSArPSA4 OwpAQCAtMTYzLDEzICsxNjEsMjAgQEAgQUxXQVlTX0lOTElORSB2b2lkIEpJVDo6ZW5kVW5pbnRl cnJ1cHRlZFNlcXVlbmNlKGludCBpbnNuU3BhY2UsIGludCBjb25zdFNwYWNlLAogCiAgICAgaWYg KCgoZHN0ID49IC0xNikgJiYgKGRzdCA8IDApKSB8fCAoKGRzdCA+IDcpICYmIChkc3QgPD0gMTUp KSkKICAgICAgICAgaW5zblNwYWNlICs9IDg7CisjZWxzZQorICAgIFVOVVNFRF9QQVJBTShkc3Qp OwogI2VuZGlmCisKICAgICBBU1NFUlQoZGlmZmVyZW5jZUJldHdlZW4obV91bmludGVycnVwdGVk SW5zdHJ1Y3Rpb25TZXF1ZW5jZUJlZ2luLCBsYWJlbCgpKSA8PSBpbnNuU3BhY2UpOwogICAgIEFT U0VSVChzaXplT2ZDb25zdGFudFBvb2woKSAtIG1fdW5pbnRlcnJ1cHRlZENvbnN0YW50U2VxdWVu Y2VCZWdpbiA8PSBjb25zdFNwYWNlKTsKKyNlbHNlCisgICAgVU5VU0VEX1BBUkFNKGluc25TcGFj ZSk7CisgICAgVU5VU0VEX1BBUkFNKGNvbnN0U3BhY2UpOworICAgIFVOVVNFRF9QQVJBTShkc3Qp OwogI2VuZGlmCiB9CiAKLSNlbmRpZgorI2VuZGlmIC8vIEFTU0VNQkxFUl9IQVNfQ09OU1RBTlRf UE9PTAogCiBBTFdBWVNfSU5MSU5FIHZvaWQgSklUOjp1cGRhdGVUb3BDYWxsRnJhbWUoKQogewo=