11255 2006-10-11 11:23:19 -0700 Links with nested continuations fail to paint their outlines 2007-05-10 03:36:12 -0700 1 1 1 Unclassified WebKit Layout and Rendering 420+ Mac OS X 10.4 RESOLVED FIXED InRadar P2 Normal --- 1 bdakin hyatt oldest_to_newest 53621 0 bdakin 2006-10-11 11:23:19 -0700 This should draw an outline but doesn't: <a href="http://www.apple.com" style="outline:10px auto purple"><h3>Hello</h3></a> 53622 1 11034 bdakin 2006-10-11 11:24:13 -0700 Created attachment 11034 Test case Here is the above html attached as a test case. 53624 2 bdakin 2006-10-11 11:33:20 -0700 <rdar://problem/4778099> 53392 3 hyatt 2006-10-11 14:26:27 -0700 The reason the outline doesn't paint is that there is no line box for the <a>. I think there may also be an issue with outline painting when the dirty rect while painting doesn't intersect the first <a>. (This could come up more often with printing when the continuation splits across page breaks). 10559 4 14456 hyatt 2007-05-10 03:20:46 -0700 Created attachment 14456 Improve continuation outline painting a lot. 10560 5 14456 mitz 2007-05-10 03:32:57 -0700 Comment on attachment 14456 Improve continuation outline painting a lot. r=me! 10561 6 hyatt 2007-05-10 03:36:12 -0700 Fixed in r21363. 11034 2006-10-11 11:24:13 -0700 2006-10-11 11:24:13 -0700 Test case test.html text/html 82 bdakin PGEgaHJlZj0iaHR0cDovL3d3dy5hcHBsZS5jb20iIHN0eWxlPSJvdXRsaW5lOjEwcHggYXV0byBw dXJwbGUiPjxoMz5IZWxsbzwvaDM+PC9hPg== 14456 2007-05-10 03:20:46 -0700 2007-05-10 03:32:57 -0700 Improve continuation outline painting a lot. patch.txt text/plain 4456 hyatt SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDIxMzYx KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0yLDYgKzIsMjggQEAKIAogICAgICAg ICBGaXggZm9yOgogCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS80Nzc4MDk5PiBMaW5rcyB3aXRo IG5lc3RlZCBjb250aW51YXRpb25zIGZhaWwgdG8gCisgICAgICAgIHBhaW50IHRoZWlyIG91dGxp bmVzICgxMTI1NSkKKyAgICAgICAgCisJaHR0cDovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTEyNTUKKworICAgICAgICBGaXggbXVsdGlwbGUgYnVncyB3aXRoIG91dGxpbmUgcGFp bnRpbmcgb2YgY29udGludWF0aW9ucyB0byBlbnN1cmUgdGhhdAorICAgICAgICBhbGwgY29tYm9z IHdvcmsgKGVtcHR5L2Z1bGwgaW5saW5lIC0gYmxvY2sgd2l0aC93aXRob3V0IG1hcmdpbnMgLSAK KyAgICAgICAgZW1wdHkvZnVsbCBpbmxpbmUpLgorCisJUmV2aWV3ZWQgYnkgbWl0egorCisgICAg ICAgIGZhc3QvaW5saW5lL2NvbnRpbnVhdGlvbi1vdXRsaW5lcy5odG1sCisKKyAgICAgICAgKiBy ZW5kZXJpbmcvUmVuZGVyQmxvY2suY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyQmxvY2s6 OnBhaW50T2JqZWN0KToKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyRmxvdy5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpSZW5kZXJGbG93OjphZGRGb2N1c1JpbmdSZWN0cyk6CisKKzIwMDctMDUt MTAgIERhdmlkIEh5YXR0ICA8aHlhdHRAYXBwbGUuY29tPgorCisgICAgICAgIEZpeCBmb3I6CisK ICAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzUxOTM1Mjk+IFJFR1JFU1NJT046IFJUTCBPdmVyZmxv d3Mgc2Nyb2xsYmFyIG5vdCBzaG93aW5nIAogICAgICAgICB3aGVuIHRoZXkgc2hvdWxkIGJlCiAg ICAgICAgIApJbmRleDogcmVuZGVyaW5nL1JlbmRlckJsb2NrLmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBy ZW5kZXJpbmcvUmVuZGVyQmxvY2suY3BwCShyZXZpc2lvbiAyMTM2MCkKKysrIHJlbmRlcmluZy9S ZW5kZXJCbG9jay5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE1NDAsOSArMTU0MCwxNCBAQCB2b2lk IFJlbmRlckJsb2NrOjpwYWludE9iamVjdChQYWludEluZm8mCiAgICAgfQogCiAgICAgLy8gNS4g cGFpbnQgb3V0bGluZS4KLSAgICBpZiAoIWlubGluZUZsb3cgJiYgKHBhaW50UGhhc2UgPT0gUGFp bnRQaGFzZU91dGxpbmUgfHwgcGFpbnRQaGFzZSA9PSBQYWludFBoYXNlU2VsZk91dGxpbmUpIAot ICAgICAgICAmJiBoYXNPdXRsaW5lKCkgJiYgc3R5bGUoKS0+dmlzaWJpbGl0eSgpID09IFZJU0lC TEUpCi0gICAgICAgIFJlbmRlck9iamVjdDo6cGFpbnRPdXRsaW5lKHBhaW50SW5mby5jb250ZXh0 LCB0eCwgdHksIHdpZHRoKCksIGhlaWdodCgpLCBzdHlsZSgpKTsKKyAgICBpZiAoIWlubGluZUZs b3cgJiYgKHBhaW50UGhhc2UgPT0gUGFpbnRQaGFzZU91dGxpbmUgfHwgcGFpbnRQaGFzZSA9PSBQ YWludFBoYXNlU2VsZk91dGxpbmUpICYmIHN0eWxlKCktPnZpc2liaWxpdHkoKSA9PSBWSVNJQkxF KSB7CisgICAgICAgIGlmIChjb250aW51YXRpb24oKSAmJiBjb250aW51YXRpb24oKS0+aGFzT3V0 bGluZSgpKSB7CisgICAgICAgICAgICBSZW5kZXJGbG93KiBpbmxpbmVGbG93ID0gc3RhdGljX2Nh c3Q8UmVuZGVyRmxvdyo+KGNvbnRpbnVhdGlvbigpLT5lbGVtZW50KCktPnJlbmRlcmVyKCkpOwor ICAgICAgICAgICAgaW5saW5lRmxvdy0+cGFpbnRPdXRsaW5lKHBhaW50SW5mby5jb250ZXh0LCB0 eCAtIHhQb3MoKSArIGlubGluZUZsb3ctPmNvbnRhaW5pbmdCbG9jaygpLT54UG9zKCksCisgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdHkgLSB5UG9zKCkgKyBpbmxpbmVGbG93 LT5jb250YWluaW5nQmxvY2soKS0+eVBvcygpKTsKKyAgICAgICAgfSBlbHNlIGlmIChoYXNPdXRs aW5lKCkpCisgICAgICAgICAgICBSZW5kZXJPYmplY3Q6OnBhaW50T3V0bGluZShwYWludEluZm8u Y29udGV4dCwgdHgsIHR5LCB3aWR0aCgpLCBoZWlnaHQoKSwgc3R5bGUoKSk7CisgICAgfQogCiAg ICAgLy8gNi4gcGFpbnQgY2FyZXQuCiAgICAgLy8gSWYgdGhlIGNhcmV0J3Mgbm9kZSdzIHJlbmRl ciBvYmplY3QncyBjb250YWluaW5nIGJsb2NrIGlzIHRoaXMgYmxvY2ssIGFuZCB0aGUgcGFpbnQg YWN0aW9uIGlzIFBhaW50UGhhc2VGb3JlZ3JvdW5kLApJbmRleDogcmVuZGVyaW5nL1JlbmRlckZs b3cuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIHJlbmRlcmluZy9SZW5kZXJGbG93LmNwcAkocmV2aXNpb24g MjEzNDkpCisrKyByZW5kZXJpbmcvUmVuZGVyRmxvdy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTY3 MSw4ICs2NzEsMTMgQEAgSW50UmVjdCBSZW5kZXJGbG93OjpjYXJldFJlY3QoaW50IG9mZnNldAog CiB2b2lkIFJlbmRlckZsb3c6OmFkZEZvY3VzUmluZ1JlY3RzKEdyYXBoaWNzQ29udGV4dCogZ3Jh cGhpY3NDb250ZXh0LCBpbnQgdHgsIGludCB0eSkKIHsKLSAgICBpZiAoaXNSZW5kZXJCbG9jaygp KQotICAgICAgIGdyYXBoaWNzQ29udGV4dC0+YWRkRm9jdXNSaW5nUmVjdChJbnRSZWN0KHR4LCB0 eSwgd2lkdGgoKSwgaGVpZ2h0KCkpKTsKKyAgICBpZiAoaXNSZW5kZXJCbG9jaygpKSB7CisgICAg ICAgIC8vIENvbnRpbnVhdGlvbnMgc2hvdWxkIGluY2x1ZGUgdGhlaXIgbWFyZ2lucyBpbiB0aGUg b3V0bGluZSByZWN0LgorICAgICAgICBpZiAoY29udGludWF0aW9uKCkpCisgICAgICAgICAgICBn cmFwaGljc0NvbnRleHQtPmFkZEZvY3VzUmluZ1JlY3QoSW50UmVjdCh0eCwgdHkgLSBjb2xsYXBz ZWRNYXJnaW5Ub3AoKSwgd2lkdGgoKSwgaGVpZ2h0KCkgKyBjb2xsYXBzZWRNYXJnaW5Ub3AoKSAr IGNvbGxhcHNlZE1hcmdpbkJvdHRvbSgpKSk7CisgICAgICAgIGVsc2UKKyAgICAgICAgICAgIGdy YXBoaWNzQ29udGV4dC0+YWRkRm9jdXNSaW5nUmVjdChJbnRSZWN0KHR4LCB0eSwgd2lkdGgoKSwg aGVpZ2h0KCkpKTsKKyAgICB9CiAKICAgICBpZiAoIWhhc092ZXJmbG93Q2xpcCgpICYmICFoYXND b250cm9sQ2xpcCgpKSB7CiAgICAgICAgIGZvciAoSW5saW5lUnVuQm94KiBjdXJyID0gZmlyc3RM aW5lQm94KCk7IGN1cnI7IGN1cnIgPSBjdXJyLT5uZXh0TGluZUJveCgpKQpAQCAtNjgzLDEwICs2 ODgsMTYgQEAgdm9pZCBSZW5kZXJGbG93OjphZGRGb2N1c1JpbmdSZWN0cyhHcmFwaAogICAgICAg ICAgICAgICAgIGN1cnItPmFkZEZvY3VzUmluZ1JlY3RzKGdyYXBoaWNzQ29udGV4dCwgdHggKyBj dXJyLT54UG9zKCksIHR5ICsgY3Vyci0+eVBvcygpKTsKICAgICB9CiAKLSAgICBpZiAoY29udGlu dWF0aW9uKCkpCi0gICAgICAgIGNvbnRpbnVhdGlvbigpLT5hZGRGb2N1c1JpbmdSZWN0cyhncmFw aGljc0NvbnRleHQsIAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg dHggLSBjb250YWluaW5nQmxvY2soKS0+eFBvcygpICsgY29udGludWF0aW9uKCktPnhQb3MoKSwK LSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHR5IC0gY29udGFpbmlu Z0Jsb2NrKCktPnlQb3MoKSArIGNvbnRpbnVhdGlvbigpLT55UG9zKCkpOworICAgIGlmIChjb250 aW51YXRpb24oKSkgeworICAgICAgICBpZiAoaXNJbmxpbmUoKSkKKyAgICAgICAgICAgIGNvbnRp bnVhdGlvbigpLT5hZGRGb2N1c1JpbmdSZWN0cyhncmFwaGljc0NvbnRleHQsIAorICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHR4IC0gY29udGFpbmluZ0Jsb2Nr KCktPnhQb3MoKSArIGNvbnRpbnVhdGlvbigpLT54UG9zKCksCisgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgdHkgLSBjb250YWluaW5nQmxvY2soKS0+eVBvcygp ICsgY29udGludWF0aW9uKCktPnlQb3MoKSk7CisgICAgICAgIGVsc2UKKyAgICAgICAgICAgIGNv bnRpbnVhdGlvbigpLT5hZGRGb2N1c1JpbmdSZWN0cyhncmFwaGljc0NvbnRleHQsIAorICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHR4IC0geFBvcygpICsgY29u dGludWF0aW9uKCktPmNvbnRhaW5pbmdCbG9jaygpLT54UG9zKCksCisgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdHkgLSB5UG9zKCkgKyBjb250aW51YXRpb24o KS0+Y29udGFpbmluZ0Jsb2NrKCktPnlQb3MoKSk7CisgICAgfQogfQogCiB2b2lkIFJlbmRlckZs b3c6OnBhaW50T3V0bGluZShHcmFwaGljc0NvbnRleHQqIGdyYXBoaWNzQ29udGV4dCwgaW50IHR4 LCBpbnQgdHkpCg==