112547 2013-03-18 02:58:59 -0700 [BlackBerry] BackingStoreClient: remove unnecessary call to toElement() 2013-03-18 04:24:04 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 111729 0 berto webkit-unassigned cgarcia mifenton rwlbuis tonikitoo webkit.review.bot xan.lopez oldest_to_newest 856933 0 berto 2013-03-18 02:58:59 -0700 frame->ownerElement() already returns an Element*, so the toElement() call is unnecessary and breaks the build because of this code in Element.h: // This will catch anyone doing an unnecessary cast. void toElement(const Element*); This changed in r145818: http://trac.webkit.org/changeset/145818/trunk/Source/WebKit/blackberry/WebKitSupport/BackingStoreClient.cpp 856935 1 193510 berto 2013-03-18 02:59:51 -0700 Created attachment 193510 Patch 856960 2 193510 tonikitoo 2013-03-18 03:49:05 -0700 Comment on attachment 193510 Patch This file should just be completely removed at some point. 856967 3 193510 webkit.review.bot 2013-03-18 03:54:41 -0700 Comment on attachment 193510 Patch Clearing flags on attachment: 193510 Committed r146051: <http://trac.webkit.org/changeset/146051> 856968 4 webkit.review.bot 2013-03-18 03:54:44 -0700 All reviewed patches have been landed. Closing bug. 193510 2013-03-18 02:59:51 -0700 2013-03-18 03:54:41 -0700 Patch 112547.diff text/plain 1461 berto ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cgYi9Tb3VyY2Uv V2ViS2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9nCmluZGV4IGM0ZTliNzYuLmViNWZlNTggMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl YktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEzLTAzLTE4ICBB bGJlcnRvIEdhcmNpYSAgPGFnYXJjaWFAaWdhbGlhLmNvbT4KKworICAgICAgICBbQmxhY2tCZXJy eV0gQmFja2luZ1N0b3JlQ2xpZW50OiByZW1vdmUgdW5uZWNlc3NhcnkgY2FsbCB0byB0b0VsZW1l bnQoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEy NTQ3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBX ZWJLaXRTdXBwb3J0L0JhY2tpbmdTdG9yZUNsaWVudC5jcHA6CisgICAgICAgIChCbGFja0JlcnJ5 OjpXZWJLaXQ6OkJhY2tpbmdTdG9yZUNsaWVudDo6YWJzb2x1dGVSZWN0KToKKwogMjAxMy0wMy0x NSAgQXJ2aWQgTmlsc3NvbiAgPGFuaWxzc29uQHJpbS5jb20+CiAKICAgICAgICAgW0JsYWNrQmVy cnldIEJsYWNrQmVycnk6OlBsYXRmb3JtOjpHcmFwaGljczo6R3JhcGhpY3NDb250ZXh0IGludGVn cmF0aW9uIHJlbGF0ZWQgY2hhbmdlcyBpbiBTb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L0JhY2tpbmdTdG9y ZUNsaWVudC5jcHAgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9CYWNr aW5nU3RvcmVDbGllbnQuY3BwCmluZGV4IDg1MGM4MTcuLmM4ZjY0NjEgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L0JhY2tpbmdTdG9yZUNsaWVudC5j cHAKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYktpdFN1cHBvcnQvQmFja2luZ1N0 b3JlQ2xpZW50LmNwcApAQCAtODAsNyArODAsNyBAQCBJbnRSZWN0IEJhY2tpbmdTdG9yZUNsaWVu dDo6YWJzb2x1dGVSZWN0KCkgY29uc3QKICAgICAvLyBGSVhNRTogU3BlZWQgaXQgdXAhCiAgICAg RnJhbWUqIGZyYW1lID0gbV9mcmFtZTsKICAgICB3aGlsZSAoZnJhbWUpIHsKLSAgICAgICAgaWYg KEVsZW1lbnQqIGVsZW1lbnQgPSB0b0VsZW1lbnQoZnJhbWUtPm93bmVyRWxlbWVudCgpKSkgewor ICAgICAgICBpZiAoRWxlbWVudCogZWxlbWVudCA9IGZyYW1lLT5vd25lckVsZW1lbnQoKSkgewog ICAgICAgICAgICAgZG8gewogICAgICAgICAgICAgICAgIHJlY3QubW92ZShlbGVtZW50LT5vZmZz ZXRMZWZ0KCksIGVsZW1lbnQtPm9mZnNldFRvcCgpKTsKICAgICAgICAgICAgIH0gd2hpbGUgKChl bGVtZW50ID0gZWxlbWVudC0+b2Zmc2V0UGFyZW50KCkpKTsK