112542 2013-03-18 01:42:26 -0700 [Qt][WK1] REGRESSION(r145973): http/tests/appcache/local-content.html fails 2013-03-28 14:56:40 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 79666 109757 1 zarvai japhet abarth japhet kadam koivisto webkit.review.bot oldest_to_newest 856907 0 zarvai 2013-03-18 01:42:26 -0700 Since r145973 test failes n Qt WK1: --- /ramdisk/qt-linux-64-release/build/layout-test-results/http/tests/appcache/local-content-expected.txt +++ /ramdisk/qt-linux-64-release/build/layout-test-results/http/tests/appcache/local-content-actual.txt @@ -1,7 +1,6 @@ -CONSOLE MESSAGE: Not allowed to load local resource: stdio.h Test that documents loaded from application cache don't get access to local resources accidentally. Should say SUCCESS: -SUCCESS +FAILURE: A local resource was opened in an iframe 857038 1 zarvai 2013-03-18 06:06:25 -0700 Skipped in http://trac.webkit.org/changeset/146042 on Qt WK1. Please unskip it with the proper fix. 861750 2 japhet 2013-03-22 12:17:08 -0700 (In reply to comment #1) > Skipped in http://trac.webkit.org/changeset/146042 on Qt WK1. > Please unskip it with the proper fix. Is there any possibility this was caused by another patch? It's certainly possible it was r145973, but I'm not immediately seeing how this could have affected local load reporting for a non-redirected iframe. 862619 3 zarvai 2013-03-25 03:39:05 -0700 (In reply to comment #2) > (In reply to comment #1) > > Skipped in http://trac.webkit.org/changeset/146042 on Qt WK1. > > Please unskip it with the proper fix. > > Is there any possibility this was caused by another patch? It's certainly possible it was r145973, but I'm not immediately seeing how this could have affected local load reporting for a non-redirected iframe. The other patches seems not to be related to this issue: Before: http://build.webkit.sed.hu/results/x86-64%20Linux%20Qt%20Release/r145971%20%2849207%29/results.html After: http://build.webkit.sed.hu/results/x86-64%20Linux%20Qt%20Release/r145974%20%2849208%29/results.html Trac range: http://trac.webkit.org/log/trunk?rev=145974&stop_rev=145970&limit=4&verbose=on 862623 4 zarvai 2013-03-25 03:44:49 -0700 Also found similar results on other bot: http://build.webkit.sed.hu/results/x86-32%20Linux%20Qt%20Release%20NRWT/r145971%20%2830339%29/results.html http://build.webkit.sed.hu/results/x86-32%20Linux%20Qt%20Release%20NRWT/r145973%20%2830340%29/results.html 864882 5 195400 japhet 2013-03-27 14:52:48 -0700 Created attachment 195400 patch 865832 6 195400 webkit.review.bot 2013-03-28 14:56:36 -0700 Comment on attachment 195400 patch Clearing flags on attachment: 195400 Committed r147165: <http://trac.webkit.org/changeset/147165> 865833 7 webkit.review.bot 2013-03-28 14:56:40 -0700 All reviewed patches have been landed. Closing bug. 195400 2013-03-27 14:52:48 -0700 2013-03-28 14:56:36 -0700 patch lc.txt text/plain 5283 japhet SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDE0NzAxMCkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDExIEBACisyMDEzLTAzLTI3ICBOYXRlIENoYXBpbiAgPGph cGhldEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmVtb3ZlIGV4cGVjdGVkIGZhaWx1cmUgZm9y IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTI1NDIKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL3F0LTUu MC13azEvVGVzdEV4cGVjdGF0aW9uczoKKwogMjAxMy0wMy0yNyAgWmFuIERvYmVyc2VrICA8emRv YmVyc2VrQGlnYWxpYS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCBHVEsgZ2FyZGVuaW5nLiBS ZWJhc2VsaW5pbmcgYWZ0ZXIgcjE0Njk5Mi4KSW5kZXg6IExheW91dFRlc3RzL3BsYXRmb3JtL3F0 LTUuMC13azEvVGVzdEV4cGVjdGF0aW9ucwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9wbGF0 Zm9ybS9xdC01LjAtd2sxL1Rlc3RFeHBlY3RhdGlvbnMJKHJldmlzaW9uIDE0NjkzNykKKysrIExh eW91dFRlc3RzL3BsYXRmb3JtL3F0LTUuMC13azEvVGVzdEV4cGVjdGF0aW9ucwkod29ya2luZyBj b3B5KQpAQCAtMTYwLDYgKzE2MCwzIEBACiB3ZWJraXQub3JnL2IvMTEyMzMzIGNzczMvY29tcG9z aXRpbmcvYmxlbmQtbW9kZS1wcm9wZXJ0eS5odG1sIFsgU2tpcCBdCiB3ZWJraXQub3JnL2IvMTEy MzMzIGNzczMvY29tcG9zaXRpbmcvc2hvdWxkLWhhdmUtY29tcG9zaXRpbmctbGF5ZXIuaHRtbCBb IFNraXAgXQogd2Via2l0Lm9yZy9iLzExMjMzMyB0cmFuc2l0aW9ucy9ibGVuZG1vZGUtdHJhbnNp dGlvbnMuaHRtbCAgWyBTa2lwIF0KLQotIyBbUXRdW1dLMV0gUkVHUkVTU0lPTihyMTQ1OTczKTog aHR0cC90ZXN0cy9hcHBjYWNoZS9sb2NhbC1jb250ZW50Lmh0bWwgZmFpbHMKLXdlYmtpdC5vcmcv Yi8xMTI1NDIgaHR0cC90ZXN0cy9hcHBjYWNoZS9sb2NhbC1jb250ZW50Lmh0bWwgWyBTa2lwIF0K SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0NzAxMCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBACisyMDEzLTAzLTI3ICBOYXRlIENo YXBpbiAgPGphcGhldEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgRG9uJ3QgZ3JhbnQgbG9jYWwg Y29udGVudCBwZXJtaXNzaW9ucyBmb3IgYXBwY2FjaGUgbG9hZHMuCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTI1NDIKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMsIGZpeGluZyBodHRw L3Rlc3RzL2FwcGNhY2hlL2xvY2FsLWNvbnRlbnQuaHRtbAorCisgICAgICAgICogbG9hZGVyL0Rv Y3VtZW50TG9hZGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkRvY3VtZW50TG9hZGVyOjpEb2N1 bWVudExvYWRlcik6CisgICAgICAgIChXZWJDb3JlOjpEb2N1bWVudExvYWRlcjo6Y29tbWl0RGF0 YSk6IERvbid0IGdyYW50IGxvY2FsIGxvYWQgcGVybWlzc2lvbnMKKyAgICAgICAgICAgIHRvIGFs bCBTdWJzdGl0dXRlRGF0YSBsb2Fkcywgb25seSBnaXZlIHRoZW0gdG8gbG9hZHMgdGhhdCB3ZXJl IFN1YnN0aXR1dGVEYXRhCisgICAgICAgICAgICBsb2FkcyBhdCB0aGUgdGltZSBvZiBEb2N1bWVu dExvYWRlciBjb25zdHJ1Y3Rpb24uIFRoaXMgY29uc3RpdHV0ZXMgYWxsCisgICAgICAgICAgICBT dWJzdGl0dXRlRGF0YSBsb2FkcyBleGNlcHQgdGhvc2UgdHJpZ2dlcmVkIGJ5IGFwcGNhY2hlLgor ICAgICAgICAqIGxvYWRlci9Eb2N1bWVudExvYWRlci5oOgorICAgICAgICAqIGxvYWRlci9GcmFt ZUxvYWRlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpGcmFtZUxvYWRlcjo6ZGlkQmVnaW5Eb2N1 bWVudCk6IE1vdmUgZ3JhbnRpbmcgbG9jYWwgbG9hZAorICAgICAgICAgICAgcGVybWlzc2lvbnMg Zm9yIFN1YnN0aXR1dGVEYXRhIGxvYWRzIHRvIERvY3VtZW50TG9hZGVyOjpjb21taXREYXRhKCku CisKIDIwMTMtMDMtMjcgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CiAKICAgICAg ICAgU2VsZWN0aW9uIGNvZGUgc3BlbmRzIGEgbG90IG9mIHRpbWUgaW4gSW5saW5lVGV4dEJveDo6 bG9jYWxTZWxlY3Rpb25SZWN0CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9sb2FkZXIvRG9jdW1lbnRM b2FkZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2xvYWRlci9Eb2N1bWVudExv YWRlci5jcHAJKHJldmlzaW9uIDE0NjkzNykKKysrIFNvdXJjZS9XZWJDb3JlL2xvYWRlci9Eb2N1 bWVudExvYWRlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTUzLDYgKzUzLDcgQEAKICNpbmNsdWRl ICJQcm9ncmVzc1RyYWNrZXIuaCIKICNpbmNsdWRlICJSZXNvdXJjZUJ1ZmZlci5oIgogI2luY2x1 ZGUgIlNjaGVtZVJlZ2lzdHJ5LmgiCisjaW5jbHVkZSAiU2VjdXJpdHlQb2xpY3kuaCIKICNpbmNs dWRlICJTZXR0aW5ncy5oIgogI2luY2x1ZGUgIlN1YnJlc291cmNlTG9hZGVyLmgiCiAjaW5jbHVk ZSAiVGV4dFJlc291cmNlRGVjb2Rlci5oIgpAQCAtMTAyLDYgKzEwMyw3IEBACiAgICAgLCBtX3N1 YnN0aXR1dGVEYXRhKHN1YnN0aXR1dGVEYXRhKQogICAgICwgbV9vcmlnaW5hbFJlcXVlc3RDb3B5 KHJlcSkKICAgICAsIG1fcmVxdWVzdChyZXEpCisgICAgLCBtX29yaWdpbmFsU3Vic3RpdHV0ZURh dGFXYXNWYWxpZChzdWJzdGl0dXRlRGF0YS5pc1ZhbGlkKCkpCiAgICAgLCBtX2NvbW1pdHRlZChm YWxzZSkKICAgICAsIG1faXNTdG9wcGluZyhmYWxzZSkKICAgICAsIG1fZ290Rmlyc3RCeXRlKGZh bHNlKQpAQCAtNzU3LDYgKzc1OSwxNCBAQAogICAgICAgICBtX3dyaXRlci5iZWdpbihkb2N1bWVu dFVSTCgpLCBmYWxzZSk7CiAgICAgICAgIG1fd3JpdGVyLnNldERvY3VtZW50V2FzTG9hZGVkQXNQ YXJ0T2ZOYXZpZ2F0aW9uKCk7CiAKKyAgICAgICAgaWYgKFNlY3VyaXR5UG9saWN5OjphbGxvd1N1 YnN0aXR1dGVEYXRhQWNjZXNzVG9Mb2NhbCgpICYmIG1fb3JpZ2luYWxTdWJzdGl0dXRlRGF0YVdh c1ZhbGlkKSB7CisgICAgICAgICAgICAvLyBJZiB0aGlzIGRvY3VtZW50IHdhcyBsb2FkZWQgd2l0 aCBzdWJzdGl0dXRlRGF0YSwgdGhlbiB0aGUgZG9jdW1lbnQgY2FuCisgICAgICAgICAgICAvLyBs b2FkIGxvY2FsIHJlc291cmNlcy4gU2VlIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xNjc1NgorICAgICAgICAgICAgLy8gYW5kIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xOTc2MCBmb3IgZnVydGhlcgorICAgICAgICAgICAgLy8gZGlzY3Vz c2lvbi4KKyAgICAgICAgICAgIG1fZnJhbWUtPmRvY3VtZW50KCktPnNlY3VyaXR5T3JpZ2luKCkt PmdyYW50TG9hZExvY2FsUmVzb3VyY2VzKCk7CisgICAgICAgIH0KKwogICAgICAgICBpZiAoZnJh bWVMb2FkZXIoKS0+c3RhdGVNYWNoaW5lKCktPmNyZWF0aW5nSW5pdGlhbEVtcHR5RG9jdW1lbnQo KSkKICAgICAgICAgICAgIHJldHVybjsKICAgICAgICAgCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9s b2FkZXIvRG9jdW1lbnRMb2FkZXIuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9sb2Fk ZXIvRG9jdW1lbnRMb2FkZXIuaAkocmV2aXNpb24gMTQ2OTM3KQorKysgU291cmNlL1dlYkNvcmUv bG9hZGVyL0RvY3VtZW50TG9hZGVyLmgJKHdvcmtpbmcgY29weSkKQEAgLTM0Myw2ICszNDMsNyBA QAogICAgIAogICAgICAgICBSZXNvdXJjZUVycm9yIG1fbWFpbkRvY3VtZW50RXJyb3I7ICAgIAog CisgICAgICAgIGJvb2wgbV9vcmlnaW5hbFN1YnN0aXR1dGVEYXRhV2FzVmFsaWQ7CiAgICAgICAg IGJvb2wgbV9jb21taXR0ZWQ7CiAgICAgICAgIGJvb2wgbV9pc1N0b3BwaW5nOwogICAgICAgICBi b29sIG1fZ290Rmlyc3RCeXRlOwpJbmRleDogU291cmNlL1dlYkNvcmUvbG9hZGVyL0ZyYW1lTG9h ZGVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9sb2FkZXIvRnJhbWVMb2FkZXIu Y3BwCShyZXZpc2lvbiAxNDY5MzcpCisrKyBTb3VyY2UvV2ViQ29yZS9sb2FkZXIvRnJhbWVMb2Fk ZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC02ODMsMTQgKzY4Myw2IEBACiAgICAgICAgICAgICBp ZiAoIWhlYWRlckNvbnRlbnRMYW5ndWFnZS5pc0VtcHR5KCkpCiAgICAgICAgICAgICAgICAgbV9m cmFtZS0+ZG9jdW1lbnQoKS0+c2V0Q29udGVudExhbmd1YWdlKGhlYWRlckNvbnRlbnRMYW5ndWFn ZSk7CiAgICAgICAgIH0KLQotICAgICAgICBpZiAoU2VjdXJpdHlQb2xpY3k6OmFsbG93U3Vic3Rp dHV0ZURhdGFBY2Nlc3NUb0xvY2FsKCkgJiYgbV9kb2N1bWVudExvYWRlci0+c3Vic3RpdHV0ZURh dGEoKS5pc1ZhbGlkKCkpIHsKLSAgICAgICAgICAgIC8vIElmIHRoaXMgZG9jdW1lbnQgd2FzIGxv YWRlZCB3aXRoIHN1YnN0aXR1dGVEYXRhLCB0aGVuIHRoZSBkb2N1bWVudCBjYW4KLSAgICAgICAg ICAgIC8vIGxvYWQgbG9jYWwgcmVzb3VyY2VzLiBTZWUgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE2NzU2Ci0gICAgICAgICAgICAvLyBhbmQgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NzYwIGZvciBmdXJ0aGVyCi0gICAgICAgICAgICAv LyBkaXNjdXNzaW9uLgotICAgICAgICAgICAgbV9mcmFtZS0+ZG9jdW1lbnQoKS0+c2VjdXJpdHlP cmlnaW4oKS0+Z3JhbnRMb2FkTG9jYWxSZXNvdXJjZXMoKTsKLSAgICAgICAgfQogICAgIH0KIAog ICAgIGhpc3RvcnkoKS0+cmVzdG9yZURvY3VtZW50U3RhdGUoKTsK