112541 2013-03-18 01:34:54 -0700 The 'formnovalidate' attribute doesn't work correctly on button elements with child elements 2013-03-19 01:41:50 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) Unspecified All RESOLVED FIXED http://jsfiddle.net/unyta/2/ P2 Normal --- 1 ksakamoto ksakamoto esprehn+autocc mibalan mifenton ojan.autocc tkent webkit.review.bot oldest_to_newest 856900 0 ksakamoto 2013-03-18 01:34:54 -0700 https://code.google.com/p/chromium/issues/detail?id=196529 The 'formnovalidate' attribute doesn't work correctly on button elements with child elements 856913 1 193505 ksakamoto 2013-03-18 01:56:18 -0700 Created attachment 193505 Patch 856989 2 193505 tkent 2013-03-18 04:40:13 -0700 Comment on attachment 193505 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=193505&action=review > Source/WebCore/html/HTMLFormElement.cpp:210 > + return static_cast<HTMLFormControlElement*>(node); Oh, we should have toHTMLFormControlElement(). static_cast<> should be avoided. 856998 3 193505 webkit.review.bot 2013-03-18 04:51:17 -0700 Comment on attachment 193505 Patch Clearing flags on attachment: 193505 Committed r146055: <http://trac.webkit.org/changeset/146055> 856999 4 webkit.review.bot 2013-03-18 04:51:20 -0700 All reviewed patches have been landed. Closing bug. 857035 5 mibalan 2013-03-18 05:57:39 -0700 I tried opening the fiddle in Chrome Canary Version 27.0.1443.2 canary - and it crashed the tab. You might want to take a(nother) look at it. 857835 6 ksakamoto 2013-03-18 18:21:51 -0700 I have tried 27.0.1444.3 canary ant it didn't crash. I believe 27.0.1443.2 canary doesn't include this fix - maybe yow saw a different bug. 858048 7 mibalan 2013-03-19 01:41:50 -0700 Yeah, might have been a glitch - it doesn't crash on Canary 27.0.1444.3 for me neither 193505 2013-03-18 01:56:18 -0700 2013-03-18 04:51:17 -0700 Patch bug-112541-20130318175210.patch text/plain 4968 ksakamoto U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ1OTc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmFhZDU3NWJjNmEzMjc0 YTliOWUzMDMyZDQ3N2E1YTMzYjE2ZTQ5MS4uODkyOTU2MjYzZDkwODRhZmRmYmJhNjgxN2FmM2Uw ODc3NTgxMDA1OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEzLTAzLTE4ICBLdW5p aGlrbyBTYWthbW90byAgPGtzYWthbW90b0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgVGhlICdm b3Jtbm92YWxpZGF0ZScgYXR0cmlidXRlIGRvZXNuJ3Qgd29yayBjb3JyZWN0bHkgb24gYnV0dG9u IGVsZW1lbnRzIHdpdGggY2hpbGQgZWxlbWVudHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTExMjU0MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEZpeCBhIGJ1ZyB3aGVyZSBmb3Jtbm92YWxpZGF0ZSBhdHRy aWJ1dGUgb2YgPGJ1dHRvbj4gaXMgbm90IGhvbm9yZWQKKyAgICAgICAgaWYgdGhlIHRhcmdldCBv ZiB0aGUgY2xpY2sgZXZlbnQgaXMgYW4gZWxlbWVudCBuZXN0ZWQgd2l0aGluIHRoZSBidXR0b24u CisKKyAgICAgICAgVGVzdDogZmFzdC9mb3Jtcy9pbnRlcmFjdGl2ZS12YWxpZGF0aW9uLWZvcm1u b3ZhbGlkYXRlLWNoaWxkLmh0bWwKKworICAgICAgICAqIGh0bWwvSFRNTEZvcm1FbGVtZW50LmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OnN1Ym1pdEVsZW1lbnRGcm9tRXZlbnQpOiBMb29rcyBmb3Ig dGhlIG5lYXJlc3QgRm9ybUNvbnRyb2xFbGVtZW50IGFuY2VzdG9yIG9mIHRoZSBldmVudCB0YXJn ZXQuCisKIDIwMTMtMDMtMTUgIENocmlzdGlhbiBCaWVzaW5nZXIgIDxjYmllc2luZ2VyQGNocm9t aXVtLm9yZz4KIAogICAgICAgICBDb252ZXJ0IG9sZCBmbGV4Ym94IHVzZXMgaW4gaHRtbC5jc3Mg dG8gbmV3IGZsZXhib3ggKG5vbi08c2VsZWN0PikKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L2h0bWwvSFRNTEZvcm1FbGVtZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTEZvcm1F bGVtZW50LmNwcAppbmRleCA3N2ZkYmZiMjllN2Y5MGIxODY5YjRkNTc4MDczZmQ4MThjNjVjNGQ0 Li5iZTYzYTllZjY4ZDMxYmUzOTVlOGQ4Zjg4MzYxN2I5MDcyNTk0YzVhIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9odG1sL0hUTUxGb3JtRWxlbWVudC5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvaHRtbC9IVE1MRm9ybUVsZW1lbnQuY3BwCkBAIC0yMDUsMTMgKzIwNSwxMSBAQCB2b2lkIEhU TUxGb3JtRWxlbWVudDo6c3VibWl0SW1wbGljaXRseShFdmVudCogZXZlbnQsIGJvb2wgZnJvbUlt cGxpY2l0U3VibWlzc2lvbgogCiBzdGF0aWMgaW5saW5lIEhUTUxGb3JtQ29udHJvbEVsZW1lbnQq IHN1Ym1pdEVsZW1lbnRGcm9tRXZlbnQoY29uc3QgRXZlbnQqIGV2ZW50KQogewotICAgIE5vZGUq IHRhcmdldE5vZGUgPSBldmVudC0+dGFyZ2V0KCktPnRvTm9kZSgpOwotICAgIGlmICghdGFyZ2V0 Tm9kZSB8fCAhdGFyZ2V0Tm9kZS0+aXNFbGVtZW50Tm9kZSgpKQotICAgICAgICByZXR1cm4gMDsK LSAgICBFbGVtZW50KiB0YXJnZXRFbGVtZW50ID0gdG9FbGVtZW50KHRhcmdldE5vZGUpOwotICAg IGlmICghdGFyZ2V0RWxlbWVudC0+aXNGb3JtQ29udHJvbEVsZW1lbnQoKSkKLSAgICAgICAgcmV0 dXJuIDA7Ci0gICAgcmV0dXJuIHN0YXRpY19jYXN0PEhUTUxGb3JtQ29udHJvbEVsZW1lbnQqPih0 YXJnZXRFbGVtZW50KTsKKyAgICBmb3IgKE5vZGUqIG5vZGUgPSBldmVudC0+dGFyZ2V0KCktPnRv Tm9kZSgpOyBub2RlOyBub2RlID0gbm9kZS0+cGFyZW50Tm9kZSgpKSB7CisgICAgICAgIGlmIChu b2RlLT5pc0VsZW1lbnROb2RlKCkgJiYgdG9FbGVtZW50KG5vZGUpLT5pc0Zvcm1Db250cm9sRWxl bWVudCgpKQorICAgICAgICAgICAgcmV0dXJuIHN0YXRpY19jYXN0PEhUTUxGb3JtQ29udHJvbEVs ZW1lbnQqPihub2RlKTsKKyAgICB9CisgICAgcmV0dXJuIDA7CiB9CiAKIGJvb2wgSFRNTEZvcm1F bGVtZW50Ojp2YWxpZGF0ZUludGVyYWN0aXZlbHkoRXZlbnQqIGV2ZW50KQpkaWZmIC0tZ2l0IGEv TGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDc3MDYy YmFiZDBmZjJiNzE2MTdjZmQyMGQzOWUyNjZkZjZlNWQxODkuLjE5YmJkODMyZWYyMzI4ZWFiY2Iw OTgzMGNlNzE0ZmI4YmQ2MjZhOTIgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZwor KysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMy0wMy0xOCAg S3VuaWhpa28gU2FrYW1vdG8gIDxrc2FrYW1vdG9AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFRo ZSAnZm9ybW5vdmFsaWRhdGUnIGF0dHJpYnV0ZSBkb2Vzbid0IHdvcmsgY29ycmVjdGx5IG9uIGJ1 dHRvbiBlbGVtZW50cyB3aXRoIGNoaWxkIGVsZW1lbnRzCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTI1NDEKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGZhc3QvZm9ybXMvaW50ZXJhY3RpdmUtdmFsaWRh dGlvbi1mb3Jtbm92YWxpZGF0ZS1jaGlsZC1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAq IGZhc3QvZm9ybXMvaW50ZXJhY3RpdmUtdmFsaWRhdGlvbi1mb3Jtbm92YWxpZGF0ZS1jaGlsZC5o dG1sOiBBZGRlZC4KKwogMjAxMy0wMy0xNSAgS2VubmV0aCBSdXNzZWxsICA8a2JyQGdvb2dsZS5j b20+CiAKICAgICAgICAgVW5yZXZpZXdlZCBuZXcgYmFzZWxpbmVzIGFmdGVyIHIxNDU5NzcuCmRp ZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL2ludGVyYWN0aXZlLXZhbGlkYXRpb24t Zm9ybW5vdmFsaWRhdGUtY2hpbGQtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZmFzdC9mb3Jt cy9pbnRlcmFjdGl2ZS12YWxpZGF0aW9uLWZvcm1ub3ZhbGlkYXRlLWNoaWxkLWV4cGVjdGVkLnR4 dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwLi40OWE1MjAyOWRmYWUwZWE1N2UwNWUxOGY4YzY0Njc4M2Q4YjAyY2QxCi0t LSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9pbnRlcmFjdGl2ZS12YWxp ZGF0aW9uLWZvcm1ub3ZhbGlkYXRlLWNoaWxkLWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDggQEAK K1Rlc3QgaWYgZm9ybW5vdmFsaWRhdGUgYXR0cmlidXRlIHdvcmtzIGZvciBhIHN1Ym1pdCBidXR0 b24gd2l0aCBjaGlsZCBlbGVtZW50cy4KKworT24gc3VjY2VzcywgeW91IHdpbGwgc2VlIGEgc2Vy aWVzIG9mICJQQVNTIiBtZXNzYWdlcywgZm9sbG93ZWQgYnkgIlRFU1QgQ09NUExFVEUiLgorCisK K1BBU1MgbG9jYXRpb24uc2VhcmNoLmluZGV4T2YoImkwPSIpICE9IC0xIGlzIHRydWUKK1RFU1Qg Q09NUExFVEUKKyBTdWJtaXQKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvaW50 ZXJhY3RpdmUtdmFsaWRhdGlvbi1mb3Jtbm92YWxpZGF0ZS1jaGlsZC5odG1sIGIvTGF5b3V0VGVz dHMvZmFzdC9mb3Jtcy9pbnRlcmFjdGl2ZS12YWxpZGF0aW9uLWZvcm1ub3ZhbGlkYXRlLWNoaWxk Lmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMC4uNWVhOTczYWE5ZGM0ODg4NmFmMWU1ZWY0MzUyZWNjZGUyYzUyYzAy NAotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvaW50ZXJhY3RpdmUt dmFsaWRhdGlvbi1mb3Jtbm92YWxpZGF0ZS1jaGlsZC5odG1sCkBAIC0wLDAgKzEsMzUgQEAKKzwh RE9DVFlQRSBodG1sPgorPGh0bWw+Cis8aGVhZD4KKzxzY3JpcHQgc3JjPSIuLi8uLi9mYXN0L2pz L3Jlc291cmNlcy9qcy10ZXN0LXByZS5qcyI+PC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keT4KKzxw IGlkPSJkZXNjcmlwdGlvbiI+PC9wPgorPGRpdiBpZD0iY29uc29sZSI+PC9kaXY+Cis8Zm9ybSBp ZD1mIGFjdGlvbj0iaW50ZXJhY3RpdmUtdmFsaWRhdGlvbi1mb3Jtbm92YWxpZGF0ZS1jaGlsZC5o dG1sIj4KKzxpbnB1dCB0eXBlPWhpZGRlbiBuYW1lPXN1Ym1pdHRlZCB2YWx1ZT0idHJ1ZSI+Cis8 aW5wdXQgbmFtZT1pMCByZXF1aXJlZCBpZD0iaTAiPgorPGJ1dHRvbiB0eXBlPSJzdWJtaXQiIGZv cm1ub3ZhbGlkYXRlPjxzcGFuIGlkPXM+U3VibWl0PC9zcGFuPjwvYnV0dG9uPgorPC9mb3JtPgor PHNjcmlwdD4KK2Rlc2NyaXB0aW9uKCdUZXN0IGlmIGZvcm1ub3ZhbGlkYXRlIGF0dHJpYnV0ZSB3 b3JrcyBmb3IgYSBzdWJtaXQgYnV0dG9uIHdpdGggY2hpbGQgZWxlbWVudHMuJyk7CisKK2Z1bmN0 aW9uIHN0YXJ0T3JWZXJpZnkoKSB7CisgICAgdmFyIHF1ZXJ5ID0gd2luZG93LmxvY2F0aW9uLnNl YXJjaDsKKyAgICBpZiAocXVlcnkuaW5kZXhPZignc3VibWl0dGVkPXRydWUnKSAhPSAtMSkgewor ICAgICAgICBzaG91bGRCZVRydWUoJ2xvY2F0aW9uLnNlYXJjaC5pbmRleE9mKCJpMD0iKSAhPSAt MScpOworICAgICAgICBkZWJ1ZygnVEVTVCBDT01QTEVURScpOworICAgICAgICBpZiAod2luZG93 LnRlc3RSdW5uZXIpCisgICAgICAgICAgICB0ZXN0UnVubmVyLm5vdGlmeURvbmUoKTsKKyAgICB9 IGVsc2UgeworICAgICAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgncycpLmNsaWNrKCk7Cisg ICAgICAgIHRlc3RGYWlsZWQoJ1RoZSBmb3JtIHdhcyBub3Qgc3VibWl0dGVkLicpOworICAgIH0K K30KKworaWYgKHdpbmRvdy50ZXN0UnVubmVyKQorICAgIHRlc3RSdW5uZXIud2FpdFVudGlsRG9u ZSgpOword2luZG93Lm9ubG9hZCA9IHN0YXJ0T3JWZXJpZnk7Cis8L3NjcmlwdD4KKzwvYm9keT4K KzwvaHRtbD4K