112528 2013-03-17 19:34:24 -0700 Mediastream.ended should return true when all tracks were removed. 2013-03-18 02:30:31 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 li.yin li.yin eric.carlson feature-media-reviews haraken hta jer.noble tommyw webkit.review.bot oldest_to_newest 856796 0 li.yin 2013-03-17 19:34:24 -0700 Spec: http://dev.w3.org/2011/webrtc/editor/getusermedia.html#widl-MediaStream-ended When all tracks have been removed, it should return true as well as all the tracks were ended. 856809 1 193481 li.yin 2013-03-17 20:33:02 -0700 Created attachment 193481 Patch 856813 2 193481 haraken 2013-03-17 20:51:11 -0700 Comment on attachment 193481 Patch LGTM. Please wait for tommyw's comment before landing. 856822 3 li.yin 2013-03-17 21:36:53 -0700 (In reply to comment #2) > (From update of attachment 193481 [details]) > LGTM. Please wait for tommyw's comment before landing. Okay, thanks for your review. 856915 4 193481 tommyw 2013-03-18 02:08:40 -0700 Comment on attachment 193481 Patch r+ from me too. 856916 5 193481 haraken 2013-03-18 02:09:15 -0700 Comment on attachment 193481 Patch Thanks! 856921 6 193481 webkit.review.bot 2013-03-18 02:30:27 -0700 Comment on attachment 193481 Patch Clearing flags on attachment: 193481 Committed r146046: <http://trac.webkit.org/changeset/146046> 856922 7 webkit.review.bot 2013-03-18 02:30:31 -0700 All reviewed patches have been landed. Closing bug. 193481 2013-03-17 20:33:02 -0700 2013-03-18 02:30:27 -0700 Patch bug-112528-20130318112900.patch text/plain 5485 li.yin U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ2MDI5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzYxYTU5MTU0ZDhiYWI4 YTBhOWQyZjVmNDE3N2FlYjNkMjBiNWVjNy4uM2NkOTdlMDNkMmZhZGUzNWQ0NWY4NDlmNTFjOTUx ODFkYzgwOWFhMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEzLTAzLTE3ICBMaSBZ aW4gIDxsaS55aW5AaW50ZWwuY29tPgorCisgICAgICAgIE1lZGlhc3RyZWFtLmVuZGVkIHNob3Vs ZCByZXR1cm4gdHJ1ZSB3aGVuIGFsbCB0cmFja3Mgd2VyZSByZW1vdmVkLgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEyNTI4CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU3BlYzogaHR0cDovL2Rldi53My5v cmcvMjAxMS93ZWJydGMvZWRpdG9yL2dldHVzZXJtZWRpYS5odG1sI3dpZGwtTWVkaWFTdHJlYW0t ZW5kZWQKKyAgICAgICAgV2hlbiBhbGwgdHJhY2tzIGhhdmUgYmVlbiByZW1vdmVkLCBpdCBzaG91 bGQgcmV0dXJuIHRydWUgYXMgd2VsbCBhcyBhbGwgdGhlIHRyYWNrcworICAgICAgICB3ZXJlIGVu ZGVkLgorCisgICAgICAgIFRlc3Q6IGZhc3QvbWVkaWFzdHJlYW0vTWVkaWFTdHJlYW0tYWRkLXJl bW92ZS10cmFja3MuaHRtbAorCisgICAgICAgICogTW9kdWxlcy9tZWRpYXN0cmVhbS9NZWRpYVN0 cmVhbS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpNZWRpYVN0cmVhbTo6cmVtb3ZlVHJhY2spOgor CiAyMDEzLTAzLTE3ICBLZW50IFRhbXVyYSAgPHRrZW50QGNocm9taXVtLm9yZz4KIAogICAgICAg ICBJTlBVVF9NVUxUSVBMRV9GSUVMRFNfVUk6IERvbid0IHVwZGF0ZSBzaGFkb3cgdHJlZSBieSB1 cGRhdGluZyBhbnkgYXR0cmlidXRlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVz L21lZGlhc3RyZWFtL01lZGlhU3RyZWFtLmNwcCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVk aWFzdHJlYW0vTWVkaWFTdHJlYW0uY3BwCmluZGV4IGJmYjU0YWUxMDc3OTFlOWY4NDFiNjU0ODI5 OWZmMzY2ODI0YjQ2M2QuLjVjMzg4YWJhZjNhZGVmMTczN2MyZGEzOTkxNjI3MjQxMDA0YzQwZTcg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzdHJlYW0vTWVkaWFTdHJl YW0uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzdHJlYW0vTWVkaWFTdHJl YW0uY3BwCkBAIC0yMDAsNiArMjAwLDkgQEAgdm9pZCBNZWRpYVN0cmVhbTo6cmVtb3ZlVHJhY2so UGFzc1JlZlB0cjxNZWRpYVN0cmVhbVRyYWNrPiBwcnBUcmFjayAsIEV4Y2VwdGlvbkMKICAgICB9 CiAgICAgfQogCisgICAgaWYgKCFtX2F1ZGlvVHJhY2tzLnNpemUoKSAmJiAhbV92aWRlb1RyYWNr cy5zaXplKCkpCisgICAgICAgIG1fZGVzY3JpcHRvci0+c2V0RW5kZWQoKTsKKwogICAgIE1lZGlh U3RyZWFtQ2VudGVyOjppbnN0YW5jZSgpLmRpZFJlbW92ZU1lZGlhU3RyZWFtVHJhY2sobV9kZXNj cmlwdG9yLmdldCgpLCB0cmFjay0+Y29tcG9uZW50KCkpOwogfQogCmRpZmYgLS1naXQgYS9MYXlv dXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZTU4M2Q5Mzgz Y2YxYzA2ZGYwMWY0ZGMyZWEyODk3MDExYTY2MWE5NC4uZDA2MzE0MDgwM2EyNjYxZTJlZTVkZWM0 MzJkYzFiNWQwNTg3MDA1NiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBi L0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEzLTAzLTE3ICBMaSBZ aW4gIDxsaS55aW5AaW50ZWwuY29tPgorCisgICAgICAgIE1lZGlhc3RyZWFtLmVuZGVkIHNob3Vs ZCByZXR1cm4gdHJ1ZSB3aGVuIGFsbCB0cmFja3Mgd2VyZSByZW1vdmVkLgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEyNTI4CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBmYXN0L21lZGlhc3RyZWFtL01l ZGlhU3RyZWFtLWFkZC1yZW1vdmUtdHJhY2tzLWV4cGVjdGVkLnR4dDoKKyAgICAgICAgKiBmYXN0 L21lZGlhc3RyZWFtL01lZGlhU3RyZWFtLWFkZC1yZW1vdmUtdHJhY2tzLmh0bWw6CisKIDIwMTMt MDMtMTcgIEtlbnQgVGFtdXJhICA8dGtlbnRAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIElOUFVU X01VTFRJUExFX0ZJRUxEU19VSTogRG9uJ3QgdXBkYXRlIHNoYWRvdyB0cmVlIGJ5IHVwZGF0aW5n IGFueSBhdHRyaWJ1dGUKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvbWVkaWFzdHJlYW0v TWVkaWFTdHJlYW0tYWRkLXJlbW92ZS10cmFja3MtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMv ZmFzdC9tZWRpYXN0cmVhbS9NZWRpYVN0cmVhbS1hZGQtcmVtb3ZlLXRyYWNrcy1leHBlY3RlZC50 eHQKaW5kZXggOTI1NzQ0MWMzZjRlMWY1NDJmYTIxMzQ0OGZjMDJlN2Q0N2U1N2U0Ni4uZmQ3YTNh NjE5NDQ4Y2M1ZDk4MjViODZiNGU2YTIyZGRmMDNlMTljMiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVz dHMvZmFzdC9tZWRpYXN0cmVhbS9NZWRpYVN0cmVhbS1hZGQtcmVtb3ZlLXRyYWNrcy1leHBlY3Rl ZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9tZWRpYXN0cmVhbS9NZWRpYVN0cmVhbS1hZGQt cmVtb3ZlLXRyYWNrcy1leHBlY3RlZC50eHQKQEAgLTgsOCArOCw4IEBAIFBBU1Mgc3RyZWFtMS5n ZXRWaWRlb1RyYWNrcygpLmxlbmd0aCBpcyAxCiBQQVNTIHN0cmVhbTIuZ2V0QXVkaW9UcmFja3Mo KS5sZW5ndGggaXMgMQogUEFTUyBzdHJlYW0yLmdldFZpZGVvVHJhY2tzKCkubGVuZ3RoIGlzIDEK IFBBU1Mgc3RyZWFtMS5nZXRBdWRpb1RyYWNrcygpLmxlbmd0aCBpcyAwCi1QQVNTIHN0cmVhbTEu Z2V0VmlkZW9UcmFja3MoKS5sZW5ndGggaXMgMAogUEFTUyBzdHJlYW0xLmdldFRyYWNrQnlJZChh dWRpb1RyYWNrLmlkKSBpcyBudWxsCitQQVNTIHN0cmVhbTEuZ2V0VmlkZW9UcmFja3MoKS5sZW5n dGggaXMgMAogUEFTUyBzdHJlYW0xLmdldFRyYWNrQnlJZCh2aWRlb1RyYWNrLmlkKSBpcyBudWxs CiBQQVNTIHN0cmVhbTEuZ2V0QXVkaW9UcmFja3MoKS5sZW5ndGggaXMgMQogUEFTUyBzdHJlYW0x LmdldFZpZGVvVHJhY2tzKCkubGVuZ3RoIGlzIDEKQEAgLTIxLDYgKzIxLDcgQEAgUEFTUyBzdHJl YW0xLmdldEF1ZGlvVHJhY2tzKCkubGVuZ3RoIGlzIDEKIFBBU1Mgc3RyZWFtMS5nZXRWaWRlb1Ry YWNrcygpLmxlbmd0aCBpcyAxCiBQQVNTIHN0cmVhbTEuZ2V0QXVkaW9UcmFja3MoKS5sZW5ndGgg aXMgMgogUEFTUyBzdHJlYW0xLmdldFZpZGVvVHJhY2tzKCkubGVuZ3RoIGlzIDIKK1BBU1Mgc3Ry ZWFtMi5lbmRlZCBpcyB0cnVlCiBQQVNTIHN0cmVhbTEuYWRkVHJhY2soYXVkaW9UcmFjaykgdGhy ZXcgZXhjZXB0aW9uIEVycm9yOiBJbnZhbGlkU3RhdGVFcnJvcjogRE9NIEV4Y2VwdGlvbiAxMS4K IFBBU1Mgc3RyZWFtMS5yZW1vdmVUcmFjayhhdWRpb1RyYWNrKSB0aHJldyBleGNlcHRpb24gRXJy b3I6IEludmFsaWRTdGF0ZUVycm9yOiBET00gRXhjZXB0aW9uIDExLgogUEFTUyBzdWNjZXNzZnVs bHlQYXJzZWQgaXMgdHJ1ZQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9tZWRpYXN0cmVh bS9NZWRpYVN0cmVhbS1hZGQtcmVtb3ZlLXRyYWNrcy5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9t ZWRpYXN0cmVhbS9NZWRpYVN0cmVhbS1hZGQtcmVtb3ZlLXRyYWNrcy5odG1sCmluZGV4IGE3OTNl MWRkMDIzOGRjOGZjN2RhYmZmMWU5NzU4ZTE4NDRkZWEzZWMuLmFhZjgyZjNhYTA1MjEyZWM2OGJl ZGYzNjZhMThlOWE3MDFlZWNkYzggMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3QvbWVkaWFz dHJlYW0vTWVkaWFTdHJlYW0tYWRkLXJlbW92ZS10cmFja3MuaHRtbAorKysgYi9MYXlvdXRUZXN0 cy9mYXN0L21lZGlhc3RyZWFtL01lZGlhU3RyZWFtLWFkZC1yZW1vdmUtdHJhY2tzLmh0bWwKQEAg LTY4LDIxICs2OCwxOCBAQCBmdW5jdGlvbiBnb3RTdHJlYW0yKHMpIHsKICAgICB2aWRlb1RyYWNr ID0gc3RyZWFtMS5nZXRWaWRlb1RyYWNrcygpWzBdOwogCiAgICAgdHJ5UmVtb3ZlVHJhY2soc3Ry ZWFtMSwgYXVkaW9UcmFjayk7Ci0gICAgdHJ5UmVtb3ZlVHJhY2soc3RyZWFtMSwgdmlkZW9UcmFj ayk7Ci0KICAgICAvLyB2ZXJpZnkgcmVtb3ZlZCB0cmFja3MKICAgICBzaG91bGRCZSgnc3RyZWFt MS5nZXRBdWRpb1RyYWNrcygpLmxlbmd0aCcsICcwJyk7Ci0gICAgc2hvdWxkQmUoJ3N0cmVhbTEu Z2V0VmlkZW9UcmFja3MoKS5sZW5ndGgnLCAnMCcpOwotCiAgICAgc2hvdWxkQmVOdWxsKCdzdHJl YW0xLmdldFRyYWNrQnlJZChhdWRpb1RyYWNrLmlkKScpOwotICAgIHNob3VsZEJlTnVsbCgnc3Ry ZWFtMS5nZXRUcmFja0J5SWQodmlkZW9UcmFjay5pZCknKTsKLQogICAgIC8vIHJlbW92ZSBhIG5v bi1leGlzdGVudCAoYWxyZWFkeSByZW1vdmVkKSB0cmFjayAoc2hvdWxkIG5vdCB0aHJvdykKICAg ICB0cnlSZW1vdmVUcmFjayhzdHJlYW0xLCBhdWRpb1RyYWNrKTsKLSAgICB0cnlSZW1vdmVUcmFj ayhzdHJlYW0xLCB2aWRlb1RyYWNrKTsKLQogICAgIC8vIChyZS0pYWRkIHRyYWNrcwogICAgIHRy eUFkZFRyYWNrKHN0cmVhbTEsIGF1ZGlvVHJhY2spOworCisgICAgdHJ5UmVtb3ZlVHJhY2soc3Ry ZWFtMSwgdmlkZW9UcmFjayk7CisgICAgc2hvdWxkQmUoJ3N0cmVhbTEuZ2V0VmlkZW9UcmFja3Mo KS5sZW5ndGgnLCAnMCcpOworICAgIHNob3VsZEJlTnVsbCgnc3RyZWFtMS5nZXRUcmFja0J5SWQo dmlkZW9UcmFjay5pZCknKTsKKyAgICB0cnlSZW1vdmVUcmFjayhzdHJlYW0xLCB2aWRlb1RyYWNr KTsKICAgICB0cnlBZGRUcmFjayhzdHJlYW0xLCB2aWRlb1RyYWNrKTsKIAogICAgIC8vIHZlcmlm eSBhZGRlZCB0cmFja3MKQEAgLTExMSw2ICsxMDgsMTEgQEAgZnVuY3Rpb24gZ290U3RyZWFtMihz KSB7CiAgICAgc2hvdWxkQmUoJ3N0cmVhbTEuZ2V0QXVkaW9UcmFja3MoKS5sZW5ndGgnLCAnMicp OwogICAgIHNob3VsZEJlKCdzdHJlYW0xLmdldFZpZGVvVHJhY2tzKCkubGVuZ3RoJywgJzInKTsK IAorICAgIC8vIHdoZW4gYWxsIHRyYWNrcyBoYXZlIGJlZW4gcmVtb3ZlZCwgc3RyZWFtLmVuZGVk IHNob3VsZCByZXR1cm4gdHJ1ZS4KKyAgICB0cnlSZW1vdmVUcmFjayhzdHJlYW0yLCBzdHJlYW0y LmdldEF1ZGlvVHJhY2tzKClbMF0pOworICAgIHRyeVJlbW92ZVRyYWNrKHN0cmVhbTIsIHN0cmVh bTIuZ2V0VmlkZW9UcmFja3MoKVswXSk7CisgICAgc2hvdWxkQmVUcnVlKCdzdHJlYW0yLmVuZGVk Jyk7CisKICAgICBzdHJlYW0xLnN0b3AoKTsKIAogICAgIHNob3VsZFRocm93KCdzdHJlYW0xLmFk ZFRyYWNrKGF1ZGlvVHJhY2spJywgJyJFcnJvcjogSW52YWxpZFN0YXRlRXJyb3I6IERPTSBFeGNl cHRpb24gMTEiJyk7Cg==