112517 2013-03-17 07:45:37 -0700 [GTK] Invalid charset encoding using when substituting a misspelled word in WebKit2 2013-03-17 09:52:05 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned andersca benjamin gustavo mrobinson webkit.review.bot xan.lopez oldest_to_newest 856705 0 cgarcia 2013-03-17 07:45:37 -0700 The problem is that we are creating the WebContextMenuItemData with the GtkAction label as UTF-8. It should be converted to UTF-16. 856706 1 193465 cgarcia 2013-03-17 07:48:07 -0700 Created attachment 193465 Patch 856716 2 193465 cgarcia 2013-03-17 09:44:34 -0700 Comment on attachment 193465 Patch Thanks for the review! 856717 3 193465 webkit.review.bot 2013-03-17 09:52:02 -0700 Comment on attachment 193465 Patch Clearing flags on attachment: 193465 Committed r146011: <http://trac.webkit.org/changeset/146011> 856718 4 webkit.review.bot 2013-03-17 09:52:05 -0700 All reviewed patches have been landed. Closing bug. 193465 2013-03-17 07:48:07 -0700 2013-03-17 09:52:02 -0700 Patch wk2-context-menu-utf8.diff text/plain 2102 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBkOGZiZDNjLi45ZWZkYzBkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTMtMDMtMTcgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFtHVEtdIEludmFsaWQgY2hhcnNldCBlbmNvZGluZyB1c2luZyB3aGVuIHN1 YnN0aXR1dGluZyBhIG1pc3NwZWxsZWQgd29yZCBpbiBXZWJLaXQyCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTI1MTcKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgcHJvYmxlbSBpcyB0aGF0IHdlIGFy ZSBjcmVhdGluZyB0aGUgV2ViQ29udGV4dE1lbnVJdGVtRGF0YQorICAgICAgICB3aXRoIHRoZSBH dGtBY3Rpb24gbGFiZWwgYXMgVVRGLTguCisKKyAgICAgICAgKiBVSVByb2Nlc3MvZ3RrL1dlYkNv bnRleHRNZW51UHJveHlHdGsuY3BwOgorICAgICAgICAoV2ViS2l0Ojpjb250ZXh0TWVudUl0ZW1B Y3RpdmF0ZWRDYWxsYmFjayk6IFVzZSBTdHJpbmc6OmZyb21VVEY4KCkKKyAgICAgICAgdG8gY29u dmVydCB0aGUgR3RrQWN0aW9uIGxhYmVsIHRvIFVURi0xNi4KKwogMjAxMy0wMy0xNCAgQ2FybG9z IEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdl ZCBidWlsZCBmaXguIEFkZCBtaXNzaW5nIGZpbGUuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvZ3RrL1dlYkNvbnRleHRNZW51UHJveHlHdGsuY3BwIGIvU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL2d0ay9XZWJDb250ZXh0TWVudVByb3h5R3RrLmNwcAppbmRleCBlZDJiNGRm Li5kN2QwNjgzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvZ3RrL1dlYkNv bnRleHRNZW51UHJveHlHdGsuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9ndGsv V2ViQ29udGV4dE1lbnVQcm94eUd0ay5jcHAKQEAgLTQ3LDkgKzQ3LDkgQEAgc3RhdGljIHZvaWQg Y29udGV4dE1lbnVJdGVtQWN0aXZhdGVkQ2FsbGJhY2soR3RrQWN0aW9uKiBhY3Rpb24sIFdlYlBh Z2VQcm94eSogcGEKIHsKICAgICBnYm9vbGVhbiBpc1RvZ2dsZSA9IEdUS19JU19UT0dHTEVfQUNU SU9OKGFjdGlvbik7CiAgICAgV2ViS2l0OjpXZWJDb250ZXh0TWVudUl0ZW1EYXRhIGl0ZW0oaXNU b2dnbGUgPyBXZWJDb3JlOjpDaGVja2FibGVBY3Rpb25UeXBlIDogV2ViQ29yZTo6QWN0aW9uVHlw ZSwKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBzdGF0aWNfY2FzdDxX ZWJDb3JlOjpDb250ZXh0TWVudUFjdGlvbj4oR1BPSU5URVJfVE9fSU5UKGdfb2JqZWN0X2dldF9k YXRhKEdfT0JKRUNUKGFjdGlvbiksIGdDb250ZXh0TWVudUFjdGlvbklkKSkpLAotICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGd0a19hY3Rpb25fZ2V0X2xhYmVsKGFjdGlv biksIGd0a19hY3Rpb25fZ2V0X3NlbnNpdGl2ZShhY3Rpb24pLAotICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIGlzVG9nZ2xlID8gZ3RrX3RvZ2dsZV9hY3Rpb25fZ2V0X2Fj dGl2ZShHVEtfVE9HR0xFX0FDVElPTihhY3Rpb24pKSA6IGZhbHNlKTsKKyAgICAgICAgc3RhdGlj X2Nhc3Q8V2ViQ29yZTo6Q29udGV4dE1lbnVBY3Rpb24+KEdQT0lOVEVSX1RPX0lOVChnX29iamVj dF9nZXRfZGF0YShHX09CSkVDVChhY3Rpb24pLCBnQ29udGV4dE1lbnVBY3Rpb25JZCkpKSwKKyAg ICAgICAgU3RyaW5nOjpmcm9tVVRGOChndGtfYWN0aW9uX2dldF9sYWJlbChhY3Rpb24pKSwgZ3Rr X2FjdGlvbl9nZXRfc2Vuc2l0aXZlKGFjdGlvbiksCisgICAgICAgIGlzVG9nZ2xlID8gZ3RrX3Rv Z2dsZV9hY3Rpb25fZ2V0X2FjdGl2ZShHVEtfVE9HR0xFX0FDVElPTihhY3Rpb24pKSA6IGZhbHNl KTsKICAgICBwYWdlLT5jb250ZXh0TWVudUl0ZW1TZWxlY3RlZChpdGVtKTsKIH0KIAo=